ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
33,319 Commits 324 Branches 20,019 Tags 1.7 GiB
Commit Graph

2 Commits

Author SHA1 Message Date
wdransfield ae2c958676 Fix first-time render issues with LTI keys 
Fixes PLAT-3924

Test Plan:
- Create a new LTI key
- Without refreshing the page verify the following:
  * toggling the "on/off" switch works
  * the global id of the key is displayed
  * the key's secret is available

Change-Id: I1cde9db31ecf8315a7814633d398364acea0a45f
Reviewed-on: https://gerrit.instructure.com/170184
Tested-by: Jenkins
QA-Review: Marc Phillips <mphillips@instructure.com>
Product-Review: Weston Dransfield <wdransfield@instructure.com>
Reviewed-by: Marc Phillips <mphillips@instructure.com>
 2018-10-30 21:50:35 +00:00
wdransfield 59942f4ff8 LTI 1.3: Add security claims and sign with Canvas private key 
Closes PLAT-3633, PLAT-3634

Test Plan:
- Do an LTI 1.3 launch in Canvas and verify the id token is
  signed with the current canvas secret key.
- Verify the following claims are included and correct:
  * exp
  * iat
  * iss
  * nonce
  * sub

Change-Id: I57699ac42bbe98a9fa03f82f3f9b9a16c6923011
Reviewed-on: https://gerrit.instructure.com/159855
Tested-by: Jenkins
Reviewed-by: Marc Alan Phillips <mphillips@instructure.com>
QA-Review: Marc Alan Phillips <mphillips@instructure.com>
Product-Review: Marc Alan Phillips <mphillips@instructure.com>
 2018-08-09 21:33:03 +00:00