just copy the external identifier like the way we
do for the rubrics themselves - when the account-level
group is added the outcomes aren't copied down to
the blueprint so we can't rely on the old way
of copying them
test plan:
* have an account-level outcome group
* create an outcome in the group
* create a blueprint course
* add the account-level group (not the outcome alone)
to the blueprint course
* sync to an associated course
* create a rubric on the blueprint and link
to the account-level outcome
* sync to the associated course
* the rubric in the associated course should still
be linked to the outcome
closes #ADMIN-1460
Change-Id: I7a0458200b467f8c9d1fbb056cebfcea4adfabb5
Reviewed-on: https://gerrit.instructure.com/165062
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Jeremy Stanley <jeremy@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
- feature flag for rubric range
Fixes: PFS-8283
test plan:
Enable feature: Rubric Criterion Range
Access rubric in account, course, and assignment.
1. Verify that 'range' option is available when editing
a non-outcome criterion.
2. Verify range option is not available for imported
outcomes.
3. Verify range option is not available when using
custom comments (assignment rubrics only)
For range enabled criterions:
1. Verify that increasing the total points assigned
to a criterion will appropriately scale all
range values.
2. Verify that increasing the max of highest score
cell increases total points available for
criterion.
3. Verify that increasing the max of a middle-cell
will increase the min of cell to left.
4. Verify that min of cell farthest to right is locked
at 0.
5. Verify that adjusting the min of a middle-cell
will adjust the max of cell to the right.
In Speedgrader:
1. Verify that selecting values anywhere within a rating
range will highlight the whole rating cell in green.
Feature Flag:
1. Verify that when feature flag is disabled app functions
as if range has been disabled for all criteria. (Leave
a criterion using range, and verify that is no longer
uses range when the feature is disabled).
In Submission Page:
We should also check the submission show page, since Rubrics
are displayed there as well. It can be a little hard to find
since it doesn't follow typical REST patterns for some reason.
When someone submits to the assignment, the url will be the
assignment's id and the user's id.
e.g, for a user id of 9 and an assignment id of 7 on course 1,
the url would be:
/courses/1/assignments/7/submissions/9
Accessibility:
Verify the new fields are a11y compliant by testing keyboard only
and voiceover navigation, so we don't introduce any new
accessibility issues.
Internationalization:
Test range ratings with different numbering system (i.e. Polish)
Verify that rounding works correctly.
Course Copy:
Verify that course copy preserves rubric ranges.
Change-Id: Ia1e9d3cc1d544aecc21c3628bd3dbec70831da2f
Reviewed-on: https://gerrit.instructure.com/121870
Tested-by: Jenkins
Reviewed-by: Matt Berns <mberns@instructure.com>
QA-Review: Aiona Hernandez <ahernandez@instructure.com>
QA-Review: Andrew Porter <hporter-c@instructure.com>
Product-Review: Sidharth Oberoi <soberoi@instructure.com>
maybe this is totally overkill but whatever
it'll put my mind at ease about conflicts in the future
also we can hack this later if we want to make
content exports for future courses shard-aware too
Change-Id: I1568e47ec1037d6e7554e7ccb0ea80965842db49
Reviewed-on: https://gerrit.instructure.com/96482
Reviewed-by: Dan Minkevitch <dan@instructure.com>
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
closes #CNVS-30349
Change-Id: Ia9e314f6495cf89127cf55ad38a28c5dc1791d10
Reviewed-on: https://gerrit.instructure.com/84594
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
test plan:
* create a course with a rubric
* create a graded discussion topic and associate it with the rubric
* use the content exports api to create a course export, passing
in a parameter to only export the discussion topic
"select[discussion_topics][]=TOPIC_ID"
* import the exported file into a new course
* the topic should have the rubric associated with it
closes #CNVS-29182
Change-Id: I6aded344a70acf53e0196f3d7cc779296d556102
Reviewed-on: https://gerrit.instructure.com/79179
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
fixes CNVS-14822
test plan:
- have an assignment with a rubric that references an outcome
- copy the course containing the assignment, selecting only the
assignment
- the destination course should contain copies of the assignment,
rubric, and outcome, linked as in the source course
Change-Id: I425dc2bb241ec8996c2195bf9365750e50e42e85
Reviewed-on: https://gerrit.instructure.com/40105
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: James Williams <jamesw@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Bracken Mosbacker <bracken@instructure.com>
having an "association" attribute causes problems in rails 3
Change-Id: I3249a25cd2a6162ff33f548a2e9f4f51a2940ece
Reviewed-on: https://gerrit.instructure.com/29058
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
test plan:
* create an account level outcome
* create an account level rubric
* attach the outcome to the rubric
* in a course, attach the rubric to an assignment
* copy the course
* check the new assignment in which you linked the rubric to
the outcome was carried over, and the association with
the account-level rubric should be preserved,
(and by extension the association with the learning
outcome)
fixes #CNVS-4200
Change-Id: I0bfa11124d599ca1a96ed3b6e684b966974e397b
Reviewed-on: https://gerrit.instructure.com/21548
Reviewed-by: Bracken Mosbacker <bracken@instructure.com>
Product-Review: Bracken Mosbacker <bracken@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Previously rubrics used by an assignment wouldn't copy unless
the rubric was selected. This makes it so that an assignment
will always bring its rubric when copied.
This also copies the two rubric properties you can select
when adding a rubric to an assignment.
Test Plan:
* Create an assignment with a rubric. Mark the rubric to be used for grading
* Copy the course and don't select the rubric to be copied
* In the new course the rubric should be there, and should be used for grading
closes#8474#8475
Change-Id: I3c117c10c159fed2d8a3d6c083f8251e8a97bee6
Reviewed-on: https://gerrit.instructure.com/10606
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
The xml generation code was checking the wrong relation to
count how many rubrics there were.
Test Plan:
* Create and assignment and add a rubric to that assignment. (don't make the rubric on the /rubrics page of the course)
* Copy the course
* The new course should have the rubric and the assignment should be associated with it
closes#8470
Change-Id: Ie1b2599d24166d13e0c19b035d23795d93f10ac7
Reviewed-on: https://gerrit.instructure.com/10572
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
Only the rubrics created directly in a course were being
copied. This commit copies ones through rubric_associations
to get everything.
Test Plan:
* Create a course with some rubrics
* Make an assignment use a rubric associated with another course
* Copy the course
* The new course should have all the necessary rubrics
closes#8266
Change-Id: Ib1e1b6c0cc053d53182c0825fe871eb8429ab734
Reviewed-on: https://gerrit.instructure.com/10266
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Bracken Mosbacker <bracken@instructure.com>
Test Plan:
* There is no UI for this yet, so check the specs.
refs #4645
Change-Id: Ibe159d222ba9a05e2edc4ead5eeb3e48b77c3542
Reviewed-on: https://gerrit.instructure.com/9741
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
This imports the syllabus, rubrics, and modules
refs #3396
Change-Id: Ie7802aa5a064f8cee471af9bfe0a23bf224831a6
Reviewed-on: https://gerrit.instructure.com/3064
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
James Williams