adds template streaming to the following endpoints:
assignments#show
context_modules#index
courses#show
discussion_topics#show
quizzes/quizzes#show
quizzes/quizzes#edit
quizzes/quizzes#history
Change-Id: I2481f3f738077fb0eaef16e6b5f0db3ea6f60c16
Reviewed-on: https://gerrit.instructure.com/202708
Tested-by: Jenkins
Reviewed-by: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
send the head tag before we start rendering
the rest of the response for the following
high traffic endpoints:
context#roster_user
courses#index
eportfolio_categories#show
eportfolio_entries#show
eportfolios#show
gradebooks#grade_summary
submissions#show
Change-Id: I2bb2e068c4c0633964aee05c27d3e6207e1cf472
Reviewed-on: https://gerrit.instructure.com/199707
Tested-by: Jenkins
QA-Review: Ryan Shaw <ryan@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
We can run these again, now that the RCE API port has been
changed in rspect.
test plan:
- tests pass
Change-Id: Id399589b5e41788210adb4b7661bc606519ae127
Reviewed-on: https://gerrit.instructure.com/195864
Tested-by: Jenkins
Reviewed-by: Kai Bjorkman <kbjorkman@instructure.com>
QA-Review: Tucker Mcknight <tmcknight@instructure.com>
Product-Review: Tucker Mcknight <tmcknight@instructure.com>
The tests should be un-skipped as soon as we change which
port the RCE API is running on, which would be a commit in the
rspect repo.
test plan:
- Tests pass
Change-Id: I4778e2210dee0e1377c9d0826fbb8768c5bc0871
Reviewed-on: https://gerrit.instructure.com/195675
Reviewed-by: Cameron Matheson <cameron@instructure.com>
QA-Review: Cameron Matheson <cameron@instructure.com>
Tested-by: Jenkins
Product-Review: Tucker Mcknight <tmcknight@instructure.com>
test plan:
* permissions should behave exactly as before
* cached permissions should update correctly when changed
through the UI (or if accounts associations are changed)
refs #CORE-2851
Change-Id: I5c39547039b44f77e1f3bd3978783520b8191e3c
Reviewed-on: https://gerrit.instructure.com/193004
Tested-by: Jenkins
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Change-Id: I322027792822f50e7c5afa75e4216534bced031c
Reviewed-on: https://gerrit.instructure.com/194572
Reviewed-by: Derek Bender <djbender@instructure.com>
Tested-by: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
test plan:
* run the migrations
* sending messages and viewing them as an admin
should work as before
closes #COMMS-1327
Change-Id: If955b49d07fa68f8a5151984eb4d9c3b97b118ee
Reviewed-on: https://gerrit.instructure.com/170657
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
closes CORE-942
test plan:
* add `attachment_specific_file_domain: true` to your dynamic_settings.yml
(or to consul) as illustrated in the example
* have a files domain configured
* browse Canvas
* verify that files go through a domain with their ID in it, rather than
just the basic files domain
Change-Id: I21540fb06266dcbf80b66bb884c09cd14eb03456
Reviewed-on: https://gerrit.instructure.com/166462
Tested-by: Jenkins
Product-Review: Matt Miller <mmiller@instructure.com>
Reviewed-by: James Williams <jamesw@instructure.com>
QA-Review: Tucker Mcknight <tmcknight@instructure.com>
This does not remove the old dead code, just all the places
that checked to see if it was enabled.
closes PLAT-3752
Test Plan:
- Regression test on the developer keys page
- Also need to check that creating an oauth 2 token is
not broken (using client credentials)
Change-Id: I89983922a894ff7f20e86c034728d55284c8c668
Reviewed-on: https://gerrit.instructure.com/168271
Tested-by: Jenkins
Reviewed-by: Weston Dransfield <wdransfield@instructure.com>
QA-Review: Weston Dransfield <wdransfield@instructure.com>
Product-Review: Marc Phillips <mphillips@instructure.com>
Change-Id: Ifef519776e4358204dd6625acd6cd9f841cd7fcb
Reviewed-on: https://gerrit.instructure.com/152331
Tested-by: Jenkins
Reviewed-by: James Williams <jamesw@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
with nested specs, where the other group has :once stuff, but the
inner does not
Change-Id: I2145cba249b5cbeb82c19ef47037674ac867f44d
Reviewed-on: https://gerrit.instructure.com/159901
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
this patchset removes the unused provisional grade comments, they
weren't used! It also refactors some app code but the majority of the
work was in speed_grader_spec.rb
test plan:
this patchset removes unused code, so we could smoke test speedgrader
for submission comments with moderated grading, but honestly it seems
like overkill if the specs pass.
closes: GRADE-1311
Change-Id: I0b5d3417d3c113b4fa88542284d1e04b2a291be6
Reviewed-on: https://gerrit.instructure.com/155612
Reviewed-by: Jeremy Neander <jneander@instructure.com>
Reviewed-by: Adrian Packel <apackel@instructure.com>
Tested-by: Jenkins
QA-Review: Derek Bender <djbender@instructure.com>
Product-Review: Keith T. Garner <kgarner@instructure.com>
* disable counter cache detection (we don't use it everywhere, because it can
be a db resource drain)
* mark objects created via spec factories that bypass AR as newly-created,
and thus not needing to have associations preloaded on them
Change-Id: Ifc39c87df753fb28f8b094d77a5afe4f90fe8809
Reviewed-on: https://gerrit.instructure.com/156646
Reviewed-by: Simon Williams <simon@instructure.com>
Tested-by: Jenkins
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
copy state over from before(:once) to examples, so that objects
created in the before(:once) don't get tagged as needing to have
been preloaded
Change-Id: I3a2f4fe1b7359f62f55d61a664e6bdcc1499862e
Reviewed-on: https://gerrit.instructure.com/156632
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
This also moves the pact_config.rb file into the pact folder.
The line filtering :pact tests has been removed from spec_helper.rb,
since rspec won't try to run them anyway now that they aren't in the
spec folder.
Change-Id: I1d8f27f4f30aa2cdc85e570deb7e0aa2cdb89c66
Reviewed-on: https://gerrit.instructure.com/152144
Reviewed-by: Michael Hargiss <mhargiss@instructure.com>
Tested-by: Jenkins
Product-Review: Tucker McKnight <tmcknight@instructure.com>
QA-Review: Tucker McKnight <tmcknight@instructure.com>
When loading or selecting a student in SpeedGrader, an ajax call is made
to obtain the provisional grade status for that student. This provides a
way to perform this request anonymously.
closes GRADE-1128
test plan
- given an anonymously graded and moderated assignment
- given some students assigned to said assignment
- when visiting speed grader
- then the page loads provisional grades endpoint which can be viewed in
the dev tools on the network tab. The URL looks like:
/api/v1/courses/1/assignments/1/anonymous_provisional_grades/status
Change-Id: Ib3d3a7b58fc8fa044d240dee0c1bef08b80384d0
Reviewed-on: https://gerrit.instructure.com/151607
Tested-by: Jenkins
Reviewed-by: Jeremy Neander <jneander@instructure.com>
Reviewed-by: Spencer Olson <solson@instructure.com>
QA-Review: Indira Pai <ipai@instructure.com>
Product-Review: Keith T. Garner <kgarner@instructure.com>
test plan:
- make sure that Jenkins still runs all of the usual tests
- create a Selenium test marked as i18n: true and make sure
that it gets run in the canvas__selenium-i18n build
- console output for failing tests in the i18n build
should include which language they failed in
closes CORE-1038
closes CORE-1041
Change-Id: Ie0f2797b704db4fa6aedae3792c0a75b9e83325e
Reviewed-on: https://gerrit.instructure.com/143659
Reviewed-by: Eric Jacobs <ejacobs@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Tucker McKnight <tmcknight@instructure.com>
Test Plan:
- follow the instructions in spec/contracts/README.md to run
the live events contract tests locally
- follow the instructions in
spec/contracts/service_providers/canvas_lms/README.md to run
the "Generic Consumer" Canvas API contract tests locally
Change-Id: I316747f53731f411ab82432587596e335c2fd059
Reviewed-on: https://gerrit.instructure.com/149766
Reviewed-by: Tucker McKnight <tmcknight@instructure.com>
Tested-by: Jenkins
Product-Review: Michael Hargiss <mhargiss@instructure.com>
QA-Review: Michael Hargiss <mhargiss@instructure.com>
Change-Id: I20d2b6f522a742d220f4263e4d53353bbd996671
Reviewed-on: https://gerrit.instructure.com/146125
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
refs QUIZ-4175
Test Plan:
- qa-cr for now. A subsequent commit will include a comprehensive
test plan once the Quiz LTI contract test is published.
Change-Id: I2ffe962d8a626994614f3cc904d131e41e3a00b1
Reviewed-on: https://gerrit.instructure.com/145857
Tested-by: Jenkins
Reviewed-by: Mark Grant <mgrant@instructure.com>
Product-Review: Michael Hargiss <mhargiss@instructure.com>
QA-Review: Michael Hargiss <mhargiss@instructure.com>
Change-Id: I4146172303ccd60375b829750296349f353f4ac4
Reviewed-on: https://gerrit.instructure.com/146356
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
Product-Review: Simon Williams <simon@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>
Change-Id: I67b0b7b9baa41d76a34f37e2b33541cb10760dc6
Reviewed-on: https://gerrit.instructure.com/145006
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Reviewed-by: Rob Orton <rob@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
closes GRADE-941
test plan:
A. Setup
1. Select or create
a. A Course
b. At least one Student
c. At least one TA
d. At least one Assignment with rubric
2. Enable avatars
3. As the Student
a. Give yo'self an avatar
* Remember to smile
b. Submit to the assignment
c. Comment on the submission
4. As the TA
a. Upload an avatar
* No smiles. You are only an assistant.
b. Comment on the submission
5. As the Teacher
a. Avatar: The Last Gradebender
* Wear that nice sweater you for for your birthday
b. Grade the submission using the rubric
c. Comment on the submission
6. In the Rails console
a. Load the submission
b. Assign `abcde` as the submission `anonymous_id`
c. Save the submission
B. With AMM Enabled
1. Enable the AMM feature flag
2. Visit the course in SpeedGrader
3. Open the browser network dev tool tab
4. Refresh to ensure the `speed_grader.json` request is present
5. View the response to that request
6. Verify for the enrollments
a. The student id is absent from the student enrollment
* `context.enrollments[*].user_id`
b. The enrollment has an anonymous_id of `abcde`
* `context.enrollments[*].anonymous_id`
7. Verify for the submission
a. The submission has an anonymous_id of `abcde`
* `submissions[*].anonymous_id`
b. The submission has no `user_id`
* `submissions[*].user_id`
c. The submission history has an anonymous_id of `abcde`
* `submissions[*].submission_history[*].anonymous_id`
d. The submission history has no `user_id`
* `submissions[*].submission_history[*].user_id`
8. Verify for the student
a. The student id is absent from the student
* `context.students[*].id`
b. The student id is absent from rubric assessments
* `context.students[*].rubric_assessments[*].user_id`
c. The student id is absent from submission comments
* `submissions[*].submission_comments[*].author_id`
d. The student comment has an anonymous_id of `abcde`
* `submissions[*].submission_comments[*].anonymous_id`
e. The student name is absent from submission comments
* `submissions[*].submission_comments[*].author_name`
f. The student avatar is the fallback on submission comments
* `submissions[*].submission_comments[*].avatar_path`
* `/images/messages/avatar-50.png`
9. Verify for the TA
a. The TA id is present on submission comments
* `submissions[*].submission_comments[*].author_id`
b. The TA comment does not have an `anonymous_id`
* `submissions[*].submission_comments[*].anonymous_id`
c. The TA name is present on submission comments
* `submissions[*].submission_comments[*].author_name`
d. The TA avatar is present on submission comments
* `submissions[*].submission_comments[*].avatar_path`
10. Verify for the Teacher
a. The Teacher id is present on submission comments
* `submissions[*].submission_comments[*].author_id`
b. The Teacher comment does not have an `anonymous_id`
* `submissions[*].submission_comments[*].anonymous_id`
c. The Teacher name is present on submission comments
* `submissions[*].submission_comments[*].author_name`
d. The Teacher avatar is present on submission comments
* `submissions[*].submission_comments[*].avatar_path`
C. With AMM Disabled
1. Disable the AMM feature flag
2. Visit the course in SpeedGrader
3. Open the browser network dev tool tab
4. Refresh to ensure the `speed_grader.json` request is present
5. View the response to that request
6. Verify for the enrollments
a. The student id present on the student enrollment
* `context.enrollments[*].user_id`
b. The enrollment does not have an anonymous_id
* `context.enrollments[*].anonymous_id`
7. Verify for the submission
a. The submission has no anonymous_id of `abcde`
* `submissions[*].anonymous_id`
b. The submission has the student id assigned to `user_id`
* `submissions[*].user_id`
c. The submission history has the student id assigned to `user_id`
* `submissions[*].submission_history[*].user_id`
8. Verify for the student
a. The student id is present on the student
* `context.students[*].id`
b. The student id is present on rubric assessments
* `context.students[*].rubric_assessments[*].user_id`
c. The student id is present on submission comments
* `submissions[*].submission_comments[*].author_id`
d. The student comment does not have an anonymous_id
* `submissions[*].submission_comments[*].anonymous_id`
e. The student name is present on submission comments
* `submissions[*].submission_comments[*].author_name`
f. The student avatar is present on submission comments
* `submissions[*].submission_comments[*].avatar_path`
9. Verify for the TA
a. The TA id is present on submission comments
* `submissions[*].submission_comments[*].author_id`
b. The TA comment does not have an `anonymous_id`
* `submissions[*].submission_comments[*].anonymous_id`
c. The TA name is present on submission comments
* `submissions[*].submission_comments[*].author_name`
d. The TA avatar is present on submission comments
* `submissions[*].submission_comments[*].avatar_path`
10. Verify for the Teacher
a. The Teacher id is present on submission comments
* `submissions[*].submission_comments[*].author_id`
b. The Teacher comment does not have an `anonymous_id`
* `submissions[*].submission_comments[*].anonymous_id`
c. The Teacher name is present on submission comments
* `submissions[*].submission_comments[*].author_name`
d. The Teacher avatar is present on submission comments
* `submissions[*].submission_comments[*].avatar_path`
11. Smoke test SpeedGrader
Change-Id: I57806c555b904757876523f4e201cfd8dcd31e61
Reviewed-on: https://gerrit.instructure.com/143287
Reviewed-by: Spencer Olson <solson@instructure.com>
Tested-by: Jenkins
Reviewed-by: Derek Bender <djbender@instructure.com>
QA-Review: Anju Reddy <areddy@instructure.com>
Product-Review: Keith T. Garner <kgarner@instructure.com>
and rename that suite of methods to make more sense
test-plan: N/A
Change-Id: Iffc520ea55141ac47da669663838a4d3c3d8712c
Reviewed-on: https://gerrit.instructure.com/142486
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: Jacob Fugal <jacob@instructure.com>
QA-Review: Jacob Fugal <jacob@instructure.com>
and overall maybe suck a little less
test plan:
* enable the feature "SIS Import Refactor"
* lower the threshold to use multiple parallel jobs
via "/plugins/sis_import" to a number like 2
* regression tests for sis batch imports
closes #CORE-927 #CORE-928
Change-Id: I91b0bb0cc0e0957cae7897af453ed2d19555303d
Reviewed-on: https://gerrit.instructure.com/140535
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Tucker McKnight <tmcknight@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
allow switching between courses that belong to different grading period
groups
closes GRADE-768
test plan:
* Create three terms in an Account, T1, T2 and T3
* Leave T1 without any grading periods
* Create a new Grading Period set (and grading periods) in T2
* Create a separate new Grading Period set (and grading periods) in T3
such that there is some overlap between the grading periods from this
set and the one you created for T2
* Create five courses, C1, C2, C3, C4, C5
* Associate C1 and C2 with term T1 so they have no grading periods
* Associate C3 and C4 with term T2
* Associate C5 with term T3
* Create assignments in each of these courses with at least one
assignment in each grading period
* Enroll one student in all four of these courses
* Grade this student for all the assignments in all courses
* As the student, visit the grade summary page for C1
* Verify you don't see the grading period filter
* From the filters, change the course to C2 and click "Apply"
* Verify you're now seeing the grade summary page for C2
* Verify the URL does not contain a parameter named "grading_period_id"
* Verify this page doesn't show the grading period filter either
* From the filters, change the course to C3 and click "Apply"
* Verify you're now seeing the grade summary page for C3
* Verify the URL does not contain a parameter named "grading_period_id"
* Verify this page now does show the grading period filter
* Verify the grading period filter shows the current grading period i.e.
one that covers the date/time right now
* From the filters, change the grading period to another one and
click "Apply"
* Verify you're still on the grade summary page for C3
* Verify the URL now does contain a parameter named "grading_period_id"
* Verify this page also shows the grading period filter
* Verify the grading period filter shows the grading period you selected
* From the filters, change the course to C4 and click "Apply"
* Verify you're now seeing the grade summary page for C4
* Verify the URL now does contain a parameter named "grading_period_id"
* Verify this page now does show the grading period filter
* Verify that the grading period filter shows the same grading period
it did for the page you just came from (grade summary for C3)
* From the filters, change the course to C5 and click "Apply"
* Verify you're now seeing the grade summary page for C5
* Verify the URL does not contain a parameter named "grading_period_id"
* Verify this page also shows the grading period filter
* Verify the grading period filter shows the current grading period i.e.
one that covers the date/time right now
Change-Id: If9ceb843fbcc2d5b38f80ef415feaff34a8c96ba
Reviewed-on: https://gerrit.instructure.com/139115
Reviewed-by: Spencer Olson <solson@instructure.com>
Reviewed-by: Derek Bender <djbender@instructure.com>
Tested-by: Jenkins
QA-Review: Anju Reddy <areddy@instructure.com>
Product-Review: Keith T. Garner <kgarner@instructure.com>
fixes CORE-324
test plan
- run a sis import with errors
- the errors should be included in the api JSON
Change-Id: I97e372a82b565e7bfa01cd9ca0bb66bb67c95723
Reviewed-on: https://gerrit.instructure.com/139071
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
this allows us to send different indexes to
multiple workers and process the file in
parallel.
fixes CORE-903
test plan
- specs should pass
Change-Id: I06d8da8c50476f4a62e0138352ab759b4874f8e8
Reviewed-on: https://gerrit.instructure.com/138814
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
test plan
- specs should pass
Change-Id: Iafc7c9b8ca64f32568e658b600e19c2e6f9045ca
Reviewed-on: https://gerrit.instructure.com/138026
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Change-Id: I13eddbe900070b8f50ff5c8f6f016daa27ec87d1
Reviewed-on: https://gerrit.instructure.com/128447
Tested-by: Jenkins
QA-Review: Steven Burnett <sburnett@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
Reviewed-by: Steven Burnett <sburnett@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
Reviewed-by: James Williams <jamesw@instructure.com>
fixes CNVS-35635
test plan:
- go to Account Settings > Admin Tools
- click on the View Notifications tab
- search for users that will result in a large number of results
- click on any of the users
- note that a modal pops up with a date range
- select a range
- note that the results update (assuming there's notification to be
found) when you click the Find button and the modal goes away
- note that this provides a decent a11y experience
Change-Id: I57db77950a69842249cace0c738025d9ee131b0d
Reviewed-on: https://gerrit.instructure.com/125818
Tested-by: Jenkins
Reviewed-by: Ed Schiebel <eschiebel@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Felix Milea-Ciobanu <fmileaciobanu@instructure.com>
test plan:
* use the API to queue a content migration for a course
with a parameter 'file_url' set to a local url
(i.e. 'localhost:3000/500.html')
* it should not download the file and allow the file
to be downloaded on the content migrations page
for the course
* create a link to a local file
in a piece of course content (i.e. a page)
* run the course link validator
* it should not actually check if the link exists locally
or not, but rather always flag the link
closes #SEC-606 SEC-607
Change-Id: I671c017ec93d88446df77d716725fff8874622bc
Reviewed-on: https://gerrit.instructure.com/125118
Tested-by: Jenkins
Reviewed-by: Brad Horrocks <bhorrocks@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Heath Hales <hhales@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
also remove a method that doesn't do anything
should make things faster maybe?
Change-Id: Ie3849b6faa539317338c6f55a0f7be86b8a20c3d
Reviewed-on: https://gerrit.instructure.com/122440
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
also clean up a final few mocha => rspec-mock translations that
were missed
Change-Id: I805c82c84d73099cc396bf9d3a976ebfc972c84c
Reviewed-on: https://gerrit.instructure.com/120680
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Change-Id: I68cd388bbf7d22d7608a68fbb075493e4a1709fc
Reviewed-on: https://gerrit.instructure.com/120423
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
* ENV['NO_MOCHA']=1 to disable mocha
* switch several core mocks to rspec-mocks
* fix Great Expectations to allow mock expectations
in before blocks
Change-Id: Icee8dee7f01234d2dd4e26ac13562fe9fc93665a
Reviewed-on: https://gerrit.instructure.com/119984
Tested-by: Jenkins
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
Change-Id: Ib6f1923b8ff0ec148bfcf5416e3c4d239f5707d5
Reviewed-on: https://gerrit.instructure.com/120243
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
until rcs is open sourced we don't want it enabled by default for
open source users.
closes CNVS-38092
test plan:
- disable rcs feature flag
- rcs should be off everywhere
- from the rails console run:
- Setting.set('rich_content_service_enabled', 'true')
- send SIGHUP to your rails process(es)
- rcs should be on for eportfolios and wiki pages
- enable rcs feature flag
- rcs should be on everywhere
Change-Id: Ibca84b7183dd0344b73433024b47e9948cbab3e8
Reviewed-on: https://gerrit.instructure.com/118223
Tested-by: Jenkins
Reviewed-by: brian kirkby <bkirkby@instructure.com>
QA-Review: Tucker McKnight <tmcknight@instructure.com>
Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
the first two rcs flags have been enabled for all hosted accounts
for a long time. we are changing the lable of the 3rd flag and removing the
first two to provide better clarity as we enable the 3rd flag for
accounts.
closes CNVS-37261
test plan:
- go to the feature flags page for an account
- there should only be one rcs flag with an updated message
- ensure that flag is disabled
- editing wiki pages should still have the new sidebar
- high risk area (i.e. quizzes, assignments) should not have the new
sidebar
- enable the flag
- all editors should be using rcs with the new sidebar
Change-Id: I689eb9ebaf4d3a5fc111c231d13861cc28ae5d87
Reviewed-on: https://gerrit.instructure.com/116542
Tested-by: Jenkins
Reviewed-by: brian kirkby <bkirkby@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
James Williams