Commit Graph

9 Commits

Author SHA1 Message Date
Jacob Burroughs 7dcc507d0a Rubocop for ruby 3.1
[skip-stages=Flakey]

Change-Id: I6abefdfa9fed6dd4525c8786e93efa548b3710f2
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/319603
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
QA-Review: Jacob Burroughs <jburroughs@instructure.com>
Product-Review: Jacob Burroughs <jburroughs@instructure.com>
Build-Review: Jacob Burroughs <jburroughs@instructure.com>
Migration-Review: Jacob Burroughs <jburroughs@instructure.com>
2023-06-06 16:44:26 +00:00
Cody Cutrer 502aa068da rubocop: Layout/Multiline*LineBreaks
[skip-stages=Flakey]

Change-Id: I24912809267088bc19a4082c49bc5f78ca7b76bb
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/317302
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
Build-Review: Jacob Burroughs <jburroughs@instructure.com>
Migration-Review: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2023-05-01 19:31:42 +00:00
Cody Cutrer 5067ecfb56 RuboCop: Style/ExplicitBlockArgument
[skip-stages=Flakey]

auto-corrected

Change-Id: I73d924591db9441458f2f128f6182d80da7e2cf1
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/278358
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-17 20:04:02 +00:00
Cody Cutrer 5e3e922307 RuboCop: Layout app
Change-Id: I4cf9600c9636a66509f1ab183b936381ea0aefb4
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274156
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2021-09-22 19:35:01 +00:00
Michael Ziwisky 338a3ef948 upgrade graphql gem to latest
fixes INTEROP-6951

upgrade required some tweaks including the following:
 - `GraphQL::Execution::Interpreter` removed from CanvasSchema because
   it is now included in GraphQL::Schema by default
 - `BaseMutation.input_type` adds arguments properly instead of using
   `merge!`, which blows up because `own_arguments` is a frozen Hash.
   (see https://github.com/rmosolgo/graphql-ruby/commit/55a955a84)
 - `NotificationPreferencesContextType` gets defined just once to avoid
   errors from specifying dupicate enum values each time its reopened
 - `.graphql_name` needed in a couple of places where `.name` (or
   implicit `.to_s` from string interpolation) previously worked.
   (see
https://github.com/rmosolgo/graphql-ruby/blob/master/CHANGELOG.md#breaking-changes-14)
 - `GraphQL::Schema` uses the new `GrpahQL::Pagination::Connections`
   connections by default (previously `GraphQL::Relay::BaseConnection`),
   so our custom `PatchedArrayConnection` and `DynamoConnection` classes
   got redone in accordance with the new interface.
 - https://github.com/rmosolgo/graphql-ruby/pull/2792 made it so
   argument names are used as-specified, while previously they were
   automatically snake-cased.  so the `gradingPeriodId` argument of
   `AssignmentFilterInputType` is now specified in snake-case, and
   everyone is happy. (note that in the generated GQL schema definition,
   it remains camel-cased, so the client interface is unchanged).
 - some sloppy queries in specs have been cleaned up because the GQL
   parser has been tightened up and was no longer recognizing them.

also, unrelated to the gem bump, but the inst_access_tokens route was
typo'd as a singular.  here it's corrected to the plural.

test plan:
 - since it's just a version bump, spec coverage should be sufficient

Change-Id: Ib73eed4c1356833dfe245188b0841c98ae2c378a
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/270132
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Ethan Vizitei <evizitei@instructure.com>
QA-Review: Michael Ziwisky <mziwisky@instructure.com>
Product-Review: Michael Ziwisky <mziwisky@instructure.com>
2021-07-30 17:01:32 +00:00
Cody Cutrer 0177f53cc2 add # frozen_string_literal: true for graphql
Change-Id: Ia976f08893ca88a6cd7cbeed73254ec36d370ac4
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/251151
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
2020-10-27 15:56:39 +00:00
Cameron Matheson 4b98213b57 support date ranges in mutation audit log
Test plan:
  search for mutations between a date range using the mutation audit log

closes GQL-82

Change-Id: I99b7cba460261fe556073f3b5cc410dd1c3250e2
Reviewed-on: https://gerrit.instructure.com/205573
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
2019-08-21 22:35:21 +00:00
Cameron Matheson e4fa18fcd7 mutation audit log: return most recent results first
closes GQL-71

Test plan:
  mutation audit log graphql queries should be ordered by date
  (descending)

Change-Id: I4f1d3fa426158b6930ffdca00f852827e93bc1e9
Reviewed-on: https://gerrit.instructure.com/202879
Tested-by: Jenkins
Reviewed-by: Landon Gilbert-Bland <lbland@instructure.com>
QA-Review: Cameron Matheson <cameron@instructure.com>
Product-Review: Cameron Matheson <cameron@instructure.com>
2019-07-30 16:40:48 +00:00
Cameron Matheson 90d8efef93 graphql: add mutation audit log
closes GQL-59, GQL-63
refs GQL-46

Test plan:
  * enable dynamodb
  * do some mutations
  * they should be queryable in the new audit log

Change-Id: I3b2753499c963fdbe3375079ffbd352285708cc7
Reviewed-on: https://gerrit.instructure.com/192138
Reviewed-by: Rob Orton <rob@instructure.com>
Reviewed-by: Landon Gilbert-Bland <lbland@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
Tested-by: Jenkins
2019-07-23 21:17:45 +00:00