this is a feature that is only accessible to site admin users and the
ability to link to a specific message would have been useful many many
times in the past. This also exposes id on the messages index to make it
easier to find the message to link to.
test plan
- go to /messages
- it should render
- it should also have id of the message above subject
- go to /messages/id
- it should render and appear like /messages but with one message
fixes KNO-455
flag=none
Change-Id: I713f7e5676bba68421d07792f1abd16a32152d0e
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/236175
Reviewed-by: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Fixes: CNVS-39096
test plan:
- navigate to localhost:3000/users/1/messages (this is
a canvas site admin only page view) - tables should
now be using `ic-Table ic-Table--condensed` vs
bootstrap `table table-condensed`
example: https://screencast.com/t/bjzgJlKelD
Change-Id: I6e993c1973af5f8691b248b67c799c10e8f8f933
Reviewed-on: https://gerrit.instructure.com/126605
Tested-by: Jenkins
Reviewed-by: Chris Hart <chart@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
QA-Review: Dan Sasaki <dsasaki@instructure.com>
Fixes CNVS-25343
Test plan:
- Verify that every visible iframe in Canvas has a non-empty title attribute
- Verify that every title attribute on an iframe has meaningful content ,
which correctly indicates the content the iframe contains.
Change-Id: Iac3a2031a81836b11e1e4bfdc2d242777a493172
Reviewed-on: https://gerrit.instructure.com/68027
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
Tested-by: Jenkins
QA-Review: Simon Williams <simon@instructure.com>
fixes CNVS-5147
test steps:
- trigger a twitter notification and ensure the link is pointing to
the correct url (without 'mr' in the url)
Change-Id: Ib70b67039e919720c941c15ec1d20eca652d478b
Reviewed-on: https://gerrit.instructure.com/19882
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Zach Pendleton <zachp@instructure.com>
Product-Review: Marc LeGendre <marc@instructure.com>
QA-Review: Marc LeGendre <marc@instructure.com>
All of the outbound email notifications have been updated to have
a matching HTML version of the email in order for us to send multi-
part emails. There has also been some tweaking of the other email
messages (summary, plain text, etc) with a better looking layout
fixes CNVS-4728
fixes CNVS-4795
test steps:
- generate email messages for each template and review the results
in the users message list view (/users/1/messages)
Change-Id: I1fd9cf2b134209e42c8d174f19b50963e6502f6a
Reviewed-on: https://gerrit.instructure.com/18942
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Marc LeGendre <marc@instructure.com>
Reviewed-by: Zach Pendleton <zachp@instructure.com>
Product-Review: Eric Berry <ericb@instructure.com>
fixes CNVS-2514
allow multiple reply-to addresses that will be rotated
across when sending mail. this commit, in conjunction with
CNVS-3781, allows canvas to receive mail from multiple
inboxes and distribute its incoming mail across them.
test plan:
* configure config/outgoing_mail.yml with multiple
reply_to_addresses as explained in
config/outgoing_mail.yml.example;
* trigger at least n notifications for a user in canvas,
where n is the number of reply_to_addresses configured;
* visit /user/:id/messages and verify that each message
is sent from a different reply_to address.
Change-Id: I53c01c7c355dcbf7c16595070f41eee721814849
Reviewed-on: https://gerrit.instructure.com/17870
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Zach Pendleton <zachp@instructure.com>
QA-Review: Zach Pendleton <zachp@instructure.com>
test plan:
- create a course with teacher and student
- set student's announcement notifications to asap
- create an announcement as a teacher
- view the students messages, see that "From Name" is displayed
Change-Id: I1d57a7df7f83806c8e7510c6a2fc692dabef7050
Reviewed-on: https://gerrit.instructure.com/15045
Reviewed-by: Mark Ericksen <marke@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Marc LeGendre <marc@instructure.com>
refs #11068
this commit (1) updates styles on messages page; and
(2) adds a reply option to the messages page that sends
a reply email to a selected message's reply-to address.
test plan:
* create a course with at least two users enrolled;
* as user 1, create a new discussion topic;
* as an admin, go to /users/{{user-2-id}}/messages and
find the message;
* click the "reply" link, enter a test message in the
modal form, and send it;
* view the discussion and verify that the new message
appears as expected.
Change-Id: I40b4596a548f7b1c9865ce6f9e875e384f2284e1
Reviewed-on: https://gerrit.instructure.com/14636
Reviewed-by: Mark Ericksen <marke@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
test plan:
* log in as site admin
* go to /users/<id>/messages
Change-Id: I87dec0526bab52ccc45b722e705e4fc6178a8aaa
Reviewed-on: https://gerrit.instructure.com/9546
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
Rob Orton