flag=none
refs: MBL-14399
Test plan:
- Enroll a student in a course
- Create and publish an assignment in the course and set its due date to
some day this month
- Create a calendar event on the user's calendar
- As the student, query the calendar_events api for the assignment
- Something like: /api/v1/calendar_events
?type=assignment
&start_date=2020-05-01
&end_date=2020-05-30
&context_codes[]=course_1
- The context_name should be included
- As the student, give the course a nickname
- The context_name should be the nickname of the course
- As the student, query the calendar_events api for the calendar event
- Something like: /api/v1/calendar_events
?start_date=2020-05-01
&end_date=2020-05-30
- The context_name should be included
Change-Id: Ie5336637824d3241d39b7fbb6dcb083e3ec25cdc
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/237393
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Ben Nelson <bnelson@instructure.com>
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Ben Nelson <bnelson@instructure.com>
Product-Review: Ben Nelson <bnelson@instructure.com>
closes LA-812
test plan:
- migrate your database to create the new is_rce_favorite column
- For root account LTI tools with an editor button placement, the
external_tools create and update actions should allow you to specify
an is_rce_favorite parameter.
- The specified value of that parameter should be returned in
external_tools index and show actions.
- LTI tools that are not at the root account should not return an
is_rce_favorite field at all.
- LTI tools that do not have an editor button placement should not
return an is_rce_favorite field at all.
Change-Id: I59ab583bdf0793bedec9c3d89d7d1fbb5582f6e0
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/229575
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Jon Willesen <jonw+gerrit@instructure.com>
closes LA-933
flag=assignment_bulk_edit_phase_2
test plan:
- The date range fields are only visible if the phase 2 flag is set
- If both dates are blank, apply button is disabled.
- If either date field is filled, apply button is enabled.
- In the "select by date range", fields enter two dates.
- If the end date is before the start date, an error should be displayed
and the apply button disabled.
- Click the apply button with a valid date range. All assignments with
any date on any override that fall within the date range should be
selected. All other assignments should not be selected
- If only the start field is filled, it should select all assignments on
that date or afterward.
- If only the end field is filled, it should select all assignments on
that date or before.
- Assignments with no dates never get selected
Change-Id: Ie5915a1e77f1b3117cd14c2818395fdde7343761
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/236971
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Lauren Williams <lcwilliams@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
closes LA-798
flag = none
Test Plan:
- verify when creating an course_account_association, that
the root_account_id is set correctly
Change-Id: I52e8086b4411fce81196ab874441dfec7cedb7d6
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/236753
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Clint Furse <cfurse@instructure.com>
closes LA-806
flag = none
Test Plan:
- create a rubric that can be used for grading
- in speed grader, use the rubric to grade a students assignment
- verify the rubric_assessment record contains the correct root_account_id
Change-Id: Ib26d7408f0ca8081a3d62a672cc5e432181eac87
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/236554
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Clint Furse <cfurse@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Closes PLAT-5557
flag=none
Test Plan:
- Verify migrations run
- Verify a root_account_id can be set on a
AssignmentOverrideStudents record
- Verify AssignmentOverrideStudents always
live on the same shard as their root account
Change-Id: I93c58d4cf59e70435d6e130555e5e8aa58d18923
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/234785
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Weston Dransfield <wdransfield@instructure.com>
Product-Review: Weston Dransfield <wdransfield@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
Reviewed-by: Evan Battaglia <ebattaglia@instructure.com>
Closes PLAT-5556
flag=none
Test Plan:
- Verify migrations run
- Verify a root_account_id can be set on a
AssignmentOverride record
- Verify AssignmentOverrides always live on the same shard
as their root account
Change-Id: Ie4a18f1bb9a3c6a525d4e56ad8df3a5b04085150
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/234787
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Weston Dransfield <wdransfield@instructure.com>
QA-Review: Weston Dransfield <wdransfield@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
Reviewed-by: Evan Battaglia <ebattaglia@instructure.com>
refs CNVS-48876
flag = none
TEST PLAN:
1) backfill auditors
2) latency in cassandra reads should be roughly
uniform for a given level of parallelism
Change-Id: Ic9bd3a6d52a28e33e11d89e32950e4f87ba67ee7
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/237655
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Ethan Vizitei <evizitei@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
closes CAL-37
flag=calendar_conferences
Test plan:
- enable conferences in calendar events
- enable BBB plugin
- add BBB conference to course calendar event
- save event
- verify that conference appears on course /conferences
page with event title and start date
- edit event to update title and start time
- verify that conference is updated on course
/conferences page
Change-Id: Idf63d522e09ba11660cbd79a70f4278c4cca0d66
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/236863
Reviewed-by: Ken McGrady <kmcgrady@instructure.com>
QA-Review: Steve Shepherd <sshepherd@instructure.com>
Product-Review: Steve Shepherd <sshepherd@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
closes OUT-3675
flag=selectable_outcomes_in_course_copy
setup:
- create a course with many outcome groups,
containing many other outcome groups, each
with multiple outcomes
test plan:
- export a copy of the course
- in a new course, import the contents of the previous course,
selecting "Select specific content" option
- confirm that when selecting content, that selectable outcomes
are availble to import
Change-Id: Id9834f1f1256f7a69d8e0edb2593b196cf4deb05
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/237433
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Michael Brewer-Davis <mbd@instructure.com>
Reviewed-by: Pat Renner <prenner@instructure.com>
QA-Review: Brian Watson <bwatson@instructure.com>
Product-Review: Jody Sailor
test plan:
* import a cc package with blank file anchor tags in
html content
* they should be visible because they are now populated
with the file name
closes #LA-1020
Change-Id: I82adb68a01b134ecf29ee4db6dde11487b8b186c
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/237443
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Jeremy Stanley <jeremy@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
there are some text fields that have issues with selenium
and send_keys, implemented a retry to attempt entering the
correct text.
Test Plan:
- jenkins passes
flag = none
fixes: CCI-371
Change-Id: Icd3eeaa823465bbddd21cbdc9ab71e53c5d37d28
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/237396
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Derek Bender <djbender@instructure.com>
Reviewed-by: Jacob Powell <spowell@instructure.com>
QA-Review: James Butters <jbutters@instructure.com>
Product-Review: James Butters <jbutters@instructure.com>
pact scripts in bin/ are for local runs of pact and need to
use web container, new files that are in build/new-jenkins
don't need the check if Jenkins.
flag = none
Change-Id: I878b157b9856f1c25e160d7608b226f7185974a3
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/237520
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Rex Fleischer <rfleischer@instructure.com>
Reviewed-by: Derek Bender <djbender@instructure.com>
Reviewed-by: Jacob Powell <spowell@instructure.com>
Product-Review: James Butters <jbutters@instructure.com>
QA-Review: James Butters <jbutters@instructure.com>
refs CNVS-48876
flag = none
TEST PLAN:
1) backfill auditors
2) job density should decrease to 1/7
3) job length of execution should not meaningfully increase
4) cassandra latency should increase a little for same
parallelism
5) cell progress should accellerate about 2x
Change-Id: Iba731fc9c11975a9eabe4865b0cd0f097853420e
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/237539
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
fixes KNO-428
flag=none
Starred conversations were previously being scoped
by those considered "visible" or, that had received
a response from another user. To circumvent that,
we introduce a new scoping method on the User.
test plan:
- have 2 users in a course
- navigate to /conversations
- as user A, send 2 separate messages to user B
- star both conversations
- as user B, respond to only 1 of the messages
- as user A, visit /conversations#filter=type=starred
- both conversations should appear
qa risk: low
Change-Id: I100766e75048afbf187b4a36cf3c4556421063c0
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/237437
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Drake Harper <drake.harper@instructure.com>
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Drake Harper <drake.harper@instructure.com>
Product-Review: Drake Harper <drake.harper@instructure.com>
refs UIDEV-313
flag=none
Test plan:
Confirm the console errors currently visible on production
when you open /styleguide are gone.
The /styleguide page should now only feature the
the following basic HTML/CSS components:
- Borders
- Buttons
- Forms
- Grid
- Icons
- Spacing
- Tables
- Typography
In the header, there should be a clearer explanation that the CSS is
usable in the RCE, but not actively maintained. LTI app builders are
pointed to Instructure UI instead.
Change-Id: I86deee3dbf71c97bd150b71ab01e8af8de553ae5
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/236943
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Pam Hiett <phiett@instructure.com>
Product-Review: Pam Hiett <phiett@instructure.com>
QA-Review: Daniel Sasaki <dsasaki@instructure.com>
This is in a separate repository (model-generator) now.
Change-Id: I5974799efe41d44b624dc037991d684e1c64a26e
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/237022
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Jeremy Slade <jslade@instructure.com>
Reviewed-by: Jeremy Slade <jslade@instructure.com>
QA-Review: Tucker Mcknight <tmcknight@instructure.com>
closes USERS-523
flag = none
test plan:
* builds should pass
Change-Id: Id34d85e58f6dc693b8a6ffca37d08d838562daec
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/235344
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Powell <spowell@instructure.com>
Reviewed-by: James Butters <jbutters@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: August Thornton <august@instructure.com>
Nate Armstrong