ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
47,915 Commits 324 Branches 20,019 Tags 1.7 GiB
Commit Graph

105 Commits

Author SHA1 Message Date
Omar Gerardo Soto-Fortuño f7317bf0b1 Add missing userId to a few tests 
flag=none

test plan:
  - Specs pass

qa risk: low

Change-Id: Iec4614be0784b0f363c579d68dd077d7ec6ac056
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277188
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Caleb Guanzon <cguanzon@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Caleb Guanzon <cguanzon@instructure.com>
 2021-11-01 15:10:07 +00:00
Jeff Largent 67ecc41b76 Suppress JSDOM scrollTo and navigation error messages 
This change stubs window.scrollTo and several window navigation
functions (window.location = '...', window.location.href = '...', and
window.location.reload()) with noops to suppress JSDOM messages
warning that these functions aren't implemented. E.g. these ones:

Error: Not implemented: scrollTo
Error: Not implemented: navigation (except hash changes)

While potentially useful if you're expecting those browser APIs to
work in a JSDOM environment, they noise up our Jest logs real good.

Test plan:
  - Tests still pass

Change-Id: I9166d0ee05273cc07069b62a1a041eeb335fbfe6
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/275919
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Robin Kuss <rkuss@instructure.com>
Reviewed-by: Charley Kline <ckline@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Jeff Largent <jeff.largent@instructure.com>
 2021-10-14 21:02:13 +00:00
Robin Kuss 007be5c609 spec: fix canReadAnnouncements missing in K5Dashboard test 
Closes LS-2731

Test Plan: Does not emit error/warning now in Jenkins

Change-Id: Iccb58891d23f521acfe3b5ff78deb9c32269b7c2
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/275882
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jeff Largent <jeff.largent@instructure.com>
QA-Review: Jeff Largent <jeff.largent@instructure.com>
Product-Review: Robin Kuss <rkuss@instructure.com>
 2021-10-14 12:05:57 +00:00
Ed Schiebel e9afcfcce3 Remove rce_enhancements flag from canvas - phase 1 
refs LS-2655
flag=none

- this updates the files under ./ui, a few ancillary files and specs.
- Sadly the commit hook ran prettier and
  fiddled with the formatting of a handful of files too.
- Also made a few changes to quiet lint errors
- Also updated OutcomeManagement.test.js. I don't understand why,
  but 'renders ManagementHeader with lhsGroupId if selected a group in lhs'
  started failing with this change, even though nothing obviously related
  changed. The problem is that the modal isn't getting attached to the
  document being tested. The spec changed to test that the modal contained
  what it's supposed to contain.

test plan: jenkins passes and the RCE works

Change-Id: I48d85077bdbf7563cb07510d3e71d2b448c55e49
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/275301
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Weston Dransfield <wdransfield@instructure.com>
QA-Review: Weston Dransfield <wdransfield@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
 2021-10-08 16:59:19 +00:00
Robin Kuss 41c08d69da spec: add required canAddObservee prop for K5Dashboard 
Closes LS-2713

Test Plan: passes Jenkins

Change-Id: I27d57fc670d1ecda7345581cba9a93c5fb075424
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/275393
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jackson Howe <jackson.howe@instructure.com>
QA-Review: Jackson Howe <jackson.howe@instructure.com>
Product-Review: Robin Kuss <rkuss@instructure.com>
 2021-10-08 13:31:11 +00:00
Robin Kuss 4e8e59b9c1 spec: fix one jest ignored error 
Closes CTA-6

Test Plan:  passes Jenkins

Change-Id: Ie58364e94213b1d70c11daf27e1362e7b3c48a28
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/275295
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Robin Kuss <rkuss@instructure.com>
Reviewed-by: Jackson Howe <jackson.howe@instructure.com>
QA-Review: Jackson Howe <jackson.howe@instructure.com>
 2021-10-06 15:33:31 +00:00
Davis Hyer beac08e570 provide correct isLiked prop type 
flag=none

test plan:
  - specs pass

qa risk: low

Change-Id: I05a7e6f135a3308f8648e1a875cd54f445037452
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274447
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
 2021-09-28 19:53:57 +00:00
Davis Hyer b6dc331acf fix IntegrationRow to provide children as a single element 
flag=none

test plan:
  - specs pass

qa risk: low

Change-Id: I0fc757a0841ade4f98fc167fd46d76fa6b661208
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274392
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Davis Hyer <dhyer@instructure.com>
Reviewed-by: Weston Dransfield <wdransfield@instructure.com>
QA-Review: Weston Dransfield <wdransfield@instructure.com>
 2021-09-28 17:15:31 +00:00
Davis Hyer 0f51de4ed3 provide correct firstAnnouncement prop type 
flag=none

test plan:
  - specs pass

qa risk: low

Change-Id: Ib4b764ced6a09b0630388557ff636aca79deac2a
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274444
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
 2021-09-25 00:07:47 +00:00
Davis Hyer c8f3e1ce0f provide correct allSubmissions prop types 
flag=none

test plan:
  - specs pass

qa risk: low

Change-Id: I96e6ca637f78baf5e54bede3bb11541074fdac39
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274436
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
 2021-09-25 00:07:31 +00:00
Davis Hyer d289fdb87a provide correct colors prop types 
flag=none

test plan:
  - specs pass

qa risk: low

Change-Id: Ic61afc7c0e56f9582ec0ec34f7cc873febed47d3
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274441
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
 2021-09-25 00:07:18 +00:00
Davis Hyer f2ad23a82a provide required accountId prop 
flag=none

test plan:
  - specs pass

qa risk: low

Change-Id: Ia5b6ae2252216c707cd6ea6497b6b4438cb2d1ae
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274434
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
 2021-09-25 00:06:57 +00:00
Omar Gerardo Soto-Fortuño c23b8f0cdd Fixes on MessageListActionContainer.test.js 
flag=none

test plan:
  - Specs pass

qa risk: low

Change-Id: Icd80f84ac17fa6fe4529ae8c812b00bbe8c30bc9
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274426
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Davis Hyer <dhyer@instructure.com>
QA-Review: Davis Hyer <dhyer@instructure.com>
Product-Review: Davis Hyer <dhyer@instructure.com>
 2021-09-24 21:06:22 +00:00
Omar Gerardo Soto-Fortuño c373a695e1 Provide imageUrl for ErrorBoundary test 
flag=none

test plan:
  - Specs pass

qa risk: low

Change-Id: Id504544694127494ad53434d9a700bdb3ba1a75c
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274422
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Davis Hyer <dhyer@instructure.com>
QA-Review: Davis Hyer <dhyer@instructure.com>
Product-Review: Davis Hyer <dhyer@instructure.com>
 2021-09-24 20:38:13 +00:00
Omar Gerardo Soto-Fortuño c301257a6a Provide type on Conference.test.js 
flag=none

test plan:
  - Specs pass

qa risk: low

Change-Id: I3e52e77ffbbbe20cb0224dc5308959455a0f2843
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274420
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Davis Hyer <dhyer@instructure.com>
QA-Review: Davis Hyer <dhyer@instructure.com>
Product-Review: Davis Hyer <dhyer@instructure.com>
 2021-09-24 20:37:36 +00:00
Omar Gerardo Soto-Fortuño 200aac7e53 Provide closeTray to HelpTray 
flag=none

test plan:
  - Specs pass

qa risk: low

Change-Id: I3730655f884e4eab7c386ff6153aaa0674ae2e41
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274418
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Davis Hyer <dhyer@instructure.com>
QA-Review: Davis Hyer <dhyer@instructure.com>
Product-Review: Davis Hyer <dhyer@instructure.com>
 2021-09-24 20:37:18 +00:00
Omar Gerardo Soto-Fortuño 53ca889a40 Fixes on RSSFeedList.test.js 
flag=none

test plan:
  - Specs pass

qa risk: low

Change-Id: Ic5fc4ad2459c2dc2e61327f274d6dfd06ef94ca7
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274406
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Davis Hyer <dhyer@instructure.com>
QA-Review: Davis Hyer <dhyer@instructure.com>
Product-Review: Davis Hyer <dhyer@instructure.com>
 2021-09-24 19:23:18 +00:00
Omar Gerardo Soto-Fortuño 27b086684f Fixes on K5Course.test.js 
flag=none

test plan:
  - Specs pass

qa risk: low

Change-Id: Ie2bf09f6d69b38276662cb1272be2df8d5915c33
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274413
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Davis Hyer <dhyer@instructure.com>
QA-Review: Davis Hyer <dhyer@instructure.com>
Product-Review: Davis Hyer <dhyer@instructure.com>
 2021-09-24 19:22:53 +00:00
Omar Gerardo Soto-Fortuño 5eb856c60b Fixes on SearchResults.test.js 
flag=none

test plan:
  - Specs pass

qa risk: low

Change-Id: Id1db6f114f2a4a722032d06902601eaf83df198f
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274385
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Davis Hyer <dhyer@instructure.com>
QA-Review: Davis Hyer <dhyer@instructure.com>
Product-Review: Davis Hyer <dhyer@instructure.com>
 2021-09-24 18:34:19 +00:00
Omar Gerardo Soto-Fortuño 98863c2f27 Provide homeroomAnnouncements on HomeroomPage.test.js 
flag=none

test plan:
  - Specs pass

qa risk: low

Change-Id: Ifa3f6f7c06d2f4f9c059644ffea48ab6fdd9642e
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274400
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Davis Hyer <dhyer@instructure.com>
QA-Review: Davis Hyer <dhyer@instructure.com>
Product-Review: Davis Hyer <dhyer@instructure.com>
 2021-09-24 18:33:57 +00:00
Omar Gerardo Soto-Fortuño b6677117d3 Fixes on ManagementHeader.test.js 
flag=none

test plan:
  - Specs pass

qa risk: low

Change-Id: I54d5dd5b5b780c632d6e754b7cc04c1182d9d8ec
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274402
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Davis Hyer <dhyer@instructure.com>
QA-Review: Davis Hyer <dhyer@instructure.com>
Product-Review: Davis Hyer <dhyer@instructure.com>
 2021-09-24 18:33:19 +00:00
Omar Gerardo Soto-Fortuño 57c878cbda Provide focusAttemptOnInit on AttemptTab.test.js 
flag=none

test plan:
  - Specs pass

qa risk: low

Change-Id: I3c5b9a9b01a8b054a197438728311f08b152b66a
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274410
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Davis Hyer <dhyer@instructure.com>
QA-Review: Davis Hyer <dhyer@instructure.com>
Product-Review: Davis Hyer <dhyer@instructure.com>
 2021-09-24 18:32:34 +00:00
Davis Hyer bbb8ee38fc provide correct content_shares prop type 
flag=none

test plan:
  - specs pass

qa risk: low

Change-Id: I46445f544cb7fd64e919c88b5aceb44f09ab4336
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274386
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
 2021-09-24 17:53:19 +00:00
Davis Hyer c27710ddbf remove wait deprecation warning 
flag=none

cleaned up on https://gerrit.instructure.com/c/multiple_root_accounts/+/274275

test plan:
  - specs pass

qa risk: low

Change-Id: Ia7c544941ff0a777b0badc3f009434eaf207a859
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274137
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
 2021-09-24 17:25:53 +00:00
Davis Hyer d9839c1f1b provide correct conversation prop types 
flag=none

test plan:
  - specs pass

qa risk: low

Change-Id: I66679bd2da2c9efac3740186da783f8bb83aebe6
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274387
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
 2021-09-24 17:25:42 +00:00
Davis Hyer 95a02fbd85 provide correct id prop type 
flag=none

test plan:
  - specs pass

qa risk: low

Change-Id: I0d0f5b6510f3e92a6b270c2abbf47ee17521df06
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274384
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
 2021-09-24 17:25:09 +00:00
Davis Hyer b14709fbae provide correct postedAt prop type 
flag=none

test plan:
  - specs pass

qa risk: low

Change-Id: Id06f390ffabea0642ed67fc7c60dfabc125e487a
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274379
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
 2021-09-24 16:08:40 +00:00
Davis Hyer 2906186fce provide correct currentUserId prop type 
flag=none

test plan:
  - specs pass

qa risk: low

Change-Id: Ib00f9908f256a46df4271f10d033d72178ac3994
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274377
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
 2021-09-24 15:58:10 +00:00
Davis Hyer bd974054fa provide correct outcomesGroup.contextId prop type 
flag=none

test plan:
  - specs pass

qa risk: low

Change-Id: If3632e2e0c9ed713606364ee2833a5dde95f8db5
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274131
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
 2021-09-24 15:57:53 +00:00
Omar Gerardo Soto-Fortuño 451d6d5979 Fix on GroupDescriptionModal.test.js 
flag=none

test plan:
  - Specs pass

qa risk: low

Change-Id: Id6e764ef1ce0c46223c81455ce9377e24df47575
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274375
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Davis Hyer <dhyer@instructure.com>
QA-Review: Davis Hyer <dhyer@instructure.com>
Product-Review: Davis Hyer <dhyer@instructure.com>
 2021-09-24 15:53:31 +00:00
Omar Gerardo Soto-Fortuño 4e8b42b3d7 Fixes on LinkValidator.test.js 
flag=none

test plan:
  - Specs pass

qa risk: low

Change-Id: I34f0559f025c501785629c99846fbc677bdc7269
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274251
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Davis Hyer <dhyer@instructure.com>
QA-Review: Davis Hyer <dhyer@instructure.com>
Product-Review: Davis Hyer <dhyer@instructure.com>
 2021-09-24 15:53:15 +00:00
Davis Hyer b7981ea7ab update ManageOutcomesFooter to provide valid background 
flag=none

test plan:
  - specs pass

qa risk: low

Change-Id: Iddf3b7be0ae7b04a8e93b47786df46c125aea34d
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274128
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
 2021-09-24 15:50:24 +00:00
Omar Gerardo Soto-Fortuño 18743c3ad9 Fixes on StudentOutcomeScore.test.js 
flag=none

test plan:
  - Specs pass

qa risk: low

Change-Id: Id6890387f2d0ec2e483e802dadf2ad679868a51f
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274371
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Davis Hyer <dhyer@instructure.com>
QA-Review: Davis Hyer <dhyer@instructure.com>
Product-Review: Davis Hyer <dhyer@instructure.com>
 2021-09-24 15:12:28 +00:00
Omar Gerardo Soto-Fortuño e33afd939c Add liveRegion to required tests 
flag=none

test plan:
  - Specs pass

qa risk: low

Change-Id: I9144193278beb7c7c4bf599609fc4df9b193fd54
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274368
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Davis Hyer <dhyer@instructure.com>
QA-Review: Davis Hyer <dhyer@instructure.com>
Product-Review: Davis Hyer <dhyer@instructure.com>
 2021-09-24 15:12:09 +00:00
Omar Gerardo Soto-Fortuño 9919baab1b Fixes on HomeroomPage.test.js 
flag=none

test plan:
  - Specs pass

qa risk: low

Change-Id: Ifebfb564138dd4790530806c9dbf6177c9e568aa
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274366
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Davis Hyer <dhyer@instructure.com>
QA-Review: Davis Hyer <dhyer@instructure.com>
Product-Review: Davis Hyer <dhyer@instructure.com>
 2021-09-24 15:11:52 +00:00
Omar Gerardo Soto-Fortuño 379d208eea Remove issue on ManageOutcomesFooter 
flag=none

test plan:
  - Specs pass

qa risk: low

Change-Id: Ieeb2925bcaa6f7ffe5f0c600c081d158898e03b8
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274364
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Davis Hyer <dhyer@instructure.com>
QA-Review: Davis Hyer <dhyer@instructure.com>
Product-Review: Davis Hyer <dhyer@instructure.com>
 2021-09-24 15:11:14 +00:00
Omar Gerardo Soto-Fortuño 7a58380d0a Fixes on RubricTab.test.js 
flag=none

test plan:
  - Specs pass

qa risk: low

Change-Id: I34689ab421cbf311276b7981997c9dda0f6cd53b
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274176
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Davis Hyer <dhyer@instructure.com>
QA-Review: Davis Hyer <dhyer@instructure.com>
Product-Review: Davis Hyer <dhyer@instructure.com>
 2021-09-24 01:34:25 +00:00
Omar Gerardo Soto-Fortuño 51dea1be2f Fixes on OutcomesPopover.test.js 
flag=none

test plan:
  - Specs pass

qa risk: low

Change-Id: Ie3f724d13eaa0c6f0acb49e8af0d957bf4338860
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274276
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Davis Hyer <dhyer@instructure.com>
QA-Review: Davis Hyer <dhyer@instructure.com>
Product-Review: Davis Hyer <dhyer@instructure.com>
 2021-09-24 01:33:00 +00:00
Omar Gerardo Soto-Fortuño 23e94574cd Fixes on FindOutcomesView.test.js 
flag=none

test plan:
  - Specs pass

qa risk: low

Change-Id: I27f792095e30b9522b36c84f6be15938e43f0bbc
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274260
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Davis Hyer <dhyer@instructure.com>
QA-Review: Davis Hyer <dhyer@instructure.com>
Product-Review: Davis Hyer <dhyer@instructure.com>
 2021-09-24 01:29:11 +00:00
Omar Gerardo Soto-Fortuño e75e8c4cf5 Add loadingAnnouncements to HomeroomPage.test.js 
flag=none

test plan:
  - Specs pass

qa risk: low

Change-Id: I284b19d1afc81bf37ef3384a9e2046c95fa40bc2
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274201
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Davis Hyer <dhyer@instructure.com>
QA-Review: Davis Hyer <dhyer@instructure.com>
Product-Review: Davis Hyer <dhyer@instructure.com>
 2021-09-24 01:27:52 +00:00
Davis Hyer 5ccf9a14f7 provide resolvers for CanvasValidatedMockedProvider 
flag=none

test plan:
  - specs pass

qa risk: low

Change-Id: Ic2085cfdcc040205361cf69146bb040fb5cea789
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274139
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
 2021-09-24 00:30:14 +00:00
Davis Hyer ef6d2ebd7e document editorOptions.plugins prop type fix 
refs MAT-453
flag=none

test plan:
  - n/a

qa risk: low

Change-Id: I7d7cdf1103ae42934cce6944da06d0f13f3e3a8a
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274129
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
 2021-09-24 00:30:03 +00:00
Davis Hyer d21913ceb8 provide __typename in mocked response 
flag=none

test plan:
  - specs pass

qa risk: low

Change-Id: I0917465b3c8f4f1b17d71222b7c654ca400d8bfd
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274140
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
 2021-09-24 00:29:27 +00:00
Davis Hyer 5d77024a85 provide correct submissions prop type 
flag=none

test plan:
  - n/a

qa risk: low

Change-Id: I78ab878ee2391ca0c7494d0921bbd9fdcb370c63
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274134
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
 2021-09-24 00:29:14 +00:00
Davis Hyer df27a8922f provide renderSortLabel for sortable tables 
flag=none

test plan:
  - specs pass

qa risk: low

Change-Id: I5c75cfe073897b065bbbd9a85d7482b12695d1b4
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274142
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
 2021-09-24 00:28:59 +00:00
Davis Hyer 0a394efa1b provide correct open prop type 
flag=none

test plan:
  - specs pass

qa risk: low

Change-Id: I87b4cab226a401e1a46f5ee15827e3192d8ad978
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274130
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
 2021-09-23 18:34:38 +00:00
Davis Hyer 6b0271a7a5 ensure id field provided for mock conversation participant 
flag=none

test plan:
  - specs pass

qa risk: low

Change-Id: I6a8296bec1a4c32d84ae4c3ee7fcd566c6915ca8
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274141
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
 2021-09-23 18:32:31 +00:00
Davis Hyer 044aede0c8 clean up Unmatched network request console warnings 
flag=none

test plan:
  - specs pass

qa risk: low

Change-Id: Ibb77fcef3a7c81e843879d8e3a082065123ce7f4
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274145
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
 2021-09-23 18:30:58 +00:00
Davis Hyer 0069377ce7 provide id for option props 
flag=none

test plan:
  - specs pass

qa risk: low

Change-Id: Id7548234277366abe9e528fd6982ca36fafbedee
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274196
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
 2021-09-23 15:04:05 +00:00
Davis Hyer ac399bde10 provide media track ids for media player 
flag=none

test plan:
  - specs pass

qa risk: low

Change-Id: I1f4c2f232bae7a0749b6b9737589caa2c5585664
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274144
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
 2021-09-22 21:44:02 +00:00