Commit Graph

4 Commits

Author SHA1 Message Date
Cody Cutrer 618eacf181 use eval_gemfile for bundler goodness
Change-Id: I1ce8c5135cb5b15f4e1fdd07cb890f5f823f11a4
Reviewed-on: https://gerrit.instructure.com/48952
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
2015-02-18 18:15:14 +00:00
Cody Cutrer f7003826ed allow gemified plugins to still have Gemfiles
so that they can specify a non-standard source for some gems,
which is not possible with a gemspec alone

Change-Id: Ia60ca2058cb78295c18b2e5fc07821311d3a547a
Reviewed-on: https://gerrit.instructure.com/48225
Tested-by: Jenkins
Reviewed-by: August Thornton <august@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2015-02-04 20:10:02 +00:00
Cody Cutrer 07a4fa8b1a give decent warning about gemified plugins
Change-Id: Ia265dea5a43e78a14e643ecc72e6f00edcad3d91
Reviewed-on: https://gerrit.instructure.com/46629
Reviewed-by: Benjamin Porter <bporter@instructure.com>
Reviewed-by: Jacob Fugal <jacob@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
2015-01-07 01:22:10 +00:00
Anthus Williams 5ed608bb72 partition Gemfile
this is a proof-of-concept to see if partitioning
our Gemfile helps more than it hurts. It's modeled
after the way the Squash team handles its dependencies

this doesn't implement any of the particularly nice
things that can be found in the Squash set up, such
as conditionally loading gems based on the contents
of our configuration files (we can already sort of
do this with groups in bundler), but it's a start.

In particular, it allows us to add non-OSS gems to
Gemfile.d without necessarily having to release it
as part of our open-source packaging

Change-Id: If7ff1fe97409de4cd09867ad5be1c4134c5d0117
Reviewed-on: https://gerrit.instructure.com/32442
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Nick Cloward <ncloward@instructure.com>
Product-Review: Anthus Williams <awilliams@instructure.com>
QA-Review: Anthus Williams <awilliams@instructure.com>
2014-03-28 16:44:56 +00:00