Also:
- Remove some unnecessary use of @instructure/ui-themeable
- Remove use of TsMigrationAny
- Remove some instui-related module declarations
(no longer needed)
- Remove old upgrade-instructure-ui script
- Upgrade typescript and babel-plugin-typescript-to-proptypes in RCE
Test plan:
- Build passes
flag=none
Change-Id: I734183ed8bdf68422e4eb46285909c30bc31ee33
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/334667
Reviewed-by: Jackson Howe <jackson.howe@instructure.com>
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Product-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
also: reduced need for specialized babel config
test plan:
- existing tests pass
flag=none
Change-Id: I2625830f01b2d65da0dad02e740f458dfb96863a
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/323643
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Product-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
Build-Review: Isaac Moore <isaac.moore@instructure.com>
also: use separate .d.ts declaration files in
defer-promise and html-escape
test plan:
- existing tests pass
flag=none
Change-Id: Idd4d2b7b3fc2f0f1e8a10d6a456ba7b7b1442758
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/323760
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
Reviewed-by: Michael Hulse <michael.hulse@instructure.com>
Build-Review: Isaac Moore <isaac.moore@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Product-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
We recently changed all .js files with JSX to .jsx extension.
https://gerrit.instructure.com/c/canvas-lms/+/323393
Storybook was not set up to be able to read files with a .jsx extensions
This commit updates the main.js file on storybook to allow it
flag = none
refs VICE-3679
Test Plan
1. Run 'yarn storybook'
2. Storybook should function normally
Change-Id: I71dde664e6de312c14d514009b0f978f97c38757
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/323476
Reviewed-by: Alexander Youngblood <alexander.youngblood@instructure.com>
QA-Review: Alexander Youngblood <alexander.youngblood@instructure.com>
Product-Review: Alexander Youngblood <alexander.youngblood@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
closes MAT-1175
flag=none
test plan:
- Navigate to a course.
- Change its title to add some inline math.
- Save it.
> Verify that the course title was updated
using Mathjax.
test plan 2:
- Navigate to a RCE instance.
- Open equation editor.
- Enable "Directly Edit LaTeX"
- Add some inline math.
> Verify that the preview was correctly
generated with Mathjax.
test plan 3:
> Verify that you can still edit a module's
title adding inline math.
> Verify that you can still edit syllabus
page content adding inline math.
> Verify that you can still create or edit
a discussion reply with some inline math.
Change-Id: Icfe60adb90f1e03e1aee72d1e60b8e2a2eb7dfd8
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/311688
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jake Oeding <jake.oeding@instructure.com>
QA-Review: Jake Oeding <jake.oeding@instructure.com>
Build-Review: Andrea Cirulli <andrea.cirulli@instructure.com>
Product-Review: Juan Chavez <juan.chavez@instructure.com>
fixes VICE-3037
Test Plan
1. Pull down code
2. `yarn install` since we added new packages
3. `yarn run storybook` to get storybook running
4. Visit localhost:6006 on your machine to test storybook
5. NOTE: Some stories are broken, but storybook should behave.
(Broken stories are most likely due to code drift)
Change-Id: Ic2e00a75146e433721ebf37a13df700169431cb8
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/297094
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
refs FOO-2696
flag = none
with the recent changes to how we generate the locale bundles, modules
no longer have to have a dependency on their (scope) locale bundle since
they do not exist
with this change, all support for the virtual "i18n!xxx" modules is
removed, as it's been a convenience carried over from the days of
require.js but is proving to be more costly as the tooling landscape
evolves
. test plan .
..... .....
assuming you checked out the change that rewrites all imports to "i18n!"
to use the "useScope" specifier from @canvas/i18n, webpack should still
run
Change-Id: I6e0db400b46133458592976cc4772365efcde317
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/286653
Tested-by: James Butters <jbutters@instructure.com>
Reviewed-by: Charley Kline <ckline@instructure.com>
QA-Review: Charley Kline <ckline@instructure.com>
Product-Review: Charley Kline <ckline@instructure.com>
refs FOO-2697
flag = none
this part concludes the dependence of canvas core on the InstUI babel
preset, but the config file / npm dependencies still need to remain
until some of the bad packages like k5uploader are migrated
~ test plan ~
.........
- you can still run storybook
Change-Id: I5e87cd73879c4d0c0c4df7747b9a004db58d8d48
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/284119
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Shafovaloff <ashafovaloff@instructure.com>
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Product-Review: Ahmad Amireh <ahmad@instructure.com>
Closes MAT-131
flag=none
Test Plan
- Navigate to a root account and verify the RCE
Autosave feature has been removed
- Navigate to a cousre and verify the RCE Autosave
feature has been removed
- Open a few RCEs in a course and verify the autosave
feature is working
Change-Id: I10f88b35501ae5499f6d066e539f953055d43b52
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/280794
Reviewed-by: Juan Chavez <juan.chavez@instructure.com>
QA-Review: Juan Chavez <juan.chavez@instructure.com>
Product-Review: David Lyons <lyons@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Test Plan
1. Pull down code
2. `yarn storybook` should open storybook
3. Should not throw an error for storybook regarding i18nPlugin
Change-Id: I2fc15dfae332819d8e45993314f4d0529427520c
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/278846
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Charley Kline <ckline@instructure.com>
Product-Review: Charley Kline <ckline@instructure.com>
QA-Review: Chawn Neal <chawn.neal@instructure.com>
fixes MAT-133
flag=none
test plan:
- Verify that there is no rce_pretty_html_editor
feature flag (site admin).
- Navigate to an RCE instance.
- Verify that pretty html editor is enabled by default.
Change-Id: Ibe76738577d0716e30f06815c9a072f41ca48103
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/275197
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Weston Dransfield <wdransfield@instructure.com>
QA-Review: Weston Dransfield <wdransfield@instructure.com>
Product-Review: Juan Chavez <juan.chavez@instructure.com>
minor QOL mainly for me; put webpack-specific configuration in its own
folder, make it portable, and make room for esbuild
the __webpack_public_path__ initializer no longer sources the value from
the build module, instead it uses a pre-defined global that webpack
injects
~ test plan ~
build is OK
Change-Id: I4ba4a3c0cb9175f96096f2b78022e152c04fc75d
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276183
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Charley Kline <ckline@instructure.com>
QA-Review: Charley Kline <ckline@instructure.com>
Product-Review: Charley Kline <ckline@instructure.com>
refs LS-2655
flag=none
- this updates the files under ./ui, a few ancillary files and specs.
- Sadly the commit hook ran prettier and
fiddled with the formatting of a handful of files too.
- Also made a few changes to quiet lint errors
- Also updated OutcomeManagement.test.js. I don't understand why,
but 'renders ManagementHeader with lhsGroupId if selected a group in lhs'
started failing with this change, even though nothing obviously related
changed. The problem is that the modal isn't getting attached to the
document being tested. The spec changed to test that the modal contained
what it's supposed to contain.
test plan: jenkins passes and the RCE works
Change-Id: I48d85077bdbf7563cb07510d3e71d2b448c55e49
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/275301
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Weston Dransfield <wdransfield@instructure.com>
QA-Review: Weston Dransfield <wdransfield@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
closes MAT-65
flag=none
- The update to package.json corrects a typo in the command line,
line, plus adds a directory needed to load brandable_css
- The instui babel presets in the new .babelrc.json file are needed
if you want an RCE in storybook
- The change to ENV in preview.js is needed if you want an RCE in
storybook
test plan:
- storybook builds and everything still works
- components are rendered using the Lato font family
Change-Id: I04c45e4dc6bd853c3513ff689d63f6388d874ec1
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/263291
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jeffrey Johnson <jeffrey.johnson@instructure.com>
QA-Review: Jeffrey Johnson <jeffrey.johnson@instructure.com>
Product-Review: Jeffrey Johnson <jeffrey.johnson@instructure.com>
refs FOO-1265
some of the stories were left out because they never show up as part of
the graph, also, its webpack config is now up to date
test plan: you can run "yarn storybook" as you did before
Change-Id: Ie204809c3e535d810b1e58ab64e12ff591f46168
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/262364
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jeffrey Johnson <jeffrey.johnson@instructure.com>
QA-Review: Jeffrey Johnson <jeffrey.johnson@instructure.com>
Product-Review: Jeffrey Johnson <jeffrey.johnson@instructure.com>
closes OUT-4236
flag=improved_outcomes_management
Test plan:
- In the Acccount create an outcome with description
- Go to Account > Settings > Feature Options
- Enable Improved Outcomes Management FF
- Turn RCE Enhancedments FF to OFF
- Go to Account > Outcomes
- Select the outcome and click on kebab menu -> Edit
- Edit Outcome modal should open and form fields should
be populated with outcome data
- Verify that Save button is enabled
- Verify that the description is displayed within RCE
- Edit description and click on Save button -> modal should
close and after a moment you should see a flash message:
"This outcome was successfully updated."
- Reload the page and confirm that description is updated
- Go to Account > Settings > Feature Options
- Turn RCE Enhancedments FF to ON
- Repeat the above tests; now you should see the enhanced
RCE when editing description within the Edit Outcome modal
- Start storybook and confirm that the Outcome Edit Modal
stories display with RCE
Change-Id: I2e611e9a5fdbe895069e43061080e6986c851ae6
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/260751
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Augusto Callejas <acallejas@instructure.com>
Reviewed-by: Pat Renner <prenner@instructure.com>
QA-Review: Brian Watson <bwatson@instructure.com>
Product-Review: Augusto Callejas <acallejas@instructure.com>
flag=none
closes OUT-4256
Test-plan: - Enable lolcalize in the toolbar (happyface icon)
- Refresh page
- Look at outcomes stories, verify that lolcalize translation
occurs where expected in stories
- Disable lolcalize in the toolbar
- Refresh page
- Verify that translations are gone
Change-Id: Ia84a8464ff7df565abc22ce89c542736f7caaa00
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/258660
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Augusto Callejas <acallejas@instructure.com>
Product-Review: Augusto Callejas <acallejas@instructure.com>
Reviewed-by: Augusto Callejas <acallejas@instructure.com>
refs OUT-4237
flag=none
Test-plan: > yarn install
> yarn storybook
- Look through outcomes stories in storybook quickly,
verify everything loads
> yarn test-storybook
- Verify everything passes, if something doesn't pass,
verify that that corresponding story is also broken in
storybook
> echo $? # should return 0 and jest results should say 0 failures
- Change one of the stories so that it doesn't render,
For example: undo the changes made to ManagementHeader.stories.js
in tis PS
> yarn test-storybook
- Verify that it fails
> echo $? # should return 1 and jest results should say 1+ failure(s)
Change-Id: I492f50d861dccdfdf4a958fd007da44041f9dd49
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/258297
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jeffrey Johnson <jeffrey.johnson@instructure.com>
Reviewed-by: Michael Brewer-Davis <mbd@instructure.com>
QA-Review: Pablo Gomez <pablo.gomez@instructure.com>
Product-Review: Brian Watson <bwatson@instructure.com>
closes OUT-4252
flag=none
Test-plan: - Click user icon in global toolbar
- Switch between 'canvas' and 'canvas-high-contrast'
- Verify that components display in expected contrast
- Verify that all stories are rendering as expected and that
'canvas' theme option displays stories as they were before
this PS
Change-Id: I0d139e228ee01f2c3bc45d6b20e69acce88cfae1
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/258545
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Manoel Quirino <manoel.quirino@instructure.com>
Reviewed-by: Michael Brewer-Davis <mbd@instructure.com>
QA-Review: Chrystal Langston <chrystal.langston@instructure.com>
Product-Review: Jody Sailor
closes OUT-4194
flag=none
Test-plan: - yarn install
- yarn storybook
- Navigate to Outcomes components
- Press 'D' on the keyboard to bring up the controls
- Verify that string / bool / number props can be edited easily
- Verify all stories load (no red screens on a story)
- OutcomeManagement will need additional work to mock out
GraphQL requests. Some Failures on the story are anticipated
Change-Id: I7e5765c50c15ae1a5ea239946ebe12a72d73b614
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/257144
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Michael Brewer-Davis <mbd@instructure.com>
Reviewed-by: Augusto Callejas <acallejas@instructure.com>
QA-Review: Pat Renner <prenner@instructure.com>
Product-Review: Michael Brewer-Davis <mbd@instructure.com>
fixes VICE-860
flag=react_inbox
test plan:
- navigate to /conversations
- the inbox should render as normal
- enable the react_inbox feature flag
- navigate to /conversations
- the inbox should be replaced with a placeholder
for our new container
qa risk: low
Change-Id: Ib10d6a20bf9fa5b4dbed804bcd1396a1843cf0b1
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/254506
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Tested-by: Jeffrey Johnson <jeffrey.johnson@instructure.com>
Reviewed-by: Jeffrey Johnson <jeffrey.johnson@instructure.com>
QA-Review: Jeffrey Johnson <jeffrey.johnson@instructure.com>
Product-Review: Jeffrey Johnson <jeffrey.johnson@instructure.com>
This story contains work to move Canvas Inbox and Storybook to `app/jsx` inside our Monolith. Storybook should now be enabled for all of `app/jsx` and works with our existing I18n code after updating webpack to load translations correctly.
Test Plan
1. Install node modules with `yarn`
2. At Canvas-LMS root, run `yarn storybook`
3. Storybook should open, test that Canvas Inbox components work as expected
Change-Id: Iccd2b103164a2da4e37b5746f4d9d2b5faf5f29d
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/253024
QA-Review: Davis Hyer <dhyer@instructure.com>
Product-Review: Davis Hyer <dhyer@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Davis Hyer <dhyer@instructure.com>
Aaron Shafovaloff