fixes CNVS-16948
test plan
- view a submission comment in the submission comment inbox
- ensure that the subject in the message detail view (right side
display) links to the submission comment
Change-Id: I2ea4bd8c44a52ff6a250b83638b4d9a2556617d0
Reviewed-on: https://gerrit.instructure.com/44541
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Janelle Seegmiller <jseegmiller@instructure.com>
Reviewed-by: Brad Horrocks <bhorrocks@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
also bump switchman to allow for .uniq across shards
fixes CNVS-14873
test plan
- site admin survey should go to students by
default
- accounts/self/settings should have checkbox to
include students in global surveys checked by
default
- accounts that have unchecked setting should
exclude students from global surveys
- regular announcements should still get to
students
- checkbox should only be visible to site admin
Change-Id: I5b268f3e19f8710cdaf0e40f37e9af87ff437649
Reviewed-on: https://gerrit.instructure.com/44457
QA-Review: August Thornton <august@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
Made it so we now show more group sets. The new limit is 50. which is the
same limit we have for the groups on the group controller.
Fixes CNVS-15436
Test Plan:
Create lots of group sets
```
require(['compiled/models/GroupCategory'], function (GroupCategory) {
function randomName(number) {
var names = ['Secret','Team','Awesome-Sauce','Ugly','Orange','Red','Fish-Sticks','Evil','<3','Garbage'],
numAr = ("" + number).split(""),
ret = "",
num;
while(num = numAr.shift()) {
ret += (ret.length && " " || "") + names[num % names.length]
}
return ret;
}
var i = 50,
course = 5; // <<<===== PUT YOUR COURSE ID HERE
while(i--) {
var name = randomName(i),
model = new GroupCategory({ name: name, course_id: course});
model.save()
}
})
```
load up the people page!
profit!
Change-Id: I73a67e9254ebe8cfa1f71c4ba0a9811e91c3b201
Reviewed-on: https://gerrit.instructure.com/44636
Reviewed-by: Brad Horrocks <bhorrocks@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Joel Hough <joel@instructure.com>
Product-Review: Janelle Seegmiller <jseegmiller@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
test plan:
1. consult the files API documentation and note the additions:
A. usage_rights include parameter on 'List files'
B. usage_rights include parameter on 'Get file'
C. 'List licenses' endpoint
D. 'Set usage rights' endpoint (PUT)
E. 'Remove usage rights' endpoint (DELETE)
2. exercise these new API features
closes CNVS-16826
closes CNVS-16841
Change-Id: I6c01128423adc24a5b70f71bb109d5a005379c37
Reviewed-on: https://gerrit.instructure.com/44403
Reviewed-by: James Williams <jamesw@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Anna Koalenz <akoalenz@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
test plan:
- with DA on and OFF
- assignments & discussions & quizzes & modules indices load
and filter properly for students/teachers
- assignments needing submitting/grading load and
filter properly
- grade summary page for students & teachers loads
and filters assignments properly
Change-Id: Ibff8ff0357360a7e09d500c2475885f3dfb7f495
Reviewed-on: https://gerrit.instructure.com/44215
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
fixes CNVS-16972
test plan
- go to /accounts/1/account_authorization_configs
- test ldap credentials
Change-Id: I50361b120da8ecf161778347a0e2b45be7010930
Reviewed-on: https://gerrit.instructure.com/44598
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
fixes CNVS-16869
You have some cases where a user has uploaded more than their quota
limit in which case, the progress bar was overflowing and creating some
style issues.
Setting up a user with more space used than in their quota
1. Create a user
2. Upload 50MB of files
3. In the console, change the users quota limit to 25MB (user.storage_quota = 25.megabytes)
4. Save the user
5. Reload the browser page.
Test Plan
Given you have new files enabled
And you have used over 100% of your quota space
When you go to your users files section
Then the file quota used bar should be 100%
Change-Id: If39aa3106cd7eea2f7d4586623f2f35069db9062
Reviewed-on: https://gerrit.instructure.com/44588
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Cosme Salazar <cosme@instructure.com>
Reviewed-by: Dan Minkevitch <dan@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Fixes: CNVS-16385, CNVS-16776
Fixes Flexbox-related layout bugs in the files list
table header columns and the File Preview overlay.
Please see JIRA for screenshots of the bugs.
Test plan:
- Test in both IE10 and 11, as well as one additional
browser to verify nothing has broken as a result of
the IE fixes
- Make sure you have Better File Browsing enabled for
your test course (under Settings > Feature Options)
- From the main course page, click on Files
- Add a file to your course, if you haven't already
- Click the eyeball icon to view the file in the
File Preview overlay
- While doing the above, verify that the bugs in
both JIRA tickets are addressed in both IE10 and IE11.
Change-Id: Ibf7467c2f6c7f9720feda9bd545b316b6559eee6
Reviewed-on: https://gerrit.instructure.com/44356
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Dan Minkevitch <dan@instructure.com>
Product-Review: Dan Minkevitch <dan@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
You can now exclude pseudonym info on api requests.
users_json will now preload section information when you include[]=section
Fixes CNVS-14836
Fixes CNVS-13093
Fixes CNVS-12932
Fixes CNVS-16216
Fixes CNVS-16218
Test Plan:
- Create a course with 800 users
- Create a group set; add 150 groups to set.
- Load groups page it should load way faster than before
- Make sure search isn't slow
Change-Id: Icff28b00141fb3573b9ed9493e8dc38521a368e4
Reviewed-on: https://gerrit.instructure.com/43356
Reviewed-by: Jacob Fugal <jacob@instructure.com>
Reviewed-by: Andrew Butterfield <abutterfield@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Joel Hough <joel@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Product-Review: Brad Horrocks <bhorrocks@instructure.com>
fixes CNVS-16834
When editing permissions for a file VO in Safari would read form fields
that were hidden via display: none. This makes sure those fields don't
get read.
Test Plan
Given you new files are enabled
And you are using VoiceOver with Safari
When you go to the few files page
And you select an item
And you open the restricted access dialog window
Then you should be able to navigate the options
And only visible options should be read by the screen reader
Change-Id: I30e1ba9f57f6071c2996efda1d61212ea60d8411
Reviewed-on: https://gerrit.instructure.com/44487
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Sterling Cobb <sterling@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Fixes: CNVS-15518
Notes:
- increased contrast of 'correct' and 'incorrect' arrows
- updated sprite
- made all text meet contrast requirements
- made published button opaque
Test Plan
- log in as admin
- navigate to quizzes
- open a published quiz
- verify contrast of published button
- log in as student
- navigate to quiz
- start quiz
- answer questions incorrectly and correctly
- leave some blank
- verify contrast
Change-Id: I1337d6e9e4cfe08ffbc8a1f013b176ee16e8f246
Reviewed-on: https://gerrit.instructure.com/43068
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Colleen Palmer <colleen@instructure.com>
Product-Review: Colleen Palmer <colleen@instructure.com>
QA-Review: Nathan Rogowski <nathan@instructure.com>
QA-Review: Anna Koalenz <akoalenz@instructure.com>
Adds some spacing between buttons for
dialog form modals.
fixes CNVS-16859
test plan:
* Enable "Better File Browsing" feature flag
* Go to any course's Files page
* Select a file or folder and click on
"Restrict Access" button in the toolbar
on top
* There should be spacing between the submit
and cancel buttons
* Repeat for the "Move" dialog
Change-Id: If0fb977e1a61e2d8cb42d4ef74497a9b36f3344b
Reviewed-on: https://gerrit.instructure.com/44570
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Anna Koalenz <akoalenz@instructure.com>
Product-Review: Dan Minkevitch <dan@instructure.com>
When you delete a selection of items
(folders/files), the selected items
are cleared and the Toolbar hides.
fixes CNVS-16856
Test Plan:
* Enable "Better File Browsing" feature flag
* Go to any course's Files page
* Select multiple files/folders
* Click the "Delete" button in the Toolbar
* Confirm the deletion on the popup
* The items should be deleted and the Toolbar
should disappear
Change-Id: Ic2d37f43399e94dd2a91fbf0c1130b75c86085bb
Reviewed-on: https://gerrit.instructure.com/44494
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Sterling Cobb <sterling@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Dan Minkevitch <dan@instructure.com>
test plan:
* with caching enabled, create an announcement or other
object that creates items in the "Recent Activity"
* delete the item
* should refresh the activity right away and not
show the now deleted item
closes #CNVS-962
Change-Id: I28b2165c238ad074c345db23b64384439d8b8efb
Reviewed-on: https://gerrit.instructure.com/44477
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Dan Minkevitch <dan@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
test plan:
* create a custom course-level role for an account
* enroll a user into an active course with the custom role
* as that user, the "Courses" dropdown menu on the navigation header
should read "Enrolled as: [Custom Role]" instead of
the base type for the role
refs #CNVS-5349
Change-Id: Ife07a10852de3d5376a945c9f35d3ef56cb4ca58
Reviewed-on: https://gerrit.instructure.com/44507
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Cosme Salazar <cosme@instructure.com>
test plan:
- as site admin, set feature to 'allowed' in a root account
- as a teacher in a course under this account, see that feature
becomes available to be allowed in course settings
closes CNVS-15864
Change-Id: I569e6febf44bcf75a46bcbbbc25d15a99571cc46
Reviewed-on: https://gerrit.instructure.com/44567
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Cosme Salazar <cosme@instructure.com>
refs CNVS-15867, CNVS-15865, CNVS-15868
Test Plan:
- Nothing really easy to test with this commit.
- You could put a breakpoint in your developer tools and
check to see if a file has usage_rights associated, but
that's rather pointless at this point. Future commits
will be based on this one.
Change-Id: I37677ab79c82d9f08f981f5123a661dc84038793
Reviewed-on: https://gerrit.instructure.com/44544
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Dan Minkevitch <dan@instructure.com>
QA-Review: Clay Diffrient <cdiffrient@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
fixes CNVS-16902
The title wasn't pluralize. It now is
Test Case
Given you are testing new files
When you select ONE item
And you click the 'restricted access' button
Then a dialog should appear with a title that says "Editing permissions
for 1 item"
Given you are testing new files
When you select two items
And you click the 'restricted access' button
Then a dialog should appear with a title that says "Editing permissions
for 2 items"
Change-Id: If19e1cf8b7c7df080e889cf9a74888fd48253186
Reviewed-on: https://gerrit.instructure.com/44479
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Product-Review: Cosme Salazar <cosme@instructure.com>
QA-Review: Matt Fairbourn <mfairbourn@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
the security fixes don't apply to Canvas, but it's good
to be on latest for the next update that we would need
Change-Id: If40afec856611340e73fa14b3c1b75e152850155
Reviewed-on: https://gerrit.instructure.com/44533
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Rob Orton <rob@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
test plan:
- add a tool with variable substitutions for $Canvas.module.id and $Canvas.moduleItem.id
- launch the tool as a module item
- it should substitute the values
Change-Id: I52540a33e4d0ada5a4d8434250e173ff1f9ffdef
Reviewed-on: https://gerrit.instructure.com/44484
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Nathan Mills <nathanm@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Nathan Mills <nathanm@instructure.com>
fixes CNVS-16717
Test Plan:
- Go to a course and favorite it.
- Make the course end date / term in the past.
- You should now be able to unfavorite it, but not re-favorite it.
Change-Id: Ie289ba1c51f9d62984c4f1a87cb2021094ca29a8
Reviewed-on: https://gerrit.instructure.com/43978
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Hilary Scharton <hilary@instructure.com>
Reviewed-by: Dan Minkevitch <dan@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
this one fails more than it passes, due to test code running before
handlers are added asynchronously
Change-Id: I4f5c8ffeadb3a50ba580e9bd221135bd433bfc23
Reviewed-on: https://gerrit.instructure.com/44500
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Michael Ziwisky <mziwisky@instructure.com>
Reviewed-by: Michael Ziwisky <mziwisky@instructure.com>
QA-Review: Michael Ziwisky <mziwisky@instructure.com>
ensure any in-flight requests (ajax or otherwise) finish processing before
we wrap up each spec, and prevent them from triggering additional requests.
this fixes various race condition failures around our shared db conn, e.g.
PG::ForeignKeyViolation, PG::InFailedSqlTransaction, as well as the
occasional segfault
Change-Id: Idfed1244a921f7742acc84b03fe33e3084f03568
Reviewed-on: https://gerrit.instructure.com/44501
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
Product-Review: Jon Jensen <jon@instructure.com>
QA-Review: Jon Jensen <jon@instructure.com>
The return signature of "Retrieve assignment-overridden dates for
quizzes" in the Quiz Assignment Overrides API returns its
QuizAssignmentOverrideSet objects inside another (currently)
anonymous object with a key of "quiz_assignment_overrides". This
de-anonymizes the object and names it
QuizAssignmentOverrideSetContainer. Necessary for machines to read
the API and know what to actually return.
Test Plan:
- A new QuizAssignmentOverrideSetContainer should exist in the API
docs.
- The type returned by "Retrieve assignment-overridden dates for
quizzes" should be of that type.
Fixes SIS-653
Change-Id: I9a1ce38824422760a2b20ceaca1722a64b9cf061
Reviewed-on: https://gerrit.instructure.com/44286
Reviewed-by: Cameron Sutter <csutter@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Tyler Pickett <tpickett+gerrit@instructure.com>
Product-Review: Tyler Pickett <tpickett+gerrit@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
fixes CNVS-16892
test plan
- disable the role based permission that allows sending to an
entire course
- send a message to an entire course as a restricted user via the
api
- ensure that the error message reads 'restricted by role'
Change-Id: Ia45ad5cd1150a3132a40da8bdd0953b08209521b
Reviewed-on: https://gerrit.instructure.com/44417
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Reviewed-by: Steven Shepherd <sshepherd@instructure.com>
Reviewed-by: Matthew Wheeler <mwheeler@instructure.com>
Product-Review: Joel Hough <joel@instructure.com>
closes CNVS-16898
Test Plan:
- Enable New Files
- Go to New Files
- Enable a Screenreader
- Search for something
- The results should be read to you.
- Search for something else
- Only results for your something else should be read.
Change-Id: Ia479e68e04d3d3285c0ccd1d27180e49bf90c5d2
Reviewed-on: https://gerrit.instructure.com/44461
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Ryan Shaw <ryan@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
fixes: CNVS-16921
closes: CNVS-16860
expected behavior:
* clicking a file name should open a preview of it.
while previewing, you should be able to use the
arrows to flip through other things in this folder.
This means that clicking a filename selects that
row and unselects all other rows.
* the "href" of the filename link should still be
the download url. this means that you can right
click and "open in new tab" or "save link as" to
download the file.
* if you have only selected folders, and you click the
"preview" eye. it should open the preview and show
all the "files" (not folders) in the current folder.
also test:
* clicking the "eye" preview button in the toolbar
should work just like it used to.
Change-Id: I468359905ede6d32f750c3896c3eb364eb0b5c3c
Reviewed-on: https://gerrit.instructure.com/44483
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
Fixes: CNVS-15536
This change removes the existing table examples from
the styleguide, but keeps the styles so as not to
break anything. New table styles and examples have been
added to the styleguide, per mockups from the UI team.
Test plan:
- Open the /styleguide page from the main Canvas url
- Click on Tables on the left-side nav
- Go through each table example and make sure it's
working as the text says it should be (i.e., is the
row-hover table actually showing a hover effect, etc.)
- Check the colors against color contrast requirements
for both regular and high-contrast UIs
- NOTE: the new table styles are only being used in the
styleguide right now, so no testing of any app areas
is needed.
Change-Id: Iaf04703dc1e2d6a6815070fe1a4c299ab152378f
Reviewed-on: https://gerrit.instructure.com/43515
Reviewed-by: Colleen Palmer <colleen@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Anna Koalenz <akoalenz@instructure.com>
QA-Review: Matt Fairbourn <mfairbourn@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
The assignment title had some issues with word wrapping. If
a word was bigger than 90 characters then it would run off screen
we fixed by adding a break all to the css, but it was unneeded
because the normal format already covered this.
fixes CNVS-14579
test plan:
-Create an assignment.
-Enter in multiple words into title see that title wraps.
Change-Id: Iad657bbc2c72c8e807c2ba4c0a4ee8decca40347
Reviewed-on: https://gerrit.instructure.com/44390
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Matt Berns <mberns@instructure.com>
QA-Review: Sean Lewis <slewis@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Hilary Scharton <hilary@instructure.com>
fixes CNVS-16870
Test Plan:
- Go to New Files, using Screenreader
- Select several files (a lot for fun)
- Download as zip
- The file percentage should be read exclusively rather than
constantly adding to the message being read
Change-Id: Icb2a459ccf29ed930a7e184cd4e7b05e8ba694fc
Reviewed-on: https://gerrit.instructure.com/44375
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Ryan Shaw <ryan@instructure.com>
QA-Review: Nathan Rogowski <nathan@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
Test Plan:
- On the outcomes page, switch between two or more outcomes and
observe that there are no JS errors (undefined type error)
- edit an outcome, but click on a different outcome befor clicking
either the cancel or submit buttons. Observe no JS errors
- edit an outcome. Click cancel and then select a different
outcome. Observe no JS errors
Fixes CNVS-16825
Change-Id: I748b3e40b6e64eec78aa9c8ae2bd7eb708211486
Reviewed-on: https://gerrit.instructure.com/44283
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Adam Stone <astone@instructure.com>
Product-Review: Benjamin Porter <bporter@instructure.com>
fixes CNVS-16719
test plan:
- as a teacher
- create a quiz
- as a student
- take the quiz
- as a teacher
- edit the quiz
- the left side navigation links should all be clickable
- edit the question to change the answer and regrade
- the regrade tour should appear
- close the regrade tour
- the hidden overlay should still not be blocking the navigation links
Change-Id: I656de5f08c7c5696ff9f8e202e3e869e529cf1b0
Reviewed-on: https://gerrit.instructure.com/44411
Reviewed-by: Jason Madsen <jmadsen@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Trevor deHaan <tdehaan@instructure.com>
Product-Review: Derek DeVries <ddevries@instructure.com>
Fixes: SIS-625
Removes BR with P because P isn't read by NVDA
Test-Plan
--With SIS Import enabled--
1.) Navigate to sis import page in accounts/self
--Using NVDA--
2.) Verify that blanks are not read out between
"no file selected" and "Import Type"
3.) Verify that blanks are not read out between
"Import Type" and "Full Batch Update"
Change-Id: Ia11f63d305b7aae9d791d4e1cbb6de3bc3fb123a
Reviewed-on: https://gerrit.instructure.com/43961
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Duane Johnson <duane@instructure.com>
Reviewed-by: Nick Houle <nhoule@instructure.com>
QA-Review: Nathan Rogowski <nathan@instructure.com>
Product-Review: Cosme Salazar <cosme@instructure.com>
add GradingPeriodGroup, and change associations between GradingPeriods,
GradingPeriodGroups, Courses, and Accounts. also adjust the grading
periods controller to account for addition of grading period groups
closes CNVS-16538
test plan:
-run bundle exec rake db:migrate, and bundle exec rake db:migrate RAILS_ENV=test
-verify the migrations successfully run
-open the rails console in sandbox: bundle exec rails c -s
-create a course, a few grading periods, and a grading period group. Add the grading periods to the group. Assign
the grading period group to the course.
$ course = Course.create
$ grading_period1 = GradingPeriod.create(weight: 25.0, start_date: Time.zone.now, end_date: 2.days.from_now)
$ grading_period2 = GradingPeriod.create(weight: 30.0, start_date: Time.zone.now, end_date: 2.days.from_now)
$ grading_period_group = GradingPeriodGroup.create()
$ grading_period_group.grading_periods << grading_period1
$ grading_period_group.grading_periods << grading_period2
$ grading_period_group.course = course
-verify the associations are working as expected, i.e. a GradingPeriodGroup has GradingPeriods, a GradingPeriod
belongs to a GradingPeriodGroup, and a GradingPeriodGroup belongs to a course or account.
$ grading_period_group.grading_periods #should return an array containing grading_period1 and grading_period2
$ grading_period1.grading_period_group #should return grading_period_group
$ grading_period2.grading_period_group #should return grading_period_group
$ grading_period_group.course #should return course
$ grading_period_group.account #should return nil (should not throw error)
Change-Id: I9d7465431dabd2afa18e7a8a33706b9a78a94cd1
Reviewed-on: https://gerrit.instructure.com/43512
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Josh Simpson <jsimpson@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
Reviewed-by: Jacob Fugal <jacob@instructure.com>
Product-Review: Spencer Olson <solson@instructure.com>
fixes CNVS-15673
fixes CNVS-15672
Since these two areas dealt with similar contrast issues, they're
tackled in one commit.
This adds the correct color ratios to meet accessibility.
Test Plan:
CNVS-15673
- Go to a specific discussion
- Click on "reply", make sure the ratio for the link "HTML Editor"
meets webaim standards. Note: we have taken away the blue background
purposely.
- Get the colors on the pubish timestamps; both on the main message
and on the individuals (see screenshots in jira story). These now
meet webaim ratio requirements.
CNVS-15672
- Go to announcements
- There should no longer be a gray background zebra striping on
some of the announcments, and this fixes the majority of ratio
contrast issues for HC mode (see jira ticket for screenshots)
Change-Id: Id76f1a6a34641af67237a0ec6298a4224786e922
Reviewed-on: https://gerrit.instructure.com/43814
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Vincent Gonzalez <vgonzalez@instructure.com>
QA-Review: Nathan Rogowski <nathan@instructure.com>
Product-Review: Colleen Palmer <colleen@instructure.com>
On the modules page this makes it so a reason is given
for why the failure occurs when it is from a blank assignment
title.
Modifies application.html.erb to have flash messages rendered
outside of #application so that they are read by screenreaders
when modals are open since everything in #application gets
aria-hidden when dialogs get opened. Also changes
$.fn.errorBox from using '#aria_alerts' in favor of
$.fn.screenReaderFlashError. This necessitates a change in the
spec for login_logout as well.
fixes CNVS-14964
Test Plan:
- Go to the modules page
- Add an item
- Choose assignment type and a new assignment
- Finish the form without a title
- A popup tooltip should appear saying that a blank title can't be used.
Change-Id: I7647721cf95d522d61b929ef5e948610ff67f9c8
Reviewed-on: https://gerrit.instructure.com/43799
Reviewed-by: Dan Minkevitch <dan@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
fixes CNVS-9047
test plan:
- enable better file browsing feature flag
- go to files page and navigate folders, all expected behaviors should occur
- click 'move folder' and navigate the folder tree, all expected behaviors should occur,
including files moving properly
- go to edit addignment, edit outcome, or edit discusson and click 'embed image' on toolbar
- go to 'Canvas' tab on modal window and navigate tree, all expected behaviors should occur,
including images properly attaching
Change-Id: I703f0db5a096d49d648fab8377001b5fd610a620
Reviewed-on: https://gerrit.instructure.com/43883
Reviewed-by: Simon Williams <simon@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Nathan Rogowski <nathan@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
Adds a way to override the announcement on the ProgressBar component.
Also makes it so that the files usage percentage is reported with no more
than 2 decimal places
fixes CNVS-16863
Test Plan:
- Enable New Files
- Using a screenreader navigate to the Files Usage bar
- Usage should be read with no more than 2 decimal places
- NOTE: Please also check other uses of progress bars for potential regression.
Change-Id: If58f49545a76476ae68b3a4105b2a6cb6908111f
Reviewed-on: https://gerrit.instructure.com/44388
Reviewed-by: Dan Minkevitch <dan@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Nathan Rogowski <nathan@instructure.com>
Product-Review: Cosme Salazar <cosme@instructure.com>
only use exceptions for the exceptional cases
this shaves ~2 seconds off every selenium spec (zomg!), and
eliminate somes spurious hangs \o/
Change-Id: I7f4513620d0d13ddd5fdfa7296b2c6af555bc94b
Reviewed-on: https://gerrit.instructure.com/44383
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Michael Ziwisky <mziwisky@instructure.com>
Product-Review: Michael Ziwisky <mziwisky@instructure.com>
QA-Review: Michael Ziwisky <mziwisky@instructure.com>
Joel Hough