This file only manages the warning banner that displays
for customers that are using a browser below the minimum
supported version. We need to bring the banner back for
users of Firefox below version 68. Firefox is already at
version 69 as of this ticket date, and Firefox ESR 60
has an end of life at the end of October; users need
to upgrade before then.
CLOSES: DOC-1107
Test plan:
- Jenkins passes
Change-Id: Ie842b54230cec3d7488d96d0bc11a4db0cb98851
Reviewed-on: https://gerrit.instructure.com/208290
Tested-by: Jenkins
Reviewed-by: Ryan Shaw <ryan@instructure.com>
QA-Review: Erin Hallmark <erin@instructure.com>
Product-Review: Erin Hallmark <erin@instructure.com>
closes COREFE-1
Test Plan:
- Enable RCE Enhancements
- Go to an RCE
- Upload Image -> Unsplash
- Notice the alt text on the image you select before
you submit it.
- Submit the image to have it insert
- The image in the RCE should have the same alt text.
Change-Id: Ib7c9933e3dec3f7f7e684d41ae08d70bb5014d4a
Reviewed-on: https://gerrit.instructure.com/203110
Tested-by: Jenkins
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
Reviewed-by: Ed Schiebel <eschiebel@instructure.com>
fixes ADMIN-2688
flag=none
Test plan
- In a course with a few different assignment
types, ensure SR reads the assignment
type for each assignment
Change-Id: Id2437146cc971c8ec2c5647a7d2df1ab0f93dfc4
Reviewed-on: https://gerrit.instructure.com/208190
Tested-by: Jenkins
Reviewed-by: Carl Kibler <ckibler@instructure.com>
QA-Review: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Daniel Sasaki <dsasaki@instructure.com>
fixes GRADE-2420
Change-Id: Iecd4f6cccb1ed9174ce3878c3a213e5b1d98396f
Reviewed-on: https://gerrit.instructure.com/208716
Product-Review: Keith Garner <kgarner@instructure.com>
Tested-by: Jenkins
Reviewed-by: Keith Garner <kgarner@instructure.com>
QA-Review: Gary Mei <gmei@instructure.com>
test plan:
- a user in a custom role who has permission to view grades
and does not have permission to manage course content
should see the "View Progress" button on the top of
the (read-only) modules page
flag=none
fixes ADMIN-2871
Change-Id: I85dd183748cbac57433c04dfe1ded36d5f38d90c
Reviewed-on: https://gerrit.instructure.com/208388
QA-Review: Anju Reddy <areddy@instructure.com>
Tested-by: Jenkins
Reviewed-by: Mysti Lilla <mysti@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
fixes: COREFE-272
core-js changed the name of all of their polyfills so they are not
based on es6 or es7 but just es.
This is to update our code to reflect that.
if you look at what's on prod
https://du11hjcvx0uqb.cloudfront.net/br/dist/ie11-polyfill-36fc8ad84a.js
vs what's on beta:
https://du11hjcvx0uqb.cloudfront.net/br/dist/ie11-polyfill-f3223dcd57.js
you can see that core-js stopped polyfilling some stuff.
so even thought this is specifically called the ie11-polyfill, and we
don't officially support ie11, we should still probably warmfix this so
that if there are any browsers that do need any of these polyfills they
still get it, out of an abundance of caution.
test plan:
* with this applied, view-source and then look for: "ie11-polyfill"
* copy and paste that url into a new tab.
* it should have a bunch of stuff in it, like the example from prod
above and not be small like the one from beta above
Change-Id: Ic92ba4a31a739db7a50eebcfd7ac63d9ad8f6742
Reviewed-on: https://gerrit.instructure.com/208605
Tested-by: Jenkins
QA-Review: Ryan Shaw <ryan@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
when a user has drafted but not saved text in a text submission
in a2 we should warn the user if they attempt to leave the page
without saving
Test Plan:
* as a teacher, create a text entry assignment
* as a student in a2, navigate to the assignment
* click the "Start Entry" button
* make any changes to the RCE so it is not a blank entry
* attempt to navigate away from the page
** i.e. attempt to navigate to the assignments page
* you should get a warning that you have unsaved data
flag=assignments_2
fixes COMMS-2320
Change-Id: Iacac4c794d7daadb17c5175479d7765015e53911
Reviewed-on: https://gerrit.instructure.com/208342
Tested-by: Jenkins
Reviewed-by: Landon Gilbert-Bland <lbland@instructure.com>
QA-Review: Steven Burnett <sburnett@instructure.com>
Product-Review: Steven Burnett <sburnett@instructure.com>
refs COMMS-2291
flag=assignment_2
Test Plan:
- tabs function and look the same
Change-Id: I25d5560edf46a88aee2c4e4e4353f0181d8a2d9e
Reviewed-on: https://gerrit.instructure.com/208595
Tested-by: Jenkins
QA-Review: Steven Burnett <sburnett@instructure.com>
Product-Review: Steven Burnett <sburnett@instructure.com>
Reviewed-by: Landon Gilbert-Bland <lbland@instructure.com>
This was the one thing in that bundle that used lodash. By using a
Native method here it will mean we don’t load lodash on pages like the
Login page
Test plan:
* lodash should not be loaded as part of the
runOnEveryPageButDontBlockAnythingElse bundle
Change-Id: I9a5ad9aea3dfb00a9bd14097189473667f96bd93
Reviewed-on: https://gerrit.instructure.com/208607
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
calling $(document).width() causes a recalculate styles
And this function gets called on window.scroll so if we can bail out
Early it could help with scroll jank as well as page load speed
Test plan:
* this should work the same as before but be a little faster
Change-Id: Ib50171e2af0abe49e6f26da4dd06a345f0dff6ff
Reviewed-on: https://gerrit.instructure.com/208608
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
see: https://github.com/ryankshaw/jquery/commit/ce59a7f0b3c4fc6ff9a2176
for the diff of the actual changes
Copying from that commit message:
All of these checks only ever returned false in older browsers that
We no longer support. By getting rid of them, we can get rid of this
Chunk of javascript execution that happens on every page right before
The domcontentloaded event fires: https://cl.ly/d368d5c9388 which ends
Up being non-trivial because it causes a couple recalculate-styles
(As seen by the purple in that screenshot)
Test plan:
jQuery should work the same as before
* domcontentloaded should end 15-200ms sooner which means all pages
Should load a little faster
Change-Id: I3efa8752708b9043107e9123d31cd509536e9993
Reviewed-on: https://gerrit.instructure.com/208606
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
from profiling, it looks like when we call trackEvent, google analytics
Executes synchronously in the middle of all our other javascript and
Blocks it for a few ms while it does its thing
see: https://cl.ly/a94a028037d2
This will make it so it waits until we are done before letting GA run
Change-Id: Iff7275c1428c7ebcec04ccc1d4d46f56131c9b79
Reviewed-on: https://gerrit.instructure.com/208616
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
Using jquery this took 5ms just on the login page:
https://cl.ly/0ffa8030060d
using document.querySelectorAll will be faster
Test plan:
* the broken image fallbacks should work exactly the same as before
Change-Id: I1c38974dbcc55d5f777d48a7603ce847217b0ec6
Reviewed-on: https://gerrit.instructure.com/208615
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
This took 7ms while testing (https://cl.ly/2fbf815cc539).
Mostly because of the :visible check.
Since usually there are no “math” elements on the page, doing a
Simple document.getElementsByTagName('math') is faster
Test plan:
* mathML should work the same as it did before but the check on pages
That don’t have it should be faster
Change-Id: I34e989519919d3921c83351f0f00b31dbd914211
Reviewed-on: https://gerrit.instructure.com/208614
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
refs COMMS-2291
flag=assignment_2
Test Plan:
- tests pass
- all attempts work the same
- check network for the bundles we are loading
that we only load what we need
Change-Id: Ib9c83239387b2f27b613f3ff1ce4bfc160b299d5
Reviewed-on: https://gerrit.instructure.com/208596
Reviewed-by: Landon Gilbert-Bland <lbland@instructure.com>
Tested-by: Jenkins
QA-Review: Steven Burnett <sburnett@instructure.com>
Product-Review: Steven Burnett <sburnett@instructure.com>
refs COMMS-2291
flag=assignment_2
Test Plan:
- in A2 as a student submitting to a media assignment
- add a media file in the computer panel and some closed
captions
- click save
- in your database check the last closed caption see its the
file you uploaded
- celebrate
Change-Id: I557b519cdc4889827924cf190742e519dc00e8cb
Reviewed-on: https://gerrit.instructure.com/208353
Reviewed-by: Landon Gilbert-Bland <lbland@instructure.com>
Tested-by: Jenkins
QA-Review: Steven Burnett <sburnett@instructure.com>
Product-Review: Steven Burnett <sburnett@instructure.com>
this is the result of running:
npx @instructure/instui-cli upgrade --version 7
test plan:
* you should see a lot less deprecation warnings from instUI components
Change-Id: I01ba7a68e4c1838e2fb11b79226d2869aa862ef4
Reviewed-on: https://gerrit.instructure.com/207743
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
Note: There appears to be an issue with VoiceOver not announcing the
aria live updates. Going to ignore this for now and see if it is still a
problem when InstUI 6 lands. Another ticket will be created to check and
fix.
refs ADMIN-2811
flag=direct_share
test plan:
- should be able to search by name for courses you manage in the direct
share course selection tray.
- copy button disabled until you select a course
- after selecting a course, the copy button just logs to the console
- cancel button closes the tray
- generally accessible, except for VO reading alerts.
- could check the flash_screenreader_holder div in the inspector if
you want to watch the DOM changes that should trigger the alert.
Change-Id: I5c102b25d277204a9929f780adbe94b9d3e46bcb
Reviewed-on: https://gerrit.instructure.com/205371
Tested-by: Jenkins
QA-Review: Anju Reddy <areddy@instructure.com>
Product-Review: Jon Willesen <jonw+gerrit@instructure.com>
Reviewed-by: Carl Kibler <ckibler@instructure.com>
Closes CORE-3304
Test plan:
Jenkins passes
Verify builds run on canvas_docker nodes
Change-Id: I789531b8962d7ca53ff938951366a173ed69f2ca
Reviewed-on: https://gerrit.instructure.com/208506
Tested-by: Jenkins
Reviewed-by: James Butters <jbutters@instructure.com>
QA-Review: Robert Lamb <rlamb@instructure.com>
Product-Review: Robert Lamb <rlamb@instructure.com>
fixes GRADE-2401
test plan:
A. Setup
1. Select or create a typical course
2. Add a SIS LTI
B. Verify in Old Gradebook
1. Ensure New Gradebook is disabled
2. Visit Old Gradebook
3. Click the "Export" button to expand the menu
4. Click the sync button for the LTI
* the Sync Grades modal will open
5. Tab through the entire dialog & iframe
* Start on the close button
* End on the close button
6. Repeat Step 5
7. Verify the iframe remains the same size
C. Verify with New Gradebook
1. Enable New Gradebook
2. Visit New Gradebook
3. Click the "Actions" menu button
4. Click the menu option for either LTI
* the Sync Grades modal will open
5. Tab through the entire dialog & iframe
* Start on the close button
* End on the close button
6. Repeat Step 5
7. Verify the iframe remains the same size
Change-Id: I66adaf5457f307eaa41aec5e984f053b3dc6a7e7
Reviewed-on: https://gerrit.instructure.com/208510
Tested-by: Jenkins
Reviewed-by: Keith Garner <kgarner@instructure.com>
Reviewed-by: Gary Mei <gmei@instructure.com>
QA-Review: Jeremy Neander <jneander@instructure.com>
Product-Review: Keith Garner <kgarner@instructure.com>
Change-Id: I038e061f7e8bb5c95fd79f66a9c17e2d6a13ef5c
Reviewed-on: https://gerrit.instructure.com/207470
Tested-by: Jenkins
Reviewed-by: Gary Mei <gmei@instructure.com>
QA-Review: Jeremy Neander <jneander@instructure.com>
Product-Review: Jeremy Neander <jneander@instructure.com>
to allow mobile app activity to appear on the course access report
test plan: the following API endpoints should appear on the course
access report (enable page views to test):
- assignments index
- assignment show
- collaborations index
- conferences index
- modules index
- course roster (/api/v1/courses/X/users)
- discussion topics index
- discussion show
- discussion view ("Get the full topic")
- pages index
- page show
- quizzes index
- quiz show
for paginated index endpoints, only the first page should result
in an asset access
canvas web pages that are built on the API should not record
double accesses
flag=none
fixes ADMIN-2840
Change-Id: I7163537b05d389a0a33b0a0128740e7be354349a
Reviewed-on: https://gerrit.instructure.com/208379
Tested-by: Jenkins
Reviewed-by: Jon Willesen <jonw+gerrit@instructure.com>
QA-Review: Jon Willesen <jonw+gerrit@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
fixes GRADE-2365
test plan:
1. Create an assignment with a loooong title
2. Visit New Gradebook
3. Open the Grade Details Tray for the assignment
4. Verify the title is truncated
Change-Id: I6b1701b2a24d38cf2f72a240253f677e0212c554
Reviewed-on: https://gerrit.instructure.com/208478
Tested-by: Jenkins
Reviewed-by: Gary Mei <gmei@instructure.com>
Reviewed-by: Keith Garner <kgarner@instructure.com>
QA-Review: Jeremy Neander <jneander@instructure.com>
Product-Review: Jonathan Fenton <jfenton@instructure.com>
closes PLAT-4770
Test Plan:
- have related changes deployed in subscription service and
live-events-lti
- endpoint to get event_types now allows query param
(message_type='live-event' or 'caliper' and will return
the appropriate event types
Change-Id: I24b2c9e00cc86bd250a7f92bef021f41992b4b8f
Reviewed-on: https://gerrit.instructure.com/208340
Tested-by: Jenkins
Reviewed-by: Xander Moffatt <xmoffatt@instructure.com>
QA-Review: Xander Moffatt <xmoffatt@instructure.com>
Product-Review: Clint Furse <cfurse@instructure.com>
test plan:
* generate a peer review notification
* the link should have a full url with host
closes #CNVS-46754
Change-Id: I6e1f7b028e79adbabbb102f5b644dc91bf76b286
Reviewed-on: https://gerrit.instructure.com/206925
Tested-by: Jenkins
Product-Review: James Williams <jamesw@instructure.com>
Reviewed-by: Gary Mei <gmei@instructure.com>
Reviewed-by: Jeremy Neander <jneander@instructure.com>
QA-Review: Jeremy Neander <jneander@instructure.com>
when the user first inserts an image from the tray, constrain its size.
closes COREFE-241
test plan:
- load a page with the rce
- have a relatively large image in the course images
- insert the image into the rce
> expect it's size to be constrained so neither edge is > 320px
- select the image, and click Options
> expect the Custom image size should reflect the correct current
size of the image
- change the image size and click Done
> expect the image to be resized
- add the image again
- save what you're working on
> expect the images to keep their set sizes
- edit again
- in html view, add a style attribute, and any other attributes
to the <img> element
- flip back to rich view
> expect the image to look like you'd expect, given what you just did
- change the image size in the tray
> expect your custom style and other attributes to be preserved
- upload landscape image that's wider than 320px
> expect the grey placeholder box to be right-sized to 320 wide
> expect the image to be right-sized when it replaces the placeholder
- repeat, uploading a landscape file taller than 320px
Change-Id: I4aa3893eda846e82775c658fd51b7b8d796b2ec0
Reviewed-on: https://gerrit.instructure.com/207492
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
fixes: COREFE-251
We made a change to not redirect IE 11 users away from the login screen
But they also need to be able to get to the /login/oauth2/confirm action
that is from the `oauth2_provider` controller so this will let them see
that too.
Change-Id: I3a19211cc219150fc40db8d19e4a1563226b220f
Reviewed-on: https://gerrit.instructure.com/208371
Tested-by: Jenkins
QA-Review: Tucker Mcknight <tmcknight@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
test plan:
- set up and enable redis caching
- enable "new SIS integration settings" feature in account
- turn on "require assignment due date" in account settings
- create an assignment with overrides for multiple sections
and "sync to SIS" checked
- save the assignment
- the list of overrides should not be blank
fixes ADMIN-2854
flag=none
Change-Id: Ida6cb4b1fbb52a104f274e5b829bf074634921cf
Reviewed-on: https://gerrit.instructure.com/208080
Reviewed-by: James Williams <jamesw@instructure.com>
Tested-by: Jenkins
QA-Review: Anju Reddy <areddy@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
Clay Diffrient