setting default_internal will cause issues with reading and writing to
files, and is no longer necessary now that we override
ActiveSupport::SafeBuffer to always be utf-8 encoded.
however, setting default_external is still necessary to correctly read
in files like erb templates, scss files, etc.
fixes #CNVS-2165
test plan: course migrations and other operations that read/write to
files should work, but erb templates should also display without error.
in a console, File.open('test', 'w').external_encoding should be nil.
Change-Id: Ica02ff164a29617e95ee3d65a0e4f31414c2ce33
Reviewed-on: https://gerrit.instructure.com/16143
Reviewed-by: Ethan Vizitei <ethan@12spokes.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Brian Palmer <brianp@instructure.com>
closes #CNVS-2165
This is recommended in some guides for upgrading a Rails 2.3 app to Ruby
1.9, but it was causing a lot of problems with file reading and writing,
especially in gems.
Our override for ActiveSupport::SafeBuffer to always be encoded as utf-8
fixes the issue that originally prompted us to add these default
encodings in the first place.
Change-Id: Ifb4649dd6aa86bfb15ff16daa706a5c6df33292a
Reviewed-on: https://gerrit.instructure.com/16079
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Ethan Vizitei <ethan@12spokes.com>
QA-Review: Brian Palmer <brianp@instructure.com>
this'll let you run script/console and such without having to cd to the
rails root dir first.
Change-Id: Ic2ff10652afc92ac1e5dc4ebfef97a9a27059e29
Reviewed-on: https://gerrit.instructure.com/2790
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Zach Wily <zach@instructure.com>
Brian Palmer