refs PLAT-3500
Change-Id: I72c7166bd58053017fba0cca0c4be271de4a2b45
Reviewed-on: https://gerrit.instructure.com/157551
Tested-by: Jenkins
Reviewed-by: Marc Alan Phillips <mphillips@instructure.com>
Product-Review: Marc Alan Phillips <mphillips@instructure.com>
QA-Review: Marc Alan Phillips <mphillips@instructure.com>
so they match the size of the icons in the coming up and recent
feedback lists in the card dashboard
closes ADMIN-1258
test plan
- have at least 1 missing item, coming up item and recent feedback.
- load the card dashboard
> expect the To Do icons to look the same size as the coming up
and recent feedback lists' icons
Change-Id: I55264a0ad26ee9bae7fc1c5fb5a398c81c198db7
Reviewed-on: https://gerrit.instructure.com/157980
Tested-by: Jenkins
Reviewed-by: Jon Willesen <jonw+gerrit@instructure.com>
QA-Review: Jon Willesen <jonw+gerrit@instructure.com>
Product-Review: Christi Wruck
Previously, the dashboard card icons only had a focus box if canvas was
in high contrast. This change provides the focus outline, and replaces
the icon font used with the instui icon.
closes ADMIN-1218
test plan:
- load the card dashboard
- tab through the page
> expect to see an outline around the action icons at the bottom
of the card when it gets focus.
- retest in high contrast
> expect the same result
Change-Id: I875c3ada62cf5c3cb86c67f8eaf6cc41bbf8aacf
Reviewed-on: https://gerrit.instructure.com/157799
Tested-by: Jenkins
Reviewed-by: Jon Willesen <jonw+gerrit@instructure.com>
QA-Review: Jon Willesen <jonw+gerrit@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
When the user makes a submission, auto-mark the item as complete.
Not when graded
Not when excused.
User can override by unmarking as complete in the UI
fixes ADMIN-1263
test plan:
- have an assignment
- student's planner shows as not complete
- student checks as complete, refresh
> students's planner shows as complete
- student unchecks as complete.
- teacher grades the assignment
> expect student's planner not to be complete
- teacher excuses the assigment
> expect student's planner not to be complete
- student submits assignment
> expect student's planner to be complete
- student unchecks completed checkbox in planner, refresh
> expect not to be complete
Change-Id: Id3bf14b59b15789e5bd863dd433662ff999b6b0d
Reviewed-on: https://gerrit.instructure.com/157970
Tested-by: Jenkins
Reviewed-by: Jon Willesen <jonw+gerrit@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Christi Wruck
fixes ADMIN-1244
test plan:
- enable VoiceOver and set High Contrast mode
- in Planner, ensure that tabbing over an item shows focus
highlight around the item text
Change-Id: Ie2bcb52cabb0ef2cc22f918d024b99483780448a
Reviewed-on: https://gerrit.instructure.com/157977
Reviewed-by: Ed Schiebel <eschiebel@instructure.com>
Tested-by: Jenkins
QA-Review: Luke Kingsley <lkingsley@instructure.com>
Product-Review: Carl Kibler <ckibler@instructure.com>
fixes QA-550
test plan:
- run bundle exec rake doc:api
- assert that the endpoint /doc/api/accounts.html has a TermsOfService object documented
- make sure that the types on each of the represented fields are accurate
to the Terms of Service JSON returned by the accounts_controller.rb
terms_of_service method
Change-Id: I4d25fff55439eff767b730b8f4ac674bb55c1054
Reviewed-on: https://gerrit.instructure.com/157943
Reviewed-by: Landon Gilbert-Bland <lbland@instructure.com>
Tested-by: Jenkins
Product-Review: Rohan Cheeniyil <rcheeniyil@instructure.com>
QA-Review: Rohan Cheeniyil <rcheeniyil@instructure.com>
fixes COMMS-1324
Test Plan
* Navigate to announcements page
* Do a Keyboard only test on the
external feeds button
* Make sure focusing and SO are correct
Change-Id: Ic5bfde2a80e5e5feda6bc6cb121c819aae4c64a1
Reviewed-on: https://gerrit.instructure.com/157879
Reviewed-by: Sara Chadwick <schadwick@instructure.com>
Tested-by: Jenkins
Product-Review: Steven Burnett <sburnett@instructure.com>
QA-Review: Steven Burnett <sburnett@instructure.com>
Fixes COMMS-1326
Test plan:
- Create a calendar event
- Click on the event and edit it, verifying that there is no "appointment
group" tab
- Make sure there are no side effects- i.e., "appointment group" doesn't
show up anywhere else, but the tab still appears when creating a new
event
Change-Id: I6cf44f915330a90c8f06cf06321b70b156690a40
Reviewed-on: https://gerrit.instructure.com/157852
Tested-by: Jenkins
Reviewed-by: Landon Gilbert-Bland <lbland@instructure.com>
QA-Review: Steven Burnett <sburnett@instructure.com>
Product-Review: Sara Chadwick <schadwick@instructure.com>
Fixes COMMS-1162
Test plan:
- Create an appointment group as a teacher in a course or group
- Have a student sign up for an appointment, and leave a comment
- Click Calendar Feed on the sidebar, and use the link to import
the calendar into Google Calendar, Outlook, etc.
- Check that the appointment that the student signed up for is in your
external calendar, with the student listed as well as the comment
they left.
- Make sure to test in courses and in groups
- Try adding mutlitple student and see that they all show up
- Make sure students cannot export their calendars, and see other
students signed up for the same appointment
Change-Id: Ia34f5d2bc0a27a11082590a6715eba2900f912f1
Reviewed-on: https://gerrit.instructure.com/157459
Tested-by: Jenkins
Reviewed-by: Landon Gilbert-Bland <lbland@instructure.com>
Reviewed-by: Steven Burnett <sburnett@instructure.com>
QA-Review: Aaron Kc Hsu <ahsu@instructure.com>
Product-Review: Steven Burnett <sburnett@instructure.com>
test plan:
* turn on the sis import refactor feature flag
* importing a small sis import (default 50 rows or less)
should show the number of successfully imported rows
for each type on the sis import page
closes #CORE-1634
Change-Id: Ifdbe98c8bc9252552e7280d3df0764503a388396
Reviewed-on: https://gerrit.instructure.com/157791
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
closes OUT-2382
test plan:
- go through the setup steps in g/157781
- load LMGB
- confirm that clicking on the header for the single
outcome sorts both ascending and descending
- repeat confirmation above with New Gradebook
feature flag enabled
Change-Id: I17452d317ca6426735e347e61fd25c6e94c5f585
Reviewed-on: https://gerrit.instructure.com/157882
Tested-by: Jenkins
Reviewed-by: Michael Brewer-Davis <mbd@instructure.com>
QA-Review: Dariusz Dzien <ddzien@instructure.com>
Product-Review: Sidharth Oberoi <soberoi@instructure.com>
closes CORE-1362
Test Plan:
- In IE 11 with RCE/RCS enabled go to a page
- Enter in some content to the page
- Select some content and click the link toolbar button
- The link should appear on those words.
- Click that link and have the cursor somewhere within that
link.
- Click the link toolbar button again
- Replace the existing url with a new one
- The link should update and look the same as it did before.
- Repeat test in another browser for completeness.
Change-Id: I62079c00526f65fa7ded58a2e6abd5986385759f
Reviewed-on: https://gerrit.instructure.com/157347
Tested-by: Jenkins
Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com>
QA-Review: Tucker McKnight <tmcknight@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
Added the search API endpoint
Test Plan:
1. Pass Jenkins
Change-Id: I9d75ffb3018912bdc84f4c579c4e29dcb14151bb
Reviewed-on: https://gerrit.instructure.com/157851
Tested-by: Jenkins
Reviewed-by: Michael Hargiss <mhargiss@instructure.com>
Product-Review: Luke Kingsley <lkingsley@instructure.com>
QA-Review: Luke Kingsley <lkingsley@instructure.com>
Fixes COMMS-1325
Test Plan:
- Go to the announcements page and click the +Announcement
button while you have a screenreader on
- Move around the area where the "Topic Title" bar is; the h1 is
screenreader-only and should be around there
- Verify that it says "New Announcement"
- Do the same for a new discussion, and verify that it says "New
Discussion"
Change-Id: Ice030b22f95e9aa3c324d2333f36e03d27105872
Reviewed-on: https://gerrit.instructure.com/157871
Tested-by: Jenkins
Reviewed-by: Landon Gilbert-Bland <lbland@instructure.com>
QA-Review: Aaron Kc Hsu <ahsu@instructure.com>
Product-Review: Sara Chadwick <schadwick@instructure.com>
i could not discover the purpose of the removeUnwantedChars when
parsing date strings, but it is currently causing a bug, and it is
not safe, especially dealing with locale specific date formats.
fixes CORE-1614
test plan:
- change computer date to a day after the 24th of the month
- test with each locale mentioned in CORE-1614
- create a new calendar event
- the date printed below the date picker should match computer date
Change-Id: I3bdefe228776b1c9a0e3ddaa71f2677dd9b5f2f0
Reviewed-on: https://gerrit.instructure.com/157419
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Reviewed-by: Ryan Shaw <ryan@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Brent Burgoyne <bburgoyne@instructure.com>
This makes it so we can activate an editor without moving
actual DOM focus to the editor. Things like the RCS sidebar
work appropriately, but allows focus to remain where it was prior
to the RCE loading.
closes CNVS-42995
closes CORE-1638
closes CORE-1575
Test Plan:
- Go to an assignment
- Create a new one or edit one
- When the create/edit page loads notice that the
title field has focus.
- Use the RCS sidebar to add something to the editor.
- It should sucessfully put stuff in the editor.
- Repeat for pages, discussions, announcements, etc.
Change-Id: I732380c1bd67a51e6a0e250ac5e6a37abd3cff04
Reviewed-on: https://gerrit.instructure.com/157620
Tested-by: Jenkins
Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com>
QA-Review: Rohan Cheeniyil <rcheeniyil@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
test plan:
* create a question with question text with
an equation identical to the one referenced
in the ticket
* copy the course
* the copied question should have a working equation image
closes #CORE-1510
Change-Id: I3bf1d1be5b21b38f0698b49695d44cd24bf41706
Reviewed-on: https://gerrit.instructure.com/156260
Tested-by: Jenkins
Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com>
QA-Review: Rohan Cheeniyil <rcheeniyil@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
We removed 'wiki' from the modal but not
from the title. Sadlol.
Closes COMMS-1333
Test plan:
- create a page in a course
- delete the page
- view the deletion modal without wiki
in the title
Change-Id: Idc94b6e9ecfd57d6b9f06205f0cd75a54141229e
Reviewed-on: https://gerrit.instructure.com/157808
Tested-by: Jenkins
Reviewed-by: Steven Burnett <sburnett@instructure.com>
Product-Review: Steven Burnett <sburnett@instructure.com>
QA-Review: Steven Burnett <sburnett@instructure.com>
closes DOC-808
Test plan:
- View API change log and look at new
words for 2018-08-04 release
- View API change log archive link and
make sure new addition looks good
- Ensure both pages look pretty
Change-Id: I9676099a12a1587174d1c55966c91e063cddde5f
Reviewed-on: https://gerrit.instructure.com/157800
Tested-by: Jenkins
Reviewed-by: Steven Burnett <sburnett@instructure.com>
Product-Review: Steven Burnett <sburnett@instructure.com>
QA-Review: Steven Burnett <sburnett@instructure.com>
fixes ADMIN-1248
test plan:
- marking an incomplete item complete should not change the sort order
- marking a complete item incomplete should not change the sort order
- expanding the "Show X completed items" section should still show those
items at the bottom
- marking those items and incomplete should not move them.
Change-Id: I460a5e8103e6f507b7847617cc47c5b1b4216bfe
Reviewed-on: https://gerrit.instructure.com/157705
Tested-by: Jenkins
Reviewed-by: Ed Schiebel <eschiebel@instructure.com>
QA-Review: Ed Schiebel <eschiebel@instructure.com>
Product-Review: Christi Wruck
closes ADMIN-1077
test plan:
- go to a course's syllabus page
- read down to the "Schedule of Delivery/Course Summary" table
- read the table using the keyboard
> in NVDA, use down-arrow to read the table, and you should be able
to press Enter to click the link in the details column.
> should continue to work with other browser/screen readers too
Change-Id: Ia6eb1ee802d037252a26cd40434ae3d245221d81
Reviewed-on: https://gerrit.instructure.com/157446
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Luke Kingsley <lkingsley@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
Closes: CORE-1606 CORE-1607
This commit goes back to using a <Select> w/ native <option>s. The
new <Select> in ui-forms still has a bunch of edge-cases it needs
to work out.
Test plan:
* run through the test plan on the 2 linked jira tickets and make sure
They work
* also run through the test plan from g/155334 and make sure those
all still work.
Change-Id: I292e1d1f7ea5f177eb02526f286b90f8233487f1
Reviewed-on: https://gerrit.instructure.com/156474
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Tested-by: Jenkins
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
closes ADMIN-1251
test plan:
- no feature test required
- will un-break planner build
Change-Id: I12f86cddb97a8e8f4d9d179fdad781ccd3275d67
Reviewed-on: https://gerrit.instructure.com/157725
Tested-by: Jenkins
Reviewed-by: Dan Minkevitch <dan@instructure.com>
Product-Review: Dan Minkevitch <dan@instructure.com>
QA-Review: Dan Minkevitch <dan@instructure.com>
fixes RECNVS-484
if the context's shard differs from the current shard, the new
attachment should go on that shard instead of the current shard
test-plan:
- have canvas with multiple accounts each on a different shard
- have a user created in one account (A)
- enroll the user in a course in another account (B)
- have inst-fs enabled on both accounts
- while on the domain for account B:
- go to the user's files area
- upload a file
- the upload should succeed and end up on inst-fs
- refresh the files area, the uploaded file should be visible
- while on the domain for account A:
- go to the user's files area
- the uploaded file should be visible
Change-Id: I3d8c73bf55313fe8dfb21801e9cf1e31742786fc
Reviewed-on: https://gerrit.instructure.com/156856
Tested-by: Jenkins
Reviewed-by: Michael Jasper <mjasper@instructure.com>
QA-Review: Xander Moffatt <xmoffatt@instructure.com>
Product-Review: Jacob Fugal <jacob@instructure.com>
fixes ADMIN-1249
the code prevously looked for the item whose time was closest to today,
but that ignored the fact that in the UI, items are first grouped so
that the next item after today visually, might not actually be the
absolutely next item due. This was confusing.
test plan:
- have a student with items in the past and future, scroll into the
past, then click today
> should focus on the first visible item in the future
- have one item in one class AAA due at 2pm today
- have another item in class BBB due at 1pm today
- click today
> should focus the item in AAA, which is first in the UI, even
though it's due after the item in BBB
Change-Id: I142ae814845b35df52c4a79218f959f9f5ce90db
Reviewed-on: https://gerrit.instructure.com/157696
Tested-by: Jenkins
Reviewed-by: Jon Willesen <jonw+gerrit@instructure.com>
QA-Review: Jon Willesen <jonw+gerrit@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
If you only had items in the future, then today wasn't in the loaded
range, even though it was being displayed in the interface. Today should
be fetched in full on the first data load, so we can always assume it is
loaded.
fixes ADMIN-1250
test plan:
- have planner items in the future, after today, but no items on today
- Create a to-do item on today. It should be displayed.
Change-Id: I8af226e87498cdff6fb92f47a821555ef24be499
Reviewed-on: https://gerrit.instructure.com/157692
Tested-by: Jenkins
Reviewed-by: Ed Schiebel <eschiebel@instructure.com>
QA-Review: Ed Schiebel <eschiebel@instructure.com>
Product-Review: Jon Willesen <jonw+gerrit@instructure.com>
Re-enable date validation for assignment overrides that apply only to
individual students, but allow dates for these overrides to fall outside
of the date boundaries prescribed by the relevant section/course/term.
Merely check that the assignment is not due within a closed grading
period and that the unlock, due-at and lock dates are consistent
relative to one another.
fixes GRADE-1343
Test plan:
Setup:
* Have a course with the following:
* Defined start and end dates
* Enrollment should be restricted to those dates (i.e., enable
"users can only participate in the course between these
dates" in Settings)
* A section with defined start and end dates and at least one student
* Enable "Users can only participate in the course between these
dates" in the section's settings
* Make the course part of a term with defined start and end dates
* Create a new assignment in the course that requires a submission
* Add an override for an individual student in the section you created
above
* The following SHOULD be allowed for the unlock/due/lock dates:
* Setting dates outside start or end date of the user's section
* Setting dates outside the course start or end date
* Setting dates outside the term's start or end date if the course
does not restrict enrollment
* The following should NOT be allowed:
* Setting the unlock/due/lock dates out of order (the unlock
date must be before the due date, which must be before the
lock date)
* Setting a due date in a closed grading period
* Confirm that the behavior of overrides for sections and "default"
overrides has not changed
* Dates must be within the course's start/end dates, or the term's
start/end dates if the course does not restrict enrollment
* An override for a section must also have dates within that section's
start/end dates
Change-Id: I8fed4d6f365c6a76a2a7e9b387f43a28a4521ec7
Reviewed-on: https://gerrit.instructure.com/157320
Reviewed-by: Spencer Olson <solson@instructure.com>
Reviewed-by: Gary Mei <gmei@instructure.com>
Reviewed-by: Jeremy Neander <jneander@instructure.com>
Tested-by: Jenkins
QA-Review: Anju Reddy <areddy@instructure.com>
Product-Review: Sidharth Oberoi <soberoi@instructure.com>
closes OUT-2191
Test plan:
- create a course with no sections
- enable mastery paths in the course
- create a quiz assigned to "Mastery Paths" only
- verify that quiz is saved assigned
to Mastery Paths only, not Everyone Else as well
- create a discussion topic assigned to
"Mastery Paths" only
- verify that discussion is saved assigned
to Mastery Paths only, not Everyone Else as well
Change-Id: I3af0c58f54a6f9a7ee612ab87276984574ef08d0
Reviewed-on: https://gerrit.instructure.com/155222
Reviewed-by: Augusto Callejas <acallejas@instructure.com>
Reviewed-by: Neil Gupta <ngupta@instructure.com>
Tested-by: Jenkins
QA-Review: Dariusz Dzien <ddzien@instructure.com>
Product-Review: Sidharth Oberoi <soberoi@instructure.com>
Added a post response test
Test Plan
1. Pass Jenkins
Change-Id: I45cb5288b8131f02b0e4bc5886d0ec9880704970
Reviewed-on: https://gerrit.instructure.com/157178
Tested-by: Jenkins
Reviewed-by: Anju Reddy <areddy@instructure.com>
Product-Review: Luke Kingsley <lkingsley@instructure.com>
QA-Review: Luke Kingsley <lkingsley@instructure.com>
Uploading a csv with moderated assignments would fail because
the attributes that would be checked weren't previously loaded in.
fixes GRADE-1374
Test Plan
- Create a moderated assignment.
- Export the gradebook.
- Modify the grade for the moderated assignment.
- If you are the final grader, uploading should work.
- If you are not the final grader, uploading should have no effect.
Change-Id: If0cef730e3b22cd9b049a9c44133cb7a389a6e85
Reviewed-on: https://gerrit.instructure.com/157526
Tested-by: Jenkins
Reviewed-by: Jeremy Neander <jneander@instructure.com>
Reviewed-by: Adrian Packel <apackel@instructure.com>
QA-Review: James Butters <jbutters@instructure.com>
Product-Review: Sidharth Oberoi <soberoi@instructure.com>
closes ADMIN-1229
test plan:
- have a course with ungraded pages and/or discussions included
in a module
> expect the todo date to show up in the modules page like
the due date would for an assignment
Change-Id: Iab3659dca116c61a4dbc2a68f57b884ea4501900
Reviewed-on: https://gerrit.instructure.com/157517
Reviewed-by: Carl Kibler <ckibler@instructure.com>
Reviewed-by: Dan Minkevitch <dan@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Christi Wruck
Tested-by: Jenkins
fixes ADMIN-1233
graded items have Due dates. ungraded items and notes have "To Do"
dates.
calendar_events have no label, just the time(s)
test plan:
- student with graded discussion, ungraded discussion added to todo
list, ungraded page added to todo list, todos, calendar event with
start time and with start&end time and all day, and an assignment.
> expect:
ungraded discussions, pages, todos to say "TO DO: time"
graded discussions, assignments to say "DUE: time"
calendar events to just show "datetime"
or "start to end"
or "ALL DAY"
announcements just show the datetime
Change-Id: I4f600bcc22e85e3c2cf2eda67eac90fa2b7cb269
Reviewed-on: https://gerrit.instructure.com/157369
Reviewed-by: Carl Kibler <ckibler@instructure.com>
Tested-by: Jenkins
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Christi Wruck
This should pick up coverage from both karma and jest
in Canvas proper. It should also pick up coverage from anything under
packages/*
closes CORE-1265
Test Plan:
- Run `COVERAGE=true yarn test`
- Coverage reports (coverage-final.json) should generate in all
packages such as (canvas-planner) as well as in coverage-karma
and coverage-jest
- Run `yarn run test:coverage`
- coverage-js folder should be generated. Opening index.html
should show the full coverage report
- Remove coverage-{js, karma, jest} and
packages/canvas-planner/coverage as well as .nyc_output to get back
to a clean state
- Run `RUN_TESTS_FIRST=true yarn run test:coverage`
- All tests should run and generate the appropriate report just
like the last time in coverage-js
Change-Id: I50744b8977e0683e079af5bdd2865dbcd6ad9066
Reviewed-on: https://gerrit.instructure.com/146098
Tested-by: Jenkins
Reviewed-by: Ryan Shaw <ryan@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
Fixes: CORE-1518
Test plan:
when using newest version of Microsoft Edge:
In the RCE, add a table.
After adding the table, attempt to edit the table.
You should be able to edit tables using the RCE when using MS Edge
Change-Id: Ibbc38ac11c6fbb808a31e16a84fe24a87a979e5b
Reviewed-on: https://gerrit.instructure.com/157456
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Tested-by: Jenkins
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
fixes CORE-1519
test plan:
- navigate to Themes page
- make sure Templates and My Themes headings are h2
Change-Id: I02effb3913a9aa84bfbd1a1dee26eec34589e444
Reviewed-on: https://gerrit.instructure.com/153849
Product-Review: Dan Sasaki <dsasaki@instructure.com>
QA-Review: Dan Sasaki <dsasaki@instructure.com>
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Tested-by: Jenkins
expanding the completed items toggle used to sort the contained
items into their respective places in the grouping. this caused them
to jump around. This changes the sort order to keep completed items
together at the bottom
fixes ADMIN-1241
test plan:
- on the same day, create todos
ccc, 11:59, not complete
bbb, 10:00, complete
aaa, 11:59, complete
- load the planner
> expect to see "ccc" and "show 2 completed items"
- open the completed items
- expect to see ccc, bbb, aaa in that order
Change-Id: I9fbdc802b35e3db6d6518a44f7719856181e0aaf
Reviewed-on: https://gerrit.instructure.com/157405
Tested-by: Jenkins
Reviewed-by: Carl Kibler <ckibler@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
when item (assignment or wikipage) can be marked done in exactly
one module, its mark-done status will reflect as completed in
planner, and vice versa.
closes ADMIN-966
test plan:
- Set assignment as having "mark done" requirement in ONE module
- Verify that marking done in module shows complete in planner and
marking un-done then un-completes it in planner.
- Add to second module, also with "mark done" requirement. Planner
status will no longer be affected by its done status.
Change-Id: Ifaed71b3397a995a0385e4add033c556600966cc
Reviewed-on: https://gerrit.instructure.com/157184
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Carl Kibler <ckibler@instructure.com>
‘html-react-parser’ causes yarn all kinds of fuss when it tries to
update stuff because it says it wants at least react 15. This approach
does the same thing we were using it for but without that package.json
dependency. This fixes some problematic stuff in our yarn.lock
Test plan:
* the permissions page should have the same perf as it did before
(Or slightly better)
Change-Id: Id7ce3e1b5e51c077b9d51ffa15ac94ee158f3ee5
Reviewed-on: https://gerrit.instructure.com/156895
Reviewed-by: Steven Burnett <sburnett@instructure.com>
Tested-by: Jenkins
QA-Review: Landon Gilbert-Bland <lbland@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
test plan:
- go to /doc/api/live
- enter an API token and click "Save token"
- expand "Courses" and "Update courses"
- enter an account_id and one or more course_ids
separated by commas
- click "Try it out"
- the request should succeed
fixes ADMIN-1124
Change-Id: I6d796fd33d0d6da88a3975617b7e0956de56cd29
Reviewed-on: https://gerrit.instructure.com/156289
Reviewed-by: Mysti Sadler <mysti@instructure.com>
Reviewed-by: Carl Kibler <ckibler@instructure.com>
Tested-by: Jenkins
QA-Review: Ed Schiebel <eschiebel@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
closes OUT-1861
test plan:
- in a course, create 5 outcomes and 5 student users
- create an assignment aligned to a single outcome
- using 2 student users, submit to the assignment
- assess the submissions' rubric assessments
- using current and new gradebook, perform the following steps:
* load up LMGB
* all students and all outcomes should be displayed, with 2 results
* enable "Hide outcomes with no results"
* confirm that only the assessed outcome appears as a column
* enable "Hide students with no results"
* confirm that a spinner appears and then displays the 2 assessed
student users
* disable "Hide outcomes with no results"
* confirm that all outcomes appear, but still just 2 students
* disable "Hide students with no results"
* confirm that a spinner appears and then displays all
outcomes and students
Change-Id: Idcf8371410b5b4871e03e175523399e9a4941651
Reviewed-on: https://gerrit.instructure.com/156908
Reviewed-by: Michael Brewer-Davis <mbd@instructure.com>
Reviewed-by: Frank Murphy <fmurphy@instructure.com>
Tested-by: Jenkins
QA-Review: Dariusz Dzien <ddzien@instructure.com>
Product-Review: Sidharth Oberoi <soberoi@instructure.com>
test plan
- repeat https://gerrit.instructure.com/#/c/145605/
Change-Id: Ife7642ca63c9338215a0d8835e3d16d35adefc65
Reviewed-on: https://gerrit.instructure.com/157362
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
refs ADMIN-798
test plan:
- specs pass without these errors
- opportunities badge on bell button still reads screen reader label in
Firefox with JAWS
Change-Id: I611c911b4378c157170f0a0fe1e55093b4578c8d
Reviewed-on: https://gerrit.instructure.com/156747
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Reviewed-by: Carl Kibler <ckibler@instructure.com>
Tested-by: Jenkins
QA-Review: Ed Schiebel <eschiebel@instructure.com>
Product-Review: Carl Kibler <ckibler@instructure.com>
Nathan Mills