Refs MAT-423
flag=rce_buttons_and_icons
Test Plan:
- Navigate to an RCE instance and open
the tray to create a button & icon
- Scroll down to the image section and
choose "coure images"
- Click an image
> Verify a base 64 data URL representing
the image is printed to the console
In the next commit this base 64 data url
will be used to populate the preview icon
Change-Id: Icb6c619c4078c0b18c9f5d5d5b9e6286ac1dc9a6
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276942
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Juan Chavez <juan.chavez@instructure.com>
Product-Review: Weston Dransfield <wdransfield@instructure.com>
Reviewed-by: Juan Chavez <juan.chavez@instructure.com>
fixes an error we see sometimes.
no new cops
Change-Id: I9224fd60ec5ba7b327a1726e17669e15f2207bda
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277631
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
refs FOO-2307
flag = none
test plan:
- merge two users
- add a communication channel with an override
- try to split the users
- it should work
Change-Id: Ibe065e58414d051f420fb8231f0882d26acdcac9
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/272361
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
Change-Id: I59c4a91a06157d9bc7716587805990828b6c4450
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277613
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
When enhanced_gradebook_filters is enabled, actually call the provided
callback functions rather than simply ignoring them. This fixes an issue
where switching between sections (or other options like student groups)
wouldn't actually update the page without a reload.
closes EVAL-2077
flag=enhanced_gradebook_filters
Test plan:
- Have a course with enhanced gradebook filters active
- In Gradebook, switching between the old-style filters using the
dropdowns (section, student group, etc.) should update immediately
rather than requiring a reload
Change-Id: I5de8667a5197957c0e16cc673158028b32cc7826
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277130
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Syed Hussain <shussain@instructure.com>
Reviewed-by: Dustin Cowles <dustin.cowles@instructure.com>
Reviewed-by: Spencer Olson <solson@instructure.com>
Add the associatedUser field to the enrollment type, and the ability to
filter a course's enrollmentsConnection by specific enrollment types and
observed user IDs. This allows us to return only enrollments for
observers observing specific students.
closes EVAL-2059
flag=none
Test plan:
- Have a course with at least two observer enrollments, and various
other types of enrollments
- Take note of the ID of one of the students being observed
- In GraphiQL or your preferred testing platform, run a query like
query MyQuery {
course(id: <course ID>) {
enrollmentsConnection(filter: {
associatedUserIds: [<observed student ID>]
types: [ObserverEnrollment]
}) {
nodes {
_id
type
user {
_id
name
}
associatedUser {
_id
name
}
}
}
}
}
- Check that you only receive observer enrollments observing the user ID
you specified
- Check that the associatedUser field for observer enrollments contains
the id/name of the observed user and is null for other enrollment
types
- Check that the "types" filter option does the right thing without
specifying any associatedUserIds; e.g., test that asking for
types: [StudentEnrollment, ObserverEnrollment] returns only student
and observer enrollments
Change-Id: Ic0be3f6006e84202e017750fe0d3adde9ade2fdc
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276775
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Syed Hussain <shussain@instructure.com>
Reviewed-by: Spencer Olson <solson@instructure.com>
Reviewed-by: Kai Bjorkman <kbjorkman@instructure.com>
QA-Review: Kai Bjorkman <kbjorkman@instructure.com>
fixes FOO-2547
flag = none
test plan: "Pages - create" description should be correct
Change-Id: Ic5c71f3987e0495d9f22c7ebc42a9bc6d53a2799
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277582
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: August Thornton <august@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: August Thornton <august@instructure.com>
refs FOO-2501
flag = none
test plan:
- merge two users with communication channels
- hard delete one of the channels
- split the users
- it should work
Change-Id: I417446cc96e7391dd9d262505ac35b59ab0a333e
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276324
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: August Thornton <august@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: August Thornton <august@instructure.com>
This reduces noise in test output
Test plan:
- All tests pass
flag=none
Change-Id: I15a9552915a75b75a1de32be40dfd3d38abd4439
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277575
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Ahmad Amireh <ahmad@instructure.com>
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Product-Review: Syed Hussain <shussain@instructure.com>
to make safari 15's address bar background match canvas better.
closes LS-2821
flag = none
Test plan:
- Open Canvas in Safari 15 and expect the tab/address bar color to
match the global nav background color
- Open Canvas on Chrome Android and make sure the browser colors
look ok
Change-Id: I52ea2f7dc5ff5800f62f33b3fce504a8c594c5e9
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277541
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Ed Schiebel <eschiebel@instructure.com>
QA-Review: Ed Schiebel <eschiebel@instructure.com>
Product-Review: Peyton Craighill <pcraighill@instructure.com>
This is handy for setting the initial state in tests.
test plan:
- specs pass
flag = none
Change-Id: I757a254508806d249190fbcc044355a6ff31c051
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276965
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Tucker Mcknight <tmcknight@instructure.com>
Product-Review: Tucker Mcknight <tmcknight@instructure.com>
Reviewed-by: Sean Scally <sean.scally@instructure.com>
For all courses, not just k5.
closes LS-2811
flag = none
Test plan:
- Open a course with no grades as a teacher
- Expect to see publish buttons on home page and in settings, also
expect the published status indicator to be gone in settings
- Open a course with grades as a teacher and/or any course as a ta
(a user without permission to publish)
- Expect to see the publish indicator on the settings page but no
publish buttons there or on the home page
- Expect the above to work for homeroom courses and k5 subjects
(although no publish controls appear on the home page in subjects)
Change-Id: I46f14c7d280cf8cf20ec32a4f370913765485ece
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277537
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
QA-Review: Isaac Moore <isaac.moore@instructure.com>
Product-Review: Peyton Craighill <pcraighill@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Closes LS-2817
Test Plan: passes Jenkins
[skip-stages=Flakey]
Change-Id: Ic5ac43e5417b685e83a117de864f8af6556ecb60
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277354
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Tested-by: James Butters <jbutters@instructure.com>
Product-Review: Robin Kuss <rkuss@instructure.com>
all manual
note that for any methods moved/re-indented, I made no other changes
(except possibly a remove of a `self.` on a method call to call another
now-private method) for ease of review
Change-Id: I0cca6644264a0b46a45a1a5c99021c9deb64fca0
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277532
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
closes VICE-2223
flag=discussions_inline_grading
Test Plan:
- turn discussion redesign ff on
- go to a discussion
- in the console enter:
ENV.inline_grading_enabled
> should be true/false
Change-Id: Idf3b002523135afc1dd59b89106ea40977710c1d
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277551
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Caleb Guanzon <cguanzon@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Caleb Guanzon <cguanzon@instructure.com>
[skip-stages=Flakey]
all manual
the majority of these were negating symbols to document a boolean
param. the preferred way to do this is to use a kwarg instead.
some of them were converted to that, but some there were many
callsites and conflicting definitions so I didn't want to go that
far in this commit, and I just changed to `true` or `false`
as appropriate
Change-Id: Iccfbc1c7a1fb744704343130a6b2951f6741192f
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277547
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
fixes LS-2814
flag = none
Test plan:
- Create a k5 course and set it to public visibility
- Open the course without logging in
- Expect to see the course content
Change-Id: Icd05f36e9dd476c742520e41ff758969c0ea6449
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277481
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Robin Kuss <rkuss@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Jackson Howe <jackson.howe@instructure.com>
This moves the inst_access gem to the public repo and references
the now published inst_access gem instead.
Github:
https://github.com/instructure/inst_access
Rubygems.org:
https://rubygems.org/gems/inst_access
Test Plan:
- Specs pass
flag = none
Change-Id: I6002b118723e5a329202085a6c649a857e34d0e3
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277527
Reviewed-by: Michael Ziwisky <mziwisky@instructure.com>
QA-Review: Michael Ziwisky <mziwisky@instructure.com>
Product-Review: Michael Ziwisky <mziwisky@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
flag=none
closes VICE-2214
Test Plan:
- see ticket for designs
- create and publish a discussion
> should see "All Sections" under topic title on landing page
> on mouse over tool tip should render
Change-Id: I1477c016eaf1815edb8e8b663f3929524e069179
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276741
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Caleb Guanzon <cguanzon@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Caleb Guanzon <cguanzon@instructure.com>
refs VICE-1995
flag=react_discussions_post
Test Plan:
- turn discussion redesign ff on
- create a discussion with unlock date in the future
- reply to the discussion topic
- enter student view
> replies should be hidden
Change-Id: I347e5c5260507b1b2280b085e98b9c747745cb91
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277460
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Caleb Guanzon <cguanzon@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Caleb Guanzon <cguanzon@instructure.com>
closes VICE-2220
flag=discussions_inline_grading
Test Plan:
> should be able to turn on feature flag
Change-Id: Ib1f7b2677004f4921f7fa4848eeb093b859fb7cd
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277539
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Caleb Guanzon <cguanzon@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Caleb Guanzon <cguanzon@instructure.com>
refs MAT-508
flag=none
Test Plan:
- Follow the "steps to reproduce" on the ticket
> Verify the issue is no longer reproducable
Change-Id: I55c1a155477629e6eb5d1b2b151efd839e7f88c8
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277506
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jon Scheiding <jon.scheiding@instructure.com>
QA-Review: Jon Scheiding <jon.scheiding@instructure.com>
Product-Review: Weston Dransfield <wdransfield@instructure.com>
Fixes a regression that prevented observers from seeing the 'coming
up' list on the classic dashboard.
fixes LS-2812
flag = none
Test plan:
- Create an observer linked to a student in a classic course with
(at least) 1 upcoming assignment
- Visit the classic dashboard as the observer
- Expect to see the upcoming assignment under 'coming up' sidebar
- Visit the classic dashboard as the student
- Expect to see the assignment in the same place
- Visit the k5 dashboard as an observer of a k5 student and switch to
the schedule tab
- Expect to see the student's assignments in the planner
Change-Id: If03b864a558727ba1185c7f126677496adbe8940
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277401
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Nate Armstrong <narmstrong@instructure.com>
QA-Review: Nate Armstrong <narmstrong@instructure.com>
Product-Review: Jackson Howe <jackson.howe@instructure.com>
alert slack channel canvas_builds-noisy on node
failure and do not fail build for rspecq node
failure.
flag = none
Test Plan:
-Jenkins passes normally
-When queue is depleted and node acquired late
-Node will release before any steps are ran
-An RSpecQ node throws an exception during steps
such as can't pull image.
-The stage will get marked as UNSTABLE, following
stages will get skipped.
-Overall build result not affected by this failing
node.
-If tearDownNode stage fails, overall build will be affected.
-RSpecQ Reporter failures do affect overall build result
Change-Id: Iccbb66cad0a988a26bf17c8332a20d8d7d55ee5b
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276927
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Andrea Cirulli <andrea.cirulli@instructure.com>
QA-Review: James Butters <jbutters@instructure.com>
Product-Review: James Butters <jbutters@instructure.com>
Weston Dransfield