[skip-stages=Flakey]
manual (it says it's auto-correct, but it didn't. which is fine cause a few
I simplified in other ways than using Array.new)
Change-Id: I8a4d5cf61deac22ad24e012f5a6f3647c84d3d3c
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/278312
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
For all courses, not just k5.
closes LS-2811
flag = none
Test plan:
- Open a course with no grades as a teacher
- Expect to see publish buttons on home page and in settings, also
expect the published status indicator to be gone in settings
- Open a course with grades as a teacher and/or any course as a ta
(a user without permission to publish)
- Expect to see the publish indicator on the settings page but no
publish buttons there or on the home page
- Expect the above to work for homeroom courses and k5 subjects
(although no publish controls appear on the home page in subjects)
Change-Id: I46f14c7d280cf8cf20ec32a4f370913765485ece
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277537
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
QA-Review: Isaac Moore <isaac.moore@instructure.com>
Product-Review: Peyton Craighill <pcraighill@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Closes LS-2817
Test Plan: passes Jenkins
[skip-stages=Flakey]
Change-Id: Ic5ac43e5417b685e83a117de864f8af6556ecb60
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277354
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Tested-by: James Butters <jbutters@instructure.com>
Product-Review: Robin Kuss <rkuss@instructure.com>
Closes LS-2767
Test Plan: passes Jenkins and tests the pace plan modules
Change-Id: Id8cdb359ca396e3ad550d2e9d46e3da420e5be02
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276584
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Nate Armstrong <narmstrong@instructure.com>
QA-Review: Nate Armstrong <narmstrong@instructure.com>
Product-Review: Robin Kuss <rkuss@instructure.com>
When the flag is on, show the new create course modal (instead of the
classic one). Moves the modal and its utils into a new shared package.
Switches vocab from classic to k5 based on user. Hides homeroom sync
details in classic mode.
closes LS-2648
flag = create_course_subaccount_picker
Test plan:
- In root account settings, allow teachers to create courses
- Visit the k5 dashboard as a teacher or admin. Expect to always see
the new create course modal with 'subject' vocab when clicking the
'+' new course button regardless of flag state.
- Visit the classic dashboard as a teacher or admin. Expect to see
the classic create course modal with the flag off, and the new
modal with the flag on (and 'course' vocab in the modal).
- Visit the /courses page as a teacher or admin. If k5 is on, expect
to see the new modal with 'subject' vocab regardless of flag state.
If k5 is off, the modal shown should depend on the flag (and use
'course' vocab).
Change-Id: I85ed8a98896fc0470de0b751e739a41f00a0b982
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274555
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Robin Kuss <rkuss@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Peyton Craighill <pcraighill@instructure.com>
fixes LS-2602
flag=none
Test plan:
- View settings for a course
- Show Announcements on Home Page checkbox should have a label
Change-Id: I34ea69de218d17b532ea472ec296830101468e85
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/272947
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jonathan Guardado <jonathan.guardado@instructure.com>
QA-Review: Jonathan Guardado <jonathan.guardado@instructure.com>
Product-Review: Nate Armstrong <narmstrong@instructure.com>
closes LS-2546
flag=none
test plan:
- in k5 mode, with at least 1 homeroom
- logged in as a teacher
- go to "All Subjects" page (/courses)
- click the +Subjects button
> expect the "Creat Subject" modal to open
- click the 'x'
> expect it to close
- click +Subject then Cancel
> expect it to close
> click +Subject
> expect the dialog to work as it always has
- checking sync enrollments shows current homeroom courses
- entering subject name enabled Create button
- clicking Create button creates the course in the teacher's account
- repeat, logged in as an admin
> expect the dialog to include "Which account will this subject
be associated with" dropdown.
> expect it to work as expected
- turn of canvas for elementary
- go to /courses
> expect the button to be +Courses
- click it
> expect the "Start a New Course" modal
Change-Id: I1b557249be9917d492dd9b57da2e335fd6d18209
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/272336
Reviewed-by: Robin Kuss <rkuss@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Peyton Craighill <pcraighill@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Don't show stars next to k5 courses (subjects & homerooms) on the
course index for students/observers. Hide the starring column
completely if none of the courses in the table are favoritable. The
dashboard_cards endpoint will always return all k5 courses where the
user has a student/observer enrollment, plus classic courses and k5
courses with an admin enrollment that are favorited (up to 20 if no
valid favorites, or all of the user's favorited courses).
closes LS-2504
flag = none
[ignore-stage-results=Flakey Spec Catcher]
Test plan:
Favoritable == a classic course or a k5 course in which the user
has a teacher/ta/designer enrollment type
- Visit /courses as a user with both favoritable and non-favoritable
enrollments (preferably with current, past and future enrollments)
- In each of the tables (current, past, and future enrollments),
expect to see stars next to favoritable courses and nothing next
to non-favoritable courses
- Remove some favoritable enrollments - if the table only contains
non-favoritable enrollments, expect the entire favoriting column to
be gone
- Unstar everything
- Visit the dashboard, expect to see all enrollments (up to 20)
- Star a few things, expect to see all favorites plus any
non-favoritable courses
Change-Id: I122ccaba7e98ab256a976b11c9fb8115149f5dcd
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/271122
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Robin Kuss <rkuss@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Peyton Craighill <pcraighill@instructure.com>
closes: USERS-72
There were two remaining specs that weren't fully converted to POM
in the course_wizard_spec.rb file. Converted them fully to POM
by adding new objects for calendar and course pages.
Also changed skips to rely on a bug fix, since they seem to
meet time thresholds now.
Change-Id: Icb3f7205a0644026fc520ce8e3298cc8a8339850
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/219806
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Tested-by: Jenkins
Reviewed-by: Anju Reddy <areddy@instructure.com>
QA-Review: Anju Reddy <areddy@instructure.com>
Product-Review: Steve Shepherd <sshepherd@instructure.com>
closes: USERS-60
All tests are skipped. Moved course wizard tests
out of selenium/courses_spec.rb.
Created page objects for Courses, and tried a new
approach with page components, sections of a page
Change-Id: Ia0b98aa9c901482fa479aab29bb53e04253d3488
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/215890
Tested-by: Jenkins
Reviewed-by: James Butters <jbutters@instructure.com>
QA-Review: Steve Shepherd <sshepherd@instructure.com>
Product-Review: Steve Shepherd <sshepherd@instructure.com>
Cody Cutrer