This change fixes the roster view specifically, but also
renames all occurrences of `can_allow_course_admin_options`
to the more aligned `can_allow_course_admin_actions`
permission set.
Refs FOO-171
flag=granular_permissions_manage_users
test plan:
• Course admins should be able to Edit Sections and Edit Role
in the People page for the following enrollment types:
• ['TeacherEnrollment', 'DesignerEnrollment', 'TaEnrollment']
Change-Id: I40f127b25d6136f0a25b9abc7c75b18f3c89bcb4
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/258875
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
Adds a new course setting to make it so students
can't see students from other sections when it is
enabled. Behavior only triggers when there is more than
one section.
test plan:
1. As a teacher, create a course and go to the course settings page
2. Under more options, check the "Hide sections on the People page
from students" checkbox and then Click Update Course Details.
3. Leave the course as a single section for now and publish it.
4. Add a student to the course, and then log in as the student.
5. Go to the people page and verify you can see the Section column
on the roster table.
6. Log in as a teacher and add a second section to the course.
7. Add another student and assign them the new section.
8. Log in as either student, and verify on the people page that
the Section column no longer appears.
9. As a teacher turn off the setting and verify the students can
see the Section column again.
10. As a teacher, delete the second section.
11. Turn on the setting again and verify the student can still see
the Section column.
closes: USERS-352
Change-Id: I9a674674424e4d37d23e9df4dea690b1114feb7a
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/234974
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
This was achieved by turning the prettier rule on in .eslintrc.js
then running:
./node_modules/eslint spec/javascripts/jsx/<folder_name>/**/*.js
on each folder from the start directory to the end directory listed
above.
Test Plan:
- Automated tests pass
refs COREFE-347
flag = none
Change-Id: Id1e5c7fdaf846a094f1361ac4b02f6588abfe468
Reviewed-on: https://gerrit.instructure.com/212581
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Clay Diffrient <cdiffrient@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
refs: UIDEV-270
TEST PLAN:
- set-up: ensure you have Pages but no front page set
- navigate to a course
- select home from the sub navigation
- select "choose home page" from the right side bar
- see 'Front Page must be set first'
- next turn off the Front Page and repeat the steps to choose a
home page... should see the name of the Front Page with a
change link (since in context has been kept as a link that
will underline by default)
- lastly, ensure 'Front Page must be set first' underlines if the
user feature is turned on to underline links
Change-Id: I043ec7b44f9ad4f83d53f4089f490401900b15c2
Reviewed-on: https://gerrit.instructure.com/197974
Tested-by: Jenkins
Reviewed-by: Jennifer Stern <jstern@instructure.com>
QA-Review: Daniel Sasaki <dsasaki@instructure.com>
Product-Review: Pam Hiett <phiett@instructure.com>
Test plan:
* Try choosing a new home page with the "Choose a home page" button.
* In a new (unpublished) course:
* Select modules as the home page. Do not make any modules.
* Try to publish the course, it should prompt you to choose another
homepage.
* make some modules, it should now allow you to publish.
Change-Id: I7ef6f92cb95b443d6ba596d5ff6c9499fa943162
Reviewed-on: https://gerrit.instructure.com/102955
Tested-by: Jenkins
QA-Review: Dan Sasaki
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Product-Review: Cameron Matheson <cameron@instructure.com>
fixes: CNVS-34727
this will make webpack faster because it cuts down
the number of files it has to look for when
it looks a module up. right now, every time
someone asked for a app/jsx/whatever.jsx file
it had to do a stat for app/jsx/whatever.js first
and then look for app/jsx/whatever.jsx. it also
slows every lookup for handlebars/coffescript files
since it has to look for the jsx first
this was just the result of running this command:
find . -type f -name "*.jsx" | while read FNAME; do git mv "$FNAME" "${FNAME//.jsx/.js}"; done
test plan:
* automated specs should pass
* webpack build should run faster than the patchset
before this one
Change-Id: Ia15ded6dc2b09c10c4f9070edcee9305b5b429ad
Reviewed-on: https://gerrit.instructure.com/101005
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
closes: CNVS-34769
this is the result of running this find & replace
(^\s+)(module)(\s[\"\']|\()
\1QUnit.module\3
s/module/qunit.module/ in spec/coffeescripts
and the result of running this find & replace
(^\s+)(module)(\s*\()
\1qunit.module\3
in canvas-lms/spec/javascripts/
test plan:
* automated js specs should pass in requireJS and webpack
Change-Id: I65188cce4bd5e6e5caa199dc108393a93f400a67
Reviewed-on: https://gerrit.instructure.com/101100
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
This doesn't solve it for when the user being removed is the
top one in the list, but that is a bug in VO on that particular
page and should be fixed in the next version of Safari.
partially fixes CNVS-29898
Test Plan:
- Go to the users page in a course
- Activate VoiceOver and navigate to the cog menu for a student
in the middle of the list
- Remove the student, if it was in the middle of the list, the
message 'User successfully removed' should read and focus should
be on the previous cog menu
- Remove the first student on the list, focus should go to the
'+ People' button. Because of a VO bug the flash message
will likely not read in the case.
Change-Id: I1e261810bac353eaaedee78a4c69de581cf577ca
Reviewed-on: https://gerrit.instructure.com/82716
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
Ahmad Amireh