Commit Graph

30562 Commits

Author SHA1 Message Date
Steven Burnett e9333b19d7 remove development feature flag for ssd
fixes COMMS-1137

Test Plan:
- go to the feature options page on your account settings
- notice the section specific feature flag no longer says development
- turn on flag
- go to discussions index page
- notice nothing has changed

Change-Id: I03837d424298a5eab263523798cfcbbeaaa66fcb
Reviewed-on: https://gerrit.instructure.com/151920
Tested-by: Jenkins
Reviewed-by: Landon Gilbert-Bland <lbland@instructure.com>
Product-Review: Steven Burnett <sburnett@instructure.com>
QA-Review: Steven Burnett <sburnett@instructure.com>
2018-05-31 04:30:37 +00:00
Steven Burnett c1709544c1 improve discussion index performance
fixes COMMS-1132

Test Plan:
- Got to the discussions index page with some discussions in that course
   (with SSD FF on) as
  a student
  a teacher
- notice nothing crashes
- go to the index page again with no discussion
- notice nothing crashes again
- navigate with SR to the svg images (you shouldn't given alt is ""
  we are testing this because we changed the tag from an SVGwrapper to
  an img tag)
- notice svgs still work

Change-Id: Ie0f1a310244522fe4e644edce4f58f0135876086
Reviewed-on: https://gerrit.instructure.com/151541
Reviewed-by: Aaron Kc Hsu <ahsu@instructure.com>
QA-Review: Landon Gilbert-Bland <lbland@instructure.com>
Tested-by: Jenkins
Product-Review: Steven Burnett <sburnett@instructure.com>
2018-05-31 01:44:31 +00:00
Nick Pitrak d058cfec8e automatically add students to moderation (back end)
closes GRADE-1177

test plan:
- turn on anonymous moderated marking
- create a course with a student
- create a moderated assignment in the course
- add another student to the course
- go to the moderation page for the assignment
- ensure both students have a speedgrader link in the first column
- go back to the assignment page
- edit the assignment to only be assigned to the first student
- open the rails console
- find the assignment
- ensure assignment.moderated_grading_selections.count returns 1

Change-Id: I8ef9fb7715b103469ea35c303c4301520b7bf7cb
Reviewed-on: https://gerrit.instructure.com/150969
Tested-by: Jenkins
Reviewed-by: Adrian Packel <apackel@instructure.com>
Reviewed-by: Keith T. Garner <kgarner@instructure.com>
QA-Review: James Butters <jbutters@instructure.com>
Product-Review: Keith T. Garner <kgarner@instructure.com>
2018-05-30 22:46:21 +00:00
Ryan Shaw 2280785b70 instUI5 upgrade: context_card stuff
refs: CORE-1437

This commit just upgrades these components to use instUI 5 instead of
getting them from ui-core in instUI 4.

It is mostly just path renaming.

Test plan:
* verify these components still work as they used to and tests pass

Change-Id: Ic73391bf71c9cbd88f40d20f38790a28e906b878
Reviewed-on: https://gerrit.instructure.com/151782
Tested-by: Jenkins
Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
2018-05-30 22:26:31 +00:00
Ryan Shaw c471dbebd9 instUI5 upgrade: calendar/scheduler stuff
refs: CORE-1437

This commit just upgrades these components to use instUI 5 instead of 
getting them from ui-core in instUI 4. 

It is mostly just path renaming.

Test plan:
* verify these components still work as they used to and tests pass

Change-Id: I84d653eac1662b82ddffa03e92fa874a4fa849af
Reviewed-on: https://gerrit.instructure.com/151773
Tested-by: Jenkins
Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
2018-05-30 22:25:51 +00:00
Ryan Shaw 96dc2f4269 instUI5 upgrade: dasboard/dashcard stuff
refs: CORE-1437

This commit just upgrades these components to use instUI 5 instead of
getting them from ui-core in instUI 4.

It is mostly just path renaming.

Test plan:
* verify these components still work as they used to and tests pass

Change-Id: Idec02d4f36e44ec7e421eca0445113de27fb01f1
Reviewed-on: https://gerrit.instructure.com/151788
Tested-by: Jenkins
Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
2018-05-30 22:25:16 +00:00
Ryan Shaw 14b2805204 instUI5 upgrade: navigation_header stuff
refs: CORE-1437

This commit just upgrades these components to use instUI 5 instead of
getting them from ui-core in instUI 4.

It is mostly just path renaming.

Test plan:
* verify these components still work as they used to and tests pass

Change-Id: Ia3767be8947e96f077e8c8cc23d466f3656ba1e2
Reviewed-on: https://gerrit.instructure.com/151781
Tested-by: Jenkins
Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
2018-05-30 22:23:49 +00:00
Derek Bender 0d77c3278f add --pure-lockfile to local-yarn script
test plan:
- docker build succeeds
- specs pass

Change-Id: Ie60f52a9e8f473454544a0aa67e1cce0197a2776
Reviewed-on: https://gerrit.instructure.com/151938
Reviewed-by: Bryan Petty <bpetty@instructure.com>
Tested-by: Jenkins
Reviewed-by: Ryan Shaw <ryan@instructure.com>
QA-Review: James Butters <jbutters@instructure.com>
Product-Review: Derek Bender <djbender@instructure.com>
2018-05-30 21:52:49 +00:00
Ryan Shaw 5b7c1111cf instUI5 upgrade: announcements stuff
refs: CORE-1437

This commit just upgrades these components to use instUI 5 instead of 
getting them from ui-core in instUI 4. 

It is mostly just path renaming.

Test plan:
* verify these components still work as they used to and tests pass

Change-Id: I87b300d281d48f5dc8df06cc95164fe60a1453d2
Reviewed-on: https://gerrit.instructure.com/151770
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
2018-05-30 21:44:54 +00:00
Ryan Shaw 4da78019d1 instUI5 upgrade: themeEditor stuff
refs: CORE-1437

This commit just upgrades these components to use instUI 5 instead of
getting them from ui-core in instUI 4.

It is mostly just path renaming.

Test plan:
* verify these components still work as they used to and tests pass

Change-Id: Ic7d11713c6b515ae0389bfbadad5fcc8ca27dfdd
Reviewed-on: https://gerrit.instructure.com/151783
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
2018-05-30 21:42:05 +00:00
Ryan Shaw 669d3c8c3b instUI5 upgrade: random stuff
refs: CORE-1437

This commit just upgrades these components to use instUI 5 instead of
getting them from ui-core in instUI 4.

It is mostly just path renaming.

Test plan:
* verify these components still work as they used to and tests pass

Change-Id: I4735d82855b0e78f3d03ec49ffc0487c60e65bb6
Reviewed-on: https://gerrit.instructure.com/151787
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
2018-05-30 21:40:47 +00:00
Ryan Shaw e267910083 instUI5 upgrade: outcomes stuff
refs: CORE-1437

This commit just upgrades these components to use instUI 5 instead of
getting them from ui-core in instUI 4.

It is mostly just path renaming.

Test plan:
* verify these components still work as they used to and tests pass

Change-Id: Ic9b100db68541c56c201a5e8a1958b4703951b3c
Reviewed-on: https://gerrit.instructure.com/151786
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
2018-05-30 21:36:51 +00:00
Jeremy Neander eed2cca7f5 create simple version of new moderation page
refs GRADE-964
refs GRADE-877
refs GRADE-1024

test plan:
 A. Setup
    1. Enable Anonymous Moderated Marking
    2. Select or create a course
       a. with Anonymous Marking enabled
       b. with three instructors (A, B, and C)
       c. with at least one student
    3. Select or create an assignment
       a. with Moderated Grading
       b. with instructor A as the final grader
    4. Select or create an assignment
       a. with Moderated Grading
       b. with Anonymous Grading
       c. with instructor A as the final grader
    5. As each instructor (B and C)
       a. give at least one student a provisional grade
          on each assignment (using SpeedGrader)
       * This SHOULD create a new moderation_grader for each user
         and for each assignment

 B. Verify the Non-Anonymous Assignment
    1. Log in or act as instructor A
    2. Visit the moderation page for the assignment
    3. Verify the assignment title is visible on the page
    4. Open the browser console
    5. View the contents of ENV.GRADERS
    6. Verify for both instructors B and C:
       a. user_id is present
       b. anonymous_id is NOT present
       c. grader_name is present

 B. Verify the Anonymous Assignment
    1. Log in or act as instructor A
    2. Visit the moderation page for the assignment
    3. Verify the assignment title is visible on the page
    4. Open the browser console
    5. View the contents of ENV.GRADERS
    6. Verify for both instructors B and C:
       a. anonymous_id is present
       b. user_id is present
       c. grader_name is NOT present

Change-Id: Id69f926972c1daaf8d7db5257f66b92e30a914fa
Reviewed-on: https://gerrit.instructure.com/151149
Reviewed-by: Derek Bender <djbender@instructure.com>
Reviewed-by: Keith T. Garner <kgarner@instructure.com>
Tested-by: Jenkins
QA-Review: Indira Pai <ipai@instructure.com>
Product-Review: Sidharth Oberoi <soberoi@instructure.com>
2018-05-30 21:21:22 +00:00
wdransfield 3acee04c47 Delete access tokens if dev key scopes are removed
Closes PLAT-3414

Test Plan:
- Create a developer key with scopes.
- request an access token for that key.
- Remove a scope from the developer key and verify the
  access token is destroyed.
- Create another access token for the developer key.
- Add a scope to the developer key.
- Verify the access token is not destroyed.
- Make a change to the developer key that does not involve
  changeing scopes.
- Verify the access token is not destroyed.

Change-Id: I7393467a2c010636170792e3679f0652db7408d1
Reviewed-on: https://gerrit.instructure.com/151270
Tested-by: Jenkins
Reviewed-by: Stewie aka Nicholas Stewart <nstewart@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Jesse Poulos <jpoulos@instructure.com>
2018-05-30 20:42:41 +00:00
Ryan Shaw 0bd21c9ef9 Make all instUI 5 packages available
in the commits that follow, we start using these new packages so this 
commit has just been split out into its own so we don’t need to worry 
about commit order in the others. It does no harm to make them available
now, before they are used.

Change-Id: I553ce5ca1a81bddd17a5de428a04d424375f62e2
Reviewed-on: https://gerrit.instructure.com/151766
Tested-by: Jenkins
Reviewed-by: Steven Burnett <sburnett@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
2018-05-30 20:35:08 +00:00
Ryan Shaw ea35ad0c14 instUI5 upgrade: /shared stuff
refs: CORE-1437

This commit just upgrades these components to use instUI 5 instead of
getting them from ui-core in instUI 4.

It is mostly just path renaming.

Test plan:
* verify these components still work as they used to and tests pass

Change-Id: I83917eecd948ead674a6f1302802e0acfdb8ac55
Reviewed-on: https://gerrit.instructure.com/151774
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Tested-by: Jenkins
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
2018-05-30 20:33:08 +00:00
Ryan Shaw c7e2bb7148 instUI5 upgrade: external_apps
refs: CORE-1437

This commit just upgrades these components to use instUI 5 instead of
getting them from ui-core in instUI 4.

It is mostly just path renaming.

Test plan:
* verify these components still work as they used to and tests pass

Change-Id: I2dcca749877555bbc56b41e8b88fbfbb67d74b61
Reviewed-on: https://gerrit.instructure.com/151779
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Tested-by: Jenkins
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
2018-05-30 20:32:51 +00:00
Stewie (Nicholas Stewart) 7879c10cff Hide dev keys from sub-account navigation
Test Plan: As a sub-account, I shouldn't see the dev keys option in the
left side nav

Change-Id: Ib45128a7adb0f1794173edde6e218da63087af4b
Refs: PLAT-3420
Reviewed-on: https://gerrit.instructure.com/151755
Tested-by: Jenkins
Reviewed-by: Weston Dransfield <wdransfield@instructure.com>
QA-Review: Weston Dransfield <wdransfield@instructure.com>
Product-Review: Stewie aka Nicholas Stewart <nstewart@instructure.com>
2018-05-30 20:08:54 +00:00
Ryan Shaw 33fbb404e3 Upgrade GraderCountNumberInput to instUI5
Change-Id: Ibfadc87a8433cea79579c6749978f29b19cdff9f
Reviewed-on: https://gerrit.instructure.com/151103
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
2018-05-30 20:06:20 +00:00
Ryan Shaw 4909a62927 instUI5 upgrade: act_as stuff
refs: CORE-1437

This commit just upgrades these components to use instUI 5 instead of 
getting them from ui-core in instUI 4. 

It is mostly just path renaming.

Test plan:
* verify these components still work as they used to and tests pass

Change-Id: I66bfaddf14f3593d33ee63f12e9aca68761bb5b1
Reviewed-on: https://gerrit.instructure.com/151769
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
2018-05-30 20:04:31 +00:00
Ryan Shaw 40668f35d0 instUI5 upgrade: blueprint_courses stuff
refs: CORE-1437

This commit just upgrades these components to use instUI 5 instead of 
getting them from ui-core in instUI 4. 

It is mostly just path renaming.

Test plan:
* verify these components still work as they used to and tests pass

Change-Id: I52fc6e14125e873804f6ecae8d120e286068b35d
Reviewed-on: https://gerrit.instructure.com/151771
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
2018-05-30 20:03:56 +00:00
Ryan Shaw 719f1200e2 instUI5 upgrade: gradebook history stuff
refs: CORE-1437

This commit just upgrades these components to use instUI 5 instead of
getting them from ui-core in instUI 4.

It is mostly just path renaming.

Test plan:
* verify these components still work as they used to and tests pass

Change-Id: I882cf9b19a2ea5e1e611bfbfdd8da82f78f36ca7
Reviewed-on: https://gerrit.instructure.com/151780
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
2018-05-30 20:03:00 +00:00
Ryan Shaw 12471130be instUI5 upgrade: new_user_tutorial stuff
refs: CORE-1437

This commit just upgrades these components to use instUI 5 instead of
getting them from ui-core in instUI 4.

It is mostly just path renaming.

Test plan:
* verify these components still work as they used to and tests pass

Change-Id: Ib0c6f33b2072d86d2c1882e20dde2a26d2e6247b
Reviewed-on: https://gerrit.instructure.com/151777
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
2018-05-30 20:01:40 +00:00
Ryan Shaw 7f0f4207d2 instUI5 upgrade: conditional_release_stats
refs: CORE-1437

This commit just upgrades these components to use instUI 5 instead of
getting them from ui-core in instUI 4.

It is mostly just path renaming.

Test plan:
* verify these components still work as they used to and tests pass

Change-Id: Ie380e0be2833871e3d9f77fa2f2fdbc58be0291b
Reviewed-on: https://gerrit.instructure.com/151775
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
2018-05-30 19:59:46 +00:00
Ryan Shaw 13b0921154 instUI5 upgrade: add_people stuff
refs: CORE-1437

This commit just upgrades these components to use instUI 5 instead of 
getting them from ui-core in instUI 4. 

It is mostly just path renaming.

Test plan:
* verify these components still work as they used to and tests pass

Change-Id: I9690ff9a74f13338b73f99bead80036f64f3c14a
Reviewed-on: https://gerrit.instructure.com/151768
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
2018-05-30 19:59:36 +00:00
Ryan Shaw 060e9b14c5 Put parse-link-header back in package.json
…since we use it in our code

It used to be there, but somehow someone deleted it on accident

Change-Id: Id516fdb8507887ffed9450869654fc42a4afc415
Reviewed-on: https://gerrit.instructure.com/151898
Reviewed-by: Steven Burnett <sburnett@instructure.com>
Tested-by: Jenkins
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
2018-05-30 19:57:52 +00:00
wdransfield 93ebe227b1 Shorten new developer key modal load time slightly
Closes PLAT-3408

Test Plan
- Verify that opening the developer key create/edit modal is ~300ms
- Verify that once the modal has loaded a user cannot tab outside of
  the modal.

Change-Id: If41bc61a236337ba1356a32b90c58d847292891a
Reviewed-on: https://gerrit.instructure.com/151414
Reviewed-by: Marc Alan Phillips <mphillips@instructure.com>
Tested-by: Jenkins
QA-Review: August Thornton <august@instructure.com>
Product-Review: Weston Dransfield <wdransfield@instructure.com>
2018-05-30 19:48:25 +00:00
Marc Phillips 148f6fd439 Fix Several A11y Issues with DevKey Management
fixes PLAT-3404,PLAT-3405,PLAT-3407

Test Plan:
 - The Dev Key Table now has a button that must be pressed
   to show the key. Check that is works to show the key
   and is generally implemented sanely.

Change-Id: I4c2ffd381a134f91984251021592c672b89c0387
Reviewed-on: https://gerrit.instructure.com/151400
Tested-by: Jenkins
Reviewed-by: Weston Dransfield <wdransfield@instructure.com>
QA-Review: Weston Dransfield <wdransfield@instructure.com>
Product-Review: Jesse Poulos <jpoulos@instructure.com>
2018-05-30 19:46:32 +00:00
James Williams 422ea827c5 make qti import form option ordering consistent with CC
closes #ADMIN-1082

Change-Id: If4ecaf77c50c34ea760a0df938cd87d3ea8e0008
Reviewed-on: https://gerrit.instructure.com/151884
Tested-by: Jenkins
Reviewed-by: Carl Kibler <ckibler@instructure.com>
Product-Review: James Williams  <jamesw@instructure.com>
QA-Review: James Williams  <jamesw@instructure.com>
2018-05-30 19:41:54 +00:00
Michael Jasper ceb0f5ec75 handle missing setting values properly
closes RECNVS-440

test plan
- enable the instfs plugin with canvas, but have missing setting
  values (app-host, secret)
- actions with respect to instfs should not cause errors
  - login, logout, file upload
- canvas should treat instfs as it is not enabled if setting values
  are not set

Change-Id: I2a33a553c6d66e99fd85e8333b8d8a3b60124d10
Reviewed-on: https://gerrit.instructure.com/150575
Reviewed-by: Andrew Huff <ahuff@instructure.com>
QA-Review: Collin Parrish <cparrish@instructure.com>
Reviewed-by: Jacob Fugal <jacob@instructure.com>
Tested-by: Jenkins
Product-Review: Michael Jasper <mjasper@instructure.com>
2018-05-30 19:03:30 +00:00
Derek Bender b57cb8cbae add anonymous provisional grades controller
When loading or selecting a student in SpeedGrader, an ajax call is made
to obtain the provisional grade status for that student. This provides a
way to perform this request anonymously.

closes GRADE-1128

test plan
- given an anonymously graded and moderated assignment
- given some students assigned to said assignment
- when visiting speed grader
- then the page loads provisional grades endpoint which can be viewed in
  the dev tools on the network tab. The URL looks like:

  /api/v1/courses/1/assignments/1/anonymous_provisional_grades/status

Change-Id: Ib3d3a7b58fc8fa044d240dee0c1bef08b80384d0
Reviewed-on: https://gerrit.instructure.com/151607
Tested-by: Jenkins
Reviewed-by: Jeremy Neander <jneander@instructure.com>
Reviewed-by: Spencer Olson <solson@instructure.com>
QA-Review: Indira Pai <ipai@instructure.com>
Product-Review: Keith T. Garner <kgarner@instructure.com>
2018-05-30 17:40:14 +00:00
Frank Murphy 268036ac35 Fix rubric code counts in UI.
Fixes OUT-2261

Test Plan:
- Create several courses, add rubrics to them and add yourself
  as a teacher.
- Verify the rubric counts under the course name in the Find Rubrics
  dialog matches the number of rubrics you created for each course.

Change-Id: Ic9ccf8ba6abdd621177adcc5b0838cfebcc92899
Reviewed-on: https://gerrit.instructure.com/151743
Tested-by: Jenkins
Reviewed-by: Michael Brewer-Davis <mbd@instructure.com>
QA-Review: Andrew Porter <hporter-c@instructure.com>
Product-Review: Sidharth Oberoi <soberoi@instructure.com>
2018-05-30 16:43:13 +00:00
Landon Gilbert-Bland 14d6ffbebe Add the role tray to the new permissions page
Fixes COMMS-904

Test Plan:
  - Enable the new permissions page feature flag
  - Navigate to the permissions page
  - Click on one of the links in the top (horizontal) header, and notice
    that the tray is displayed
  - Nothing is hooked up to the backend yet, but notice that you can
    click on everything (minus the individual permissions edit buttons
    and it will properly display everything as designated in the designs
  - Make sure all this functionality works with a screenreader and
    keyboard only navigation.
  - Click around, see if you can break anything with this :)
  - Make sure everything is properly translated

Change-Id: I349f8c78a63358957d26de9112fa381898db8e66
Reviewed-on: https://gerrit.instructure.com/150383
QA-Review: Venk Natarajan <vnatarajan@instructure.com>
Reviewed-by: Venk Natarajan <vnatarajan@instructure.com>
Tested-by: Jenkins
Product-Review: Landon Gilbert-Bland <lbland@instructure.com>
2018-05-30 16:41:57 +00:00
Keith Garner a89d8b7b8b change assignment due date caching from a singleton to a strand
When invoking the DueDateCacher with update_grades on, switch to using
a strand based on the course instead of a singleton based on the
assignment. This should avoid score table contention when lots of
assignments in a single course are edited close in time to each other.

closes GRADE-1194

test plan:
 - Have a course with some students and a bunch of assignments
 - Edit the assignments quickly back to back
 - Ensure the jobs queued as a strand
 - (Testing this may be easier if delayed jobs isn't running and you
   edit inst-jobs to always background even if not in production.)

Change-Id: I4b5600f52f2f09b6faf994e29e6056e1c6eaeb60
Reviewed-on: https://gerrit.instructure.com/151661
Tested-by: Jenkins
Reviewed-by: Adrian Packel <apackel@instructure.com>
Reviewed-by: Jeremy Neander <jneander@instructure.com>
QA-Review: Jeremy Neander <jneander@instructure.com>
Product-Review: Keith T. Garner <kgarner@instructure.com>
2018-05-30 16:01:30 +00:00
James Williams d87f74ed4e fix cross-shard submission restoration on user split
closes #CORE-1427

Change-Id: I9573dba41b07463c8673e285936546987441ab8f
Reviewed-on: https://gerrit.instructure.com/151859
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
Product-Review: James Williams  <jamesw@instructure.com>
QA-Review: James Williams  <jamesw@instructure.com>
2018-05-30 15:39:18 +00:00
Michael Brewer-Davis fb67558957 remove stray colon
Test plan:
qa-cr

Change-Id: I1e1758d33fe888cb1490874823eb6724661ea84b
Reviewed-on: https://gerrit.instructure.com/151791
Tested-by: Jenkins
Reviewed-by: Augusto Callejas <acallejas@instructure.com>
Product-Review: Michael Brewer-Davis <mbd@instructure.com>
QA-Review: Michael Brewer-Davis <mbd@instructure.com>
2018-05-30 15:14:20 +00:00
Transifreq 7ca7110deb update ko translation
Change-Id: I6382cfe7bded28417ebbf0b2012ae7bb36768622
2018-05-30 06:08:54 -06:00
Transifreq 71bdfbf9a1 update de translation
Change-Id: Iaa471340848866ea5fb66c68939aebf2a1656155
2018-05-30 05:17:13 -06:00
Rob Orton 6abcee9d7a users are not deleted or tracked
Change-Id: I50c3f37199545e747233f73e014752fecd850e07
Reviewed-on: https://gerrit.instructure.com/151809
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
2018-05-29 23:46:58 +00:00
Augusto Callejas 3e2fdfd225 Outcome proficiency endpoints
closes OUT-1855, OUT-2214

test plan:
  - create an access token, which will be used below
    to perform HTTP requests, see:
    https://canvas.instructure.com/doc/api/file.oauth.html#using-access-tokens
  - using a tool like Postman, set an outcome proficiency
    for an account. perform a POST request at the endpoint
    `http://canvas.docker/api/v1/accounts/1/outcome_proficiency`
    with a `Content-Type` header value `application/json`
    and body with content like:

    {
      "ratings": [
        {
            "description": "great work",
            "points": 10,
            "mastery": true,
            "color": "00ff00"
        }
      ]
    }

  - retrieve the saved proficiency by performing GET request
    at the endpoint
    `http://canvas.docker/api/v1/accounts/1/outcome_proficiency`.
    it should match the proficiency created above.
  - update the proficiency by doing another POST request, but
    with multiple ratings, like:

    {
      "ratings": [
        {
            "description": "great work",
            "points": 10,
            "mastery": true,
            "color": "00ff00"
        },
        {
            "description": "bad work",
            "points": 0,
            "mastery": false,
            "color": "ff0000"
        }
      ]
    }
  - do a GET request to confirm the above changes were saved
  - do several other POST requests with multiple ratings
    that contain either multiple mastery ratings or none.
    these requests should fail with a 422 status code
    and an error message that contains `Only one rating can have mastery`.

Change-Id: Ib301c0394a99dbf55d7d85ceef28a95075faaec2
Reviewed-on: https://gerrit.instructure.com/150095
Reviewed-by: Frank Murphy <fmurphy@instructure.com>
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
Reviewed-by: Matt Berns <mberns@instructure.com>
QA-Review: Andrew Porter <hporter-c@instructure.com>
Product-Review: Michael Brewer-Davis <mbd@instructure.com>
2018-05-29 22:20:03 +00:00
Matthew Berns f58e92fb88 add spiky ui to react rubrics
closes OUT-1850

test plan:
- enable the non-scoring rubrics feature flag (note that due to caching
  you may need to wait for the feature to be truly enabled)
- create an outcome with 6 different tiers (from 5 points to 0 points
  and a mastery of 4 (necessary for proper testing until '0' is properly
  working in new UI)
- create a rubric with several criterion (at least 3, all with 3 or more
  scoring tiers) and the newly created outcome
- assess a student using the rubric. On the regular criterion, Provide a
  score of 100%, a score of over 50-100%, and a score of 0-50%
- view the rubric in the student grades page, the score of 100% should
  have a green spike, the middle score should have a yellow spike, and
  the lowest score should have a red spike
- assess the rubric again, providing a grade to the outcome (easiest to
  leave the grades page open and do this in another window)
- the following score/color combinations should happen, assuming 5 tiers:
  - 5pts - green
  - 4pts - green
  - 3pts - yellow
  - 2pts - yellow
  - 1pt - red

Change-Id: I1568cf62544b042f579cd10544523e97441dd288
Reviewed-on: https://gerrit.instructure.com/150783
Tested-by: Jenkins
Reviewed-by: Augusto Callejas <acallejas@instructure.com>
QA-Review: Dariusz Dzien <ddzien@instructure.com>
Product-Review: Sidharth Oberoi <soberoi@instructure.com>
2018-05-29 22:14:27 +00:00
Rob Orton 7c9f41312c restore states for sis_imports
fixes CORE-1397
fixes CORE-1398

test plan
 - run sis import that changes workflow_states of objects
 - restore the sis import
 - the states should be restored
 - rake doc:api should work

Change-Id: I4fb401699d53d4d8309c986ae27eefea99e93d53
Reviewed-on: https://gerrit.instructure.com/150113
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
QA-Review: Rohan Cheeniyil <rcheeniyil@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
2018-05-29 21:38:09 +00:00
Rob Orton 8e7e865c86 handle when analytics is not present
Change-Id: I7a491ee3144d1ec9e84b2f41a70e8c3edf164854
Reviewed-on: https://gerrit.instructure.com/151747
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
2018-05-29 21:36:20 +00:00
Rob Orton 4b1b66359a don’t use long transaction to add enrollments
Change-Id: I2b794751b3a20ef54ff2f9aa991c8050b8f61ff5
Reviewed-on: https://gerrit.instructure.com/150550
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
QA-Review: Rohan Cheeniyil <rcheeniyil@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
2018-05-29 21:28:57 +00:00
Rob Orton f3e4827e15 batch is required for sis imports
Change-Id: Ia1ff87b2b610c8e54e3ddd88e72242d92786ffb7
Reviewed-on: https://gerrit.instructure.com/150548
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
QA-Review: Rohan Cheeniyil <rcheeniyil@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
2018-05-29 21:28:50 +00:00
Rob Orton 2c18165470 create roll back data for batch_mode
closes CORE-1396

test plan
 - import batch_mode import
 - batch deletes should be logged

Change-Id: Iec11fdef8adc1cdf9175c09b5451df9d5f1afca4
Reviewed-on: https://gerrit.instructure.com/150109
Tested-by: Jenkins
Reviewed-by: James Williams  <jamesw@instructure.com>
QA-Review: Rohan Cheeniyil <rcheeniyil@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
2018-05-29 21:28:38 +00:00
Rob Orton 91a4234bd3 create roll back data for users
closes CORE-1395

test plan
 - import users
 - workflow_state changes should be logged

Change-Id: I1466d6ec9f0ac3d38f74fd1b7a68dd0fa1c77a2f
Reviewed-on: https://gerrit.instructure.com/150103
Tested-by: Jenkins
Reviewed-by: James Williams  <jamesw@instructure.com>
QA-Review: Rohan Cheeniyil <rcheeniyil@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
2018-05-29 21:28:29 +00:00
Rob Orton 9cfe51d449 create roll back data for groups
closes CORE-1394

test plan
 - import groups and group_memberships and
   group_categories
 - workflow_state changes should be logged

Change-Id: I91d50dcb7a34051b3c6b70bfb5acc2021cdbbc30
Reviewed-on: https://gerrit.instructure.com/150102
Reviewed-by: James Williams  <jamesw@instructure.com>
Tested-by: Jenkins
QA-Review: Rohan Cheeniyil <rcheeniyil@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
2018-05-29 21:28:23 +00:00
Rob Orton 57d0771887 create roll back data for admin importer
closes CORE-1393

test plan
 - import admin
 - workflow_state changes should be logged

Change-Id: I5067cf85f68cb2cc65d1f77c89572bb728b21988
Reviewed-on: https://gerrit.instructure.com/150101
Reviewed-by: James Williams  <jamesw@instructure.com>
Tested-by: Jenkins
QA-Review: Rohan Cheeniyil <rcheeniyil@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
2018-05-29 21:28:17 +00:00
Rob Orton 063e36faa4 create roll back data for section importer
closes CORE-1391

test plan
 - import sections
 - workflow_state changes should be logged

Change-Id: I18d24bd0dbffb26c9132a63e5b9da937e0742455
Reviewed-on: https://gerrit.instructure.com/150100
Reviewed-by: James Williams  <jamesw@instructure.com>
Tested-by: Jenkins
QA-Review: Rohan Cheeniyil <rcheeniyil@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
2018-05-29 21:28:10 +00:00