flag = new_quizzes_bank_migrations
Test Plan:
- New Quizzes Bank Migration should have a beta pill
- New Quizzes Bank Migration is hidden in production
Change-Id: Idbddab5d05bb900c22e6e324bf34bbe3ef8c34a9
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/283047
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Alex Slaughter <aslaughter@instructure.com>
QA-Review: Mark McDermott <mmcdermott@instructure.com>
Product-Review: Susan Sorensen <susan.sorensen@instructure.com>
We have many "Browserslist: caniuse-lite is outdated" warnings.
This enables one to run `npx browserslist@latest --update-db`
Test plan:
- All automated tests pass
flag=none
Change-Id: Ia1c863323f5ef0e0b748425a4bd40ace26ca54fa
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/282886
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Dustin Cowles <dustin.cowles@instructure.com>
Reviewed-by: Ed Schiebel <eschiebel@instructure.com>
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Product-Review: Syed Hussain <shussain@instructure.com>
With this we can more easily identify tests that can be moved to Jest.
Some of these were hard to categorize. The arrangement can be improved.
test plan:
- all automated tests pass
closes EVAL-2188
Change-Id: I8d926df4715f2a30fbb464fde4cf68b4e4bd7663
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/282898
Reviewed-by: Syed Hussain <shussain@instructure.com>
Reviewed-by: Spencer Olson <solson@instructure.com>
Product-Review: Syed Hussain <shussain@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
closes LS-2942
flag=none
test plan:
- follow the recreate steps in the ticket
> expect to get the child events when excludes[]=child_events
is not included in the URL
> expect not to get the child events when excludes[]=child_events
IS in the URL
Change-Id: I9594defad0679a5ea47912dc8738ba9556422518
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/282874
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jackson Howe <jackson.howe@instructure.com>
QA-Review: Jackson Howe <jackson.howe@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
closes LS-2891
flag=pace_plans
test plan:
- in a course with a pace plan
- in settings, set Participation to "Course" and enter dates
- go to pace plans and click Show Projections, uncheck
Required Completion... checkbox if checked
> expect the caption under End Date to say
"Required by course end date"
- create a term if you don't have one
- see /accounts/:id/terms
- from course settings, set Term to be a term with an end date
- go to pace plans and click Show Projections
> expect the caption under End Date to say
"Required by term end date"
- check Require Completion by Specified End Date
> expect the caption to say
"Required by specified end date
Change-Id: I132188385976e5d27142b472dfb3b5465aa803c7
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/282876
Reviewed-by: Jackson Howe <jackson.howe@instructure.com>
QA-Review: Jackson Howe <jackson.howe@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
closes EVAL-1960
flag=assignments_2_student
flag=observer_picker
Test plan:
- PreReqs:
- Setting.set("assignments_2_observer_view", "true")
- A course with multiple students and an assignment
- An observer in the course with multiple associated students and at
least one student enrollment of their own
- Submit to the assignment with each associated student including the
observer
- As the observer, navigate to the dashboard and select a student
- Navigate to an assignment in the course
- Observe the selected student's submission is shown
- Observe a flash message indicating the name of the student
- Repeat for each student
- Delete site cookie "k5_observed user_for..."
- Load an assignment page without visiting the dashboard first
- Observe flash message indicating the first student is being observed
- As the Observer, select their own name on the dashboard
- Navigate to an assignment in the observer's student enrollment course
- Observe their submission details are visible and no flash message is
displayed
Change-Id: I4b1354ce58c709991d1f32a531864ed32df7469a
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/280668
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Syed Hussain <shussain@instructure.com>
Product-Review: Syed Hussain <shussain@instructure.com>
Reviewed-by: Aaron Shafovaloff <ashafovaloff@instructure.com>
Reviewed-by: Spencer Olson <solson@instructure.com>
refs SEC-4437
flag = none
[pin-commit-respondus_lockdown_browser=8746ff2ccfd6e9ac1d7280687c88e9fa67c0f693]
[pin-commit-multiple_root_accounts=7b11533084764b3a34f390e9a75df26e9dd871f9]
rationale in the script file and more context in the accompanying ticket
~ test plan ~
edit package.json and modify one of the explicit workspace dependencies
such as @instructure/ready to have a specifier other than "*", run the
script and verify it exits with 1
yarn --silent workspaces info --json | \
node script/yarn-validate-workspace-deps.js 2>/dev/null
Change-Id: I6624ada67a21d433477a7ad4d36acf5801853b7a
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/282948
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Ben Rinaca <brinaca@instructure.com>
QA-Review: Ahmad Amireh <ahmad@instructure.com>
Product-Review: Ahmad Amireh <ahmad@instructure.com>
closes VICE-2410
flag=partial_anonymity
Test Plan:
- turn on redesign, anonymity and partial anonymit ff
- go to a partially anonymous discussion
- create an anonymous reply as a student
- edit the reply
> should not see anonymous response selector
Change-Id: I3cf2d4d896d8dcfa5a8687e9dae35489c3e90a8d
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/283030
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Caleb Guanzon <cguanzon@instructure.com>
Reviewed-by: Chawn Neal <chawn.neal@instructure.com>
closes VICE-2411
flag=partial_anonymity
Test Plan:
- turn on redesign, anonymity and partial anonymity ff
- go to a partially anonymous discussion
- create an anonymous reply as a student
> focus should not be cut off for dropdown selector
Change-Id: I400590d3970f2e9196cab55cd0f46f12cccc8b0e
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/283035
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Chawn Neal <chawn.neal@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Reviewed-by: Chawn Neal <chawn.neal@instructure.com>
closes VICE-2412
flag=partial_anonymity
Test Plan:
- turn on redesign, anonymity and partial anonymity ff
- go to a partially anonymous discussion
- as a student:
> should see anonymous avatar without blue border
Change-Id: I5773c39f2b82ec0f27e97f24d85706e73ee3cb25
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/283038
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Caleb Guanzon <cguanzon@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Caleb Guanzon <cguanzon@instructure.com>
I'd like to do some refactoring to user_search, but
wanted to see if I could cover all cases in the existing code first.
Change-Id: I40f50513d178d02dd194a463ec010c48d4334bd1
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/282892
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Ben Rinaca <brinaca@instructure.com>
QA-Review: Sean Scally <sean.scally@instructure.com>
Product-Review: Sean Scally <sean.scally@instructure.com>
closes VICE-2153
flag=react_inbox
test plan:
- Specs pass
- Go to Inbox
- Click on the compose icon
- You should be able to select To using the AddressBook
- Send a message
- Make sure selected users received the message
qa risk: low
Change-Id: Ie070548e8765fabacfaf664a69e257e275f4e04a
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/283015
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jeffrey Johnson <jeffrey.johnson@instructure.com>
Product-Review: Jeffrey Johnson <jeffrey.johnson@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
closes FOO-2586
flag = none
Test plan:
• Create an assignment and assign it to the one student with a
due date (Assignment due date override for individual user)
excluding the "everyone" default section scope
• Create a second user and merge the first student into the
newly created user
• Check the submission API for the merged student and assignment
and notice that the "cached_due_date" displays the assigned due
date used when creating the assignment
• See Jira for additional notes and attachments
Change-Id: If1ecddc72939fafc373f8aa060ccfd252bd01d8a
Change-Id: Idae972fceb4f28d9b1f9a99fb70f3dba0fc0d9e1
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/282894
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Ben Rinaca <brinaca@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: August Thornton <august@instructure.com>
closes MAT-497
flag=none
test plan:
- Edit a wiki page
- Embed a Studio video in RCE
> Verify in HTML view that the iframe
contains lti-embed class
- Save wiki page
- Open wiki page preview
- With browser dev tools, adjust the screen
width to < 320px
> Verify that the page padding is removed for
LTI iframe
> Verify that the iframe width fills the page
> Verify that you can horizontally scroll
inside iframe. With this we need to make sure
that no content is cut, for example: audio
scroll controls
Change-Id: Id420208deb9161741748fccec6fafe336e435859
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/282817
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob DeWar <jacob.dewar@instructure.com>
QA-Review: Jacob DeWar <jacob.dewar@instructure.com>
Product-Review: David Lyons <lyons@instructure.com>
James Butters