closes: CNVS-32953
This commit re-introduces Instructure Icons into Canvas.
Due to the range in aesthetic impact of including both line
and solid icons, the change is expansive and will be refined
in subsequent commits. The purpose of this commit is to:
- Make InstIcons available in Canvas allowing the use of the
react components
- Replace the current icon font with the new InstIcons font
- Allow for use of both 'Line' and 'Solid' icon variants
- Update the styleguide to reference the InstIcons github
documentation for examples
- Remove font custom from Canvas
Icons changed to line versions in Canvas:
- icon-compose (view on Dashboard card)
- icon-info (view on global notification)
- Updated icons to be larger for better visibility
(our old font was using a small font size)
- Updated font-size is now relative vs fixed, so better a11y
Test Plan:
- On compiling, icons in Canvas should now be changed to the
corresponding Instructure Icons as can be seen here
http://instructure.github.io/instructure-icons/
- The icon default displaying in Canvas should be solid icons.
If the variant "icon-Line" is added to an icon's css class,
it should display as line. For example, in the case of
<i class="icon-edit"></i>, adding
<i class="icon-edit icon-Line"></i> would result in a line
version of the edit icon displaying
- As a developer, you should be able to use InstUI react icons
- The rake task `bundle exec rake icons:compile` should no
longer exist
- The styleguide should no longer display example icons, but
should now include a link to the Instructure Icons github
documentation
Change-Id: I9780332de9fdf937b35caabadc2b2ee615892a43
Reviewed-on: https://gerrit.instructure.com/94175
Reviewed-by: Pam Hiett <phiett@instructure.com>
QA-Review: Dan Sasaki
Tested-by: Jenkins
Product-Review: Kyle Follett <kfollett@instructure.com>
Fixes PLAT-1908
Test Plan:
- Create an originality report and note the
id. Also note the assignmet id for the
associated attachment's assignment.
- Do a GET request to /api/v1/assignments/
<assignmnet_id>/originality_report/
<originality_report_id>
- Verify the specified originality report
is returned in the response body.
Change-Id: Icf584ed00305de8d78134ef85fca4e6003735f3e
Reviewed-on: https://gerrit.instructure.com/94739
QA-Review: August Thornton <august@instructure.com>
Reviewed-by: Nathan Mills <nathanm@instructure.com>
Tested-by: Jenkins
Product-Review: Weston Dransfield <wdransfield@instructure.com>
Fixes PLAT-1907
Test Plan:
- Create an originality report and note the
id. Also note the assignmet id for the
associated attachment's assignment.
- Do a PUT request to /api/v1/assignments/
<assignmnet_id>/submissions/:submission_id/
originality_report/<originality_report_id>
with the following
in the body:
{
"originality_report": {
"originality_score": 0.3
}
}
- Verify the originality report's
originality score is updated
accordingly.
- Repeat the request with:
- 'originality_report_file_id'
- 'originality_report_url'
- 'originality_report_lti_url'
and verify the report is updated
accordingly. Note that 'originality_report_file_id''
will require a valid attachment id.
- Attempt to update multiple values
at once and verify the report is
updated correctly.
- Verify the action does not allow setting
the originality_score to a number not in th
0..1 range.
Change-Id: I8ef00fd60c34e3bb79c6c531e002d4cab132ae2c
Reviewed-on: https://gerrit.instructure.com/94714
QA-Review: August Thornton <august@instructure.com>
Reviewed-by: Nathan Mills <nathanm@instructure.com>
Tested-by: Jenkins
Product-Review: Weston Dransfield <wdransfield@instructure.com>
Fixes: PLAT-1906
Test Plan:
- Create a new assignment with submission type
online with file upload.
- As a student submit a document as a
submission for the assignment and get
the Attachment id from the submission.
- Make a post request to
"/api/v1/assignments
/:assignment_id/submissions/:submission_id/originality_report" with
the following param in the body:
"originality_report": {
"external_tool_id":<id of the tool you installed>,
"originality_score": <any value between 0 and 1>
}
- Verify a new OriginalityReport is created.
- Verify create action fails if not all required
params are given
- Verify create action sets optional params correctly.
- Verify the action requires all specified resources
exists (file_id, and originality_score).
- Verify the action does not allow creating a tool with an
originality_score not in the 0..1 range.
- Verify the action requires the attachment to be
part of the submission.
- verify the action requires the submission to be
part of the assignment.
Change-Id: Id5b0b61d399e4330c8c815bd4715735907f7cc6b
Create OriginalityReport Api Create endpoint
Fixes: PLAT-1906
Test Plan:
- Create a new assignment with submission type
online with file upload.
- As a student submit a document as a
submission for the assignment and get
the Attachment id from the submission.
- Make a post request to
"/api/v1/assignments
/:assignment_id/submissions/:submission_id/originality_report" with
the following param in the body:
"originality_report": {
"external_tool_id":<id of the tool you installed>,
"originality_score": <any value between 0 and 1>
}
- Verify a new OriginalityReport is created.
- Verify create action fails if not all required
params are given
- Verify create action sets optional params correctly
- Verify the action requires all specified resources
exists (file_id, and originality_score).
- Verify the action does not allow creating a tool with an
originality_score not in the 0..1 range.
- Verify the action requires the attachment to be
part of the submission.
- verify the action requires the submission to be
part of the assignment.
Change-Id: Id5b0b61d399e4330c8c815bd4715735907f7cc6b
Reviewed-on: https://gerrit.instructure.com/94476
Tested-by: Jenkins
Reviewed-by: Nathan Mills <nathanm@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Weston Dransfield <wdransfield@instructure.com>
fixes CNVS-33525
Change-Id: Ib367aa590b350412bc86e6132194f059e7661154
Reviewed-on: https://gerrit.instructure.com/96026
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
Fixes CNVS-30796
Test Plan:
- With the id of a conversation_message and the
user_id and the conversation_id
- Hit PUT /api/v1/conversations/restore and include
user_id=<user_id> and
message_id=<conversation_message_id> and
conversation_id=<conversation_id>
- After the response returns go to the UI and you
should see the conversation/message reappear in
the UI
Change-Id: I4d5858de716c87c72cf99a382c7205056d614f24
Reviewed-on: https://gerrit.instructure.com/87406
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins
QA-Review: David Tan <dtan@instructure.com>
Product-Review: Steven Burnett <sburnett@instructure.com>
An endpoint has been added for site-admins to be able to resubmit broken
crocodoc documents to crocodoc. It can look at a whole school's
documents that are in an error state or a specific
fixes CNVS-33022
test plan:
- access /api/v1/support_helpers/crocodoc/shard to make sure it kicks
off a new shard fixer job. It should send you a success email.
- access
/api/v1/support_helpers/crocodoc/submission?assignment_id=5&user_id=6
to make sure it kicks off a new shard fixer job. It should send you a
success email.
- make sure that endpoint is only accessible when you are logged in as
a site admin user
Change-Id: I607260434eddb44e1e92ffba9254553363908d81
Reviewed-on: https://gerrit.instructure.com/93840
Tested-by: Jenkins
Reviewed-by: Shahbaz Javeed <sjaveed@instructure.com>
Reviewed-by: Neil Gupta <ngupta@instructure.com>
QA-Review: KC Naegle <knaegle@instructure.com>
Product-Review: Keith T. Garner <kgarner@instructure.com>
closes CNVS-32614
Test Plan:
- Enable dashboard card reordering
- Move dashcards around via drag n drop
- Refresh the page
- Cards should maintain the positions you moved them
to
Change-Id: I4c465b50698c4cc46e9a9418b8f62e137e2519cf
Reviewed-on: https://gerrit.instructure.com/92748
Tested-by: Jenkins
Reviewed-by: Felix Milea-Ciobanu <fmileaciobanu@instructure.com>
QA-Review: David Tan <dtan@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
gives a place for us to keep track of changed items for now
(and soon the restrictions for content after copy)
closes #MC-7
Change-Id: I7bbd6e371528a06ea93181b0f4d91f451ae99d52
Reviewed-on: https://gerrit.instructure.com/95502
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
also pins all migrations to Rails 4.2 semantics
Change-Id: I386566f7a1f3e3e8aa31675f467c87c443457aee
Reviewed-on: https://gerrit.instructure.com/95571
Reviewed-by: Simon Williams <simon@instructure.com>
Tested-by: Simon Williams <simon@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
ParamsParser isn't used in Rails 5 anymore (I think they just moved
it out middleware)
Change-Id: I5efb9cb779e6bd9863fd4093629b9415174269ff
Reviewed-on: https://gerrit.instructure.com/95546
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
they raised minimum postgres to 8.3, and changed the code to assume
the higher precision
Change-Id: I8f12004bb098da5f3f37ebf48708f3ee18833a21
Reviewed-on: https://gerrit.instructure.com/95545
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Colleen Palmer