closes: CNVS-32953
This commit re-introduces Instructure Icons into Canvas.
Due to the range in aesthetic impact of including both line
and solid icons, the change is expansive and will be refined
in subsequent commits. The purpose of this commit is to:
- Make InstIcons available in Canvas allowing the use of the
react components
- Replace the current icon font with the new InstIcons font
- Allow for use of both 'Line' and 'Solid' icon variants
- Update the styleguide to reference the InstIcons github
documentation for examples
- Remove font custom from Canvas
Icons changed to line versions in Canvas:
- icon-compose (view on Dashboard card)
- icon-info (view on global notification)
- Updated icons to be larger for better visibility
(our old font was using a small font size)
- Updated font-size is now relative vs fixed, so better a11y
Test Plan:
- On compiling, icons in Canvas should now be changed to the
corresponding Instructure Icons as can be seen here
http://instructure.github.io/instructure-icons/
- The icon default displaying in Canvas should be solid icons.
If the variant "icon-Line" is added to an icon's css class,
it should display as line. For example, in the case of
<i class="icon-edit"></i>, adding
<i class="icon-edit icon-Line"></i> would result in a line
version of the edit icon displaying
- As a developer, you should be able to use InstUI react icons
- The rake task `bundle exec rake icons:compile` should no
longer exist
- The styleguide should no longer display example icons, but
should now include a link to the Instructure Icons github
documentation
Change-Id: I9780332de9fdf937b35caabadc2b2ee615892a43
Reviewed-on: https://gerrit.instructure.com/94175
Reviewed-by: Pam Hiett <phiett@instructure.com>
QA-Review: Dan Sasaki
Tested-by: Jenkins
Product-Review: Kyle Follett <kfollett@instructure.com>
Change-Id: I77344f04a763b6e69cc045b026d536af0d138b04
Reviewed-on: https://gerrit.instructure.com/95949
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
fixes FALCOR-28
test plan:
- link to a project with a long name (like above)
- the linter should not complain
Change-Id: Ib28c5cdcb136ca1b7cb76dc8bca4518889e9bfa5
Reviewed-on: https://gerrit.instructure.com/95832
Reviewed-by: Landon Wilkins <lwilkins@instructure.com>
Product-Review: Landon Wilkins <lwilkins@instructure.com>
QA-Review: Landon Wilkins <lwilkins@instructure.com>
Tested-by: Jenkins
but have to use github, as the rails 5 compatible version is unreleased
Change-Id: I668fff26b7879365f148eea9ec6c93a79862735e
Reviewed-on: https://gerrit.instructure.com/95529
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
and pin aroi, now that canvas_statsd is more lax about that requirement
Change-Id: I613e18cc509e9a3682cd113d35ae92b4d6e4deb5
Reviewed-on: https://gerrit.instructure.com/95491
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
my bug fix was merged in upstream
Change-Id: If1d4cb6e8276360aa2a30124890883999dbdae79
Reviewed-on: https://gerrit.instructure.com/95406
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
refs CNVS-32945
test plan: the `[STATSD]` lines should still appear in the debug logs,
and should now include a cache_read value.
Change-Id: Ib19800ab2942bc61fb36574db8dc65087778371d
Reviewed-on: https://gerrit.instructure.com/94693
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Benjamin Christian Nelson <bcnelson@instructure.com>
Product-Review: Brian Palmer <brianp@instructure.com>
This isn't currently functioning in canvas, and isn't used often enough
to justify maintaining it.
test plan: This is all removing functionality, so we just need to verify
that canvas still loads without error.
Change-Id: I596587b773a5528521f6ee6dbbd8b5ce18d52d74
Reviewed-on: https://gerrit.instructure.com/95041
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
QA-Review: Benjamin Christian Nelson <bcnelson@instructure.com>
Product-Review: Brian Palmer <brianp@instructure.com>
This reverts commit c0e20beb55.
Change-Id: Ic8663b4c50ff15e535e3cb27af7a002502314111
Reviewed-on: https://gerrit.instructure.com/94946
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>
no functionality change, just making sure nothing broke with
switchman dropping rails 4.0/4.1 support
Change-Id: If7f56f833e185c303db60595853cf7e583f67941
Reviewed-on: https://gerrit.instructure.com/94691
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
We need some of the features introduced in the newer versions for LTI
Content Migration token creation.
Change-Id: Ie99af3f811d1eacd395286d221ca399f04b4534f
Refs: PLAT-1755
Reviewed-on: https://gerrit.instructure.com/93693
Reviewed-by: Andrew Butterfield <abutterfield@instructure.com>
Tested-by: Jenkins
QA-Review: August Thornton <august@instructure.com>
Product-Review: Tyler Pickett <tpickett@instructure.com>
This reverts commit ce771d353b.
fixes CNVS-32874
test plan:
- make sure that old icons are working appropriately, especially with
inst-ui components
Change-Id: If749cec08302b1bd252c0938ad9fd2329e1c1040
Reviewed-on: https://gerrit.instructure.com/93540
Reviewed-by: Colleen Palmer <colleen@instructure.com>
Product-Review: Colleen Palmer <colleen@instructure.com>
Tested-by: Jenkins
QA-Review: Pierce Arner <pierce@instructure.com>
Change-Id: Id1900160375644ea33badaa9d9f9185fab6b81ac
Reviewed-on: https://gerrit.instructure.com/92726
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
test plan:
* add an invalid hex code to a scss file
e.g. _variables.scss:
color: #YARRRRRRRR
* run stylelint with: `script/stylelint`
* verify the colored output only returns your introduced error
Change-Id: Ia4f2adef3635f34154d50d61249b952a380208bf
Reviewed-on: https://gerrit.instructure.com/92229
Reviewed-by: Jon Jensen <jon@instructure.com>
Product-Review: Jon Jensen <jon@instructure.com>
QA-Review: Jon Jensen <jon@instructure.com>
Tested-by: Jenkins
reduce runtime over 50% (200sec -> 90sec). also add `around(:all)` support
so we can speed up some plugins (this way we can Timecop.freeze an entire
group, including its :once blocks)
Change-Id: Iec66b01bad27de017d23cc1de49e34339cf18e79
Reviewed-on: https://gerrit.instructure.com/93331
Tested-by: Jenkins
Reviewed-by: Landon Wilkins <lwilkins@instructure.com>
Product-Review: Landon Wilkins <lwilkins@instructure.com>
QA-Review: Landon Wilkins <lwilkins@instructure.com>
Bundler 1.10.1 (and .2) contained a bug that didn't allow missing
gemspec files when validating path gems. This breaks autoextend as
shown in this reported Canvas issue:
https://github.com/instructure/canvas-lms/pull/927
This corresponds with the following fix in Bundler 1.10.3:
https://github.com/bundler/bundler/pull/3708
Test Plan:
1. Install bundler 1.10.3
2. Run clean bundle install
3. Verify successful bundle install
Change-Id: I322060b7316a1bcb60e95e3e7a992fd80dfeb64c
Reviewed-on: https://gerrit.instructure.com/93299
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Kausty Saxena <kausty@instructure.com>
Product-Review: Bryan Petty <bpetty@instructure.com>
bundler has correctly enforced its own gem requirement for long
enough that I'm no longer worried about confusion from people
running ancient versions of bundler
Change-Id: I55e2b5588e3ae38f9bba49bb370e0053ff4a72ed
Reviewed-on: https://gerrit.instructure.com/93036
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
To turn off, set DISABLE_BETTER_ERRORS ENV variable:
export DISABLE_BETTER_ERRORS=true
To re-enable, delete or unset the DISABLE_BETTER_ERRORS ENV var.
Setting the key to false will not work.
Change-Id: Icfe3985365d7fb3c3f2d005e998807bb9614fba1
Reviewed-on: https://gerrit.instructure.com/84383
Reviewed-by: Shahbaz Javeed <sjaveed@instructure.com>
Tested-by: Jenkins
Reviewed-by: Neil Gupta <ngupta@instructure.com>
Product-Review: Keith T. Garner <kgarner@instructure.com>
QA-Review: Keith T. Garner <kgarner@instructure.com>
it can coexist with v1, and now we can move our usages over to v2
one at a time
Change-Id: I6aa1ff3f46dbe3762ee2548d41ffd26e4c1b26fe
Reviewed-on: https://gerrit.instructure.com/92704
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
Reviewed-by: Jon Jensen <jon@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
and remove shoulda-matchers (the newer version breaks `redirect_to().or`,
and all the of the specs using it were self-evident specs of little
value)
Change-Id: Idca701a36203f3aa822909360c9bd2a90c9dcee8
Reviewed-on: https://gerrit.instructure.com/92503
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
Reviewed-by: Jon Jensen <jon@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
closes: CNVS-29706
This initial commit introduces Instructure Icons into Canvas.
Due to the range in aesthetic impact of including both line
and solid icons, the change is expansive and will be refined
in subsequent commits. The purpose of this commit is to:
- Make InstIcons available in Canvas allowing the use of the
react components
- Replace the current icon font with the new InstIcons font
- Allow for use of both 'Line' and 'Solid' icon variants
- Update the styleguide to reference the InstIcons github
documentation for examples
- Remove font custom from Canvas
Test Plan:
- On compiling, icons in Canvas should now be changed to the
corresponding Instructure Icons as can be seen here
http://instructure.github.io/instructure-icons/
- The icon default displaying in Canvas should be solid icons.
If the variant "icon-Line" is added to an icon's css class,
it should display as line. For example, in the case of
<i class="icon-edit"></i>, adding
<i class="icon-edit icon-Line"></i> would result in a line
version of the edit icon displaying
- As a developer, you should be able to use InstUI react icons
- The rake task `bundle exec rake icons:compile` should no
longer exist
- The styleguide should no longer display example icons, but
should now include a link to the Instructure Icons github
documentation
Change-Id: Id5a2f7be33b8e5bed76867da067309d044b5be06
Reviewed-on: https://gerrit.instructure.com/91014
Tested-by: Jenkins
QA-Review: Pierce Arner <pierce@instructure.com>
Reviewed-by: Jennifer Stern <jstern@instructure.com>
Product-Review: Jennifer Stern <jstern@instructure.com>
Product-Review: Kyle Follett <kfollett@instructure.com>
Colleen Palmer