[skip-stages=Flakey]
[skip-crystalball]
99% of fixes are Performance/StringIdentifierArgument, but one or
two instances of each of Performance/Count, Performance/MapCompact,
Rails/Pluck in safe navigation chains
Change-Id: Ibd2292fb9e7c1e9162068021073c3c0f4b0d65df
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/335489
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Ogata <aogata@instructure.com>
Build-Review: Aaron Ogata <aogata@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
[skip-stages=Flakey]
Change-Id: I6abefdfa9fed6dd4525c8786e93efa548b3710f2
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/319603
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
QA-Review: Jacob Burroughs <jburroughs@instructure.com>
Product-Review: Jacob Burroughs <jburroughs@instructure.com>
Build-Review: Jacob Burroughs <jburroughs@instructure.com>
Migration-Review: Jacob Burroughs <jburroughs@instructure.com>
test plan:
- enable redis
- in the rails console, for a given course, do
course.add_content_notice :import_in_progress, 1.hour
- navigate to a page in that course as a user who has
manage_content permission
- the "One ore more items are currently being imported" message
should appear at the top of the page and should be read
to screenreaders
fixes ADMIN-2208
Change-Id: I39f2efe231c27e009aee0b13bbe26dc8fa37bad5
Reviewed-on: https://gerrit.instructure.com/175149
Tested-by: Jenkins
Reviewed-by: Ed Schiebel <eschiebel@instructure.com>
QA-Review: Daniel Sasaki <dsasaki@instructure.com>
Product-Review: Daniel Sasaki <dsasaki@instructure.com>
test plan:
- in an environment with redis caching enabled,
- create a content migration with the API and add the
undocumented parameter
settings[import_in_progress_notice]=1
- while the course import is in progress, course pages
should show a blue banner at the top of each page
indicating that an import is in progress, and linking
to the migration status page
fixes CNVS-14517
Change-Id: I9cf5c10e043f07460a1e42491addd029cfe31396
Reviewed-on: https://gerrit.instructure.com/38815
Reviewed-by: James Williams <jamesw@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Cosme Salazar <cosme@instructure.com>
Cody Cutrer