disable bullet in rails 6
Change-Id: Ic84a291c9bd81dd1ef93d414b9ef73d277d07273
Reviewed-on: https://gerrit.instructure.com/204711
Tested-by: Jenkins
Reviewed-by: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
two breaking changes:
* validations are gone, just use vanilla rails validations
* authenticates_many is gone. use a scoping call instead
Change-Id: Iad2a5d4655ad116e85ea3ea98bc209b37cbdba39
Reviewed-on: https://gerrit.instructure.com/202619
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
RedisStore is no longer supported
somewhat surprisingly, the serialization formats are compatible, so we don't
need to do any namespacing
Change-Id: Iede3a023cada95313875f0ce419b649c364ee97c
Reviewed-on: https://gerrit.instructure.com/202663
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
add flags for 6.0, even though it doesn't actually do anything yet
Change-Id: If8aba4d9f92e8a8ec890deadba7a94e21e01a804
Reviewed-on: https://gerrit.instructure.com/202686
Tested-by: Jenkins
Reviewed-by: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
Change-Id: I3d09440a090838edc8dd4557d98705926c2aaa09
Reviewed-on: https://gerrit.instructure.com/202620
Tested-by: Jenkins
Reviewed-by: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
Change-Id: I27e8cb40a488b433b8f7ca265af654290b17fab2
Reviewed-on: https://gerrit.instructure.com/202820
Tested-by: Jenkins
Reviewed-by: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
Change-Id: Ic17eb6ac5e0d6cfd595f34a47224d954e7a4cf82
Reviewed-on: https://gerrit.instructure.com/202616
Tested-by: Jenkins
Reviewed-by: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
closes CORE-2754
Change-Id: I38a255abf0f6ae06d3f9323d7da53239a8ebaf47
Reviewed-on: https://gerrit.instructure.com/202528
Reviewed-by: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
Tested-by: Jenkins
Change-Id: I31ba396e551b78d173a960b0e714a0da74539eb1
Reviewed-on: https://gerrit.instructure.com/202032
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
https://github.com/thoughtbot/shoulda-matchers/blob/master/NEWS.md
use new `required` key in the configuration for belongs_to associations
Change-Id: I52fe5ffd2a50698781b5d78218989762dd0e3fbe
Reviewed-on: https://gerrit.instructure.com/200501
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
Reviewed-by: Keith Garner <kgarner@instructure.com>
Product-Review: Keith Garner <kgarner@instructure.com>
QA-Review: Derek Bender <djbender@instructure.com>
We do not use any of the features that the fork was intended for.
Change-Id: I19c8e69ac77ecb8aef586bcda15fc26723de7253
Reviewed-on: https://gerrit.instructure.com/200050
Reviewed-by: Jeremy Putnam <jeremyp@instructure.com>
Tested-by: Jenkins
QA-Review: Tucker Mcknight <tmcknight@instructure.com>
Product-Review: Tucker Mcknight <tmcknight@instructure.com>
closes ADMIN-2574
Test plan:
- Add a key (from Carl or Mysti) to
the Unsplash plugins in /plugins
- Access the api at /api/v1/image_search?query=<query>
- Verify you can get data from Unsplash
- Verify that you have to be logged in to
get data
- Verify that link headers work and look right
Change-Id: I9940a7c9b409f36f897fab1852679c3a2388d31c
Reviewed-on: https://gerrit.instructure.com/191149
Tested-by: Jenkins
Reviewed-by: Carl Kibler <ckibler@instructure.com>
QA-Review: Carl Kibler <ckibler@instructure.com>
Product-Review: Mysti Lilla <mysti@instructure.com>
refs CORE-2793
useragent hasn't been updated in years, and browser gives us more features
for detecting mobile platforms easily
test plan:
* use a modern browser
* nothing should change
* use an old version of IE, Chrome, Safari, and/or Firefox (or spoof
the user agent string)
* should still get a warning about an unsupported browser
Change-Id: I57707a49d4e6cd9c4389103acb546a9eadbb36f3
Reviewed-on: https://gerrit.instructure.com/190809
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
fixes COMMS-2021
Change-Id: I66f208182d1bf4d45ebb804f371b050d8c43f347
Reviewed-on: https://gerrit.instructure.com/190489
Reviewed-by: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
Tested-by: Jenkins
this should speed things up by reducing the amount of traffic over the
Wire for our JS/CSS/images from our cdn for most browsers/users
(everyone besides IE 11 supports brotli). Should especially help people
on mobile connections and in remote areas.
For example, our vendor webpack bundle went from 850KB to ~500KB
closes: CORE-2755
Test plan:
* with the dev CDN set up in canvs_cdn.yml
* run: RAILS_ENV=production bundle exec rake canvas:compile_assets
* then run: bundle exec rake canvas:cdn:upload_to_s3
* then run:
RAILS_ENV=production bin/rake brand_configs:generate_and_upload_all
* then run RAILS_ENV=production bundle exec rails s
now go to canvas in your browser
* from any browser that supports brotli compression, the assets you get
From the CDN should come from /br/dist/whatever
(instead of /dist/whatever)
* everything should work the same but you should notice smaller file
Sizes in the network panel for your js and css assets
Now go to canvas in a browser that doesn’t support brotli, like IE 11
* you should see that it gets its css and js files from
<cdn host>.com/dist/whatever (and not from /br/dist/whatever)
* you should notice that the assets you are looking at are gzipped
Just like before, and you can compare against those in chrome and see
That the gzip version of those files is bigger than the brotli version
Change-Id: I81d28fa31c307d745ecd9b84f1fd55c07fba88ca
Reviewed-on: https://gerrit.instructure.com/188866
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
refs gh-1435
fixes CORE-2764
note that this defaults to sending the client authorization for
access token requests in an Authorization header, rather than
as part of the post body
test plan:
* smoke test login with oauth2 providers
Change-Id: I3907d554924c86f4aec34a4d79b7a90b2ed2ea18
Reviewed-on: https://gerrit.instructure.com/188971
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
Tested-by: Jenkins
James Butters