Commit Graph

19257 Commits

Author SHA1 Message Date
Sterling Cobb b27b4ceea9 add descriptive aria-label to rich content editors
fixes CNVS-15756

Test Plan
Given I'm working in NVDA
And I'm using firefox
When I go to any page with the Rich Content Editor
And I navigate to that editor
Then I should hear the screen reader read aria-label "Rich Content Editor"

Change-Id: Idb5f527e58ac5cf66c97419e452d87480733fd06
Reviewed-on: https://gerrit.instructure.com/71104
Product-Review: Aaron Cannon <acannon@instructure.com>
Tested-by: Jenkins
Reviewed-by: Bryan Petty <bpetty@instructure.com>
QA-Review: Michael Hargiss <mhargiss@instructure.com>
2016-02-01 19:30:23 +00:00
Spencer Olson 4558243af0 grading schemes page: fix a11y issues
fix multiple a11y issues on the
grading schemes page.

closes CNVS-26083
closes CNVS-26082
closes CNVS-26206
closes CNVS-26217

test plan:

A) Verify extraneous focus area
no longer exists when editing

  - Begin editing a grading scheme
  - Press Tab to move from the title
    field to the first row
  - Note that the "+" is focused (before
    this fix, a large, awkwardly placed
    grey box would be focused before the
    "+" button was focused)

B) Verify focus on grading schemes

  - Tab to the "Add grading scheme" button
  - Tab again and note that focus is on a
    grading scheme (before this fix, the
    focus would disappear and skip over the
    grading scheme)

C) Verify the icon to add a new line on
a grading scheme is always visible when editing

  - Begin editing a grading scheme
  - Verify a "+" icon appears next to each line
    of the grading scheme (before this fix, the
    "+" icon would only appear when hovering
    or focusing on a line)

D) Verify the 'Add a grading scheme button' is
   announced as a 'Button'

  - Navigate to the "Add a grading scheme" button
    using a screenreader. Verify the "Add a grading
    scheme" button is announced as a button (
    previously, this was announced as a link)

E) Verify the icons to edit and trash grading
   schemes are announced as 'Button's

  - Using a screenreader, navigate to the pencil
    icon within a grading scheme. Verify the
    pencil icon is announced as a button (
    previously, this was announced as a link)
  - Using a screenreader, navigate to the trash
    icon within a grading scheme. Verify the
    trash icon is announced as a button (
    previously, this was announced as a link)

F) Verify the icons to add and delete lines of
a grading scheme are announced as 'Button's

  - Begin editing a grading scheme
  - Navigate to the "+" icon using a screenreader.
    Verify the "+" is announced as a button (
    previously, this was announced as a link)
  - Navigate to the "x" icon using a screenreader.
    Verify the "x" is announced as a button (
    previously, this was announced as a link)

Change-Id: I49c46fe8d9d7eaf40551e23f70673b519ed89898
Reviewed-on: https://gerrit.instructure.com/70796
Tested-by: Jenkins
Reviewed-by: Derek Bender <djbender@instructure.com>
QA-Review: KC Naegle <knaegle@instructure.com>
Product-Review: Spencer Olson <solson@instructure.com>
2016-02-01 18:29:56 +00:00
Ethan Vizitei 5df84d1171 include root account on error_report messages
refs CNVS-26792

messages are easier to group back to their accounts if the
root_account_id is popluated when a ticketing system ticket
is created and a send via email is attempted.

TEST PLAN:
 1) enable ticketing connector for email
 2) file a ticket
 3) in the rails console, the generated message object
    has it's root_account_id populated

Change-Id: Iceae2d09c6a33ba522a4333f634d238a78c81e03
Reviewed-on: https://gerrit.instructure.com/71068
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
2016-02-01 18:16:55 +00:00
Simon Williams eb598ab5b3 only count active quizzes in course stats
fixes CNVS-26308

test plan:
- create 2 quizzes, with questions
- take them both
- delete 1 of them
- go to the course stats page
- only the non-deleted quiz should count
  (for quizzes, questions, and submissions)

Change-Id: Ib6155e1036fce43c81c2ad346b7252e818831114
Reviewed-on: https://gerrit.instructure.com/70822
Tested-by: Jenkins
Reviewed-by: Ryan Taylor <rtaylor@instructure.com>
QA-Review: Michael Hargiss <mhargiss@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
2016-02-01 17:53:28 +00:00
Cody Cutrer ec50e13f2d bump switchman
test plan:
 * test all the things!

Change-Id: I1ecd36be4165fbbce84132a26d0e47db6d1aa31d
Reviewed-on: https://gerrit.instructure.com/71073
Tested-by: Jenkins
Reviewed-by: James Williams  <jamesw@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
2016-02-01 17:12:38 +00:00
Cody Cutrer 4585fdedb2 enforce not-null on role overrides.enabled and locked
Change-Id: Iba5cffd103ccd15aedfd996403057967dd60be62
Reviewed-on: https://gerrit.instructure.com/25895
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
2016-02-01 17:11:50 +00:00
Brian Palmer 60ad3d4e57 have sentry use our configured rails logger
Change-Id: I31863e1a2f040b27a35c8b3d9c1ccb1539b67945
Reviewed-on: https://gerrit.instructure.com/71156
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Brian Palmer <brianp@instructure.com>
QA-Review: Brian Palmer <brianp@instructure.com>
2016-02-01 16:14:07 +00:00
Matthew Berns 5ef39ff1b4 fixes focus with move/copy question dialog
fixes CNVS-26267

test plan:
- open a question bank
- click move/copy question to another bank
- focus should be set to the dialog's close button

Change-Id: I25c6bed380e8423bfbac42f3c68f5b144161620b
Reviewed-on: https://gerrit.instructure.com/70800
Tested-by: Jenkins
Reviewed-by: Davis McClellan <dmcclellan@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Nathan Rogowski <nathan@instructure.com>
2016-02-01 14:39:51 +00:00
Matthew Berns 284a7bfd41 fix focus and tabbing issues in question bank
fixes CNVS-26265

test plan:
- go into a question bank that is only 1 page
- the header and text body of questions should
  not be in the taborder
- go into a question bank with 2 or more pages
- the headers should be displayed as links
  and be in the taborder
- clicking on a heading should expand question
  details (if any)
- clicking on a heading should retain focus
  on that heading
- headings will remain in taborder, but text body
  should still be non-tabbable

Change-Id: Id361777e08ed69338689f0d7fae52b6502da941c
Reviewed-on: https://gerrit.instructure.com/70811
Tested-by: Jenkins
Reviewed-by: Davis McClellan <dmcclellan@instructure.com>
QA-Review: Michael Hargiss <mhargiss@instructure.com>
Product-Review: Aaron Cannon <acannon@instructure.com>
2016-02-01 14:38:30 +00:00
Transifreq ae93a23ef5 update mi translation
Change-Id: I0690d3a6b7b5bd808841d6b2d7c5e734f1d8ca41
2016-02-01 05:17:38 -07:00
Transifreq 86a21c1a0f update hy translation
Change-Id: Ic46380258d82706ad928d3c56ddefed909a549a4
2016-02-01 05:14:52 -07:00
Cody Cutrer 3cb79cac2c mark several models as using strong_params
Change-Id: Ia925f291df671630dd6a30f3a4e566cfebe08d4b
Reviewed-on: https://gerrit.instructure.com/57842
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
2016-01-31 17:22:17 +00:00
Transifreq 88244da65f update zh translation
Change-Id: I1a2d277822f79e8e3618f260b315b2a1b4ac88dd
2016-01-31 05:25:27 -07:00
Transifreq 4c4074edaa update pt translation
Change-Id: I1b042c272ae550731b319d50bf3e994372ab5e2d
2016-01-31 05:20:46 -07:00
Davis McClellan 73c26ec59c Fix missed created_at and replace it with client_timestamp
fixes CNVS-26913

test plan
- Create a quiz and add a question of any type to the quiz.
- Open the quiz in safari as a student.
- Ensure that the quiz loads correctly

Change-Id: I31aecfd63f5753aaa0251377371a732b603a8481
Reviewed-on: https://gerrit.instructure.com/71164
Reviewed-by: Josh Simpson <jsimpson@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Tested-by: Jenkins
Product-Review: Davis McClellan <dmcclellan@instructure.com>
2016-01-30 18:18:23 +00:00
Clay Diffrient e909760c4b Revert "Make module sequence footer sticky"
closes CNVS-26906

This reverts commit b9c7017456.

Change-Id: I2a27ba3146c1728ae1e284957103c7e75443a354
Reviewed-on: https://gerrit.instructure.com/71161
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
2016-01-30 05:11:10 +00:00
Clay Diffrient 59ad01eb03 Revert "Make MSF work properly in test instance environments"
refs CNVS-26906

This reverts commit 0a4e16282d.

Change-Id: I776f2c4dde999cb68e783e6a133eb0f54fbd853c
Reviewed-on: https://gerrit.instructure.com/71160
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
2016-01-30 05:10:59 +00:00
Clay Diffrient 278710e2d1 Revert "Make MSF work for wiki pages in old UI"
refs CNVS-26906

This reverts commit 3ceda8fe88.

Change-Id: If4e48b25aa1fe9e797d53fc964cd3a9fe6f2d9b0
Reviewed-on: https://gerrit.instructure.com/71159
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
2016-01-30 05:10:50 +00:00
Clay Diffrient ced8f6a8c8 Revert "Add additional padding for MSF with external tools"
refs CNVS-26906

This reverts commit dd88726b90.

Change-Id: I01a94fb40d7b22d96c987ec362e493a2e83ebbb2
Reviewed-on: https://gerrit.instructure.com/71158
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
2016-01-30 05:10:37 +00:00
Simon Williams 30d7f4cb54 doc: fix link to dinghy install
fixes gh-754

test plan: dinghy link in docs should work

Change-Id: I655145f5440f076717c4131b5bf9d24e88b3ef3e
Reviewed-on: https://gerrit.instructure.com/71149
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
Product-Review: Simon Williams <simon@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>
2016-01-29 23:42:59 +00:00
Brian Palmer 5c217faa4a fix media_object_failure errors
Our video platform stopped transcoding to .flv a long time ago, so every
single new upload was failing this check for .flv and generating an
error report. What we really want is to ensure that the mp3/mp4
transcoding is available, depending on if it is audio or video.

This error didn't prevent the media from actually embedding and playing,
which is why it was never really noticed before. So this commit is
effectively just silencing noise.

test plan: enable media uploads and upload a video/audio file. it should
transcode and play as expected, and no media_object_failure error should
be recorded.

Change-Id: I960980ecff8a8235b0598b60fd257b22e9cd5f1f
Reviewed-on: https://gerrit.instructure.com/71142
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
QA-Review: August Thornton <august@instructure.com>
Product-Review: Brian Palmer <brianp@instructure.com>
2016-01-29 22:49:21 +00:00
Cody Cutrer c31d13fead bump rails 4.2 to latest security update
Change-Id: I1c95b1ee5f5835eecda45cd5df7784c04b8d316c
Reviewed-on: https://gerrit.instructure.com/71150
Tested-by: Jenkins
Reviewed-by: James Williams  <jamesw@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
2016-01-29 19:22:43 +00:00
Clay Diffrient 29c610f437 Update masquerade and student view alert box
This makes the alert box into a banner showing at the bottom of
the screen.  It is now magenta in color ($ic-color-action).  This
commit also makes a border show around the body of the page showing
the same color.

This will keep the dialog out of the way of the rest of the content
on the page.

closes CNVS-26723

Test Plan:
  - Masquerade as a user
  - The banner should show at the bottom in a magenta color.
  - The screen should have a magenta border around it.
  - As a teacher, Go to the student view of a course
  - Similar behavior should be shown
  - Go to a module item that has a module sequence footer.
  - The module sequence footer should not be obstructed by the
    banner.

Change-Id: I54fb6e482c75fdbc80de974f887ec6ed285131c9
Reviewed-on: https://gerrit.instructure.com/71058
Reviewed-by: Colleen Palmer <colleen@instructure.com>
Product-Review: Colleen Palmer <colleen@instructure.com>
Tested-by: Jenkins
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
2016-01-29 19:03:53 +00:00
James Williams 1a9fb4ceea rails 4.2: remove not-null constraint on brand config variables
since it defaults to an empty hash, it doesn't bother
serializing one when it isn't needed

refs #CNVS-26056

Change-Id: I2515257c8c58aabd26c50c18330361e49cd8b0b1
Reviewed-on: https://gerrit.instructure.com/71133
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: James Williams  <jamesw@instructure.com>
QA-Review: James Williams  <jamesw@instructure.com>
2016-01-29 17:51:24 +00:00
Simon Williams 36c18dfccf spec: fix spec to pass individually
this spec passes when the whole file runs together, and it appears that
the any_instance stub just doesn't work in that scenario.  when run
individually it fails legitimately.  this fixes the failure, but the
issue with any_instance needs further investigation.

test plan: specs should pass

Change-Id: I3a279066ccaabce6719f3b99fcd6ee58822b0cd9
Reviewed-on: https://gerrit.instructure.com/71130
Tested-by: Jenkins
Reviewed-by: Ryan Taylor <rtaylor@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>
2016-01-29 17:04:37 +00:00
James Williams f4a2645ee3 rails 4.2: fix db:migrate with plugins
wasn't using the correct migrations_paths

refs #CNVS-26056

Change-Id: I5e291399031e1eeaf132f2845c77fa99d750de39
Reviewed-on: https://gerrit.instructure.com/71109
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
Product-Review: James Williams  <jamesw@instructure.com>
QA-Review: James Williams  <jamesw@instructure.com>
2016-01-29 14:33:33 +00:00
Transifreq 097cde1367 update sv translation
Change-Id: I3ab1652d714ab79b9668d71c41b496d2ec3021cf
2016-01-29 05:23:34 -07:00
Ethan Vizitei 3128cb5f8a spec: stabilize discussions_index_page_student_spec
refs CNVS-25916

applies the same fix to the any_user spec as the student spec
for the same functionality. See /c/71032/

also reset mouse events because depending on what
order the specs run in, not triggering
the "mouse leave" event can have leftover effects
on the icon state from before.

TEST PLAN:
 1) discussions_index_page_student_spec fail rate should fall

Change-Id: I550fd3b41646801577a76bfae9036e6457524ebb
Reviewed-on: https://gerrit.instructure.com/71101
Reviewed-by: Derek Bender <djbender@instructure.com>
Tested-by: Jenkins
Product-Review: Ethan Vizitei <evizitei@instructure.com>
QA-Review: Ethan Vizitei <evizitei@instructure.com>
2016-01-29 02:14:14 +00:00
Ethan Vizitei 26ffca7ffd spec: stabilize course_settings_spec
refs CNVS-25916

sometimes this lookup catches the element that's still on the page
from before the page refreshes, meaning it has no text in it.  This
confirms the message has rendered out before checking it's contents

TEST PLAN:
 1) course_settings_spec should increase it's pass rate

Change-Id: I1b213b3ec7ce86adea3faa87ed98972dc56807e4
Reviewed-on: https://gerrit.instructure.com/71127
Reviewed-by: Derek Bender <djbender@instructure.com>
Tested-by: Jenkins
Product-Review: Ethan Vizitei <evizitei@instructure.com>
QA-Review: Ethan Vizitei <evizitei@instructure.com>
2016-01-29 01:05:59 +00:00
Ethan Vizitei 17d79595ff glob webpack unit tests
maintaining a list of specs manually is crummy.  This loads them
dynamically.

also solves some run-order fragileness between screenreader
gradebook and shared ember component tests.

TEST PLAN:
 1) webpack aux build should pass

Change-Id: I120b0bafc3b48523e758f576babea7f4af244673
Reviewed-on: https://gerrit.instructure.com/71082
Reviewed-by: Simon Williams <simon@instructure.com>
Tested-by: Jenkins
Product-Review: Ethan Vizitei <evizitei@instructure.com>
QA-Review: Ethan Vizitei <evizitei@instructure.com>
2016-01-29 00:08:50 +00:00
Ethan Vizitei fb2ce96335 spec: stabilize quizzes_edit_quiz_teacher_spec
refs CNVS-25916

re-find an element to keep it from being stale if
selenium doesn't recognize it (intermittant failures caused
by looking an element up, doing things that change the page,
and depending on it still being there)

Change-Id: Ifad192efface691bdcfc9fd48694dd66a6290ab7
Reviewed-on: https://gerrit.instructure.com/71122
Reviewed-by: Derek Bender <djbender@instructure.com>
Tested-by: Jenkins
Product-Review: Ethan Vizitei <evizitei@instructure.com>
QA-Review: Ethan Vizitei <evizitei@instructure.com>
2016-01-29 00:08:37 +00:00
Zach Wily 43ec4a9647 send stats to statsd on ldap success/failures
closes CNVS-26812

Per account/auth config, we'll increment counters based on ldap
successes, failures, timeouts, and errors.

Test Plan:
 * Configure statsd
 * Configure LDAP auth on an account
 * Attempt a successful ldap login and an unsuccessful login.
 * Verify that metrics show up in statsd at
   stats.counters.auth.account_<accountid>.config_<configid>.ldap_*
 * Change your config to point at a non-ldap host, and make sure the
   timeout or exception metrics show up.

Change-Id: I821f79133430f69f6ff73b3a7e98fded36807dc4
Reviewed-on: https://gerrit.instructure.com/49205
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
QA-Review: August Thornton <august@instructure.com>
Product-Review: Zach Wily <zach@instructure.com>
2016-01-28 23:23:07 +00:00
Rob Orton aff9ffabc5 fix malformed terms api query
fixes CNVS-26771

test plan
 - pass /api/v1/accounts/self/terms?workflow_state[all]
   instead of /api/v1/accounts/9/terms?workflow_state[]=all
 - it should work and show active terms

Change-Id: Ie21f069049dd3ace869c166046d2253711a9fec4
Reviewed-on: https://gerrit.instructure.com/71057
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
2016-01-28 22:27:52 +00:00
Sterling Cobb e72ecc6417 fix css issues with the post grades to sis cbox
fixes CNVS-26093

Ensures the label doesn't jump to the bottom of the checkbox. It's now
using the styleguide style checkbox/labels

Test Plan

Given you've enabled the "SIS Post Grades" feature flag
And you're on account/settings page
And you're on the settings tab
When you scroll down
Then you should see the "Post Grades to SIS" checkbox
And there should be a label next to it
And when you make the window smaller
Then the label should be to the right of the checkbox
And it should NOT be under the checkbox

Change-Id: I2738e21e823085fa83506a944e6a1179b5f4a550
Reviewed-on: https://gerrit.instructure.com/69345
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Sterling Cobb <sterling@instructure.com>
2016-01-28 21:31:21 +00:00
Michael Brewer-Davis b553eae6a3 remove keyboard drag/drop in outcomes page
fixes CNVS-26060

Test plan:
1.  Go to account or course outcomes page with multiple
    levels of outcomes defined
Using keyboard navigation:
2.  Navigate to an outcome
3.  Verfify that space selects the outcome (and does not
    start a drag/copy)
4.  Move to an outcome group in directory view
5.  Verify that space bar selects the outcome group
    (and does not complete a drag/copy)

Change-Id: I468d2469807fcc7b44764287a86a27e620dd1377
Reviewed-on: https://gerrit.instructure.com/70751
Tested-by: Jenkins
Reviewed-by: Matt Berns <mberns@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Nathan Rogowski <nathan@instructure.com>
2016-01-28 21:22:52 +00:00
Michael Brewer-Davis 7a5a59422c remove keyboard focus from non-interactive cells
fixes CNVS-26072, CNVS-26075
refs CNVS-13110, CNVS-13130

Test plan:
1.  Visit account rubrics page
2.  Select an existing rubric
3.  Tab through page to verify that non-interactive cells
    are not focused
4.  Click "Edit Rubric"
5.  Tab through page to verify that non-interactive cells
    are not focused

Using screenreader (esp. NVDA),
6.  Verify that individual ratings are read by screenreaders
    in show and edit pages.

Change-Id: Ie10338b8e51c21391c53997632a0d30886070f74
Reviewed-on: https://gerrit.instructure.com/70770
Tested-by: Jenkins
Reviewed-by: Matt Berns <mberns@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Nathan Rogowski <nathan@instructure.com>
2016-01-28 21:06:30 +00:00
Michael Brewer-Davis 860d6de980 fix outcomes keyboard focus issues
fixes CNVS-26566

- ensures directory view allows keyboard focus after "Go Back"
- ensures directory view retains focus after left arrow

Test plan:
1.  Go to account outcomes page, ensure nested outcomes
    and groups are defined
Using keyboard navigation:
2.  Traverse the directory view using arrow keys, verify
    that focus remains in the directory view
3.  With a nested outcome group selected, navigate to
    "Go Back" button and select.
4.  Verify that the directory view can still be reached by
    keyboard navigation
5.  Repeat steps 3-4 with an outcome selected.

Change-Id: Ie491167533d483b836c1d4abc33be7b225b69763
Reviewed-on: https://gerrit.instructure.com/70703
Tested-by: Jenkins
Reviewed-by: John Corrigan <jcorrigan@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Nathan Rogowski <nathan@instructure.com>
2016-01-28 21:06:23 +00:00
Michael Brewer-Davis be95674814 fix focus after add rubric
fixes CNVS-26071
refs CNVS-21404
see also SHA c16e0d6590

Test plan:
1.  From an assignment, use keyboard to select "Add Rubric"
2.  Verify that focus is on the "Find a rubric" button
    per CNVS-21404
3.  From the account rubrics page, use keyboard to select "Add rubric"
4.  Verify that focus is on the "Rubric Title" text field.

Change-Id: I78b8d24d70db41d4685e95e5340edd3bb47392e9
Reviewed-on: https://gerrit.instructure.com/70527
Tested-by: Jenkins
QA-Review: Michael Hargiss <mhargiss@instructure.com>
Reviewed-by: John Corrigan <jcorrigan@instructure.com>
Product-Review: Nathan Rogowski <nathan@instructure.com>
2016-01-28 21:06:10 +00:00
Michael Brewer-Davis 36280a05fc correct focus on rubric editor events
prevent focus going to document on
 - recalculating criteria point values
 - deleting a rating category

fixes CNVS-26079, CNVS-26078

Test plan:
1.  Create a new or edit an existing rubric
2.  Add several ratings
3.  Using the keyboard, navigate to the pts field
4.  Change the value of the pts field and press Enter
5.  Verify that the focus stays on the pts field and is
    not taken to the top level document
6.  Using the keyboard, navigate to the delete button
    of a rating
7.  Press enter on the delete button
8.  Verify that the focus is taken to the next available
    rating edit button, and not to the top level document

Change-Id: I8c21a3d06a1aaa6e4e415806ce5dc6d65239f565
Reviewed-on: https://gerrit.instructure.com/70476
Tested-by: Jenkins
Reviewed-by: Matt Berns <mberns@instructure.com>
QA-Review: Michael Hargiss <mhargiss@instructure.com>
Product-Review: Nathan Rogowski <nathan@instructure.com>
2016-01-28 21:06:02 +00:00
Michael Brewer-Davis 6a9b8d1ada fix tab order of outcomes buttons
Fixes: CNVS-25983

Also changes <a> style buttons to <button> tags

Test plan:
1.  Go to outcomes detail page
2.  Tab through page options
3.  Verify that action buttons tab left to right
4.  View outcomes detail page for an outcome that has
    been applied to student work
5.  Verify that modify/delete buttons are disabled
    and are not included in tab order

Change-Id: I81777a068ef58d3e0cab819555e491d714cb0648
Reviewed-on: https://gerrit.instructure.com/70412
Tested-by: Jenkins
Reviewed-by: Matt Berns <mberns@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Nathan Rogowski <nathan@instructure.com>
2016-01-28 21:05:44 +00:00
Clay Diffrient dd88726b90 Add additional padding for MSF with external tools
This will allow the external tools to fully show given the
module sequence footer is floating at the bottom now.

closes CNVS-26677

Test Plan:
  - Load up a course with TurnitIn enabled
  - Add an external tool to a module
  - As a student take a look at the module
  - The footer should not cover the "accept/reject" buttons
    for TurnitIn.
    * Note: This must be done at a lower resolution as it doesn't
            affect larger screens since they have plenty of screen
            real estate.

Change-Id: I3ae25cf3cc1e31dfd69cab3246afeaf8eb41aff8
Reviewed-on: https://gerrit.instructure.com/71042
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Tested-by: Jenkins
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
2016-01-28 20:57:24 +00:00
Rob Orton 0282e60cb6 only allow view courses with that permission
fixes CNVS-26856

test plan
 - hit api/v1/accounts/self/courses with an admin
   that does not have "View the list of courses”
 - it should 401
 - give permission and it should work

Change-Id: Ib70361fc4c9f894fa5562d9e447e632858f31b6a
Reviewed-on: https://gerrit.instructure.com/71069
QA-Review: August Thornton <august@instructure.com>
Reviewed-by: Ethan Vizitei <evizitei@instructure.com>
Tested-by: Jenkins
Product-Review: Rob Orton <rob@instructure.com>
2016-01-28 20:48:13 +00:00
Ethan Vizitei 53c67242b9 spec: stabilize profile_spec
refs CNVS-25916

this spec is checking the DB to check it's efficacy, which is something
hard to time right, and not correct for an acceptance test anyway.

To stabilize it, we check it's efficacy by examining what the user
can see instead (same way QA would check it), and we use the normal
selenium tools for awaiting page loads.

TEST PLAN:
 1) profile_spec failure rate should drop

Change-Id: Iec1e0b95353a13d4f12b5cc005f2722d2d9f73c4
Reviewed-on: https://gerrit.instructure.com/71086
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
2016-01-28 20:12:08 +00:00
Spencer Olson d1df06cf72 sort assignments on course grades page
allow sorting by assignment group, due date, module,
and title on the course grades page. also, store
the user's sort preferences and remember that
preference on subsequent page loads.

closes CNVS-21660

test plan:
  - as a student, go to the /courses/:course_id/grades
    page.
  - verify there is a dropdown to sort assignments by
    due date and title. the first time you visit this
    page, the dropdown option should default to
    ordering by due date. verify each option correctly
    sorts the assignments.
  - if the course has any Modules, there should be an
    option to sort by Module. if the course does not
    have any Modules, there should not be a Module sort
    option.
  - if the course has assignments that belong to different
    Assignment Groups, there should be an option to sort
    by Assignment Group. if the course does not have any
    assignments, or if all of the course's assignments
    belong to the same Assignment Group, there should not
    be an Assignment Group sort option.
  - select any option besides 'Due Date'. next, leave the
    page and return back to the page. verify the selected
    dropdown option matches the option you selected before
    leaving the page.
  - repeat the steps above while logged in as a teacher, TA,
    student view student, and admin. when logged in as a teacher,
    TA, or admin, the url will be /courses/:course_id/grades/
    :student_id
  - verify the dropdown is accessible
  - note: if a student is enrolled in multiple courses, the
    dropdown for the sort order should be on the right-hand
    side of the /courses/:course_id/grades page (and the
    dropdown for the course selection should be on the
    left-hand side). if a student is only enrolled in
    one course, the dropdown for sort order should be on
    the left-hand side of the page.

Change-Id: Idbcbea2d25051cb5d933bfb395daebeedc630855
Reviewed-on: https://gerrit.instructure.com/69419
Reviewed-by: Derek Bender <djbender@instructure.com>
Tested-by: Jenkins
QA-Review: KC Naegle <knaegle@instructure.com>
Product-Review: Spencer Olson <solson@instructure.com>
2016-01-28 19:33:57 +00:00
Michael Brewer-Davis e8ed984332 fix encoding of "no outcomes" url
- also encode URI components when generating context URI

Fixes CNVS-26130

Test plan:
1.  Create a course with no outcomes defined
2.  Create and save an assignment
3.  Click on "Add Rubric"
4.  Click on "Find Outcome"
5.  Click on "Click here to go to the outcomes page"
6.  Verify that you are taken to outcomes page instead of error

7.  Go to Outcomes/Manage rubrics in course with no outcomes defined
8.  Repeat steps 3-6

9.  Go to Accounts/Rubrics in account with no outcomes defined
10.  Repeat steps 3-6

Change-Id: I2ada04858d124ecbdb1e205baef34e0180063f6a
Reviewed-on: https://gerrit.instructure.com/70258
Reviewed-by: John Corrigan <jcorrigan@instructure.com>
Tested-by: Jenkins
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: McCall Smith <mcsmith@instructure.com>
2016-01-28 18:51:10 +00:00
Shawn Meredith c11d4d15b1 spec: coverage tool tweaking for test-queue
Change-Id: I694839ec7467d64fb306a3de70b49676d32a8e9b
Reviewed-on: https://gerrit.instructure.com/69606
Tested-by: Jenkins
Reviewed-by: Jon Jensen <jon@instructure.com>
Product-Review: Jon Jensen <jon@instructure.com>
QA-Review: Jon Jensen <jon@instructure.com>
2016-01-28 18:16:16 +00:00
Strand McCutchen 46aa7c724e make gradebook header assignment urls properly formatted
This commit removes technical debt introduced in
CNVS-25850.

fixes CNVS-25853

Test plan:
 0. With the "Gradebook Performance" flag turned off on:
    `/accounts/1/settings`
 1. Go to Gradebook in a Course with Assignments.
 2. Click on the name of the assignment.
 3. Verify that the assignment show page loads.
 4. Review links and text throughout gradebook to verify
    that nothing else is mangled.
 5. Create an assignment with the following text as its
    title:
       <script>alert('oh 💩')</script>
 6. Reload the gradbook and verify that no popup is visible

Change-Id: I0cf4d191fa69f1ab2f8ceab763b2078d1be255fe
Reviewed-on: https://gerrit.instructure.com/68834
Tested-by: Jenkins
Reviewed-by: Keith T. Garner <kgarner@instructure.com>
QA-Review: KC Naegle <knaegle@instructure.com>
Product-Review: Strand McCutchen <smccutchen@instructure.com>
2016-01-28 17:38:38 +00:00
Strand McCutchen 696f099e7c sort assignments in gradebook by teacher settings when MGP is on
fixes CNVS-25686

Test plan:
 0. With multiple grading periods enabled in a course with
    many periods, a teacher, and a student…
 1. As the teacher, create many assignments in several
    different grading periods, ensuring the assignments are
    not created in calendar order.
 2. As the teacher select "Arrange columns by due date" in
    gradebook settings.
 3. Refresh the page and verify that the assignments are
    sorted by due date.
 4. As the teacher select "Arrange columns by assignment
    group" in gradebook settings.
 5. Refresh the page and verify that the assignments are
    not sorted by due date.

Change-Id: Iaa590e29d9bf512c0b2ac12dad2b7c64a2b579ab
Reviewed-on: https://gerrit.instructure.com/69253
Reviewed-by: Derek Bender <djbender@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
Tested-by: Jenkins
Product-Review: Strand McCutchen <smccutchen@instructure.com>
2016-01-28 17:38:27 +00:00
Jahnavi Yetukuri 594eb9a396 spec: module and usage rights spec
Change-Id: I0f8abfe51594298d68c682d150223773a2794678
Reviewed-on: https://gerrit.instructure.com/70999
Tested-by: Jenkins
Reviewed-by: Michael Hargiss <mhargiss@instructure.com>
Product-Review: Michael Hargiss <mhargiss@instructure.com>
QA-Review: Michael Hargiss <mhargiss@instructure.com>
2016-01-28 17:37:33 +00:00
John Corrigan ee15911543 disable multiple_dropdowns_question selects when not editable
fixes CNVS-14719

test plan:
- Create a quiz with a multiple-dropdowns-question.
- Navigate to take the quiz.
- Observe that the dropdowns work as expected.
- Complete the quiz with a student.
- Observe the completed quiz screen.
- Observe that there are no dropdowns in the question text.
- Observe that the selected answers are just treated as plaintext
  when interacted with via VoiceOver, NVDA & JAWS.

Change-Id: I9506f064417eae85c084a15c416974d4f00568ee
Reviewed-on: https://gerrit.instructure.com/70156
Tested-by: Jenkins
Reviewed-by: Matt Berns <mberns@instructure.com>
QA-Review: Michael Hargiss <mhargiss@instructure.com>
Product-Review: Nathan Rogowski <nathan@instructure.com>
2016-01-28 16:50:25 +00:00