don't do a `clear`, because that triggers a change event. instead, select
any existing text, hit backspace, and then type the new text.
fixes:
* ajax <-> selenium race condition in speed grader specs (cuz two updates
would happen)
* an invalid scheduler spec that would usually incorrectly pass because of
the clear behavior
* (hopefully) other flaky specs
Change-Id: I08f52e9ea9712068986462a0ab59a75c785714df
Reviewed-on: https://gerrit.instructure.com/71777
Reviewed-by: Ethan Vizitei <evizitei@instructure.com>
Tested-by: Jenkins
Product-Review: Jon Jensen <jon@instructure.com>
QA-Review: Jon Jensen <jon@instructure.com>
test plan:
- go to Terms tab in account settings
- using the keyboard,
1. edit a term. focus should return to the edit (pencil) icon
afterward.
2. cancel editing a term. focus should return to the edit
icon afterward.
3. add a new term. focus should end up on the new term's edit
icon.
4. cancel adding a new term. focus should remain on the
"Add New Term" button.
5. delete a term. focus should go to:
a) the previous term, if there is one;
b) the next term, if the first term was deleted;
fixes CNVS-26284
Change-Id: I081d66f873a2d7f823363e32739c11ceeb792afd
Reviewed-on: https://gerrit.instructure.com/71821
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
and make it more straightforward and not dependent on the total
number of accounts in the tree
Change-Id: If08ccddea067456d17faeb81d71ede12b7630a51
Reviewed-on: https://gerrit.instructure.com/71848
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Fixes: CNVS-26680
test plan:
- as an admin using new ui
- navigate to a course and click "pages"
- select the cog to allow you to select the trash icon to delete
the page
- the modal text should no longer be cut off
examples:
old bad exp: http://screencast.com/t/M9pIDCFxkPna
new good exp: http://screencast.com/t/gNauRojonc
- ensure experience is good/consistent using old ui
Change-Id: I30645ab4ce28d36f65b781991b9a72ec15cf60b0
Reviewed-on: https://gerrit.instructure.com/71389
Tested-by: Jenkins
Reviewed-by: Colleen Palmer <colleen@instructure.com>
Product-Review: Colleen Palmer <colleen@instructure.com>
QA-Review: Myller de Araujo <myller@instructure.com>
fixes: CNVS-26786
Regression from our line-height commit where we needed to change any
margins or padding using $ic-line-height to use $ic-sp instead.
Test Plan:
- Go to an area in Canvas that uses tiny mce
- Create an h2 header - using inspector note the
margin using px sizing, not relative sizing. Output should be
margin-top: 6px; margin-bottom: 6px;
- Go to a Course > Settings > Apps and inspect the "External Apps" title.
The padding-bottom should be 6px
Change-Id: I6192deb6e214f7536e294362f1a1af51661ed4b8
Reviewed-on: https://gerrit.instructure.com/71545
Tested-by: Jenkins
Reviewed-by: Pam Hiett <phiett@instructure.com>
Product-Review: Pam Hiett <phiett@instructure.com>
QA-Review: Myller de Araujo <myller@instructure.com>
Will fix the date time issue that is experienced with
the lock_at field
fixes CNVS-26307
Test Plan:
- Masquerade as a teacher in a timezone other them MST
- Create or edit an ungraded discussion
- Enter a date and time in the "Until Date" field
- Save and click edit; notice the time has been changed
- Save once more and click edit
notice the time once again has been changed
Change-Id: I2de33c565075dc691e39791b24a0dda9bcaa9de0
Reviewed-on: https://gerrit.instructure.com/71264
Reviewed-by: Alex Boyd <aboyd@instructure.com>
Tested-by: Jenkins
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Product-Review: Steven Burnett <sburnett@instructure.com>
fixes CNVS-26201
Test-Plan:
- Run a message through canvas with twitter configured
- Notice you recieve a direct message through twitter
Change-Id: I7cd31bb2caf285a2bfadad44c248e6617da2f92e
Reviewed-on: https://gerrit.instructure.com/70893
QA-Review: Gentry Beckmann <gbeckmann@instructure.com>
Tested-by: Jenkins
Reviewed-by: Alex Boyd <aboyd@instructure.com>
Product-Review: Steven Burnett <sburnett@instructure.com>
fixes: CNVS-26411
When taking a quiz on a lower-resolution screen, the quiz questions
would get cut off. Now it either wraps so the whole question is visible,
or if the screen is really really small, scrolls horizonally
Test Plan:
- Create a quiz with some long quiz questions
- Make your browser window small <=1024px wide
- Quiz questions should now be readable whether they're wrapped or allow
you to scroll horizontally
- Go to Edit a quiz, notice the quiz question adhering to the container
width (no more overlap with righthand sidebar)
- Legacy UI should remain as it was before, this only should affect
New UI
Change-Id: Icf0053e0a79cf2db37183f889f844f1ffd60f9b0
Reviewed-on: https://gerrit.instructure.com/71293
Reviewed-by: Pam Hiett <phiett@instructure.com>
Product-Review: Pam Hiett <phiett@instructure.com>
Tested-by: Jenkins
QA-Review: KC Naegle <knaegle@instructure.com>
This image is an appliance more in line with the postgres or redis
images, so it manages its own data volume. Thus the docker-compose and
doc file changes.
Change-Id: I8f435400bd8427313d0bc290c84cd44639ead074
Reviewed-on: https://gerrit.instructure.com/71502
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Brian Palmer <brianp@instructure.com>
QA-Review: Brian Palmer <brianp@instructure.com>
test plan:
- go to Account Settings | Sub-Accounts
- use the keyboard to do the following:
1. expand and contract sub-accounts. ensure keyboard focus
remains on the expand/contract button.
2. create a new sub-account. ensure keyboard focus ends up
on the name of the new account.
3. edit an account name. ensure keyboard focus remains on the
edited account's name.
4. delete an account. ensure keyboard focus goes to the
previous account on the page.
fixes CNVS-26272
fixes CNVS-26273
fixes CNVS-26274
fixes CNVS-26275
Change-Id: Ic280c582c17992b6afc31180dc6be1ba6d7fb860
Reviewed-on: https://gerrit.instructure.com/71776
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
The sunburst theme wasn't high contrast enough.
test plan: `rake doc:api` and the generated api docs should be using the
default prettify.js theme, which is darker text on a white background.
Change-Id: I44f3e105ea11a99308163318db675f9be5c41f24
Reviewed-on: https://gerrit.instructure.com/71813
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins
Product-Review: Brian Palmer <brianp@instructure.com>
QA-Review: Brian Palmer <brianp@instructure.com>
there are already specs that cover the logic of the methods I changed
test plan:
* change a course and account's time zone
* it should work
Change-Id: I0780ee1b705e1cf341b7d0fc34aa23b4c9344be6
Reviewed-on: https://gerrit.instructure.com/71418
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
test plan:
* create a student with their files over quota
(the easiest way to do this would probably be to edit
the "User" quota setting for the account to a low number
temporarily)
* create a course for the student, and enable
"Let students attach files to discussion"
(in More Options)
* create and publish a discussion topic
* as the student try to attach a file to a reply
to the topic
* it should show an error (instead of pretending to
succeed and disappearing the entry)
closes #CNVS-27062
Change-Id: I33491bc390e429ec5e9bd8b9b7203ba8b874719a
Reviewed-on: https://gerrit.instructure.com/71630
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
fixes CNVS-26485
fixes CNVS-26486
fixes CNVS-26488
test plan:
- navigate the help dialog with a keyboard
- it should manage focus well moving in and out of the "report
a problem" subview
Change-Id: I6f2da565afd8cc887be41336f62a650667172f72
Reviewed-on: https://gerrit.instructure.com/71336
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Tested-by: Jenkins
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
Test Plan:
* Enable scheduler in settings tab
* Create a class with two students
* Create a Group and add the two students
* Create an appointment group, make sure to check "Have students sign
up in groups", and set the group category created above
* Masquerade as one of the students, and sign up for the appointment
group
* Login as teacher again, and navigate to
"/users/<teacher_id>/messages"
* Confirm that a "User signed up for..." message is staged
closes CNVS-26800
Change-Id: Ie7276d30537f51946c63c9fc31ca873feb0b5abf
Reviewed-on: https://gerrit.instructure.com/71495
Reviewed-by: Matthew Wheeler <mwheeler@instructure.com>
Tested-by: Jenkins
QA-Review: Heath Hales <hhales@instructure.com>
Product-Review: Jonathan Featherstone <jfeatherstone@instructure.com>
fixes PLAT-1330
test plan:
you should be able to build and run the docker image
Change-Id: I4620cba9f6b4378d0677e1e500c367422187a27d
Reviewed-on: https://gerrit.instructure.com/71678
Reviewed-by: Benjamin Porter <bporter@instructure.com>
Product-Review: August Thornton <august@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Tested-by: Jenkins
fixes CNVS-26297
Also add a simple test to hit QuestionBanksController#show because there
wasn't one before :(
test plan:
- Ensure you have outcomes defined.
- Create a question bank.
- Choose "Align Outcome" from the question bank detail page.
- Choose one of your defined outcomes to see details.
- Click on the outcome title.
- Observe that the link now works.
Change-Id: I0a6ad2b95705104c6c8d5eafce2daafae7965b70
Reviewed-on: https://gerrit.instructure.com/71432
Tested-by: Jenkins
Reviewed-by: Ryan Taylor <rtaylor@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: McCall Smith <mcsmith@instructure.com>
test plan:
* create a custom student role
* disable the "View discussions" permission for the role
* add a student to a course with the role
* add a discussion topic to the course
* the student should not be able to view it
* conclude the course
* the student should still not be able to view the topic
closes #CNVS-26972
Change-Id: I4556da5e9a7f07636ecf8ab70c634aac96d37557
Reviewed-on: https://gerrit.instructure.com/71633
Reviewed-by: Alex Boyd <aboyd@instructure.com>
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
test plan:
* create a future course (but one that isn't restricted)
* create a module with a view requirement for an item
* add a student to the course, they should be able to look around
but not participate
* confirm that viewing the module item does not fulfill the
module item requirement
closes #CNVS-26326
Change-Id: Ibe58be1280d377a587e41b45e39ca38168f6093b
Reviewed-on: https://gerrit.instructure.com/71302
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Matt Goodwin <mattg@instructure.com>
In order to facilitate better and more efficient debugging, this commit
improves the quality of the error messages reported by SIS imports. When
a user does not exist in users.csv, and enrollments in enrollments.csv
reference that user, the message "User XXX didn't exist for enrollment"
is not particularly useful. This commit adds course and section IDs to
the message to make it easier to search for broken rows.
Test plan:
* Create or change an existing enrollments.csv file so that it
references a user that doesn't exist.
* Run the CSV through the SIS importer.
* Check the error messages for the last import; the new error message
should show up instead of the old one.
Change-Id: Ie3ea4d95c6877ef8c5b27cee9d530a6fdf0e6e6e
Fixes: SIS-1733
Reviewed-on: https://gerrit.instructure.com/71116
Tested-by: Jenkins
Reviewed-by: Ken Romney <kromney@instructure.com>
Reviewed-by: Tyler Pickett <tpickett@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Product-Review: Ken Romney <kromney@instructure.com>
fixes CNVS-21510
test plan:
- with screenreader on
- go to quizzes index
- filter by title in the
search box
- the screenreader announces
the new item count
- go to assignment index
- do the same
Change-Id: I172e84cbf9fd3f0de49f6faf76d7336eb622d2c8
Reviewed-on: https://gerrit.instructure.com/69858
Tested-by: Jenkins
Reviewed-by: Matt Berns <mberns@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Aaron Cannon <acannon@instructure.com>
also do some minor refactoring around this coffeescript to make it safer
and easier to test.
fixes CNVS-26490
test plan:
- basic regression test around user profile editing
(you need to enable profiles in account settings)
- specifically, when you delete links while editing the profile, focus
should go to the previous delete link button or the bio textarea (if
you delete the top one)
Change-Id: I15b5e552485c447d51cdccedf9990456de10b13d
Reviewed-on: https://gerrit.instructure.com/71298
Tested-by: Jenkins
Reviewed-by: Ryan Shaw <ryan@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
Closes CNVS-12310
Test Plan:
- Take a quiz as a student
- Can't take a quiz as a teacher
- Note nothing a teacher can do will prevent "unpublishing" of a quiz.
Change-Id: I1606bed3f59a902609c2832ab83a40b6ca9bb54c
Reviewed-on: https://gerrit.instructure.com/69582
Tested-by: Jenkins
Reviewed-by: Davis McClellan <dmcclellan@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Jason Sparks <jsparks@instructure.com>
fixes CNVS-26300
test plan:
- Create a course with two sections and add the same user to both
- Create a quiz in the course
- As the student verify they can view the Take Quiz button
- Go to the course Settings page and set a start and end date in
the past, checking the box to say users can only participate
between those dates and save settings
- Edit one of the sections to add a current start and end date
(so it ends in the future), checking the box to allow users to
participate between those dates
- Ensure that Take Quiz button is visible
Change-Id: I1dfc8a1b8ece4bf97bbf35a1c0ada180df36229b
Reviewed-on: https://gerrit.instructure.com/70595
Tested-by: Jenkins
Reviewed-by: Ryan Taylor <rtaylor@instructure.com>
QA-Review: Michael Hargiss <mhargiss@instructure.com>
Product-Review: Jason Sparks <jsparks@instructure.com>
fixes CNVS-26887
test plan:
- make an anonymous survey and have some
students take it
- as a teacher go to the survey show page
and hit Show Student Survey Results in
the gear
- note that you cant see the student names
- click on Student X
- you go to the quiz submission page and
can see the survery results
- important part: you cannot map this survey
back to the student as the teacher
Change-Id: Ia8573832ea037bc803fdd0e6f0dcc93e29fa4d30
Reviewed-on: https://gerrit.instructure.com/71404
Reviewed-by: Ryan Taylor <rtaylor@instructure.com>
Tested-by: Jenkins
QA-Review: Michael Hargiss <mhargiss@instructure.com>
Product-Review: Jason Sparks <jsparks@instructure.com>
test plan:
* create a course with a future term date
* restrict students from accessing the course before start date
in the course settings
* enroll a student in the course and add them to a group
* as the student, the courses index ("/courses") should
not list the group (or the course)
closes #CNVS-26623
Change-Id: Iedddd118f40024480bae8c7b5a42315dc41af335
Reviewed-on: https://gerrit.instructure.com/71382
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Matt Fairbourn <mfairbourn@instructure.com>
test plan:
* on the account, turn the "Allow Bulk Grade Export to SIS"
feature flag on
* reload the account settings page and turn on the
"Post Grades to SIS checkbox is enabled by default" setting
* create a module and add a new assignment and a new quiz
through the module items dialog
* the new assignment and quiz should have their respective
sis exporting settings enabled
closes #CNVS-26909
Change-Id: Ia95bd921d9a93878cc4ad0bd614154408c2d9166
Reviewed-on: https://gerrit.instructure.com/71221
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
Cody Cutrer