refs ADMIN-2277
test plan:
- Do some spot checking all around, esp. on newer stuff written with
InstUI
- Do some specific spot checking on:
- Assignments edit page. Esp. with moderated grading
- Gradebook late policies
- Check the original bug (ADMIN-2211)
Change-Id: Iaaaeb9d86dc2d59cb2c9ccca2a8764a5adb0896b
Reviewed-on: https://gerrit.instructure.com/176912
Tested-by: Jenkins
Reviewed-by: Anju Reddy <areddy@instructure.com>
QA-Review: Steven Burnett <sburnett@instructure.com>
Product-Review: Steven Burnett <sburnett@instructure.com>
fixes: ADMIN-2259
Test-Plan:
run the steps in ticket and make sure it doesnt happen anymore :)
Change-Id: I316fb4c72477afc2ed5c06a7c31fbdba558223d0
Reviewed-on: https://gerrit.instructure.com/174012
Tested-by: Jenkins
Reviewed-by: Ed Schiebel <eschiebel@instructure.com>
QA-Review: Anju Reddy <areddy@instructure.com>
Product-Review: Rex Fleischer <rfleischer@instructure.com>
fixes OUT-2848
Test plan:
* Visit the course or account outcomes page
* Click add a new outcome
* Turn on VoiceOver
* Navigate to rich text area
* VoiceOver should now read the label "Describe this outcome"
This fix should fix the label issue for all instances of RCE in Canvas
Change-Id: I476a50a4fae1d22c04ccbac0ffd142a594c8427c
Reviewed-on: https://gerrit.instructure.com/173366
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Brian Watson <bwatson@instructure.com>
Product-Review: Neil Gupta <ngupta@instructure.com>
closes QA-614
Test Plan:
- Run yarn test inside the canvas-planner directory
- A junit file should be created in ./coverage/canvas-planner-junit.xml
- It should also report to jenkins 'Test Results' when there is a failure
Change-Id: Ibfb1ec088ceb60f2c265b3c31e77029968268f9a
Reviewed-on: https://gerrit.instructure.com/173008
Tested-by: Jenkins
Reviewed-by: Carl Kibler <ckibler@instructure.com>
Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com>
QA-Review: Clay Diffrient <cdiffrient@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
refs QA-614
Test Plan:
- `yarn test` inside of packages/canvas-rce outputs
`coverage/canvas-rce-junit.xml`
- Also, Jenkins should pick that file up on patchset builds
as well
Change-Id: Ib4db4ba16b90e181e17a319219544aa2f0c205ea
Reviewed-on: https://gerrit.instructure.com/172430
Tested-by: Jenkins
Reviewed-by: Steven Burnett <sburnett@instructure.com>
QA-Review: Clay Diffrient <cdiffrient@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
closes CORE-1976
Test Plan:
- Set Canvas language to Dansk GR/GY
- Go to an RCE instance
- The sidebar should be translated
- Repeat for Norsk (Bokmal) GS/VGS and Svenska GR/GY
Change-Id: Iac81f9ac5246e1c874d62652a9e759180447e0d9
Reviewed-on: https://gerrit.instructure.com/170826
Tested-by: Jenkins
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
Reviewed-by: Ryan Shaw <ryan@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
refs CORE-1976
Test Plan:
- Setting language to Ukranian shows language
translated in the RCE and the RCE Sidebar
Change-Id: I37c6dab381421d93435d4cb91ea43aad8d7aac86
Reviewed-on: https://gerrit.instructure.com/168646
Tested-by: Jenkins
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Reviewed-by: Ryan Shaw <ryan@instructure.com>
refs CORE-1976
Test Plan:
- Set the language to Danish and notice that the
sidebar is translated on RCE pages.
Change-Id: Ia87a658da33fbd102e693e2ae8079a54f56019ad
Reviewed-on: https://gerrit.instructure.com/168654
Tested-by: Jenkins
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Reviewed-by: Ryan Shaw <ryan@instructure.com>
closes CORE-1983
Test Plan:
- Go to an instance of the RCE sidebar
- Use the keyboard to navigate into the Files and/or Images panel
- Go back to the tab bar and go to Links
- Press tab
- Focus should go into the Links panel
Change-Id: I8e4befba3d52a9bad1ae854e7f7040e36a271cfe
Reviewed-on: https://gerrit.instructure.com/168907
Tested-by: Jenkins
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com>
When something was due at midnight, the planner erroneously changed
the due time to 11:59pm the same day, not 1 minute earlier.
After discussing it with the team and @cwruck, we decided that planner
- should be displaying items at the time they were created
- should not do any fancy midnight stuff when the user creates a to do
fixes ADMIN-1522
test plan:
- have an assignment due at midnight in the student's timezone
which is easier to accomplish if the course and student are
in different timezones
- load the planner
> expect it to be due at midnight
- load the card dashboard
> expect it to be in the To Do sidebar at midnight
- in planner, create a new To Do due at midnight
> expect it show up in planner at midnight
Change-Id: I87190ccd5ed5dd22e62e9a8e92b41a573f418038
Reviewed-on: https://gerrit.instructure.com/169411
Tested-by: Jenkins
Reviewed-by: Jon Willesen <jonw+gerrit@instructure.com>
QA-Review: Jon Willesen <jonw+gerrit@instructure.com>
Product-Review: Christi Wruck
implements the planner layout for narrow screens.
in the process, the window.matchMedia mock used for
responsiviser.spec.js (since the dom used by jest doesn't support
window.matchMedia) became too much and the tests were more a test
of the mock than responsiviser. Added a selenium spec in its place.
the main difference between this implmentation and Mary's design is
that the item title should truncate after 2 lines, but is only 1.
Attempting to fix that sent me down a rabbit hole. I may revisit later.
also added `constrain="window"` to the opportunities popover. It doesn't
work now, but should when instui fixes their placement code, which is
currently a WIP.
skipping the "scrolls to the next new activity" spec, since it's not
behaving well. It thinks the page scrolls only 3px on the 2nd
new activity button click.
closes ADMIN-1527
test plan:
- open planner on your phone, or use devtools to simulate a phone, or
simply shrink the browser to < 592px wide
> expect planner to look like the screenshot attached to the ticket
- if you're using a skinny browser, make it wider. It should
automatically switch to tablet layout
- make the browser even wider. Planner should switch to desktop layout
Change-Id: Id8302bef1e9dd773cfb229d12a338d403df8ab68
Reviewed-on: https://gerrit.instructure.com/167588
Tested-by: Jenkins
Reviewed-by: Jon Willesen <jonw+gerrit@instructure.com>
QA-Review: Jon Willesen <jonw+gerrit@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
fixes ADMIN-1530
test plan:
- have a student with an upcoming peer review due
- as the student, load the card dashboard
> expect the item's title to be "Peer Review for <item_title>"
- go to the course
> expect the same in the course's todo sidebar
Change-Id: Id5986923dbe39cc2024d9c8406503c273b939da5
Reviewed-on: https://gerrit.instructure.com/169182
Tested-by: Jenkins
Reviewed-by: Jon Willesen <jonw+gerrit@instructure.com>
QA-Review: Jon Willesen <jonw+gerrit@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
When dismissing an opportunity, the code that looked for the next thing
to give focus was being handed the planner item's plannable_id, but it
was its assignment_id that was registered with a value that matched its
assignment_id, which is different in this case.
fixes ADMIN-1496
test plan:
- create a course and add a student
- create a graded discussion due in the past
- create a quiz due in the past
- create an assignment due in the past
- load planner as the student
- click on the bell to open the opportunity center
> expect that you can dismiss all the items
> expect that focus moves to the next item if there is one,
and to the previous item if there's not, and the close
button if there are none left
Change-Id: I973f2c4ddf9ee021c33b9b8e2633fd3325731b23
Reviewed-on: https://gerrit.instructure.com/169051
Tested-by: Jenkins
Reviewed-by: Jon Willesen <jonw+gerrit@instructure.com>
QA-Review: Anju Reddy <areddy@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
Simple oversight left the planner item's type untranslated. For
example the "Assignment" in "Chemistry 101 Assignment".
fixes ADMIN-1553
test plan:
- build canvas using RAILS_LOAD_ALL_LOCALES=1 yarn build
- start rails using RAILS_LOAD_ALL_LOCALES=true bundle exec rails server
- from /profile/settings change your student's language
- as the student load the planner
> expect the item's type to be translated. (you don't have to check
all possible types. if one is translated, they all are. trust me)
Change-Id: I750eb979e29452f1492ddbbfbe76a20ec605c8ad
Reviewed-on: https://gerrit.instructure.com/168794
Tested-by: Jenkins
QA-Review: Carl Kibler <ckibler@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
Reviewed-by: Carl Kibler <ckibler@instructure.com>
changed the logic so dynamic ui manager is given the ids of the 2 dom
elements we're most interested in when scrolling: the planner header
and the new activity button. Now it can look for them and compute the
necessary offset from the top of the window as needed.
this will become necessary when the phone layout is finished,
since the header will wrap and it's height becomes dynamic.
fixes ADMIN-1486
test plan:
- have a planner with some new activity in the past
- click the new activity button
> expect planner to load the past data and scroll the
blue dot into view just below the new activity button
- press the button again
> expect the next dot to scroll into view.
Change-Id: I82ec54648466a7f9499296a8292c86721d2f847e
Reviewed-on: https://gerrit.instructure.com/168551
Tested-by: Jenkins
QA-Review: Jon Willesen <jonw+gerrit@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
Reviewed-by: Jon Willesen <jonw+gerrit@instructure.com>
closes CORE-1974
Test Plan:
- The tooltip for Record/Upload Media should be
translated (once translations are received)
Change-Id: I55eb1d4519cff02bf28e51ecd9f68a8b542aaf73
Reviewed-on: https://gerrit.instructure.com/168228
Tested-by: Jenkins
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
this updates all the stuff we get from npm that we _can_ upgrade to
the newest versions available.
test plan:
* all the builds should pass
Change-Id: Icf1cc3cd02d66e6e1f999ea5f5fc3b5b28775881
Reviewed-on: https://gerrit.instructure.com/167282
Reviewed-by: Steven Burnett <sburnett@instructure.com>
Tested-by: Jenkins
QA-Review: Ryan Shaw <ryan@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
closes CORE-1861
Test Plan:
- Open up the RCE and make sure it works
with all the languages
Change-Id: Ibd75e0ce71fc5bd4de094f2fd381471305ba9881
Reviewed-on: https://gerrit.instructure.com/163960
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Tested-by: Jenkins
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
closes ADMIN-1111
test plan:
- create calendar events courses a student is enrolled in
- create calendar events on the student's calendar
- create calendar events in a group a student is part of
- go to planner and click on these calendar event titles
- a dialog displaying the calendar information should appear
- in the dialog, clicking the calendar event title should take you to
that event in the calendar
- the dialog should display the proper dates, calendar, location, and
details
Change-Id: Iabb3649c32bdef551dc73740dd2191e301b0de34
Reviewed-on: https://gerrit.instructure.com/166148
Reviewed-by: Carl Kibler <ckibler@instructure.com>
QA-Review: Carl Kibler <ckibler@instructure.com>
Tested-by: Jenkins
Product-Review: Jon Willesen <jonw+gerrit@instructure.com>
closes CORE-1644
Test Plan:
- Go to a course and disable the files section
- As a student, go to a page with an RCS sidebar
- You should not see a files tab
Change-Id: I3291cc90a363404a33e5b07077bcea3a031f9dcc
Reviewed-on: https://gerrit.instructure.com/159626
Tested-by: Jenkins
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
Reviewed-by: Ryan Shaw <ryan@instructure.com>
closes ADMIN-1456
test plan:
- Main acceptance criteria is in the jira - please double check
- in Courses and Planner sidebars, Students see a calendar button
instead of the Coming Up section.
- Teachers, observers, TAs, etc still have Coming up and not the
View Calendar button. Don't need to check all those, just fyi
- new Todo list: As Student with Planner enabled, To Do list on
Course shows 7 items. Also on Dashboard Card View
- old Todo list (Teacher view of Dashboard Card, for example)
still has 5 items.
- new Todo list looks infinitely far into future, not just 2
weeks.
Change-Id: Id2c703338b0b28c82e56d3b34619ff5de0c5d28c
Reviewed-on: https://gerrit.instructure.com/166130
Tested-by: Jenkins
Reviewed-by: Jon Willesen <jonw+gerrit@instructure.com>
QA-Review: Jon Willesen <jonw+gerrit@instructure.com>
Product-Review: Carl Kibler <ckibler@instructure.com>
Ubuntu