Screen readers no longer enter, exit, or report applications mode/region when
passing over menu trigger controls. Menu triggers can also be navigated
to with screen reader "jump to next/previous button" navigation shortcuts.
Fixes CNVS-15275
Test plan:
- Visit each kyle menu in Canvas.
- Verify with a screen reader:
- That the trigger is reachable via normal arrow key navigation
- That the trigger is reachable when navigating by buttons
- That the menu opens when enter is pressed on the menu trigger
- That forms mode is activated when the menu is opened (N/A in Voice Over).
- That the up and down arrow keys allow one to navigate through the menu
- That pressing enter on a menu option activates that action
- Verify that menu triggers are reachable by the keyboard (sans screen reader).
- Verify that all the other functionality relating to menus as discussed above
is accessible to keyboard only users.
Change-Id: I81d7678251b7c43e67504d5569e59ccd2f846949
Reviewed-on: https://gerrit.instructure.com/40951
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Ryan Florence <ryanf@instructure.com>
Product-Review: Ryan Florence <ryanf@instructure.com>
Reviewed-by: Ryan Shaw <ryan@instructure.com>
QA-Review: Nathan Rogowski <nathan@instructure.com>
Test plan:
- Visit the conference concluded page and verify that the accessible label on
the pop-up menu is "Settings" and not "settings".
- Visit the New Conference page and verify that the Edit option in the pop-up
menu no longer has an unnecessary aria-label.
Change-Id: I563b1a1a479b213253b65da4362bd5c050c4ec35
Reviewed-on: https://gerrit.instructure.com/34629
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Reviewed-by: Liz Abinante <labinante@instructure.com>
Product-Review: Aaron Cannon <acannon@instructure.com>
fixes CNVS-9554
all items are properly read and focused when
navigating Kyle Menus via keyboard
this commit patches JQueryUI menu.js :(
test plan:
- Create a graded discussion.
- Activate the discussion cog menu, and confirm
that all items are read by a
screen reader, and properly focused on screen
when arrowing up and down via the keyboard.
- Leave a reply, and test the cog menu on the
reply as above.
- Confirm that all items within the menu are
activatable by pressing enter
- Verify that the appearance of the page is still correct.
- Visit all other pages with Kyle Menus, and
verify the same as above.
- make sure to test in IE since the way click
events are simulated is different code
Change-Id: I735573b3151c1133b6bdfb2f0e6bea6b7a285372
Reviewed-on: https://gerrit.instructure.com/27447
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Aaron Cannon <acannon@instructure.com>
Reviewed-by: Ryan Florence <ryanf@instructure.com>
QA-Review: Trevor deHaan <tdehaan@instructure.com>
fixes CNVS-11010
test plan:
* open a course conferences page
* open the new conference dialog
* attempt to enter more than 255 characters in the title field
* verify that you cannot do so
* save your new conference
* verify that it saves successfully
Change-Id: I3d7c5d51ee0c8e224827a576982690cfebc38553
Reviewed-on: https://gerrit.instructure.com/31690
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Trevor deHaan <tdehaan@instructure.com>
Reviewed-by: Jon Willesen <jonw@instructure.com>
Product-Review: Braden Anderson <banderson@instructure.com>
fixes PS-1006
test-plan
test with g/28553
creds found in PS-954
training center and meeting center meetings should work
Change-Id: Ibac8b863f5295671cb2e852e26b89eb8b7ed91ce
Reviewed-on: https://gerrit.instructure.com/28556
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jake Sorce <jake@instructure.com>
Reviewed-by: Braden Anderson <banderson@instructure.com>
Product-Review: Adam Phillipps <adam@instructure.com>
QA-Review: Adam Phillipps <adam@instructure.com>
fixes CNVS-10195
test plan:
* regression test conferences
(I suggest you compare to beta)
Change-Id: Idd8f8fff6636509f00d87b83193c097339d5fd14
Reviewed-on: https://gerrit.instructure.com/28094
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Zach Pendleton <zachp@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Product-Review: Braden Anderson <banderson@instructure.com>
refs PS-894
test-plan:
requires g/27337 to test functionality
* conferences should behave the same without g/27337
Change-Id: I546e806897fa35bc93b983da2d149e312f502d2d
Reviewed-on: https://gerrit.instructure.com/27338
Reviewed-by: Braden Anderson <banderson@instructure.com>
Product-Review: Adam Phillipps <adam@instructure.com>
QA-Review: Adam Phillipps <adam@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
fixes CNVS-9639
test plan:
* create a new conference with a time limit of 1 minute
and a description that spans multiple lines;
* start the conference;
* wait for the conference to conclude, and then check
the display of its description on the conferences index
page;
* verify that the description is properly truncated.
Change-Id: I4cea989955a1f017f1c71dae0cd9681d2e60adab
Reviewed-on: https://gerrit.instructure.com/26667
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jon Willesen <jonw@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Zach Pendleton <zachp@instructure.com>
adds the option for a text field, and adds the ability to add new
new options to the members section of the edit/new dialog
refs PS-799
test plan
* enable the webex plugin (must include this gerrit g/25892)
* create a conference, adding external email addresses
Change-Id: I54ddbd3fcf5e1567c8be03b4a127a30fc43205f6
Reviewed-on: https://gerrit.instructure.com/25894
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Adam Phillipps <adam@instructure.com>
QA-Review: Adam Phillipps <adam@instructure.com>
Reviewed-by: Braden Anderson <banderson@instructure.com>
fixes CNVS-8740
test plan:
* create a conference with a long description;
* verify that it properly truncates with an ellipsis;
* shrink the browser window horizontally and verify that
the conference title and description don't overlap.
Change-Id: I17a0d6bb2583655198e6624694be690ba2e01b7c
Reviewed-on: https://gerrit.instructure.com/25526
Reviewed-by: Jon Willesen <jonw@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Matt Fairbourn <mfairbourn@instructure.com>
Product-Review: Zach Pendleton <zachp@instructure.com>
refs PS-667
test-plan
*create multiple recordings with adobe connect
*you should be able to see them listed under the conference
Change-Id: Idaab5e25bbc7f1c2a991aba00d6e76d163c8a496
Reviewed-on: https://gerrit.instructure.com/24712
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Zach Pendleton <zachp@instructure.com>
QA-Review: Adam Phillipps <adam@instructure.com>
Product-Review: David Scoville <davids@instructure.com>
the recording checkbox should have been disabled after the
conference has started, like other conference controls, because
you can't change the recording setting after the conference has
started.
fixes CNVS-8288
test plan:
- create a BBB conference, recording checkbox should be
editable.
- edit the BBB conference, recording checkbox should still be
editable.
- start the BBB conference, recording checkbox should no
longer be editable.
Change-Id: I8ee65b45448c9a469516c6c246ea2cbd354e634a
Reviewed-on: https://gerrit.instructure.com/24635
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Zach Pendleton <zachp@instructure.com>
QA-Review: Cam Theriault <cam@instructure.com>
Product-Review: Jon Willesen <jonw@instructure.com>
the initial implementation had an order-of-operations bug, causing most
disabled or un-named inputs to be serialized, as well as unchecked
checkboxes and radio buttons. radio buttons were also serialized as bools,
which makes absolutely no sense. these weird issues inspired little
patches (and regressions), but the the major underlying problems were
never really fixed, so here we are.
this commit resets $.serializeForm to a straight coffeescript port of
$.serializeArray (no underscore conversion), with just the things we need:
1. a canvas-friendly value mapper (for date pickers, files and tinymce)
2. support for non-forms
additionally, change (almost) every checkbox field in handlebars templates
to use the {{checkbox}} helper (so you get the hidden input right before
it, a la rails)
a notable side effect is that checkboxes are no longer serialized as
booleans, rather as "1" / "0" (or whatever the value is, per the html
spec). so now you can use checkboxes for non-bool scenarios (e.g. multiple
selection), which is nice. the big takeaway is you should *not* do truthy
checks on checkbox values in coffeescript moving forward if you use the
{{checkbox}} helper, since "0" is truthy.
test plan:
1. run specs
2. regression test of checkbox functionality in the following places:
* gradebook2 dialogs w/ checkboxes, specifically:
* group weights dialog
* curve grades dialog
* submission details
* create/edit assignment (lots of checkboxes)
* don't forget turnitin settings
* create/edit appointment group (scheduler)
* edit timeslot (scheduler)
* edit calendar event (specifically section-level dates)
* create/edit conference
* conversations (group convo / faculty journal options)
* add course users dialog (limit-to-section option)
* discussion settings dialog (index page)
* create/edit discussion topic (various options)
* notification preferences (just a couple checkboxes)
3. regression of radio button functionality in the following places:
* content migrations
* delete assignment group dialog
Change-Id: Ifa5ef3cea954ca260a899da9fa426f8f833472f8
Reviewed-on: https://gerrit.instructure.com/23096
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Marc LeGendre <marc@instructure.com>
QA-Review: Marc LeGendre <marc@instructure.com>
Reviewed-by: Landon Wilkins <lwilkins@instructure.com>
Reviewed-by: Ryan Florence <ryanf@instructure.com>
sometimes there is a delay between when the big blue button
conference concludes and the recording is ready. This commit
adds a new message for this state, "preparing video", instead
of showing "no recording".
fixes CNVS-6171
- create a big blue button conference with the "long duration"
and "recording" checkboxes checked.
- start the conference.
- while the conference is active, go back to the conferences
tab and refresh the page.
- press the "End" button to conclude the conference while it
is running.
- the conference should move to the concluded section and say
"preparing video".
- go back to the active bbb conference tab and close it to
really end the conference.
- wait for a bit, and then refresh the conference page.
eventually the "preparing video" should be replaced by the
view button, once the bbb server has finished processing the
recording.
Change-Id: I138762480bdb9f793de9c6ed434cfa49a3d910ba
Reviewed-on: https://gerrit.instructure.com/21241
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Zach Pendleton <zachp@instructure.com>
QA-Review: Cam Theriault <cam@instructure.com>
Product-Review: Jon Willesen <jonw@instructure.com>
fixes CNVS-5985, CNVS-5661
testing instructions
=====================
on the conferences page:
* create a new conference
* can edit and update an existing conference
* can delete a conference
* after deleting all conferences in a group,
the text showing "no conferences" should appear
* web conference type selection is disabled
but visible when there is only 1 conference type
* conference type selection is visible and enabled
when there are multiple types to choose from.
* concluded conferences can be deleted
* users should not be able to update or delete
when they don't have permission
* long running conference that is started
should show the "Join" button and the
"End" button that will close the conference.
Wimba Conferences:
* "Manage Advanced Settings..." link
shows up for and does not appear for other
conference types
BBB Conferences:
* make sure the "recording" checkbox appears and
is persisted properly
* test recording and playback of BBB conferences
Change-Id: Id97e9d4bdc509396b6d995a2b18e600f9426aba2
Reviewed-on: https://gerrit.instructure.com/20939
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jon Willesen <jonw@instructure.com>
QA-Review: Jon Willesen <jonw@instructure.com>
Product-Review: Jon Willesen <jonw@instructure.com>
Aaron Cannon