closes CNVS-23614
Test Plan:
- Setup a moderated grading environment
- Use the + Reviewers button
- You should see the flash message show
- Use the publish button
- You should also see that flash message
Change-Id: I350fba7bc0dd964f35df9aaf5f51224424182bb8
Reviewed-on: https://gerrit.instructure.com/64104
Tested-by: Jenkins
Reviewed-by: Sterling Cobb <sterling@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
The assignment "Assign to" field is implemented in a react app that
utilizes react-tokeninput. When focusing on the field, focus jumps to
remove button of last entered asignee, which prevents non-visual users
from knowing what the field is for.
I attempted a few different approaches to solving this problem using the
react-tokeninput component as it exists now, but no dice. We should add
functionality to the component to hint context on focus, but for now, I
added tabindex on the label field above the field to cue context.
Test Plan:
* Open assignment edit page
* Verify that tab stops on "assign to" field, and various screen
readers read text properly
closes CNVS-23041
Change-Id: I76d879eceee46f691c712293ba44e089abe31e32
Reviewed-on: https://gerrit.instructure.com/63952
Reviewed-by: Matthew Wheeler <mwheeler@instructure.com>
Tested-by: Jenkins
QA-Review: Adam Stone <astone@instructure.com>
Product-Review: Aaron Cannon <acannon@instructure.com>
Added some screenreader only labels for options in the online submission
type of assignment. Visual context is obvious from grouping of checkbox
elements, but non-visual users lose context very quickly of what the
checkboxes are for.
Additionally pointed the input box for allowed file types in file upload
submissions to read hint text of div below.
Test Plan:
* Verify that checkbox elements in online submission type read "online
submission type" in various screen readers
* Verify that "Allowed file extensions" input box reads hint text in
div below when focused in various screen readers
closes CNVS-23040
Change-Id: I326c9d181dc07fee4a8eb52dd57fd8e9b8132b0a
Reviewed-on: https://gerrit.instructure.com/63908
Tested-by: Jenkins
Reviewed-by: Matt Berns <mberns@instructure.com>
Reviewed-by: Matthew Wheeler <mwheeler@instructure.com>
QA-Review: Michael Hargiss <mhargiss@instructure.com>
Product-Review: Aaron Cannon <acannon@instructure.com>
fixes CNVS-22551
test plan
- see repro step on the ticket
- ensure multiple notifications aren't sent
Change-Id: Ia3e3b5623cd4c8bd78961e1857a045d81b0bc91f
Reviewed-on: https://gerrit.instructure.com/64174
Tested-by: Jenkins
Reviewed-by: Steven Burnett <sburnett@instructure.com>
QA-Review: Adrian Russell <arussell@instructure.com>
Product-Review: Joel Hough <joel@instructure.com>
test plan:
* create a account with the "View all grades" permission
disabled for a TA role
* as a TA in a course in that account, should not be able
to view the gradebook when the course is concluded
closes #CNVS-23677
Change-Id: Ie0ba4d7fa4a45446e10d8caab584168088ed7547
Reviewed-on: https://gerrit.instructure.com/64211
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
fixes CNVS-23636
fixes CNVS-23690
This touches almost every part of the moderated grading page so needs a
full regression test.
Change-Id: I86cfc5052bd554c4add61337f0e08e091b1b4c7c
Reviewed-on: https://gerrit.instructure.com/63989
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
Fixes CNVS-23042
Test plan:
- Create a new assignment.
- Using a screen reader, ensure that the Add New Due Date Set button is read
by screen readers when tabbed to or arrowed to.
Change-Id: Ieb2c08f74e8f3d6896cb94bc7df85c2405fc00cb
Reviewed-on: https://gerrit.instructure.com/63044
Tested-by: Jenkins
Reviewed-by: Matt Berns <mberns@instructure.com>
QA-Review: Adam Stone <astone@instructure.com>
Product-Review: Aaron Cannon <acannon@instructure.com>
fixes CNVS-21793, CNVS-21794, CNVS-21795
- Adds EpubExport model to manage state of generated epubs.
- Adds controller to list, create & show epub exports.
- Adds a mini react app to manage UI for creating epub exports.
- Adds shared ApiProgressBar react comoponent to diplay a progress bar
that polls the progress API.
- Updates ContentExport to have a relationship with EpubExport.
test plan:
- Navigate to `/epub_exports`.
- Observe a list of courses that are active & user is enrolled in.
- Click on the Generate button.
- Observe that info about the state of the export and the timestamp are
added to the middle of the row.
- Observe that a progress bar is displayed while the export is in
progress.
- Observe that upon completion, the progress bar is replaced by two
button / links: Download & Regenerate.
- Observe that Download at the moment does nothing... this is because
the backend is not yet hooked up to generate the epub.
- Observe that the Regenerate button triggers the process all over
again.
Change-Id: I6cd844baa06db0c6648ad19389d235b89659919c
Reviewed-on: https://gerrit.instructure.com/62135
Tested-by: Jenkins
Reviewed-by: Matt Berns <mberns@instructure.com>
QA-Review: Adam Stone <astone@instructure.com>
Product-Review: Cosme Salazar <cosme@instructure.com>
Fixes: CNVS-23684
Test Plan:
- as an admin using the old or new UI
- navigate to your inbox
- hover over a message that is in your "inbox" or "sent" tab
- you should see an outlined star appear on the left-hand side
(inspect the star using dev tools - it should be displaying in
#333 vs original #34444f - note: this is prior to the star being
clicked at which time it changes to a golden color
Change-Id: I38ae8cb87419631f47ba68ad183e9fe14b193d71
Reviewed-on: https://gerrit.instructure.com/64129
Reviewed-by: Jennifer Stern <jstern@instructure.com>
Product-Review: Jennifer Stern <jstern@instructure.com>
Tested-by: Jenkins
QA-Review: Myller de Araujo <myller@instructure.com>
Fixes: CNVS-23629
Test Plan:
- as an admin using the new or old UI
- ensure you have the "Quiz Log Auditing" feature allowed at the
highest account level under >Settings >Feature Options
- also ensure you have "Quiz Log Auditing" turned on for the
account the quiz will be conducted in
- navigate to a course with a quiz *or* create a short quiz
- once it has been taken/submitted/attempted you should see a
# Attempt so far / View Previous Attempts on the right-hand
area
- click the "View Previous Attempts" from this screen click the
"View Log" inspect the number with the dark background following
the Attempt label (it should now be filled with #333 vs the orig
#34444f)
Change-Id: Ia1072af666f399f2cf8d0995231ca7206e9ae829
Reviewed-on: https://gerrit.instructure.com/64124
Reviewed-by: Jennifer Stern <jstern@instructure.com>
Product-Review: Jennifer Stern <jstern@instructure.com>
Tested-by: Jenkins
QA-Review: Myller de Araujo <myller@instructure.com>
test plan:
1. add an unpublished file to an unupblished module
2. publish the module
3. the file's module item should appear published
4. a student should be able to click on the module item
and get to the actual file, instead of an error message
fixes CNVS-22955
Change-Id: I5c5736afc7e4b984f7aed56df3b0cc278b4bb467
Reviewed-on: https://gerrit.instructure.com/63905
Reviewed-by: Dan Minkevitch <dan@instructure.com>
Tested-by: Jenkins
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
This removes the smarts from it and makes the component a pure
component. It also adds tests.
closes CNVS-23615
closes CNVS-23637
Test Plan:
- Set up a moderated grading environment
- The buttons in the header should work as previously expected
- The + reviewers button should add people to the moderation
set
- The publish buttons should first confirm the choice, then
publish everything (and make the page read only)
Change-Id: I15e5c7b7dedec12224ba8ee6f270c32988547364
Reviewed-on: https://gerrit.instructure.com/64131
Reviewed-by: Sterling Cobb <sterling@instructure.com>
Tested-by: Jenkins
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
test plan:
- enable moderated grading for a course and create a moderated
assignment
- associate the assignment with a rubric
- submit the assignment
- as a TA, mark the assignment's rubric in speedgrader
(click View Rubric, enter a score and comments, click
Save)
- the score and comments should be immediately visible in
speedgrader
- if you click View Rubric again, the score and comments
entered previously should remain visible
fixes CNVS-23686
Change-Id: I01f22c957bc092b58d0d095a779247d77f9006d3
Reviewed-on: https://gerrit.instructure.com/64185
Reviewed-by: James Williams <jamesw@instructure.com>
Tested-by: Jenkins
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
We can now use context_external_tools_helper to update lti links inside
erbs
Fixes PLAT-1242
Test Plan:
Add an LTI tool using [this
xml](https://gist.github.com/defektive/dbd182cb04500e236bde) or use
[this
url](4a7939ccb4/canvas_icon_class-lti_test.xml)
check the following cog menus for functioning LTI links
- assignments
- quizzes
- modules
- discussions
Check the following right side menus for functioning LTI links
- Course Home
- Course Settings
Change-Id: I75f6cf7c5b3e73b25f8bd6c20404e7379bc46ce6
Reviewed-on: https://gerrit.instructure.com/63620
Tested-by: Jenkins
Reviewed-by: Nathan Mills <nathanm@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Brad Horrocks <bhorrocks@instructure.com>
refs PFS-2661
Test Plan
* Make sure Usage Rights is active in the account settings/Feature
* Options
* Go to http://localhost:3000/courses/<course_id>/files
* Open Manage Usage Rights (both the Cog on the right and feature
* Buttons above)
* User should be able to edit publishing on the Usage Rights modal
* Publishing Radio button should display publishing icons next to radio
* buttons
* Go to http://localhost:3000/courses/<course_id>/modules and verify
* that
the Publishing Modal also displays the icons next to the radio buttons
Change-Id: Ie7856d6fd53a2103d50c3ac415b7a81d94a2f9e4
Reviewed-on: https://gerrit.instructure.com/63195
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Nathan Rogowski <nathan@instructure.com>
Product-Review: Cosme Salazar <cosme@instructure.com>
fixes CNVS-23174
Test Plan:
1. Log into a course as a teacher.
2. Navigate to the Calendar.
3. Click a date like September 14th 2015, and add a new event to the COURSE calendar.
4. Click More Options on the event modal.
5. Check the Repeat checkbox at the bottom.
6. Make the event a larger range so it goes into November, such as every 2 weeks for 4 occurences.
7. Check the count box for good measure and easy reading event names, then click Create Event.
8. Go to the teacher's settings and make sure the time zone is set to Mountain Standard Time, and check the month or agenda view.
9. Verify the times don't start changing to an earlier hour until november 9th, after Daylight Savings time.
10. Change the user's time zone to UTC +1, (Amsterdam or Berlin) and check the calendar dates again.
Change-Id: I9cce9e03fb8b8601eea6c184a1094cee182fd3e9
Reviewed-on: https://gerrit.instructure.com/64150
Reviewed-by: Alex Boyd <aboyd@instructure.com>
Reviewed-by: Dan Minkevitch <dan@instructure.com>
Tested-by: Jenkins
QA-Review: Adrian Russell <arussell@instructure.com>
Reviewed-by: Matthew Wheeler <mwheeler@instructure.com>
Product-Review: Steven Burnett <sburnett@instructure.com>
test plan:
* pass a valid value for pseudonym[authentication_provider_id] to create user
API
* the user's initial pseudonym should be associated with that auth provider
Change-Id: Ibfe78a2154b52afd4f98c62862d52365a54ec0d6
Reviewed-on: https://gerrit.instructure.com/62039
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
* don't treat suffix-like-names as suffixes when they're more likely
the given name
* even more so when it should already be in last-name-first context
test plan:
* have a user with the full name "Vi Duing", which should translate
to a sortable name of "Duing, Vi"
* do an LTI launch
* first name should come through as Vi, last name as duing
Change-Id: I2d728614af8ff421a5e14e8c2d116d9f0d0a2499
Reviewed-on: https://gerrit.instructure.com/63139
Tested-by: Jenkins
QA-Review: August Thornton <august@instructure.com>
Reviewed-by: Rob Orton <rob@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
fixes gh-695
test plan:
* enroll a user with an SIS ID in a group
* you should be able to use the API to do
DELETE /api/v1/groups/<group_id>/users/sis_user_id:<sis id>
(assuming proper permissions)
Change-Id: Idf07a28eabc53fbe604efac8f96b56ed8120ff57
Reviewed-on: https://gerrit.instructure.com/63681
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Change-Id: Ib335386aabb254b10753de59fb289998a4c327b3
Reviewed-on: https://gerrit.instructure.com/64163
Reviewed-by: James Williams <jamesw@instructure.com>
Reviewed-by: Dan Minkevitch <dan@instructure.com>
Product-Review: Dan Minkevitch <dan@instructure.com>
Tested-by: Jenkins
QA-Review: Jeremy Stanley <jeremy@instructure.com>
Fixes: CNVS-23652
Test Plan:
- as an admin with the new UI turned on
- open theme editor
- jump down to the "Login Screen" section
- change the "Login Label" color from white to a red color
- next change the "Login Link Color" from white to a green color
- preview your changes and make sure they took affect _or_ save
and then logout so you can view the live login screen (per the
settings you should now see red labels and green links)
Change-Id: I95804f46c31f20feafbfb4f8f3e7e92ef472e825
Reviewed-on: https://gerrit.instructure.com/64017
Tested-by: Jenkins
Reviewed-by: Chris Hart <chart@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
QA-Review: Myller de Araujo <myller@instructure.com>
Fixes: CNVS-23631
Test Plan:
- as a teacher/admin using the old or new UI
- create a new course, then click into the wizard to help set it up
- the icon that appears in the center of the right visual area
should now have a background color of #333 vs original #34444f
Change-Id: I3b0ac03827ed0980b33f6a5c2594b9c8f5268938
Reviewed-on: https://gerrit.instructure.com/64015
Reviewed-by: Jennifer Stern <jstern@instructure.com>
Product-Review: Jennifer Stern <jstern@instructure.com>
Tested-by: Jenkins
QA-Review: Myller de Araujo <myller@instructure.com>
Fixes: CNVS-23630
Test Plan:
- there is nothing to "see" on the /styleguide#colors other than
ensuring the removal of these styles did not break anthing
- the front-facing styles were removed on CNVS-23109 and these
class references were overlooked as far as needing to be
removed
Change-Id: I12ce2820e5c618efbf5897cbdd989b71e69ca730
Reviewed-on: https://gerrit.instructure.com/64014
Reviewed-by: Jennifer Stern <jstern@instructure.com>
Product-Review: Jennifer Stern <jstern@instructure.com>
Tested-by: Jenkins
QA-Review: Myller de Araujo <myller@instructure.com>
fixes CNVS-23327
0. As a student in a course with an assignment…
1. Navigate to the students grade summary for a course.
2. Change focus with the keyboard so it is on a grade.
3. Press return, and verify that you can edit the what-if
grade.
Change-Id: I84a5077cd3cdc8b256c1b3b409d6a0ffcf4ff2c8
Reviewed-on: https://gerrit.instructure.com/63991
Reviewed-by: Derek Bender <djbender@instructure.com>
Tested-by: Jenkins
QA-Review: Jason Carter <jcarter@instructure.com>
Product-Review: Nathan Rogowski <nathan@instructure.com>
fixes CNVS-22981
test plan:
- Create a Formula question which uses 1 decimal place
- Use a set of numbers which would generate a two decimal
answer ending in a 5
- Ensure that number rounds as expected
Change-Id: Id8bcd017795b85b60636bcc0d202b55ad74b3bdf
Reviewed-on: https://gerrit.instructure.com/63706
Tested-by: Jenkins
Reviewed-by: Brian Finney <bfinney@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Jason Sparks <jsparks@instructure.com>
fixes CNVS-23337
Test Plan:
* Import an assignment into a course from another
canvas course, making sure that the assignment
is marked as "Group Assignment" and the group
that it belongs to exists in both the source and
destination courses
* The imported assignment should be imported
as part of the existing group of the same name
from the source course
Change-Id: I32446e1c15d643d33e8a2bb49e6b9381afe85ebe
Reviewed-on: https://gerrit.instructure.com/63717
Tested-by: Jenkins
Reviewed-by: James Williams <jamesw@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Dan Minkevitch <dan@instructure.com>
also add beta documentation for these endpoints and the
moderation set API endpoints
test plan:
- specs cover the controller/route change
- render documentation and sanity check the
Moderated Grading page (noting the beta tag)
closes CNVS-23310
Change-Id: I64517184fc38d5af0cd7d088222fd5131534e448
Reviewed-on: https://gerrit.instructure.com/63682
Tested-by: Jenkins
Reviewed-by: James Williams <jamesw@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
fixes CNVS-23641
test plan:
- in console
- find an account
- `act = Account.find(:id)`
- find this accont via cache
- Account.find_cached(:id)
- change `act` and save
- re-find the account via cache
and note that the changes are
reflected in the cached value
- brand a subaccount
- brand it again to look different
- go to a course in this subaccount
and the new branding is reflected
Change-Id: I2cec204681ffe87a71ad72dc1c34942fd88ccd9f
Reviewed-on: https://gerrit.instructure.com/64030
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Jacob Fugal <jacob@instructure.com>
Test Plan:
- pass Jenkins
- check for syntax errors
- make sure new test_ids match up to an existing test case in TestRails
Change-Id: I8e6a31a2e0861c69c8bb3b71b3634026c653d98a
Reviewed-on: https://gerrit.instructure.com/63819
Tested-by: Jenkins
Reviewed-by: Derek Hansen <dhansen@instructure.com>
Product-Review: Derek Hansen <dhansen@instructure.com>
QA-Review: Derek Hansen <dhansen@instructure.com>
Test Plan:
- pass Jenkins
- check for syntax errors
- make sure new test_ids match up to an existing test case in TestRails
Change-Id: I3cd6cc98c0b4dbf6ffa11193902ab0165209fbc3
Reviewed-on: https://gerrit.instructure.com/64080
Tested-by: Jenkins
Reviewed-by: Derek Hansen <dhansen@instructure.com>
Product-Review: Derek Hansen <dhansen@instructure.com>
QA-Review: Derek Hansen <dhansen@instructure.com>
closes CNVS-19900
test plan:
- create a brand_config for an account
- apply brand_config
- add ?mobile=1 to an api request that returns a
body (like a wiki page);
observe no additional stylesheets in the body
- go to /accounts/self/, and go to brand
config and upload a mobile_css_override
- add ?mobile=1 and check the api result again
your stylesheet should be there appended to the
body of the wiki page
- back in brand_config, remove the uploaded file
- check your source again - there should not be
an empty stylesheet tag
Change-Id: Ief728a397d185282a57f8cede0916c7ffe4a2584
Reviewed-on: https://gerrit.instructure.com/61885
Tested-by: Jenkins
Reviewed-by: Ryan Shaw <ryan@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
fixes gh-642
test plan:
- verify that the following mime type is supported by the box view api:
application/vnd.openxmlformats-officedocument.spreadsheetml.sheet
(see https://developers.box.com/view/#filetypes)
Change-Id: Ia0cfc5a86d9d7c2b433645bc0b2efe1cfefd403f
Reviewed-on: https://gerrit.instructure.com/59596
Tested-by: Jenkins
Reviewed-by: Cameron Matheson <cameron@instructure.com>
Product-Review: Cameron Matheson <cameron@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
closes CNVS-22002
test plan:
- Load up a moderated grading assignment
- Click the checkbox at the top by the 'name' column
- All students should be selected
- Unselect it all students should be unselected
- You should be able to click the + Reviewers button
and they all get added to the moderation set.
Change-Id: I841b2edd4671e31051ca69d86e253da00fe92d00
Reviewed-on: https://gerrit.instructure.com/63846
Tested-by: Jenkins
Reviewed-by: Sterling Cobb <sterling@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
fixes CNVS-23417
This will show radio buttons next to grades for moderation sets. It
also adds urls for the speedgrader.
Test Plan
- Go to an assignment with students that are being moderated then.
- Make sure non of them are added to the moderation list
- there should only be one column represented
- add a student to the moderation set
- notice there are now 4 columns, 3 for the mark, 1 for the final mark
- you should also be able to click on on the speedgrader links
Change-Id: I1e0be0195ffa95d6b43d738178ffd0dcb75832bd
Reviewed-on: https://gerrit.instructure.com/63833
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Cosme Salazar <cosme@instructure.com>
closes: CNVS-23137
We have a new jenkins build "canvas-sel-r21-hourly-p2-new-styles"
that will will test everything against new UI. It sets the
CANVAS_FORCE_USE_NEW_STYLES environment variable which, with
this commit will make it so account factories have new_ui
turned on by default. Tests can still explicitly turn off new UI
so they can test something with it turned on and then off if they want.
Change-Id: I8f7384064aa6674c09abc02d712a048a726f76d9
Reviewed-on: https://gerrit.instructure.com/61888
Tested-by: Jenkins
Reviewed-by: Jacob Fugal <jacob@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Derek Hansen <dhansen@instructure.com>
closes CNVS-21970
Test Plan
- Publish grades on a moderated assignment from the moderation page
- All buttons should be disabled after success
- All checkboxes and radio buttons should also be disabled
Change-Id: I9e866ad3f05231a497fb096b4e716e8f02eab981
Reviewed-on: https://gerrit.instructure.com/63821
Tested-by: Jenkins
Reviewed-by: Sterling Cobb <sterling@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
Fixes: CNVS-23628
Test Plan:
- using the old or new UI navigate to the "inbox"
- i did not have any messages in my inbox so i was able to send a
few messages and then go to the "sent" tab from the dropdown
- at the end of each message is a rounded corner box that has a
number containing the number of threads within that email string
upon inspection the background of the box should be #333
Change-Id: Idbda2382efe7ffcf9784c5ef6c3bd99fe40b8504
Reviewed-on: https://gerrit.instructure.com/63959
Reviewed-by: Jennifer Stern <jstern@instructure.com>
Product-Review: Jennifer Stern <jstern@instructure.com>
Tested-by: Jenkins
QA-Review: Myller de Araujo <myller@instructure.com>
Test plan:
* speedgrader should work the same way it has been for moderated
grading
Change-Id: I64999ed7545c00a9ce0788148ea9c070a6edaf9e
Reviewed-on: https://gerrit.instructure.com/63528
Reviewed-by: James Williams <jamesw@instructure.com>
Tested-by: Jenkins
Product-Review: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Jeremy Stanley <jeremy@instructure.com>
also don't poll unread count when we don't have anywhere to put it
test plan:
* turn on new nav
* log out and go to the login page
* there should not e a bunch of HTML about menus
* it should not automatically do XML-HTTP requests for unread count
* get to the MFA screen
* the same should still be true
Change-Id: Id5e0280089cc16934d87c1294a74644683b6d182
Reviewed-on: https://gerrit.instructure.com/63502
Reviewed-by: Cody Cutrer <cody@instructure.com>
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Tested-by: Jenkins
QA-Review: August Thornton <august@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Clay Diffrient