closes VICE-4301
flag=discussion_checkpoints
Test plan:
- Test passes
- Go to Discussions > + Discussion
- Fill the title and description
- Select the option "Graded"
- Select the option "Assign graded checkpoints"
- Add points
- Click on "Manage Due Dates and Assign To"
- Fill in "Reply to Topic Due Date" and
"Required Replies Due Date"
- click on Apply
- Clck "Save and Publish"
- Go back to the discussion pages
- the newly created Discussion should show the
"Reply to topic" and "Required Replies" due dates
Change-Id: Icda226183560dcd6bbad9a3c4df312013205b486
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/355284
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Dave Wenzlick <david.wenzlick@instructure.com>
Product-Review: Sam Garza <sam.garza@instructure.com>
closes RCX-2291
flag=block_editor
test plan:
- start a page from scratch
- change the layout from column to row on the default Group
- add a couple things (icons will do)
> expect them to be in a row
- add a group
- ad a couple things to that group
> expect the new group items to be in a column
> expect the original items to be at the top of the Group
- on the outer group, change the vertical alignment to center
> expect the original items to be cenered vertically
- change the vertical alignment to end
> expect the original items to be at the bottom
Change-Id: I39c249a3800b95ee1dd2e03d58a5a47fd7e31861
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/355890
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob DeWar <jacob.dewar@instructure.com>
QA-Review: Jacob DeWar <jacob.dewar@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
The AVS makes 3 queries, and the remaining services issue just 2
queries.
flag = selective_release_optimized_services_v2
[skip-crystalball]
Test plan:
- Specs pass
- Regression test unassigning assignments, quizzes, pages, and
ungraded discussions
Change-Id: I208a6a4c3e4cfc9fdad40916309395707c175222
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/356018
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Sarah Gerard <sarah.gerard@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Jackson Howe <jackson.howe@instructure.com>
flag = selective_release_optimized_services_v3
[skip-crystalball]
Test plan:
- Specs pass
- regression test assigning and unassigning wiki pages
Change-Id: Ia993f023c03905e775bdaba70412b309cfc23dae
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/355988
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jackson Howe <jackson.howe@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Sarah Gerard <sarah.gerard@instructure.com>
implement tanstack's query library into temp enrollments.
this switch was made to pagination in TempEnrollView for now,
since TempEnrollView will benefit the most.
closes FOO-4586
flag=temporary_enrollment
test-plan:
- Prerequisites:
- Have multiple users; only one enrolled in a course
- Enable temporary enrollment feature flag
- Optional: Lower number of ITEMS_PER_PAGE in types.ts
- This makes testing pagination much easier
- Go to /accounts/<account_id>/users
- Follow these steps multiple times
- Click the temp enroll icon next to the enrolled user
- Follow the steps to create a temporary enrollment
- After creating each temp enrollment
- Click the green temp enroll icon by the enrolled user
- EXPECT that pagination is correct
- EXPECT left arrow on the first page to be disabled
- EXPECT right arrow on the last page to be disabled
- EXPECT no arrows to render when there is only one page
- EXPECT pages to be cached for 10 seconds
Change-Id: I2ac6634a1223c7014967b209c07639c98220e42b
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/354421
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Charley Kline <ckline@instructure.com>
QA-Review: Maya Tyner <maya.tyner@instructure.com>
Product-Review: Maya Tyner <maya.tyner@instructure.com>
password settings will use the custom/forbidden words list. this commit
makes it so we can upload that file using the forbidden words file upload
component.
closes FOO-4674
flag=password_complexity
test plan:
- make sure password_complexity flag is enabled
- go to authentication_providers settings
- check the "Customize forbidden words/terms list"
- select "Upload"
- click "Upload File" in modal
- select a file
- network settings tab should not have any failed requests
Change-Id: I8c443855390476d664fed60a1378f8d667527ad8
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/356012
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: AJ Esa <ajmal.esa@instructure.com>
Reviewed-by: Michael Hulse <michael.hulse@instructure.com>
QA-Review: AJ Esa <ajmal.esa@instructure.com>
Product-Review: AJ Esa <ajmal.esa@instructure.com>
flag = selective_release_optimized_services
[skip-crystalball]
Test plan:
- Specs pass
- Regression test unassigning quizzes, pages, and ungraded discussions
Change-Id: I3b6be54a38d0bcc1fba4ed5f8b117a973c34fbad
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/355994
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Sarah Gerard <sarah.gerard@instructure.com>
QA-Review: Sarah Gerard <sarah.gerard@instructure.com>
Product-Review: Jackson Howe <jackson.howe@instructure.com>
- columns instead of blank section
- new GroupBlock
- you can now nest blocks
- columns work differently now
- something about the TabsBlock tests broke
- fixed 1 resizing bug (there are more)
- fixed the About and Hero section layout which the above
changes broke
closes RCX-2191
flag=block_editor
test plan:
Start from scratch:
- from Pages, click +Page
- Next thru the stepper to create an empty page
> expect a Blank section (aka Columns Section) with 1 column
> expect no trash can in the column's toolbar (because you
can't delete the last child of the blank section
> expect no trash can in the section's toolbar (becauser you
can't delete the last section in the page)
- add some stuff to "Drop a block to add it here"
> expect the stuff to be in a coumn
- in the toolbar, change from column to row layout
> expect the things to be in a row
- add a group
- change the group so its layout is opposite its parent
- put some stuff in there
> expect a row of stuff in a column or visa versa
- nest at will
> you cannot resize the group that is the child of the
blank section
> you can resize a group that's a child of something else
- from the section toolbar, add column(s)
> expect new group blocks to be added to fill out the new cols.
- reduce the number of cols.
> expect the current groups to organize themselves into the current
number of columns
> expect to be able to grag the group blocks around to reorder them
- preview
> expect the columns to rearrange as the space narrows
- add About and Hero sections to a page
> expect them to look correct
Change-Id: I1b854386e90b75fe54b5e567d6934fe09204cc17
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/354801
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob DeWar <jacob.dewar@instructure.com>
QA-Review: Jacob DeWar <jacob.dewar@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
fixes RCX-2071
flag=none
Test plan:
- Create a Canvas course with a video and course copy it
- Act as a TA or designer in the resulting course and navigate
to the files tab and select the video.
- Select the “CC” option at the bottom right. Select a language,
a subtitle file from your computer and upload it.
- Check the captions were submitted properly.
Change-Id: I670c2f1f90f339fd888b1ab10c57d1a233d97630
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/355984
Reviewed-by: Eric Saupe <eric.saupe@instructure.com>
QA-Review: Eric Saupe <eric.saupe@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Luis Oliveira <luis.oliveira@instructure.com>
when I updated creating the WikiPage model for the block editor
I passed the context options in the wrong place. this changed the
options in the dropdown.
closes RCX-2292
flag=none
test plan:
- create a new page
> expect to see "Only teachers", "Teachers and students", and "Anyone"
in the "Users allowed to edit this page" dropdown
Change-Id: Ibfd4fbf7b54e841e64e8f05f4bf15013524e8ae2
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/356001
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Juan Chavez <juan.chavez@instructure.com>
QA-Review: Juan Chavez <juan.chavez@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
refs FOO-4696
flag = password_complexity
test plan:
- enable the feature flag `Enhance password options`
- exercise the "Update an account" endpoint with the new parameters
- `common_passwords_attachment_id: <id>`
- `common_passwords_folder_id: <id>`
- PUT /api/v1/accounts/:root_account_id
Change-Id: Iae937601accabc4968984d66c6ff01ba5150f5e0
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/356003
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Michael Hulse <michael.hulse@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: August Thornton <august@instructure.com>
flag=discussion_checkpoints
fixes VICE-4429
no new specs, existing specs
for indiv gb and making sure they
don't fail is enogh
test plan:
- must have a checkpointed discussion that has been
submitted by a student
- visit gradebook
- inspect network
- change traditional gradebook dropdown to
individual gradebook
- verify GradebookQuery response has
submissionsConnection { subAssignmentSubmissions } and data is correct
- verify it also has assignmentsConnection { Checkpoints } and data
is correct
Change-Id: I22eb1798901f211ebdcfec1f744fd19b9eafb1d0
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/355815
Reviewed-by: Jason Gillett <jason.gillett@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
closes EVAL-4030
flag=none
Test Plan:
1. Create a course with a symbol in the name and publish it
2. Create an assignment with a symbol in the name and publish it
3. Add a student to the course
4. Submit to the assignment as the student
5. Enter a comment with a symbol
6. Download the submission comments from the Speedgrader
7. Observe that symbols are displayed properly in the report
Change-Id: I8fb8c640578cb46bee3bae8aed46d0123bda9831
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/353241
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Shafovaloff <ashafovaloff@instructure.com>
Reviewed-by: Spencer Olson <solson@instructure.com>
Reviewed-by: Derek Williams <derek.williams@instructure.com>
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Product-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
The original code in this commit did redundant work per assignment
passed in. This optimizing the code to do as much work as possible in
bulk but retain the same functionality.
test plan:
- specs pass
Change-Id: If9321429d719f79c584fc3c34494e4d2a9dd5f84
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/355975
Reviewed-by: Spencer Olson <solson@instructure.com>
QA-Review: Keith Garner <kgarner@instructure.com>
Product-Review: Keith Garner <kgarner@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Elimintes an N+1 on graphql queries for content modules.
test plan:
- specs pass
Change-Id: I7748b73f81d3e025a5185ce38717188df55fcdc8
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/355992
Reviewed-by: Spencer Olson <solson@instructure.com>
QA-Review: Keith Garner <kgarner@instructure.com>
Product-Review: Keith Garner <kgarner@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
closes FOO-4696
flag = password_complexity
test plan
- enable password complexity feature flag
- set password policy settings via API or rails console
- leverage the API:
- GET /api/v1/accounts/:account_id/settings
- verify the password policy settings are returned
- with the feature flag disabled, verify the password policy settings
are not returned
Change-Id: Ifd51a5594ef673258d1608b94a3883b4d0f54762
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/355991
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Michael Hulse <michael.hulse@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: August Thornton <august@instructure.com>
why: There were several students who had assignments who's TII reports
were showing "pending" because they had resubmitted with a previous
attachment from their files and we were not finding the correct
originality report that already existed.
This change will also cause the updated_at field of the existing
report to be updated when the data received from TII is the same as
what we already have. This will indicate that we received a new one
instead of seeming like nothing happened
fixes INTEROP-8646
flag=none
test plan:
- as a teacher, create an assignment that allows unlimited resubmissions
- as a student, submit to the assignment with an attachment three times
- the first time upload a file from your computer
- the second time upload the same file from your computer (it should
get a display_name of <filename>-1 to distinguish it from the first)
- the third time upload the same file as the first but do so with the
"Click here to find a file you've already uploaded" option
this time it should have the same display_name as the first
- in a rails console create a new OriginalityReport for the first and
second submissions
- prior to code change the third submission should be the last but have
no originality report score next to it while the previous two do
- after the code change the third submission should have the same score
as the first one
Change-Id: Ia09215abd41b1ed25a816e3fff43ff6922e623cc
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/354435
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Alexis Nast <alexis.nast@instructure.com>
Reviewed-by: Xander Moffatt <xmoffatt@instructure.com>
QA-Review: Xander Moffatt <xmoffatt@instructure.com>
it's bigger, but solves some bugs I don't have time to track down
plus it will do clipping and other stuff
closes RCX-2259
flag=block_editor
test plan:
- resize stuff
> see that it works even better, and with less (of our) code
Change-Id: Iedb6f3c407a5b687b8e4dd85804436ccb12dcd4c
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/355618
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Murilo Paiva <murilo.paiva@instructure.com>
QA-Review: Eric Saupe <eric.saupe@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
fixes RCX-2163
flag=none
test plan:
- Type text in the RCE
- Select the text
- Choose Lato Extended form the Fonts choices
- Inspect element to verify "Lato Extended" is the font being used.
Firefox's element inspector has a Fonts tab that makes this easier but
can be verified with anything.
Change-Id: Ibec71b62889407823a7c33760b606f1ae5a5ffcf
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/355851
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Luis Oliveira <luis.oliveira@instructure.com>
QA-Review: Luis Oliveira <luis.oliveira@instructure.com>
Product-Review: Eric Saupe <eric.saupe@instructure.com>
closes LX-1917
flag=selective_release_ui_api
test plan:
- acting as a teacher
- go to course modules page
- test the following trays
- "Add Module"
- "Assign To" from the module kebab menu
- "Assign To" from an item kebab menu
- all trays must behave well with the masquerade on/off
Change-Id: Ie4372b846c734dd9f652ceb8d9f9e3499a891a43
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/353884
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Alvaro Talavera <alvaro.talavera@instructure.com>
Reviewed-by: Robin Kuss <rkuss@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
fixes LX-1948
flag=selective_release_ui_api
test plan:
- Set the course language to Català (Catalan).
- Create an assignment.
- Go to a an Assign To card and select a date
in Jan, Apr, May, Aug, Sep, Dec.
> Verify that there are no errors after
selecting and blurring the date time picker.
> Verify that you are able to save the
assignment.
Change-Id: I94e4097362085f49e772273af03d9688e87c97cc
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/355754
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Drake Harper <drake.harper@instructure.com>
QA-Review: Drake Harper <drake.harper@instructure.com>
Product-Review: Drake Harper <drake.harper@instructure.com>
Roberto Noguera