make sure that switchman's extension is still active
Change-Id: I8d9d06103f1eb4b09f529b634fba758c72da371a
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/339249
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
to avoid a concurrency issue where another of the same query selects
the row, and then it's gone before it can delete it, causing an error
Change-Id: I1155044c007988c4c7244352fae87de84c34894b
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/338921
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Similar to g/339134, we need to pass the success handler into
the proper .then block.
refs FOO-4220
flag=none
Test Plan:
- Jenkins Passes
Change-Id: I04513448d3b428ce06fc20dc76bf0bd8a1c3a1cf
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/339135
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jen Smith <jen.smith@instructure.com>
QA-Review: Angela Gomba <angela.gomba@instructure.com>
Product-Review: Angela Gomba <angela.gomba@instructure.com>
instead of complaining that they need to be run
also fix the migration check to look at actual versions, not just count of
migrations, in case a migration has been renamed or deleted - throwing
off counts
Change-Id: Ifefdf5783cc908db4053ed79fa54f767dcb61514
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/339251
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
fixes LF-1016
flag=none
Test plan
- Ensure you have new quizzes working properly
with RCE
- Inside a new quiz RCE, link an image, media,
doc and any other kind of file from a course
- Ensure the HTMl for the link DOES NOT
have the file verifier added to the link
- Ensure user files do have the verifier still
- Locally Chrome will not be able to show
the files properly unless you are running
Canvas (and probably Quizzes) with https
- The workaround is to use another browser
like Firefox or Safari
Change-Id: I1ff38ffdee048ed3257e3fa3d4c977659b54841c
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/338767
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob DeWar <jacob.dewar@instructure.com>
QA-Review: Jacob DeWar <jacob.dewar@instructure.com>
Product-Review: Mysti Lilla <mysti@instructure.com>
closes VICE-4030
flag=discussion_create
Test Plan:
- create a new discussion as a teacher
- go to the Anonymous Discussion section
- verify that an info banner with the message "Grading and Groups are
not supported in Anonymous Discussions" appears when you select
either the partial or full radio buttons
- verify it does not appear when Off is selected
- save the discussion
- edit the discussion and verify that even when partial or full is
selected, the info banner does not appear
- verify that no publish indicator appears
- perform the same above steps as the student
Change-Id: I81b270469685dd7982d58bf7c8b4b00d7065c7c1
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/339044
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Jason Gillett <jason.gillett@instructure.com>
Reviewed-by: Drake Harper <drake.harper@instructure.com>
Product-Review: Samuel Lee <samuel.lee@instructure.com>
fixes LF-1192
flag=differentiated_modules
test plan:
- Open Modules page.
- Open "Add Module" tray.
- Type a name and pick a valid lock until date (a date
in the future).
- Click Save.
> Verify that the new module has the
"Will unlock <date-time>" message using the selected
date-time.
> Verify that when refreshing the page the new
module has the same "Will unlock <date-time>" message
using the selected date-time.
- Open "Edit Module" tray.
> Verify that the loaded unlock time is the same as
the "Will unlock <date-time>" message.
Change-Id: Ic7d64739243846f046e9c38ee267855ffd6901a5
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/339179
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Robin Kuss <rkuss@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Juan Chavez <juan.chavez@instructure.com>
Using .then and .error breaks when upgrading from jQuery 1.7 to
1.8. The fix is to move the success and error blocks into the
ajaxJSON call as the success and error handlers
refs FOO-4220
flag=none
Test Plan:
- Jenkins Passes
- I also manually tested in the UI the success and error
cases
Change-Id: I9e7bb9cceb5cc1071024d9c8b73bf2bb44ed22a9
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/339134
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Michael Hulse <michael.hulse@instructure.com>
Reviewed-by: Aaron Shafovaloff <ashafovaloff@instructure.com>
QA-Review: Angela Gomba <angela.gomba@instructure.com>
Product-Review: Angela Gomba <angela.gomba@instructure.com>
also:
- improve the structure and readability of <head>
- load main entry after react
closes CFA-49
[skip-crystalball]
Change-Id: Ic638446cb3430bc572ccf16c3c81a4752a528dff
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/339183
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Product-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Fixes FOO-3941
flag=none
Test Plan:
- As an admin, create a new auth provider
- see that you can opt out of SMS for one-time passcodes
- The MFA setup screen will not include text about SMS or show
field for phone number entry if opt-via-sms is not enabled
Change-Id: I7294427162368cd18ac1dcecdc04d12aaa88102c
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/335543
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Jason Perry <jason.perry@instructure.com>
This test fixes an unrecognized expression error due to a bad
selector where the class “dot” was duplicated across two lines.
It appears as though jQuery 1.7 was more loose about matching
selectors. In 1.8, and Sizzle, the selector syntax became more
strict, hence why this test now fails on this line.
refs FOO-4220
flag=none
test plan: tests pass
Change-Id: Icc8c6fea74b7451fa846ccc00e11f87b77379c8e
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/339186
QA-Review: Michael Hulse <michael.hulse@instructure.com>
Product-Review: Michael Hulse <michael.hulse@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Angela Gomba <angela.gomba@instructure.com>
this selector syntax finds a submit button in jquery 1.7
but incorrectly finds the button's type in jquery 1.8
flag = none
Test Plan: tests pass
refs FOO-4220
Change-Id: I074a4688036fc08891f25fa8d16d4d6ed9a4118d
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/339184
QA-Review: Jen Smith <jen.smith@instructure.com>
Product-Review: Jen Smith <jen.smith@instructure.com>
Reviewed-by: Michael Hulse <michael.hulse@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Some syntax cleanup for the jQuery 1.8 upgrade:
- Moving ':first' selector to the end of the chain (similar to
g/338660)
- Remove extra " (similar to g/339172)
refs FOO-4220
flag=none
Test Plan:
- Jenkins passes
Change-Id: I004a9c547c04418279b5474b4f1dd35ec8fd6c5c
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/339133
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Michael Hulse <michael.hulse@instructure.com>
QA-Review: Angela Gomba <angela.gomba@instructure.com>
Product-Review: Angela Gomba <angela.gomba@instructure.com>
This commit fixes a minor syntax error in the event hash of
EditCalendarEventView. The 'change' event for '#duplicate_event' had
mismatched quotes, which could potentially lead to event binding issues.
The extraneous quote has been removed to ensure proper functionality.
refs FOO-4220
flag=none
test plan: tests pass
Change-Id: I294118ba5e2dfddb702341c7b767e09dbd51bfc3
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/339172
QA-Review: Michael Hulse <michael.hulse@instructure.com>
Product-Review: Michael Hulse <michael.hulse@instructure.com>
Reviewed-by: Jen Smith <jen.smith@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
the outcome service data that may be merged in is still being loaded
in its entirety; we should fix that in the future, but that's a bigger
lift than enumerating `canvas_scope` in batches
test plan:
- specs pass
- student competency report, outcome export,
and outcome results reports work
flag=none
fixes FOO-4118
Change-Id: I301a62285c87837bee2a5d8379f723717b4c2087
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/338507
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Martin Yosifov <martin.yosifov@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
modify the desktop view for the assignment index page as
part of the ICE initiative
fixes EVAL-3594
flag=instui_nav
Test Plan:
- tests pass
- Acceptance Criteria
- 2.25rem from the header to the content
- primary title is changed to h1 tag and font weight of 700
- search bar and grading period filter are moved to the content
- confirm that the search bar and grading period filters still work
- 12px between the create assignment, create quiz, create group,
and settings buttons on the teacher account
- confirm that the buttons still work as intended since they were
modified to using instui buttons
- on the student side confirm that the show by button filters work
by toggling the type and date.
- refresh the page and confirm that the previously selected filter
for type and date still applies on refresh
Change-Id: Ib2dab9c337dc9f505a04b0783b2e9bb94504a962
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/334354
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Melissa Kruger <melissa.kruger@instructure.com>
Product-Review: Melissa Kruger <melissa.kruger@instructure.com>
Reviewed-by: Kai Bjorkman <kbjorkman@instructure.com>
Reviewed-by: Derek Williams <derek.williams@instructure.com>
flag=instui_for_import_page
fixes LF-815
test plan:
- Go to the import page
- Select Unzip .zip file into folder
- Verify form looks like design
- Verify form works and requires a file and a folder
- Verify the course copy and course export packages forms still work
Change-Id: Ic11518f2ae89fd4ce236e206ae0e64b83959a1c9
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/331408
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Eric Saupe <eric.saupe@instructure.com>
Reviewed-by: Mysti Lilla <mysti@instructure.com>
QA-Review: Mysti Lilla <mysti@instructure.com>
refs FOO-4240
flag = none
Test plan:
• Exercise new API endpoint:
• DELETE /api/v1/users/mobile_sessions
• Verify user access tokens associated to mobile app developer
keys are invalidated
• Verify user generated or otherwise tokens to developer keys
without an sns_arn are not invalidated
Change-Id: I89eb1b92a091f19aa1b54fb1c7d4f25f5eae7c85
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/339119
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: August Thornton <august@instructure.com>
closes VICE-4040
flag=discussion_create
Test Plan:
- create a new discussion
- go to the buttons at the bottom and verify that using the keyboard
nav, the focus outline shows fully for each button
- once a discussion is created, go to the edit page and verify
that the bottom button's focus outlines show fully
- go to create an announcement and verify that the bottom button's
focus outlines show fully
Change-Id: I04a39711c8df2f7e01bce104a050f5c747c06942
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/338818
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Drake Harper <drake.harper@instructure.com>
QA-Review: Jason Gillett <jason.gillett@instructure.com>
Product-Review: Samuel Lee <samuel.lee@instructure.com>
Fixes FOO-4247
flag=none
We had a bit of a flake because the front-end boot code in
ui/index.ts would almost immediately look for the existence
of a link classed `help_trigger_dialog` which appears only
on the login screen. But sometimes when that code executes,
nothing with that class is yet in the DOM. It's kind of weird
because that page is rendered by an ERB so it should be there
statically. But there may be some race condition between the
browser's page painting and the execution of that code.
Solution is to just look for that trigger after the document
comes fully ready.
Test plan:
* Load the login page
* The "Help" link should ALWAYS bring up the login page's
help dialog. Previously, sometimes it would but sometimes
it wouldn't.
Change-Id: I67f25ddc2d6ab8984df66400bc55438e9eed93c5
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/339151
Reviewed-by: Aaron Shafovaloff <ashafovaloff@instructure.com>
QA-Review: Charley Kline <ckline@instructure.com>
Product-Review: Charley Kline <ckline@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
These are some quick fixes to selectors in selenium tests that
resulted in syntax errors after upgrading to jQuery 1.8. Cleaning
up the selectors in the tests fixed the issues. Additionally, I
got an eslint warning to use f over fj, so I fixed that as well.
refs FOO-4220
flag=none
Test Plan:
- Jenkins Passes
Change-Id: Icf8d08f3fa65d7a138d1fde34d4f261ee4bcd495
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/339132
Reviewed-by: Aaron Shafovaloff <ashafovaloff@instructure.com>
Reviewed-by: Charley Kline <ckline@instructure.com>
QA-Review: Charley Kline <ckline@instructure.com>
Product-Review: Charley Kline <ckline@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
closes LF-685
flag = differentiated_modules
Test plan:
- Create a module with at least 1 assignment
- In a rails console, call:
`assignment.submissions.reload.pluck(:user_id)`
- Expect to see the ID for each student in the course
- Add an override to the module
- Make the same call in the rails console
- Expect to see only the IDs of the students targeted by the module
override
Change-Id: I9faf8f1b4d1a2bb3f89290915b2b878f5d7d0c19
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/339076
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Sarah Gerard <sarah.gerard@instructure.com>
Reviewed-by: Robin Kuss <rkuss@instructure.com>
QA-Review: Sarah Gerard <sarah.gerard@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Jackson Howe <jackson.howe@instructure.com>
this behavior has been removed from canvas, but the label remains
test plan:
- attempt to create a new quiz with anonymous grading
- verify that the label does not say that it is irreversible
Change-Id: If976cfcdd3ca4bfc7cddf946d365b401a6814d0e
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/338091
Reviewed-by: Samuel Lee <samuel.lee@instructure.com>
Reviewed-by: Aaron Shafovaloff <ashafovaloff@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Derek Williams <derek.williams@instructure.com>
Product-Review: Cameron Ray <cameron.ray@instructure.com>
With the 1.8 upgrade we need to make sure that non-elements
(i.e. comment or text nodes) do not get passed into
getComputedStyle. This can be easily fixed by using .filter('*').
See this jQuery ticket for more context:
https://bugs.jquery.com/ticket/12462/
refs FOO-4220
flag=none
Test Plan:
- Jenkins Passes
Change-Id: I8a66d7ae09183ea2db5e7ab0609d73b66429a956
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/339131
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Shafovaloff <ashafovaloff@instructure.com>
Reviewed-by: Michael Hulse <michael.hulse@instructure.com>
QA-Review: Angela Gomba <angela.gomba@instructure.com>
Product-Review: Angela Gomba <angela.gomba@instructure.com>
occasionally admins find they can't masquerade as other
users who were previously admins in now-deleted accounts
because their account_users are still active
FOO-199 made accounts delete account_users upon deletion
but didn't clean up existing ones, which have required
occasional support and engineering effort to clean up on
demand. might as well do a datafix migration to forestall
future effort
test plan:
- set up admins in an account
- delete the account by directly updating the workflow_state
bypassing callbacks
- run the datafix migration
- the orphaned account_users should be soft-deleted
flag=none
closes FOO-4251
Change-Id: I50b6a951307933dec587a78372ef3069a826c213
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/338935
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: August Thornton <august@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
Migration-Review: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
add pagination to used locations in
backend lvl
fixes EVAL-3905
flag=archived_grading_schemes
test plan:
-GET http://canvas.test:3000/accounts/2/
grading_schemes/9/used_locations?page=1
- validate pagination is working for grading scheme
used locations
Change-Id: I6d8c233b6e8ec9ded93157bd2c3df66f95d881f9
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/338283
Reviewed-by: Derek Williams <derek.williams@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Rohan Chugh <rohan.chugh@instructure.com>
Product-Review: Ravi Koll <ravi.koll@instructure.com>
rationale:
- To allow internal and partner tools to specify multiple launches that
can occur in the submission_type_selection placement.
- This is only the backend work. The frontend work will take place
in a later commit.
- This only works for 1.3 tools. 1.1 tools, such as Mastery Connect,
replicate this behavior by installing multiple versions of the tool so
that multiple versions get listed.
closes INTEROP-8399
flag=none
test-plan:
- Install the 1.3 test tool with the submission_type_selection
placement.
- Modify the Lti::ToolConfiguration associated with that developer key
by navigating to the Developer Key associated with the tool and
manually modifying the JSON. Search for the
`submission_type_selection` placement entry object and add a new
`submission_type_selection_launch_points` property
so that it looks something like this:
```
{
"text": "LTI 1.3 Test Tool",
"enabled": true,
"icon_url": "https://static.thenounproject.com/png/131630-200.png",
"placement": "submission_type_selection",
"message_type": "LtiDeepLinkingRequest",
"target_link_uri": "http://lti13testtool.docker/launch?placement=submission_type_selection",
"canvas_icon_class": "icon-lti"
"submission_type_selection_launch_points" => [
{
"target_link_uri": "http://lti13testtool.docker/launch?placement=submission_type_selection",
"icon_url":
"https://static.thenounproject.com/png/131630-200.png",
"title": "First"
},
{
"target_link_uri": "http://lti13testtool.docker/launch?placement=submission_type_selection",
"icon_url":
"https://static.thenounproject.com/png/131630-200.png",
"title": "Second"
},
]
},
```
- Navigate to the assignment creation page and open up the developer
tools.
- In the console, type `ENV.SUBMISSION_TYPE_SELECTION_TOOLS`
- Assuming you only have the 1.3 tool installed, you should see just it
listed. You should see an additional property in the object, that
wasn't there before, titled:
"submission_type_selection_launch_points" that contains the
appropriate info.
Change-Id: I2a671f66e00f5c7dca99605710a93cf59b5ef360
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/338648
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Tucker Mcknight <tmcknight@instructure.com>
QA-Review: Tucker Mcknight <tmcknight@instructure.com>
Product-Review: Alexis Nast <alexis.nast@instructure.com>
Cody Cutrer
