fixes FOO-2930
flag = none
this hasn't been used for quite some time and there's no good reason for
the code to stay, also I noticed it was used in test at some point but
again, no more
~ test plan ~
CI is ok
Change-Id: If4c5dab06d1b5a579d4475c5f3f33ab4f34c5c91
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/291699
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Charley Kline <ckline@instructure.com>
QA-Review: Charley Kline <ckline@instructure.com>
Product-Review: Charley Kline <ckline@instructure.com>
refs DE-1070
flag=none
TEST PLAN:
Confirm local jest tests work
Confirm Jenkins builds still work
Change-Id: I7bec13fd8292fb14ea1ea932bf8befd6e6139292
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287958
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
QA-Review: Bobby Buten <bobby.buten@instructure.com>
Product-Review: Bobby Buten <bobby.buten@instructure.com>
refs DE-1070
flag=none
TEST PLAN:
Confirm build still runs
Compare build times of pre/post changes
Change-Id: I9364314b8e5f99ea8f29cc69c0f711bf959c8fa3
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/286171
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Bobby Buten <bobby.buten@instructure.com>
Product-Review: Bobby Buten <bobby.buten@instructure.com>
Reviewed-by: Aaron Ogata <aogata@instructure.com>
refs FOO-2697
flag = none
those two packages were relying on canvas's babel.config.js but no more
test plan: the build phase of the CI is enough as there were no logical
changes
Change-Id: I7814796f36f1e30b4dd494a12f768f9dbafb4f1f
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/286759
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: August Thornton <august@instructure.com>
Product-Review: August Thornton <august@instructure.com>
QA-Review: Ahmad Amireh <ahmad@instructure.com>
refs LS-3017
flag=none
In regards to the BulkEditDateSelect change:
The previously used timezone library was formatting the date to null on
blur which was throwing the error. Switching to the new standard as it
both handles the formatting correctly and is the new preference
test plan:
- tests pass
qa risk: low
Change-Id: I8103cfdf2ccd9bc8ad4f4b58c192c05ae0e34596
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/286329
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
refs FOO-2696
flag = none
jest needs to explicitly load the _core_en translation file since its
i18nTransformer is no longer a thing (and it's what was doing that
before)
otherwise, this just cleans up the remaining references to i18n! in the
code, aside of eslintrc which we'll address in FOO-2738
Change-Id: Ie0a74b46c4d0a48188ba86765b46b2793eed94d7
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/286763
Tested-by: James Butters <jbutters@instructure.com>
Reviewed-by: Charley Kline <ckline@instructure.com>
QA-Review: Charley Kline <ckline@instructure.com>
Product-Review: Charley Kline <ckline@instructure.com>
refs LS-3017
flag=none
Shape is not a valid prop type, but rather a function that returns a
valid prop type. Since no shape was being defined, requiring a simple
object seemed more appropriate.
test plan:
- tests pass
qa risk: low
Change-Id: I10d6743669c3138d6426a455868f5af1c33722fe
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/286330
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
refs LS-3017
flag=none
These warnings were not causing tests to fail for some reason. I wasn't
able to pin the reason down, my suspicion is that fetch-mock uses an
internal logging mechanism.
test plan:
- run `yarn test:jest ui/features/k5_`
- there should be no console output regarding unmatched requests
qa risk: low
Change-Id: I4e8eb876571ca74eb0b2edef6a62640387f15a15
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/286391
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
refs FOO-2697
flag = none
on "babel-plugin-transform-imports": the behavior of this plugin was
surprising to me in that it not only rewrote the specifiers to point to
the CommonJS instead of the ESM variants, but it actually changed the
specifiers to point to the exact file that exports the symbol through a
mixture of fs globbing and guesses.
Consider the following import:
import { DateTime } from '@instructure/ui-i18n'
Normally, you'd think we'll be loading the {main,module,browser} file of
the @instructure/ui-i18n package and refer to the `DateTime` symbol
exported by that file. With the plugin activated, however, the import
*itself* changes to:
import DateTime from '@instructure/ui-i18n/lib/DateTime.js'
This is no longer merely a variant rewrite in any way as we're no longer
loading the same file. This caused new problems to surface that up to
this point were not encountered, as now we're actually loading the
entrypoints as specified.
An example of this is in that specific package where it (its entrypoint)
loads a package `decimal.js` whose ESM variant doesn't work as-is but
its CJS variant does -- something neither we nor the InstUI team were
privy to as the plugin was simply clobbering this piece of information.
~ test plan ~
- jest suite runs and passes
Change-Id: I55d7db1ede742e0f588a84d54a761b7aba03729f
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/283543
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Shafovaloff <ashafovaloff@instructure.com>
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Product-Review: Ahmad Amireh <ahmad@instructure.com>
fixes VICE-2255
flag=discussion_anonymity
note 1: changing this settings will not persist
as the backend portion will happen in a different ticket
note 2: I had to put checkbox inside view even if
checkbox group wants only checkbox children because
it was the best way i can indent it. i added it to jest's
ignored errors
test pilan:
- with discussion redesign ff off but discussion anonymity ff on,
- visit discussion index page as a teacher
- verify that when you open the top right cog menu
- you do not see a Create anonymous discussion topics checkbox
- turn on both react discussions post and discussion anonymity ff's
- revisit index
- verify that cog menu checkbox has a Create anonymous discussion topics
checkbox
- verify that it is only enabled if parent Create discussion topics
is checked
Change-Id: I8fb22b10955d952a90d7c6c03c137cfa9a097ffd
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/278783
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Drake Harper <drake.harper@instructure.com>
QA-Review: Drake Harper <drake.harper@instructure.com>
Product-Review: Drake Harper <drake.harper@instructure.com>
Ethan Knapp