[ci no-cached-dist]
test plan:
* teachers in courses with term dates for teachers
set in the past should still be able to view all the tabs
in their past courses
closes #CORE-1792
Change-Id: I6d2204e691ee0693d8c6aa99abcdfd91ec45d76b
Reviewed-on: https://gerrit.instructure.com/163046
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
test plan:
* an account admin should be able to see announcements
in a course in a sub-account
* also cross-shard account admins (e.g. site admins)
should be able to see announcements
refs #COMMS-1399
Change-Id: I1acb6c917ff02b091f0ef78f4341d003a4de3a1e
Reviewed-on: https://gerrit.instructure.com/162125
Reviewed-by: Keith T. Garner <kgarner@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Tested-by: Jenkins
Product-Review: James Williams <jamesw@instructure.com>
test plan:
* an account admin should still be able to view
announcements on a course
closes #COMMS-1399
Change-Id: I85aa151a17a4ecfcdc77e0c504f45ea3590c83f3
Reviewed-on: https://gerrit.instructure.com/162122
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
Tested-by: James Williams <jamesw@instructure.com>
Change-Id: I83d5b7d5ce2641eadb83b59ac55d0d44d314a85e
Reviewed-on: https://gerrit.instructure.com/161457
Tested-by: Jenkins
Reviewed-by: Mysti Sadler <mysti@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
test plan:
* dashboard still loads
Change-Id: I7560a8ddd56d954cc1304b71d9bdd49e3c6968f2
Reviewed-on: https://gerrit.instructure.com/161651
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
test plan:
* the dashboard should still work
closes #CORE-1746
Change-Id: Id522cf740eed9e60a7410f0222bb1a76add2fcb0
Reviewed-on: https://gerrit.instructure.com/161484
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
test plan:
* regression test dashboard
closes #CORE-1733
Change-Id: I301e8670c9fccd1a2340adce01379f0c6d3b7c01
Reviewed-on: https://gerrit.instructure.com/161174
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
closes ADMIN-1199
closes ADMIN-1031
Test plan
- This is a pretty hefty re-write for appointment
group permissions. May need regression testing
- Set up at least one or two courses with
appointment groups
- Set up at least one "manage_calendar by default"
user and one non-default user
- Ensure they can see the appointment groups in
the calendar as appropriate
- Fiddle with their permissions (by the enrollment
role or by admin roles) and ensure the user can
see the appointment groups as appropriate
- While a student is able to manage the appointment
groups, ensure they can see them on the planner
- In the server logs, ensure the appointment groups
don't create N+(6/7/8) queries
Change-Id: I5d5e1b4e8a83544374db063c76377b85b095d61e
Reviewed-on: https://gerrit.instructure.com/154975
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Reviewed-by: James Williams <jamesw@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Mysti Sadler <mysti@instructure.com>
James Williams