ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
54,110 Commits 324 Branches 20,019 Tags 1.7 GiB
Commit Graph

11 Commits

Author SHA1 Message Date
Aaron Ogata abf067a6f5 use canvas_rails_switcher for bin/spring try 2 
Change-Id: Id0c285f7d795d92cc680ad30745ada7415fe9865
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/288022
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Aaron Ogata <aogata@instructure.com>
Product-Review: Aaron Ogata <aogata@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
 2022-04-07 18:14:05 +00:00
Aaron Ogata 3a20fdd258 Revert "use canvas_rails_switcher for bin/spring" 
This reverts commit 76b7d8a66e.

Reason for revert: broke deploy

Change-Id: Ide7073ba2b1328aa7a28ebd085fddf258990f718
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/288021
Reviewed-by: Andrea Cirulli <andrea.cirulli@instructure.com>
Tested-by: Aaron Ogata <aogata@instructure.com>
QA-Review: Aaron Ogata <aogata@instructure.com>
Product-Review: Aaron Ogata <aogata@instructure.com>
 2022-04-07 14:57:22 +00:00
Aaron Ogata 76b7d8a66e use canvas_rails_switcher for bin/spring 
Change-Id: Iea745351302cc457ea051ce9b8f081ef5cce9e54
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/289075
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Aaron Ogata <aogata@instructure.com>
Product-Review: Aaron Ogata <aogata@instructure.com>
 2022-04-07 14:34:05 +00:00
Aaron Ogata fb51177993 allow rails console to be called from alternate directory 
refs DE-523

Change-Id: I253f972336a07130d58a3e28800db468ff3bcdba
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/288742
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Aaron Ogata <aogata@instructure.com>
Product-Review: Aaron Ogata <aogata@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
 2022-04-01 18:36:21 +00:00
Aaron Ogata a5cb130154 add rails version to Gemfile.lock 
refs DE-523

Previously, the current version would be represented by Gemfile.lock and the next version by Gemfile.lock.next. Replace both with a common format of Gemfile.rails<version>.lock to be able to iterate over the files in a cleaner way.

Change-Id: I35aef3a14e726eb35db8aebc808af4a925552c01
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/288563
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Aaron Ogata <aogata@instructure.com>
Product-Review: Aaron Ogata <aogata@instructure.com>
 2022-03-31 17:01:45 +00:00
Cody Cutrer 103dce1f4a add frozen_string_literal comment to binaries 
Change-Id: I4d0b95c1f22891772cfdc8a20adf0ff1e1bc8a8b
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/261819
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
 2021-03-30 18:14:03 +00:00
Cody Cutrer e0cd137946 add (springified) binstub for rubocop 
Change-Id: Iff04dbe1d24f55ff2c160df472d615cf680256dc
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/259774
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
 2021-03-10 20:32:21 +00:00
Cody Cutrer 4ba5387a8a fix bin/rails to work not-under-spring 
i.e. in production

Change-Id: I2f26a83302eb4360a19b414ca5060c6de9dfb455
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/259674
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
 2021-03-02 18:05:57 +00:00
Cody Cutrer 1988edd0e0 fix spring to work with only a next lockfile 
Change-Id: Ia933d210363f11faa2b0acff00577d7466fa1a43
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/258427
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
 2021-02-09 16:09:27 +00:00
Cody Cutrer 095e760ad4 update spring and binstub 
fixes `bin/rake css:styleguide` and gemfile confusion

Change-Id: I4f46b9fdb2e610b4ff64af49b888f33aea0cdbdb
Reviewed-on: https://gerrit.instructure.com/92163
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
 2016-10-06 20:25:33 +00:00
Cody Cutrer 51e987de62 add springified binstubs 
also switch rails3 lockfile to the default, so the spring binstub can
use the default lockfile and see itself

Change-Id: Id10cbc3df010671a59c73137a77583e2c2e0e5a8
Reviewed-on: https://gerrit.instructure.com/37802
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Cameron Sutter <csutter@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
 2014-07-21 15:45:13 +00:00