Commit Graph

12 Commits

Author SHA1 Message Date
Cody Cutrer c2cba46851 RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation
[skip-stages=Flakey]

auto-corrected

Change-Id: I4a0145abfd50f126669b20f3deaeae8377bac24d
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279535
Tested-by: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Migration-Review: Cody Cutrer <cody@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
2021-11-25 14:03:06 +00:00
Cody Cutrer e9d63396ff rubocop: split configuration
* remove spurious .rubocop.yml override files
 * split the configuration into an enforced and optional
 * run both configurations in jenkins (may result in some duplicate
   comments at different levels)
 * auto-correct the enforced configuration in the pre-commit hook
 * fix comments for Gemfile.d and the root dir; enforced configuration
   is only applied to that directory for now

Change-Id: I8da21073d74e19138b1b580d66c7aae6465348d4
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/273898
Reviewed-by: Simon Williams <simon@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2021-09-21 16:02:22 +00:00
Cody Cutrer 4e09b12caa add frozen_string_literal comment to Gemfile and Rakefile
Change-Id: I721bd841d310efb7389a232001b3d36bb8efbf0b
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/261812
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2021-03-30 17:51:26 +00:00
Cody Cutrer 1dc9623c50 allow choosing rails 5.1 via consul
also add a hook so plugins can preset $canvas_cluster

Change-Id: I508ffc6e5c73e87f9f086dd9a3877833286bb83b
Reviewed-on: https://gerrit.instructure.com/129327
Tested-by: Jenkins
Reviewed-by: James Williams  <jamesw@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
2017-10-11 19:13:02 +00:00
Landon Wilkins 8403054825 da licença part 22
add consistent license headers to all source files
(ruby, coffeescript, javascript)

except for vendor files

Change-Id: I289eec4c72b19324a049188939dc14b5965c1f25
Reviewed-on: https://gerrit.instructure.com/110044
Tested-by: Jenkins
Reviewed-by: Jon Jensen <jon@instructure.com>
Product-Review: Jon Jensen <jon@instructure.com>
QA-Review: Jon Jensen <jon@instructure.com>
2017-04-27 21:51:33 +00:00
Cody Cutrer 5fc6c0a62e fix Gemfile.d for plugins
Change-Id: I96b8f208c2daff56657bf08f76b14d18d6108eb3
Reviewed-on: https://gerrit.instructure.com/95471
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
2016-11-17 23:32:25 +00:00
James Williams 2a6fe50996 fix plugin loading from outside rails root directory
Change-Id: I215b3cc73cc58ca889fe7591f1658da754a28d23
Reviewed-on: https://gerrit.instructure.com/85688
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>
2016-07-22 15:18:59 +00:00
Cody Cutrer 0cc82ca5ab allow bundler up to 1.12.5
also stop using the undocumented eval_gemfile - apparently its
implementation changed

Change-Id: I5db6c98cb06baa5da2573ba15a4764cf4822aae1
Reviewed-on: https://gerrit.instructure.com/84534
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
2016-07-11 18:03:47 +00:00
Cody Cutrer 618eacf181 use eval_gemfile for bundler goodness
Change-Id: I1ce8c5135cb5b15f4e1fdd07cb890f5f823f11a4
Reviewed-on: https://gerrit.instructure.com/48952
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
2015-02-18 18:15:14 +00:00
Cody Cutrer f7003826ed allow gemified plugins to still have Gemfiles
so that they can specify a non-standard source for some gems,
which is not possible with a gemspec alone

Change-Id: Ia60ca2058cb78295c18b2e5fc07821311d3a547a
Reviewed-on: https://gerrit.instructure.com/48225
Tested-by: Jenkins
Reviewed-by: August Thornton <august@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2015-02-04 20:10:02 +00:00
Cody Cutrer 07a4fa8b1a give decent warning about gemified plugins
Change-Id: Ia265dea5a43e78a14e643ecc72e6f00edcad3d91
Reviewed-on: https://gerrit.instructure.com/46629
Reviewed-by: Benjamin Porter <bporter@instructure.com>
Reviewed-by: Jacob Fugal <jacob@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
2015-01-07 01:22:10 +00:00
Anthus Williams 5ed608bb72 partition Gemfile
this is a proof-of-concept to see if partitioning
our Gemfile helps more than it hurts. It's modeled
after the way the Squash team handles its dependencies

this doesn't implement any of the particularly nice
things that can be found in the Squash set up, such
as conditionally loading gems based on the contents
of our configuration files (we can already sort of
do this with groups in bundler), but it's a start.

In particular, it allows us to add non-OSS gems to
Gemfile.d without necessarily having to release it
as part of our open-source packaging

Change-Id: If7ff1fe97409de4cd09867ad5be1c4134c5d0117
Reviewed-on: https://gerrit.instructure.com/32442
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Nick Cloward <ncloward@instructure.com>
Product-Review: Anthus Williams <awilliams@instructure.com>
QA-Review: Anthus Williams <awilliams@instructure.com>
2014-03-28 16:44:56 +00:00