Commit Graph

12 Commits

Author SHA1 Message Date
Aaron Ogata 2662430025 remove non-application manual version pins
refs DE-1492

Change-Id: I1c1891db70debb2582bd1caf28c10ee0002e242a
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/309774
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
Build-Review: Alex Slaughter <aslaughter@instructure.com>
QA-Review: Aaron Ogata <aogata@instructure.com>
Product-Review: Aaron Ogata <aogata@instructure.com>
2023-01-30 15:53:38 +00:00
Aaron Ogata feb8286b0e version pin vcr gem
refs DE-1492

[pin-commit-instructure_misc_plugin=459c9c72c80d8816413d91f79652fc2a4841d266]

Change-Id: Ieac3ff1b9e370a7fc9c2af1abb6ebefed57fe03d
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/309660
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
QA-Review: Aaron Ogata <aogata@instructure.com>
Product-Review: Aaron Ogata <aogata@instructure.com>
Build-Review: Aaron Ogata <aogata@instructure.com>
2023-01-27 15:08:08 +00:00
Aaron Ogata f3469cd16f commit partial lockfiles
refs AE-1492

Test Plan:
1. Ensure that all appropriate gem versions are installed for CANVAS_RAILS=6.1 with plugins enabled
2. Ensure that all appropriate gem versions are installed for CANVAS_RAILS=7.0 with plugins enabled
3. Ensure that removing Gemfile.rails*.lock and running “bundle install” produces both 6.1 & 7.0 lockfiles with no overwrites to the partial files
4. Ensure that all lockfiles update when using “bundle update” in both versions and there are changes to commit
5. Ensure that removing plugins and running “bundle install” produces no changes to commit
6. Ensure that “bundle exec rails c” with CANVAS_RAILS=6.1 runs the right version
7. Ensure that “bundle exec rails c” with CANVAS_RAILS=7.0 runs the right version
8. Ensure that the Gemfile.*.lock.partial does not contain any secrets or private plugin names

NOTE: “vcr” gem is intentionally pinned to an old version (6.0.0) for testing

Change-Id: Id8e449466ec7839b3b71f2430256c0e8d0967775
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/309093
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
Reviewed-by: Alex Slaughter <aslaughter@instructure.com>
QA-Review: Isaac Moore <isaac.moore@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Build-Review: Alex Slaughter <aslaughter@instructure.com>
Product-Review: Aaron Ogata <aogata@instructure.com>
2023-01-25 15:32:17 +00:00
Cody Cutrer c2cba46851 RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation
[skip-stages=Flakey]

auto-corrected

Change-Id: I4a0145abfd50f126669b20f3deaeae8377bac24d
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279535
Tested-by: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Migration-Review: Cody Cutrer <cody@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
2021-11-25 14:03:06 +00:00
Cody Cutrer 60af1af7d7 Revert "pin gem paths to the actual current directory"
This reverts commit 765b685eb6.

Change-Id: Ib9901630d55f81e7674e7fc566195ac3e9076af9
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/271839
Reviewed-by: Ryan Norton <rnorton@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2021-08-19 20:28:54 +00:00
Cody Cutrer 765b685eb6 pin gem paths to the actual current directory
not one with the same name, in case we're inside a symlink that has changed

Change-Id: I5142b727f89ab662c4d909eccc7b781888551239
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/270998
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Ethan Vizitei <evizitei@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2021-08-10 01:06:30 +00:00
Cody Cutrer 4e09b12caa add frozen_string_literal comment to Gemfile and Rakefile
Change-Id: I721bd841d310efb7389a232001b3d36bb8efbf0b
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/261812
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2021-03-30 17:51:26 +00:00
Landon Wilkins 8403054825 da licença part 22
add consistent license headers to all source files
(ruby, coffeescript, javascript)

except for vendor files

Change-Id: I289eec4c72b19324a049188939dc14b5965c1f25
Reviewed-on: https://gerrit.instructure.com/110044
Tested-by: Jenkins
Reviewed-by: Jon Jensen <jon@instructure.com>
Product-Review: Jon Jensen <jon@instructure.com>
QA-Review: Jon Jensen <jon@instructure.com>
2017-04-27 21:51:33 +00:00
James Williams 2a6fe50996 fix plugin loading from outside rails root directory
Change-Id: I215b3cc73cc58ca889fe7591f1658da754a28d23
Reviewed-on: https://gerrit.instructure.com/85688
Tested-by: Jenkins
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>
2016-07-22 15:18:59 +00:00
Cody Cutrer 0cc82ca5ab allow bundler up to 1.12.5
also stop using the undocumented eval_gemfile - apparently its
implementation changed

Change-Id: I5db6c98cb06baa5da2573ba15a4764cf4822aae1
Reviewed-on: https://gerrit.instructure.com/84534
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
2016-07-11 18:03:47 +00:00
Brian Palmer c5abe5a455 avoid using a relative path for gem plugin loading
Change-Id: I33108ffccaa26a5995543e740f2696d4829254c4
Reviewed-on: https://gerrit.instructure.com/41358
Reviewed-by: Dave Donahue <ddonahue@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Brian Palmer <brianp@instructure.com>
2014-09-18 22:29:07 +00:00
Brian Palmer b55992e8ac gemify respondus_soap_endpoint
This turns the vendor/plugin into a rails engine, and establishes the
convention of canvas-dependent rails engines/gems going into
gems/plugins, and everything in that dir being auto-required and added
to canvas spec runs.

closes CNVS-14286

test plan: regression test on the respondus quiz builder client. no
behavior should change.

Change-Id: I51b548418bcb70af77e87c2c2d62cac27ed4ab44
Reviewed-on: https://gerrit.instructure.com/38394
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: Brian Palmer <brianp@instructure.com>
2014-08-21 16:49:54 +00:00