Commit Graph

12 Commits

Author SHA1 Message Date
Cody Cutrer 8c68fec61a fix sis imported multiple enrollment types and multiple observers in same section
fixes #7117

test plan:
 * import a user as a student and a teacher in the same course
 * import two students, and one observer that is associated with both students

Change-Id: Iab49f6884f84a2e947edb5d5380f8d31b23c5afc
Reviewed-on: https://gerrit.instructure.com/8427
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
2012-02-08 13:06:10 -07:00
Cody Cutrer 7e97621462 store sis_batch_id as an integer, not a string
test plan:
 * run the migration
 * redo the migration
 * do a batch mode sis import

Change-Id: I0204256f3825ffe0b4d252bbb83a0604d7a58942
Reviewed-on: https://gerrit.instructure.com/7904
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Jacob Fugal <jacob@instructure.com>
Reviewed-by: Ben Chobot <bench@instructure.com>
2012-01-11 09:14:36 -07:00
Cody Cutrer 795b372024 don't add items to list if their scope is nil
also remove existing attachments that aren't in a folder from their list

test plan:
 * run specs
 * create sis batches - make sure their position is NULL
 * destroy their associated attachment, the query logs should not indicate
   an UPDATE attachments SET position = position - 1... being executed

Change-Id: I6117c2ade0ef5ec41a3ffeeb13096b9d8473f3f9
Reviewed-on: https://gerrit.instructure.com/7843
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
2012-01-04 11:16:50 -07:00
Jacob Fugal 78807849f7 don't try and remove old batches without a term
test-plan:
 - import a course, a section, and an enrollment as a sis batch
 - import another sis batch that doesn't include the previous imported
   entities without specifying a term
 - none of the original course, section, and enrollment should be
   deleted

Change-Id: Ia03d4abf8c86d2ebd14987357ad073033ab28700
Reviewed-on: https://gerrit.instructure.com/7168
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: JT Olds <jt@instructure.com>
2011-11-29 14:27:26 -07:00
Cody Cutrer 42d5269cd8 don't bother figuring out where in the nil folder list attachments go for sis imports
Change-Id: I2f93d1bcce4d523b4a2d389a03163fcaaf2ffaaf
Reviewed-on: https://gerrit.instructure.com/5363
Reviewed-by: JT Olds <jt@instructure.com>
Tested-by: Hudson <hudson@instructure.com>
2011-08-31 10:51:18 -06:00
Brian Palmer 85476a42fb fix typos in sis importer causing wrong object ids to update batch id
This was causing "full batch mode" to delete things that it shouldn't.

Fixes #5084

Change-Id: I6e19820ae9daf0b2096fd569451669ad2bb5f52f
Reviewed-on: https://gerrit.instructure.com/4820
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Hudson <hudson@instructure.com>
2011-07-27 09:46:24 -06:00
Brian Palmer d92c44f00c delete courses and enrollments in sub-accounts for batch mode sis imports
fixes #4789

Change-Id: If2ab0f07c16c6a6d8b33def3ef590e65145dde54
Reviewed-on: https://gerrit.instructure.com/4087
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: JT Olds <jt@instructure.com>
2011-06-06 16:02:20 -06:00
Jon Jensen 58a25bd462 preliminary i18n setup, closes #4124
* i18n key scoping for controller/model/js/etc.
 * inline English translation support
 * rdiscount gem for markdown'ed translations
 * html_safe interpolation tweaks
 * label helpers
 * crummy tweak to translate symbol keys
 * internationalized most of lib, and some plugins/messages
 * conference i18n (view/model/controller/js)

Change-Id: I42772b9e19a110efbe855dc83a681be49ec98df2
Reviewed-on: https://gerrit.instructure.com/4080
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Zach Wily <zach@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
2011-06-06 14:19:03 -06:00
Brian Palmer 7131821cac remove sis batch batch mode all-term mode
We decided this was extremely dangerous/error-prone and not that useful.

Change-Id: Ib0ff0c9d4ac8eeeb9d2088ed86be24991561a763
Reviewed-on: https://gerrit.instructure.com/3994
Reviewed-by: Zach Wily <zach@instructure.com>
Tested-by: Hudson <hudson@instructure.com>
2011-06-02 12:22:15 -06:00
Bracken Mosbacker e15cb0e085 added fields for editing sis_source_ids and new sis permission
closes #4475

Change-Id: Ie6da7ec45dcba65409c0909d180358a3796319dc
Reviewed-on: https://gerrit.instructure.com/3944
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Bracken Mosbacker <bracken@instructure.com>
2011-05-31 17:53:46 -06:00
Brian Palmer 3080f367ab more robust sis batch mode spec, refs #4397
Change-Id: Id1c3c3ec1a578cb1a899276e8a77274fd870aac6
Reviewed-on: https://gerrit.instructure.com/3800
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Zach Wily <zach@instructure.com>
2011-05-24 10:23:50 -06:00
Brian Palmer 04d36dcdf5 support batch mode for sis imports, refs #4397
In this mode, any courses, sections or enrollments that aren't
referenced in the sis import will be deleted.

This is the back-end piece, support in the UI and API are coming next.

Change-Id: Ica634f9fa7008ef7b612c4ea43163792f5d54fa5
Reviewed-on: https://gerrit.instructure.com/3768
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: JT Olds <jt@instructure.com>
Reviewed-by: Zach Wily <zach@instructure.com>
2011-05-23 09:52:56 -06:00