this includes a fix for https://github.com/ruby-i18n/i18n/issues/639,
and thus we need to adjust a spec
Change-Id: I5b1425245f942dcdfdcfa34863ec43c1afe6ff0f
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/317518
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Ogata <aogata@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
Include the auto_subscribe value in the response from all endpoints
and support setting auto_subscribe in update/bulk_update endpoints.
Supported when the auto_subscribe_account_calendars is enabled.
closes LS-3982
flag = auto_subscribe_account_calendars
Test plan:
- Enable the feature flag
- PUT /api/v1/account_calendars/<account_id> with a combination of
`visible` and `auto_subscribe` params
- Expect the attributes to be updated accoringly
- Expect `auto_subscribe` to be present in the response body
- PUT /api/v1/accounts/<account_id>/account_calendars with a body
like:
[{"id": 1, "visible": true, "auto_subscribe": false},
{"id": 13, "visible": false, "auto_subscribe": true}]
- Expect attributes to be updated accordingly
- Disable the FF and repeat the above process
- Expect only the `visible` attribute to be updated and for the
`auto_subscribe` value to not appear in the response
Change-Id: I68dc8cafd5e3e54991bbee67e005f0161f2759d0
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/317213
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jonathan Guardado <jonathan.guardado@instructure.com>
QA-Review: Jonathan Guardado <jonathan.guardado@instructure.com>
Product-Review: Jackson Howe <jackson.howe@instructure.com>
refs INTEROP-7865
why
To prepare LTI tools to work in NQ, we need them to send messages to the
NQ window (as opposed to NQ's parent, Canvas). This will allow NQ to
implement messages needing access to a specific frame, while bubbling
other message to Canvas.
Change-Id: I2cafbec2b956c8c21a3fc19345100a2464295532
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/312981
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Xander Moffatt <xmoffatt@instructure.com>
QA-Review: Xander Moffatt <xmoffatt@instructure.com>
Product-Review: Paul Gray <paul.gray@instructure.com>
why:
* it was sending "production" always
* I want to be able to partition between prod and beta in Datadog
refs INTEROP-7143
flag=none
test plan
* specs
Change-Id: Ie466b5b465db889f5103795bf7d1ea1b6987cd69
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/317445
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Steve Mcgee <steve.mcgee@instructure.com>
QA-Review: Xander Moffatt <xmoffatt@instructure.com>
Product-Review: Xander Moffatt <xmoffatt@instructure.com>
why:
* DeveloperKey.enable_external_tools! used the
Lti::ToolConfiguration#privacy_level method while turning a dev key on
to set the tool's privacy level back to its correct state
* however, an old bug meant the privacy_level column is unused and is
always nil, and the ToolConfiguration internally uses
`canvas_extensions["privacy_level"]` instead
* this is a quick fix to get the desired behavior, and the followup work
is to correctly set the privacy_level column, backfill it for all
existing records, and then always reference it
closes INTEROP-7913
flag=none
test plan:
* create or use an existing LTI 1.3 developer key, and install it in a
context
* get a reference to this ContextExternalTool in a rails console
* `tool.privacy_level` should be `public`
* without this commit checked out:
* in the developer keys UI, turn the key Off, then On again
* `tool.reload.privacy_level` will be `anonymous`, which is wrong
* with this commit checked out:
* toggle the dev key Off then On again
* `tool.reload.privacy_level` should correctly be `public` again
Change-Id: I9d11d31a81fc7acd02da308234892a36b8604e51
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/316908
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Paul Gray <paul.gray@instructure.com>
QA-Review: Paul Gray <paul.gray@instructure.com>
Product-Review: Paul Gray <paul.gray@instructure.com>
so that switchman can tranpose the sub-queries
refs AE-164
Change-Id: I0bb0be10cd7c47126767d94e0bdb83cd0b3d16bf
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/316973
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
allowing overriding any gem, and passing through any other arguments
Change-Id: I839716268cc2eee980e0c790cc7271132d283c03
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/317441
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
and remove now-duplicated config
also fix a few offenses that snuck in due to code review race conditions
as part of this, Rubocop was loading the lockfile, so our "clever" rubocop
binstub had to be adjusted to use a lockfile. this allows us to commit the
lockfile, which I then also updated the sync_lockfiles script to handle
this one as well
flag = none
test plan: N/A
Change-Id: I20ee2672c5219a40e90bc1138f8900a8d2ce08ee
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/317373
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
Build-Review: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
closes MAT-1265
flag=none
test plan:
-have some media tracks without attachment ids
-have multiple media tracks with the same locale and
media object id and no attachment id
-run the migration and ensure that it does what
is expected
qa risk: low/medium
Change-Id: I597141d7757557f844a8d65bfb76060f34769366
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/315984
Migration-Review: Cody Cutrer <cody@instructure.com>
Reviewed-by: Mysti Lilla <mysti@instructure.com>
QA-Review: Mysti Lilla <mysti@instructure.com>
Product-Review: Jake Oeding <jake.oeding@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
fixes VICE-3244
flag=none
test plan:
- Specs pass.
- Enroll a user in a course and note his ID.
- As a teacher, create a new Announcement (or
anything else that will trigger a notification).
- Notification should be sent, you can verify on
/users/[ID]/messages
- As an admin, go to /users/[ID] and click on Suspend User.
- Try creating another announcement.
- Notification shouldn't be sent.
qa risk: low
Change-Id: Ia8a484901c76391c92f6d3f4e51a9046426b0f87
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/316576
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Chawn Neal <chawn.neal@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Caleb Guanzon <cguanzon@instructure.com>
closes LS-3985
flag=auto_subscribe_account_calendars
test plan:
- have a user enrolled in courses in 2 sub-accounts
- have account calendars turned on in both sub-accounts
- set sub_account2.account_calendar_subscription_type = 'auto'
- load /calendar as the user
> expect to sub_account2's calendar in the sidebar
- have the user add sub_account1's calendar
- refresh the page
> expect both sub-account calendars to show up
Change-Id: Ide72c02a0b51d11df7c9c0cdef6e8d640bf1822b
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/317135
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jackson Howe <jackson.howe@instructure.com>
QA-Review: Jackson Howe <jackson.howe@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
Jenkins