Commit Graph

1 Commits

Author SHA1 Message Date
Jeremy Stanley 29fdaf4f92 redesign and simplify error pages
fixes ADMIN-2336

test plan:
 - create a page in a course that links to the following:
   * a file that has been deleted
   * a file with an invalid id
   * a resource (file, assignment, etc.) that is unpublished
   * a resource that is in a different course (most easily done
     by changing the course id in the link in the html)
 - as a student, click these links and ensure the pages you
   see look like the mockups in ADMIN-2331.
   - in all of these cases,
     * there is a centered image
       - this image is not read by screen readers,
         since it is purely decorative
     * there is not a red box
     * there is not a link to contact support
   - for the deleted file, you should see "Page Not Found" and
     a note that the file has been deleted
   - for other links to nonexistent items, you should just see
     "Page Not Found"
   - for unpublished items, you should see "Not Yet Available"
     and a locked document picture
   - for items in a different course (that the student is not
     enrolled in), you should see "Access Denied" and a lock picture
 - also test the new 400 and 500 error pages. the easiest way to
   do this is with the /test_error endpoint:
   - /test_error?status=400
   - /test_error?status=500
   - these show the broken rocket picture and still include
     a support link

Change-Id: I9f20e742e690482887cf375c79e4060aff6d7146
Reviewed-on: https://gerrit.instructure.com/178581
Tested-by: Jenkins
Reviewed-by: Ed Schiebel <eschiebel@instructure.com>
Reviewed-by: Carl Kibler <ckibler@instructure.com>
QA-Review: Carl Kibler <ckibler@instructure.com>
Product-Review: Kyle Follett <kfollett@instructure.com>
2019-01-31 17:50:29 +00:00