Trigger the selenium build so we can watch for issues and flaky
specs. Skips a few flaky specs with jira tickets to come. Set
reruns to 2 so we can rule out any minor flaky specs.
rspec-tests.sh and rspec-with-retries.sh removed nounset and all logging
for rspec-with-retries.sh.
fixes: CCI-126
flag = none
Test plan:
Selenium builds are triggered with each ps from the main-canvas build.
Change-Id: I504e1b158e1c85e9c137a5b5757be101207420d0
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/219425
Tested-by: Jenkins
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Rex Fleischer <rfleischer@instructure.com>
Reviewed-by: Robert Lamb <rlamb@instructure.com>
QA-Review: James Butters <jbutters@instructure.com>
Product-Review: James Butters <jbutters@instructure.com>
the current defalut window-size is so small it causes
flakiness with specs and is smaller than what a
real user would be using. Changed to use window
size 1680x1050 using selenium methods rather than
the custom javascript stuff we have currently.
Change-Id: Ie6b31540e6cd1ba7d1f561fb2ea5f35e8a041c22
Reviewed-on: https://gerrit.instructure.com/212239
Tested-by: Jenkins
Reviewed-by: S. Jacob Powell <spowell@instructure.com>
QA-Review: James Butters <jbutters@instructure.com>
Product-Review: James Butters <jbutters@instructure.com>
the scroll is causing issues. Adding make_full_screen
removes the need for the scroll and makes the spec
more stable.
Change-Id: I91059baf41d9a9b1ceadcb373e2638742aaa6191
Reviewed-on: https://gerrit.instructure.com/210989
Tested-by: Jenkins
Reviewed-by: Anju Reddy <areddy@instructure.com>
QA-Review: James Butters <jbutters@instructure.com>
Product-Review: James Butters <jbutters@instructure.com>
refs ADMIN-2277
test plan:
- Do some spot checking all around, esp. on newer stuff written with
InstUI
- Do some specific spot checking on:
- Assignments edit page. Esp. with moderated grading
- Gradebook late policies
- Check the original bug (ADMIN-2211)
Change-Id: Iaaaeb9d86dc2d59cb2c9ccca2a8764a5adb0896b
Reviewed-on: https://gerrit.instructure.com/176912
Tested-by: Jenkins
Reviewed-by: Anju Reddy <areddy@instructure.com>
QA-Review: Steven Burnett <sburnett@instructure.com>
Product-Review: Steven Burnett <sburnett@instructure.com>
Closes: CORE-1697
Test plan:
* do a basic regression test of things that use instUI components.
Specifically: the new developer keys page and the gradebook grade
details tray since those had the most specs that needed to be fixed
* do a basic regression test of the a11y checker to make sure the
instUI components work the same as before
Change-Id: Ie88c4fc1b01eadeecceb7536944da986e37bf3dd
Reviewed-on: https://gerrit.instructure.com/156473
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Tested-by: Jenkins
QA-Review: Tucker McKnight <tmcknight@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
Update: Copyright years now reflect the year that the file was first
committed.
Refs: PLAT-3200
Test Plan: jenkins is still happy and specs pass!!
Change-Id: Ic26463defe41fc52cf4da8020976394c641f51d5
Reviewed-on: https://gerrit.instructure.com/143545
Tested-by: Jenkins
Reviewed-by: Weston Dransfield <wdransfield@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Stewie aka Nicholas Stewart <nstewart@instructure.com>
There is also other stuff by request of product such as
default value for position setting and UI changes
fixes COMMS-241
Test Plan
* Go to pages that have group contents like assignments
* Go through the process of moving the item through
the menu
* Notice how there is a new move contents selection
* Enjoy the awesomeness of moving
Change-Id: I4e0f83f1069add63d9505eac6f1534cbeb856791
Reviewed-on: https://gerrit.instructure.com/131759
Reviewed-by: Felix Milea-Ciobanu <fmileaciobanu@instructure.com>
Tested-by: Jenkins
QA-Review: Heath Hales <hhales@instructure.com>
Product-Review: Kyle Follett <kfollett@instructure.com>
refs COMMS-184 COMMS-181
test plan:
- in a course with multiple students, navigate to the people page
- click on the groups tab and create a group set with multiple groups
- add some students to a group
- from the cog menu for a student in a group, select the "move" option
- select a new group from the dropdown in the move tray
- ensure the user move to that group once you click done
- focus should return to the heading of the student's old group
- when you refresh the page, the student should remain in that group
- ensure the other "move to" uses were not broken by refactoring:
- on assignments page, move assignments and move assignment groups
- on modules page, move modules and module items
- on the discussions page, move pinned discussions
- on the course settings nav tab, move navigatio items
Change-Id: I2ebbb67b1e4827483766fdd2955f8f5fef2a39c3
Reviewed-on: https://gerrit.instructure.com/129612
Tested-by: Jenkins
Reviewed-by: Aaron Kc Hsu <ahsu@instructure.com>
QA-Review: Aaron Kc Hsu <ahsu@instructure.com>
Product-Review: Felix Milea-Ciobanu <fmileaciobanu@instructure.com>
Fixes: CNVS-34740
Test plan:
- Go to [any course] > People > + Group Set
- Cancel out of the modal
- If you need to, adjust your Canvas settings (or just comment out
the logic in the Handlebars files), so you can see the page with
the search bar, and the self-sign-up and group limit messages showing.
- With this commit, the layout should look as follows and no longer
break when the group limit message is displayed:
- Phone breakpoint: https://www.screencast.com/t/sMGXxVKb
- Tablet breakpoint: https://www.screencast.com/t/Q0e0b9QVS
- Desktop breakpoint: https://www.screencast.com/t/RJPnfBNZ84E
Change-Id: Iba8b906fb5a4108ffea019f650960d3d86bfff87
Reviewed-on: https://gerrit.instructure.com/101954
Tested-by: Jenkins
Reviewed-by: Stephen Jensen <sejensen@instructure.com>
QA-Review: Dan Sasaki
Product-Review: Chris Hart <chart@instructure.com>
fixes SD-1147
now if you nest any waiting matchers/helpers in a keep_trying_until,
you'll get an error. the eventual goal is to remove keep_trying_until
and wait_for_ajaximations entirely
misc enhancements:
* make `be_displayed` wait
* add `have_size` matcher for ff and friends that will automatically
wait (and reload)
* remove not_found because it was slow
* make in_frame a little smarter
* add various helpers, e.g.
* dismiss_flash_messages
* scroll_into_view
* scroll_element
Change-Id: Ib5fc27ed72b14ca9453e3c3d57a37c8633843faa
Reviewed-on: https://gerrit.instructure.com/80257
Reviewed-by: Landon Wilkins <lwilkins@instructure.com>
Product-Review: Landon Wilkins <lwilkins@instructure.com>
QA-Review: Landon Wilkins <lwilkins@instructure.com>
Tested-by: Jenkins
fixes SD-1063, speeds up :allthethings:
negative DOM assertions are 💩, but if we must have them, make them
more tolerable. the old way:
expect(f(".something-that-should-be-gone")).to be_nil
expect(fj("buhleeted:visible")).to be_nil
expect(fln("Can't Click Here Anymore").to be_nil
the new way:
expect(container).not_to contain_css(".something-that-should-be-gone")
expect(container).not_to contain_jqcss("buhleeted:visible")
expect(container).not_to contain_link("Can't Click Here Anymore")
(you can of course use these new matchers for positive assertions as well)
although it's a tad more verbose, the new way is better because:
1. it's smart enough to bail once the assertion is met (versus the old way
which would take 10-20 seconds to not find the thing and *then* run the
assertion)
2. it requires them to be scoped, to reduce the likelihood of false
positives (e.g. if the page is totally broken, then of course the
assertion would pass)
also reworked the various flash message assertions... see the new
expect_flash_message and expect_no_flash_message
this should remove over an hour of linear time off the build (10 sec per
old assertion, except fj ones which took 20 sec)... so like a minute of
actual time, cuz parallelization :P
a consequence of this change is that f/fj/ff/ffj now raise if nothing is
found, so you really have to go out of your way to do it the bad way. so
don't :)
Change-Id: I0fe6e8500947c27d748b70bb2cda585edf71e427
Reviewed-on: https://gerrit.instructure.com/78420
Tested-by: Jenkins
Reviewed-by: Landon Wilkins <lwilkins@instructure.com>
Product-Review: Landon Wilkins <lwilkins@instructure.com>
QA-Review: Landon Wilkins <lwilkins@instructure.com>
- reasoning: this group contains set-up and teardown,
it does not include 'it' blocks
Change-Id: I1803420a5c7f59246f3af211e42ced808a994c3f
Reviewed-on: https://gerrit.instructure.com/60329
Tested-by: Jenkins
Reviewed-by: Matt Fairbourn <mfairbourn@instructure.com>
Product-Review: Matt Fairbourn <mfairbourn@instructure.com>
QA-Review: Matt Fairbourn <mfairbourn@instructure.com>
test plan:
* create a course with "Let students organize their own groups"
enabled
* add some students to the course
* as a student, visit the groups page and open the dialog
to create a group
* should be able to invite other users into the group
on creation
closes #CNVS-17916
Change-Id: I5c40cc88b39be6040b423b8ee24aa4166b2917a6
Reviewed-on: https://gerrit.instructure.com/48200
Tested-by: Jenkins
Reviewed-by: Joel Hough <joel@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
Delete some tests around old groups
Fixes CNVS-17547
Test plan:
1) As an admin, visit the account settings page, click on the
'Feature Options' tab, and see that the ' New Student Groups Page'
feature is 'ENABLED' and does not have the 'beta' label
2) As a student, visit the groups page for a course, and see that
you are shown the new groups page.
Change-Id: I0a809fb1fedba020112d4214ab0859418283f023
Reviewed-on: https://gerrit.instructure.com/45983
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Brad Horrocks <bhorrocks@instructure.com>
Reviewed-by: Mark Severson <markse@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Product-Review: Matthew Wheeler <mwheeler@instructure.com>
Robert Lamb