ylqjgm
/
canvas-lms
mirror of https://github.com/instructure/canvas-lms.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
49,827 Commits 324 Branches 20,019 Tags 1.7 GiB
Commit Graph

164 Commits

Author SHA1 Message Date
Davis Hyer 9fb5c79848 expect correct prop type for CancelAttemptButton 
refs LS-3017
flag=none

Shape is not a valid prop type, but rather a function that returns a
valid prop type. Since no shape was being defined, requiring a simple
object seemed more appropriate.

test plan:
  - tests pass

qa risk: low

Change-Id: I10d6743669c3138d6426a455868f5af1c33722fe
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/286330
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
 2022-03-04 16:44:52 +00:00
Davis Hyer 811f3b838f mock additional k5 requests 
refs LS-3017
flag=none

These warnings were not causing tests to fail for some reason. I wasn't
able to pin the reason down, my suspicion is that fetch-mock uses an
internal logging mechanism.

test plan:
  - run `yarn test:jest ui/features/k5_`
    - there should be no console output regarding unmatched requests

qa risk: low

Change-Id: I4e8eb876571ca74eb0b2edef6a62640387f15a15
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/286391
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
 2022-03-04 16:44:44 +00:00
Davis Hyer c8d8efe784 ignore package translations in jest 
refs LS-3017
flag=none

test plan:
  - tests pass

qa risk: low

Change-Id: I8da0db910b0647405f27b04c1f9c143b35126f70
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/286184
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
 2022-03-04 15:39:06 +00:00
Davis Hyer 65a1e1700f provide errors type for gql mocks 
refs LS-3017
flag=none

test plan:
  - tests pass

qa risk: low

Change-Id: If7cf0e4e2ed5810d686efa189bbc8be811d3b94a
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/286183
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
 2022-03-02 23:57:03 +00:00
Davis Hyer 4bff7f75a0 provide proper outcomes context for rootId prop validation 
refs LS-3017
flag=none

test plan:
  - tests pass

qa risk: low

Change-Id: I87b73fea2ced38d3f5e80da2b0fd75b5e25cc016
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/286071
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
 2022-03-02 21:47:12 +00:00
Davis Hyer bbe2edc991 move select value from option to select 
refs LS-3017
flag=none

test plan:
  - tests pass

qa risk: low

Change-Id: Ia52680b0e2b5c277f6078ea19737c7107985abfb
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/286069
Reviewed-by: Ahmad Amireh <ahmad@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
 2022-03-01 16:55:05 +00:00
Davis Hyer afac4e90a0 provide required moduleItem gql type 
refs LS-3017
flag=none

test plan:
  - tests pass

qa risk: low

Change-Id: Ib823b0533e6126346adc14c76a2880eaff01f96a
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/286070
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
 2022-03-01 16:30:36 +00:00
Davis Hyer ca1312866e remove isLoading prop validation suppression 
refs LS-3017
flag=none

test plan:
  - tests pass

qa risk: low

Change-Id: I0b7c7b3e81e0d22fc943bfdad814c75de0e15dcc
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/286052
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
 2022-03-01 00:46:40 +00:00
Davis Hyer 5ecc77e664 fix modalProps.onDismiss error 
refs LS-3017
flag=none

test plan:
  - tests pass

qa risk: low

Change-Id: I7643eef56da11a29579b5ff579b2d4beeb2710de
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/286051
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
 2022-02-28 22:17:27 +00:00
Davis Hyer 1b1b632b30 remove generic deprecation warning suppression 
refs LS-3017
flag=none

Appears to have been fixed by another effort

test plan:
  - tests pass

qa risk: low

Change-Id: I813b110939764300815085ef5f127cd331a7ffca
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/286049
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
 2022-02-28 22:07:28 +00:00
Davis Hyer 7d1e30fcbf fix waitForElement deprecation warning 
refs LS-3017
flag=none

[optional] any extra details that might be useful to add

test plan:
  - TODO

qa risk: low

Change-Id: I7233a9ccdb0238ea54e60b3285fa036be6fbe662
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/286044
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
 2022-02-28 18:56:10 +00:00
Davis Hyer a418b6f9ea replace deprecated toBeEmpty with toBeEmptyDOMElement 
flag=none

test plan:
  - tests pass

qa risk: low

Change-Id: I71810f19ccc4590b7c4ca70a92c86ebdb14c4043
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/286038
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
 2022-02-28 18:11:00 +00:00
Ahmad Amireh 901fffe9ef babel independence(3): jest 
refs FOO-2697
flag = none

on "babel-plugin-transform-imports": the behavior of this plugin was
surprising to me in that it not only rewrote the specifiers to point to
the CommonJS instead of the ESM variants, but it actually changed the
specifiers to point to the exact file that exports the symbol through a
mixture of fs globbing and guesses.

Consider the following import:

    import { DateTime } from '@instructure/ui-i18n'

Normally, you'd think we'll be loading the {main,module,browser} file of
the @instructure/ui-i18n package and refer to the `DateTime` symbol
exported by that file. With the plugin activated, however, the import
*itself* changes to:

    import DateTime from '@instructure/ui-i18n/lib/DateTime.js'

This is no longer merely a variant rewrite in any way as we're no longer
loading the same file. This caused new problems to surface that up to
this point were not encountered, as now we're actually loading the
entrypoints as specified.

An example of this is in that specific package where it (its entrypoint)
loads a package `decimal.js` whose ESM variant doesn't work as-is but
its CJS variant does -- something neither we nor the InstUI team were
privy to as the plugin was simply clobbering this piece of information.

~ test plan ~

- jest suite runs and passes

Change-Id: I55d7db1ede742e0f588a84d54a761b7aba03729f
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/283543
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Shafovaloff <ashafovaloff@instructure.com>
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Product-Review: Ahmad Amireh <ahmad@instructure.com>
 2022-02-09 17:20:24 +00:00
Caleb Guanzon 784829e593 add student anonymous discussions setting 
fixes VICE-2255
flag=discussion_anonymity

note 1: changing this settings will not persist
as the backend portion will happen in a different ticket

note 2: I had to put checkbox inside view even if
checkbox group wants only checkbox children because
it was the best way i can indent it. i added it to jest's
ignored errors

test pilan:
- with discussion redesign ff off but discussion anonymity ff on,
- visit discussion index page as a teacher
- verify that when you open the top right cog menu
- you do not see a Create anonymous discussion topics checkbox

- turn on both react discussions post and discussion anonymity ff's
- revisit index
- verify that cog menu checkbox has a Create anonymous discussion topics
checkbox
- verify that it is only enabled if parent Create discussion topics
is checked

Change-Id: I8fb22b10955d952a90d7c6c03c137cfa9a097ffd
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/278783
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Drake Harper <drake.harper@instructure.com>
QA-Review: Drake Harper <drake.harper@instructure.com>
Product-Review: Drake Harper <drake.harper@instructure.com>
 2021-11-18 22:58:19 +00:00
Drake Harper b2abd848f5 Fix error in UserLink 
flag=none

Test Plan:
 - specs pass

Change-Id: Idb7ca385f8626033679a76f9df134a75d1c046a8
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277562
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
 2021-11-08 15:42:56 +00:00
Drake Harper 7d721cbf66 Fix 'Cannot read property 'length' of null' 
flag=none

Test Plan:
 - specs pass

Change-Id: If298b7d628b4202abf6fac9c3109d5e26a474ee6
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277563
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
 2021-11-08 15:42:35 +00:00
Drake Harper 5876c888f7 Fix h4 passes to BillBoard headingAs prop 
flag=none

Test Plan:
 - specs pass

Change-Id: If0b5b243282dc39090931ff09c0f55c09b9fa4df
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277564
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
 2021-11-08 15:42:25 +00:00
Drake Harper 81f653edd8 Fix name is marked as required in Avatar 
flag=none

Test Plan:
 - specs pass

Change-Id: I0322d2287c08af1ab2e432b827b8b76dd2910193
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277498
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
 2021-11-05 18:11:32 +00:00
Drake Harper 773eb481df Fix activeMailbox is marked as required 
flag=none

test plan:
  - Specs pass

qa risk: low

Change-Id: I937b3de616175245f3f4940e5f4ab75ce64adb87
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277493
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
 2021-11-05 18:11:28 +00:00
Drake Harper e7d7990b91 Fix screenReaderLabel is marked as required 
flag=none

Test Plan:
 - specs pass

Change-Id: Iec9cfcd9ead0a2fd72a6d2fdab92237aa912657d
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277496
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Caleb Guanzon <cguanzon@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Caleb Guanzon <cguanzon@instructure.com>
 2021-11-05 18:04:40 +00:00
Omar Gerardo Soto-Fortuño 3a3cf7a6e6 Fix issue on MobileNavigation.test.js 
flag=none

test plan:
  - Specs pass

qa risk: low

Change-Id: I39b66fdc9f6b42f7c4f07ec8194b03acd3f2495b
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277473
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Drake Harper <drake.harper@instructure.com>
QA-Review: Drake Harper <drake.harper@instructure.com>
Product-Review: Drake Harper <drake.harper@instructure.com>
 2021-11-04 21:18:03 +00:00
Omar Gerardo Soto-Fortuño e0044c0170 Add avatarName to CoursesListRow.js 
flag=none

test plan:
  - Specs pass

qa risk: low

Change-Id: I941526af5273a0f6b01abf10eda88f9a526489b7
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277487
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Drake Harper <drake.harper@instructure.com>
QA-Review: Drake Harper <drake.harper@instructure.com>
Product-Review: Drake Harper <drake.harper@instructure.com>
 2021-11-04 21:17:47 +00:00
Omar Gerardo Soto-Fortuño bd88f59ab1 Fix issue on AddConference test 
flag=none

test plan:
  - Specs pass

qa risk: low

Change-Id: I7b101f46c0fe1043172e7050c2da134d9ad5e1a1
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277475
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Drake Harper <drake.harper@instructure.com>
QA-Review: Drake Harper <drake.harper@instructure.com>
Product-Review: Drake Harper <drake.harper@instructure.com>
 2021-11-04 21:17:38 +00:00
Omar Gerardo Soto-Fortuño 00d2af090d Remove StatusColorListItem error that isn't needed 
flag=none

test plan:
  - Specs pass

qa risk: low

Change-Id: I41da04e05c1bd7da23e1ddabaa597df2ac0ffd9e
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277444
Reviewed-by: Drake Harper <drake.harper@instructure.com>
QA-Review: Drake Harper <drake.harper@instructure.com>
Product-Review: Drake Harper <drake.harper@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
 2021-11-04 17:10:53 +00:00
Omar Gerardo Soto-Fortuño d6bb5170c1 Remove outcomeGroup.title error that isn't needed 
flag=none

test plan:
  - Specs pass

qa risk: low

Change-Id: Ibcd4c2eb70a4b0128190cf1c276f7d1f36edd4b8
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277452
Reviewed-by: Drake Harper <drake.harper@instructure.com>
QA-Review: Drake Harper <drake.harper@instructure.com>
Product-Review: Drake Harper <drake.harper@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
 2021-11-04 17:10:42 +00:00
Omar Gerardo Soto-Fortuño 16652e106f Remove Gradebook|ScoresGrid error that isn't needed 
flag=none

test plan:
  - Specs pass

qa risk: low

Change-Id: I9b0817cd7d887fc7ebcfea17330c73fe6f2e32c4
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277431
Reviewed-by: Drake Harper <drake.harper@instructure.com>
QA-Review: Drake Harper <drake.harper@instructure.com>
Product-Review: Drake Harper <drake.harper@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
 2021-11-04 15:47:28 +00:00
Omar Gerardo Soto-Fortuño 7bdbb53df3 Remove HomeroomAnnouncementsLayout|LoadingWrapper error that isn't needed 
flag=none

test plan:
  - Specs pass

qa risk: low

Change-Id: I06f16b79589751a675b683ca64615dd4c2c41045
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277434
Reviewed-by: Drake Harper <drake.harper@instructure.com>
QA-Review: Drake Harper <drake.harper@instructure.com>
Product-Review: Drake Harper <drake.harper@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
 2021-11-04 15:47:08 +00:00
Omar Gerardo Soto-Fortuño cc89c3a6f2 Fixes on studentMocks.js 
flag=none

test plan:
  - Specs pass

qa risk: low

Change-Id: Ide5410396bf2c3e87bddc48d2e8b69df40e7bf8b
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277432
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Drake Harper <drake.harper@instructure.com>
QA-Review: Drake Harper <drake.harper@instructure.com>
Product-Review: Drake Harper <drake.harper@instructure.com>
 2021-11-04 15:46:47 +00:00
Omar Gerardo Soto-Fortuño 93ae132983 Remove other CanvasContentTray error that isn't needed 
flag=none

test plan:
  - Specs pass

qa risk: low

Change-Id: I5a7988c0ece517fcb5d7adff2f731e4005edcc19
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277439
Reviewed-by: Drake Harper <drake.harper@instructure.com>
QA-Review: Drake Harper <drake.harper@instructure.com>
Product-Review: Drake Harper <drake.harper@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
 2021-11-04 15:46:34 +00:00
Omar Gerardo Soto-Fortuño 13ae8a62d8 Remove CanvasContentTray error that isn't needed 
flag=none

test plan:
  - Specs pass

qa risk: low

Change-Id: I62592d42fd9a1a0f6dd76e1f439f765dcde081d2
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277437
Reviewed-by: Drake Harper <drake.harper@instructure.com>
QA-Review: Drake Harper <drake.harper@instructure.com>
Product-Review: Drake Harper <drake.harper@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
 2021-11-04 15:46:24 +00:00
Omar Gerardo Soto-Fortuño 6e439c0f46 Fixes on Scopes.test.js 
flag=none

test plan:
  - Specs pass

qa risk: low

Change-Id: I77e182eb8c6afdb65c4f762ce86a78967efb4fda
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277355
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Drake Harper <drake.harper@instructure.com>
QA-Review: Drake Harper <drake.harper@instructure.com>
Product-Review: Drake Harper <drake.harper@instructure.com>
 2021-11-03 18:51:15 +00:00
Omar Gerardo Soto-Fortuño be4de1c4a9 Fix issue on ActionButtons.test.js 
flag=none

test plan:
  - Specs pass

qa risk: low

Change-Id: Ieee854eaad959c57983437ca86908c221cdfcb42
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277345
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Drake Harper <drake.harper@instructure.com>
QA-Review: Drake Harper <drake.harper@instructure.com>
Product-Review: Drake Harper <drake.harper@instructure.com>
 2021-11-03 18:04:00 +00:00
Omar Gerardo Soto-Fortuño 1000057511 Fix issue on MessageListActionContainer.test.js 
flag=none

test plan:
  - Specs pass

qa risk: low

Change-Id: Icbb4ed087b68c9b0ff2f05e23f015e06fe7951d3
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277343
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Drake Harper <drake.harper@instructure.com>
QA-Review: Drake Harper <drake.harper@instructure.com>
Product-Review: Drake Harper <drake.harper@instructure.com>
 2021-11-03 18:03:47 +00:00
Omar Gerardo Soto-Fortuño e3820d60bb Remove PermissionTray error that isn't needed 
flag=none

test plan:
  - Specs pass

qa risk: low

Change-Id: I02d7e0bddbf0afbcf4a1e6ea5bd96248bcac6d46
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277340
Reviewed-by: Drake Harper <drake.harper@instructure.com>
QA-Review: Drake Harper <drake.harper@instructure.com>
Product-Review: Drake Harper <drake.harper@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
 2021-11-03 18:03:32 +00:00
Omar Gerardo Soto-Fortuño 94c5e42ba8 Fix missing attributes on StudentOutcomeScore.test.js 
flag=none

test plan:
  - Specs pass

qa risk: low

Change-Id: Ibccc31b1937c9463e3dcc009f9f3c8e0fc5136c5
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277292
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Drake Harper <drake.harper@instructure.com>
QA-Review: Drake Harper <drake.harper@instructure.com>
Product-Review: Drake Harper <drake.harper@instructure.com>
 2021-11-03 18:03:21 +00:00
Omar Gerardo Soto-Fortuño 9a4d5cd7ee Remove StudentOutcomeScore error that isn't needed 
flag=none

test plan:
  - Specs pass

qa risk: low

Change-Id: Iee41f20f3d3f1195cbd8ca72658b22164584ec80
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277290
Reviewed-by: Drake Harper <drake.harper@instructure.com>
QA-Review: Drake Harper <drake.harper@instructure.com>
Product-Review: Drake Harper <drake.harper@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
 2021-11-03 12:21:20 +00:00
Omar Gerardo Soto-Fortuño 99867afd89 Remove Gradebook error that isn't needed 
flag=none

test plan:
  - Specs pass

qa risk: low

Change-Id: I0ce651f6f05fc8ea5c80f9ad01a18df0b3aad8de
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277287
Reviewed-by: Drake Harper <drake.harper@instructure.com>
QA-Review: Drake Harper <drake.harper@instructure.com>
Product-Review: Drake Harper <drake.harper@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
 2021-11-02 18:53:12 +00:00
Omar Gerardo Soto-Fortuño cc65b893bc Fix missing ids on people_search.spec.js 
flag=none

test plan:
  - Specs pass

qa risk: low

Change-Id: I2e4c00ba9c66804d74cb30550f70c8fe909b3763
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277186
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Drake Harper <drake.harper@instructure.com>
QA-Review: Drake Harper <drake.harper@instructure.com>
Product-Review: Drake Harper <drake.harper@instructure.com>
 2021-11-02 18:52:49 +00:00
Omar Gerardo Soto-Fortuño ea590876ea Remove RubricTab error that isn't needed 
flag=none

test plan:
  - Specs pass

qa risk: low

Change-Id: Ie88893070e812bcd95c3f599f938d5d2b9aefdd9
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277251
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Drake Harper <drake.harper@instructure.com>
QA-Review: Drake Harper <drake.harper@instructure.com>
Product-Review: Drake Harper <drake.harper@instructure.com>
 2021-11-02 18:12:34 +00:00
Omar Gerardo Soto-Fortuño cb8f2da2d2 Fix issue on SVGWithTextPlaceholder.test.js 
flag=none

test plan:
  - Specs pass

qa risk: low

Change-Id: I072a65e2e94a6f84a9b3bfff969831c9188a643b
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277198
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Drake Harper <drake.harper@instructure.com>
QA-Review: Drake Harper <drake.harper@instructure.com>
Product-Review: Drake Harper <drake.harper@instructure.com>
 2021-11-02 18:12:22 +00:00
Omar Gerardo Soto-Fortuño a6e831b6bc Add missing mastery to test files 
flag=none

test plan:
  - Specs pass

qa risk: low

Change-Id: Ic7e2fd51927fa9620f226ea91175760eef0525cb
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277256
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Drake Harper <drake.harper@instructure.com>
QA-Review: Drake Harper <drake.harper@instructure.com>
Product-Review: Drake Harper <drake.harper@instructure.com>
 2021-11-02 16:07:00 +00:00
Omar Gerardo Soto-Fortuño 57e84ebdca Remove Rubric error that isn't needed 
flag=none

test plan:
  - Specs pass

qa risk: low

Change-Id: Icb0066744675c2c2cc254ec86e66f61479255ad7
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277254
Reviewed-by: Drake Harper <drake.harper@instructure.com>
QA-Review: Drake Harper <drake.harper@instructure.com>
Product-Review: Drake Harper <drake.harper@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
 2021-11-02 16:06:30 +00:00
Omar Gerardo Soto-Fortuño 5a3425c504 Remove Rubric error that isn't needed 
flag=none

test plan:
  - Specs pass

qa risk: low

Change-Id: I82cecfe4905cea3d6b9ed0bd6eecc04bc3624649
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277209
Reviewed-by: Drake Harper <drake.harper@instructure.com>
QA-Review: Drake Harper <drake.harper@instructure.com>
Product-Review: Drake Harper <drake.harper@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
 2021-11-02 16:04:30 +00:00
Omar Gerardo Soto-Fortuño b37ce854f3 Fix missing value on examples.js 
flag=none

test plan:
  - Specs pass

qa risk: low

Change-Id: If48d470b51d92e22bc3c5ea26a311d04eda366f1
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277200
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Drake Harper <drake.harper@instructure.com>
QA-Review: Drake Harper <drake.harper@instructure.com>
Product-Review: Drake Harper <drake.harper@instructure.com>
 2021-11-02 16:03:58 +00:00
Omar Gerardo Soto-Fortuño c32c54a887 Remove RCEWrapper error that isn't needed 
flag=none

test plan:
  - Specs pass

qa risk: low

Change-Id: If8fe48b2b82d6b31a12c3dcc6900abb7e096f419
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277191
Reviewed-by: Drake Harper <drake.harper@instructure.com>
QA-Review: Drake Harper <drake.harper@instructure.com>
Product-Review: Drake Harper <drake.harper@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
 2021-11-02 16:02:53 +00:00
Omar Gerardo Soto-Fortuño f7317bf0b1 Add missing userId to a few tests 
flag=none

test plan:
  - Specs pass

qa risk: low

Change-Id: Iec4614be0784b0f363c579d68dd077d7ec6ac056
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277188
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Caleb Guanzon <cguanzon@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Caleb Guanzon <cguanzon@instructure.com>
 2021-11-01 15:10:07 +00:00
Ahmad Amireh 5f976f9989 rename frontend_build -> ui-build 
minor QOL mainly for me; put webpack-specific configuration in its own
folder, make it portable, and make room for esbuild

the __webpack_public_path__ initializer no longer sources the value from
the build module, instead it uses a pre-defined global that webpack
injects

~ test plan ~

build is OK

Change-Id: I4ba4a3c0cb9175f96096f2b78022e152c04fc75d
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276183
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Charley Kline <ckline@instructure.com>
QA-Review: Charley Kline <ckline@instructure.com>
Product-Review: Charley Kline <ckline@instructure.com>
 2021-10-21 19:13:02 +00:00
Jeff Largent 67ecc41b76 Suppress JSDOM scrollTo and navigation error messages 
This change stubs window.scrollTo and several window navigation
functions (window.location = '...', window.location.href = '...', and
window.location.reload()) with noops to suppress JSDOM messages
warning that these functions aren't implemented. E.g. these ones:

Error: Not implemented: scrollTo
Error: Not implemented: navigation (except hash changes)

While potentially useful if you're expecting those browser APIs to
work in a JSDOM environment, they noise up our Jest logs real good.

Test plan:
  - Tests still pass

Change-Id: I9166d0ee05273cc07069b62a1a041eeb335fbfe6
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/275919
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Robin Kuss <rkuss@instructure.com>
Reviewed-by: Charley Kline <ckline@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Jeff Largent <jeff.largent@instructure.com>
 2021-10-14 21:02:13 +00:00
Robin Kuss 007be5c609 spec: fix canReadAnnouncements missing in K5Dashboard test 
Closes LS-2731

Test Plan: Does not emit error/warning now in Jenkins

Change-Id: Iccb58891d23f521acfe3b5ff78deb9c32269b7c2
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/275882
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jeff Largent <jeff.largent@instructure.com>
QA-Review: Jeff Largent <jeff.largent@instructure.com>
Product-Review: Robin Kuss <rkuss@instructure.com>
 2021-10-14 12:05:57 +00:00
Ed Schiebel e9afcfcce3 Remove rce_enhancements flag from canvas - phase 1 
refs LS-2655
flag=none

- this updates the files under ./ui, a few ancillary files and specs.
- Sadly the commit hook ran prettier and
  fiddled with the formatting of a handful of files too.
- Also made a few changes to quiet lint errors
- Also updated OutcomeManagement.test.js. I don't understand why,
  but 'renders ManagementHeader with lhsGroupId if selected a group in lhs'
  started failing with this change, even though nothing obviously related
  changed. The problem is that the modal isn't getting attached to the
  document being tested. The spec changed to test that the modal contained
  what it's supposed to contain.

test plan: jenkins passes and the RCE works

Change-Id: I48d85077bdbf7563cb07510d3e71d2b448c55e49
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/275301
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Weston Dransfield <wdransfield@instructure.com>
QA-Review: Weston Dransfield <wdransfield@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
 2021-10-08 16:59:19 +00:00