fixes FOO-3978
flag = none
test plan:
- go to welcome tour
- click on the video links
- make sure they go to the correct working videos on Studio
Change-Id: I4dae322f8b00cdfc8092a8c09638f6ba5dceb3ef
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/331173
Reviewed-by: Michael Hulse <michael.hulse@instructure.com>
Reviewed-by: Aaron Shafovaloff <ashafovaloff@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: August Thornton <august@instructure.com>
why:
- To remove FF cruft
- To simplify the code. We were using errors to redirect on missing
scopes, but explicitly redirecting for all other oauth param issues,
which was confusing. We don't do that anymore.
closes INTEROP-7446
flag=none
test-plan:
- The tests cover all of these cases, as there should be no user/API
changes, just code removal/simplification.
Change-Id: I1a5e1f6e07e517d936748fc41a38dd2e7ee8f49d
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/330832
Reviewed-by: Tucker Mcknight <tmcknight@instructure.com>
QA-Review: Tucker Mcknight <tmcknight@instructure.com>
Product-Review: Ryan Hawkins <ryan.hawkins@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Start theme overriding global CSS on new SideNav
closes FOO-3885
closes FOO-3937
flag=instui_nav
test plan:
- Log in to Canvas as an Admin
- Go to RootAccount > Settings > Feature Options >
Enable New InstUI NavBar
Change-Id: I44de95190bab61fc29d542b7fc599f0aec0acf9e
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/331107
QA-Review: Gustavo Bernardes <gustavo.bernardes@instructure.com>
Product-Review: Gustavo Bernardes <gustavo.bernardes@instructure.com>
Reviewed-by: Aaron Shafovaloff <ashafovaloff@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
to specify the (singular) key you will operate on, so address
a specific node when it's a distributed redis client
Change-Id: I9c4c0ab7114ea491439b42e4f4310f81470422a7
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/331131
Reviewed-by: Aaron Ogata <aogata@instructure.com>
Build-Review: Aaron Ogata <aogata@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
closes LF-759, LF-760, LF-761
flag= differentiated_modules
qa risk: low
test plan:
In a course with some modules
Click on the + Module button
Expect the new tray to be open with all the inputs empty
Expect to see Add Module in the header and as the label for the
primary button
Expect not to see the Assign To tab
Try to save the module without the name
Expect not to be allowed and an alert to appear
Fill in the module information and save the module
Expect the module to be added to the DOM
Edit the created module
Expect the module to be editable and the settings you saved to be
shown when you try to edit the new module.
Change-Id: I56ae74d2af87cefa4510ee8e67e0ce9146b3a1fb
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/330515
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Jonathan Guardado <jonathan.guardado@instructure.com>
Reviewed-by: Jake Oeding <jake.oeding@instructure.com>
QA-Review: Jake Oeding <jake.oeding@instructure.com>
because writing to the shadow record is deprecated, and the
primary record might not be deleted. instead follow the
code path where a non-deleted clash exists and generate a
new random lti_context_id
test plan: specs
flag=none
fixes CANVAS-MDMF
fixes CANVAS-MAEC
fixes CANVAS-MAH9
fixes CANVAS-MAGM
Change-Id: Ic511d0bad3a90b1299fca5ed5944125b91f6ecfe
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/330990
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: August Thornton <august@instructure.com>
QA-Review: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
refs AE-563
this change still allows multiple shards to be queried for
each context in the account chain
Change-Id: I74df653793328a627ddf0c4ef6ec1fa412a87acd
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/331130
Reviewed-by: Xander Moffatt <xmoffatt@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
QA-Review: Aaron Ogata <aogata@instructure.com>
Product-Review: Aaron Ogata <aogata@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
test plan:
badge counts show up in navbar items in new SideNavBar
flag=instui_nav
refs FOO-3880
refs FOO-3894
refs FOO-3895
Change-Id: Iea01d6d9b5aa6aed7afe129842b17b1a6463c9b1
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/331126
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Martin Ochoa <martin.ochoa@instructure.com>
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Product-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
closes LF-913
flag=instui_for_import_page
test plan:
- Navigate to a course content import page.
- Import content that have more than 10 issues.
(DM me or Eric if want a file with these number of issues)
- Wait until the import process finishes.
- Check that in "Progress" column has more than 10 issues.
- Click "View Issues" button.
> Verify that 10 issues are initially loaded in the modal.
- Click "Show More" button.
> Verify that a spinner is showed meanwhile is fetching.
> Verify that more issues are loaded in the modal.
> Verify that the "Show More" button is not showed after
all issues are already loaded in the modal.
Change-Id: Id6ab206732bdd30ea7bcb9925c45501e1889c291
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/330983
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Eric Saupe <eric.saupe@instructure.com>
QA-Review: Eric Saupe <eric.saupe@instructure.com>
Product-Review: Juan Chavez <juan.chavez@instructure.com>
need to run the pipeline against a singular node
Change-Id: I33befbf4e11daaf5942c37af9233d8f90adde732
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/331124
Reviewed-by: August Thornton <august@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
closes FOO-3963
closes FOO-3964
flag = temporary_enrollments
test plan:
• in rails console create a temporary enrollment pairing
TemporaryEnrollmentPairing.create!(root_account: Account.default)
• should be created with a default workflow_state of "active"
• temporary enrollment pairings are soft-deletable
• they have a one to many association on enrollments to be used for
tracking the enrollments that were created from the pairing
during temporary enrollment creation (TempEnrollAssign) modal
Change-Id: I75083d3163af13a609b15d984313f4dc8ec944a8
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/330991
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jason Perry <jason.perry@instructure.com>
Migration-Review: Cody Cutrer <cody@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: August Thornton <august@instructure.com>
closes VICE-3874
flag=discussion_checkpoints
Test Plan:
1. Create a checkpointed discussion in a rails console via
DiscussionTopic#create_checkpoints. Set the points_possible on the
checkpoints to 3 and 7, and the required replies to 1.
2. Verify the "parent" assignment has points_possible of 10:
topic.reload.assignment.points_possible
3. Update the points_possible on the first checkpoint from 3 to 4, and
then verify the points_possible on the parent are updated from 10 to
11:
topic.reply_to_topic_checkpoint.update!(points_possible: 4)
topic.reload.assignment.points_possible # should be 11
Change-Id: Ic4f3472a624faab68c989daade6f8cc7f55c4496
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/330996
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
fixes LF-887
flag=media_links_use_attachment_id
Test plan
- In a Blueprint parent course, upload
a media file and lock the file for editing
in the children courses
- Link a child course and sync the content
from the parent
- Link the video in the RCE in the child course
- Click on the video in the editor and go to
Video Options
- Verify that an API response to the RCS at
api/files/:fileId was sent
- For best results, test with g/330028 and
g/330353 (which will actually provide the
required API field)
Change-Id: Ib0f734ba45842c6320804c4d46516ab8b1a76304
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/330025
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Luis Oliveira <luis.oliveira@instructure.com>
QA-Review: Luis Oliveira <luis.oliveira@instructure.com>
Product-Review: Mysti Lilla <mysti@instructure.com>
A conversation participant should not be able to exist
However we have run into a few instances where they do
This commit handles them gracefully
refs VICE-3725
flag=react_inbox
Test Plan
1. Test the new test case before and after changes
Or
1. Disable foreign key restraints
2. Delete a conversation in a way that preserves
the participant
3. verify orphaned participant exists
4. open inbox, no error should occur
Change-Id: I16b067bddf72d12a92d8f97dbb4abdcfd4e491f8
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/330792
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Spencer Olson <solson@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
flag=restrict_quantitative_data
closes EVAL-3585
Test Plan:
- Enable restrict_quantitative_data flag
- create a course
- go to courses/:course_id/settings#tab-details
- check 'Restrict view of quantitative data' and click update
- copy the course
- the copy should has 'Restrict view of quantitative data'
checked
Change-Id: I6e5ad1bd34a20ddfb73fa2eef27a73a7da72b77f
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/330507
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Derek Williams <derek.williams@instructure.com>
Reviewed-by: Samuel Lee <samuel.lee@instructure.com>
QA-Review: Kai Bjorkman <kbjorkman@instructure.com>
Product-Review: Ravi Koll <ravi.koll@instructure.com>
Drake Harper