flag = none
Change-Id: I33bc4af82d2e7db4cf067b86d941981cefefaba8
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/291464
Reviewed-by: Andrea Cirulli <andrea.cirulli@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: James Butters <jbutters@instructure.com>
Product-Review: James Butters <jbutters@instructure.com>
refs DE-938
flag=none
TEST PLAN:
Confirm all builds still run successfully
Confirm all webpack linter jobs still run
Comfirm bundle sizes are appropriately reported
This task removes the webpack linter stage from premerge builds,
spreads the previous tasks around,
and adds a step to postmerge builds to track and report
webpack bundle sizes
Change-Id: I017876726ac0db6f099367b1ecfd086cfb726cf8
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/289680
Reviewed-by: Aaron Ogata <aogata@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Bobby Buten <bobby.buten@instructure.com>
Product-Review: Bobby Buten <bobby.buten@instructure.com>
Change-Id: I44decd04cc35a179a69cc2951c106019b06bff15
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/289673
Reviewed-by: Bobby Buten <bobby.buten@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: James Butters <jbutters@instructure.com>
Product-Review: James Butters <jbutters@instructure.com>
flag = none
Test Plan:
-Jenkins passes
-with only config/locales/ changes, gerrit votes -2 and build runs
-with more than config/locales/, Jenkins runs as normal
Change-Id: I2ffa3c18840be5e8a833919428ec119f4b17178d
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/289502
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Andrea Cirulli <andrea.cirulli@instructure.com>
QA-Review: James Butters <jbutters@instructure.com>
Product-Review: James Butters <jbutters@instructure.com>
refs DE-523
Test Plan
1. Ensure CANVAS_RAILS override works
2. Ensure file override works
3. Ensure consul override works
Change-Id: I6eea63bba5c401428c02179a3d6187c8265ce33e
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287849
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Aaron Ogata <aogata@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
Product-Review: Aaron Ogata <aogata@instructure.com>
flag = none
Change-Id: I26c2cbe5219a24185d003c8dc728439a05dd213e
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287698
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: James Butters <jbutters@instructure.com>
Product-Review: James Butters <jbutters@instructure.com>
Reviewed-by: Andrea Cirulli <andrea.cirulli@instructure.com>
This reverts commit 18e78b3c2a.
Reason for revert: didn't break jenkins
Change-Id: I5074570df6eeaf249cc380210cb20d8fc2439b80
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/286902
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
QA-Review: James Butters <jbutters@instructure.com>
Product-Review: James Butters <jbutters@instructure.com>
[change-merged]
[build-registry-path=jenkins/canvas-lms/de1103]
flag = none
Test Plan:
-Jenkins passes normally, no new builds ran
-With new/deleted spec file
-Jenkins will not run the crystalball map build
-Jenkins will run all rspec tests, no prediction
-With new/deleted spec file and post-merge
-Jenkins will trigger a new crystalball map build
-main post-merge build will not wait for map build
Change-Id: I77cddacfb98c8e77798eab276fc5cf08fb524cd3
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287658
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Andrea Cirulli <andrea.cirulli@instructure.com>
QA-Review: James Butters <jbutters@instructure.com>
Product-Review: James Butters <jbutters@instructure.com>
because patchset revision gets set to an actual value elsewhere
Change-Id: I792b7bf96ddca1309e13b79782cce2ceb3471ebc
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287552
Reviewed-by: Bobby Buten <bobby.buten@instructure.com>
QA-Review: Aaron Ogata <aogata@instructure.com>
Product-Review: Aaron Ogata <aogata@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
refs DE-989
flag=none
[change-merged] [build-registry-path=jenkins/canvas-lms/de-989]
TEST PLAN:
Builds successfully
Change-Id: If7aa8084d18c9b0403e79cadc2ead666aa5dd79d
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/286635
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Ogata <aogata@instructure.com>
QA-Review: Bobby Buten <bobby.buten@instructure.com>
Product-Review: Bobby Buten <bobby.buten@instructure.com>
remove poc/test-suite build trigger and small modifications
to Jenkinsfile.rspecq to ensure full builds don't get skipped.
flag = none
Change-Id: I5520800f90af0362e85551650b98cea388c09ca6
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/285058
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Bobby Buten <bobby.buten@instructure.com>
QA-Review: James Butters <jbutters@instructure.com>
Product-Review: James Butters <jbutters@instructure.com>
flag=none
Test-plan:
- run a patchset with different value set for crystalball map
- previous timestamp should appear in #crystalball-noisy
Change-Id: I206e2c62bcfc00f0f8bc8c8ad0b1262d28caab4f
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/283794
Reviewed-by: Kyle Rosenbaum <krosenbaum@instructure.com>
QA-Review: Brian Watson <bwatson@instructure.com>
Product-Review: Brian Watson <bwatson@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Change-Id: Ia2d06a7d28f7937eb5a677c5acba098c655ad17c
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/283060
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Reviewed-by: Andrea Cirulli <andrea.cirulli@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Andrea Cirulli <andrea.cirulli@instructure.com>
Product-Review: Andrea Cirulli <andrea.cirulli@instructure.com>
do not run crystalball prediction in post-merge
and wrap in try/catch to not fail build while
still testing crystalball
flag = none
Test Plan:
-Jenkins passes
Change-Id: I33bb4ee2bf6107456e1d85614b0a3c9c994f1e2e
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/282773
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: James Butters <jbutters@instructure.com>
Product-Review: James Butters <jbutters@instructure.com>
Reviewed-by: Brian Watson <bwatson@instructure.com>
run crystalball build silently, in parallel to regular
builds.
flag = none
Test Plan:
-Jenkins passes
-proofs-of-concept/test-queue build runs same tests
-with ruby file change, proofs-of-concept/test-queue only
runs crystalball predictions for selenium
-regular test-queue still runs all tests
Change-Id: I243c096c9ac3fb2907d7b67272610663284aebc6
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/282684
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Ogata <aogata@instructure.com>
Reviewed-by: Brian Watson <bwatson@instructure.com>
QA-Review: James Butters <jbutters@instructure.com>
Product-Review: James Butters <jbutters@instructure.com>
This reverts commit 7dd287adea.
Reason for revert: try again
Change-Id: Ie0eededa8465a7fb79bbd221c777646ab2640fa7
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/282036
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Ogata <aogata@instructure.com>
QA-Review: James Butters <jbutters@instructure.com>
Product-Review: James Butters <jbutters@instructure.com>
This reverts commit 276eb49f8e.
Reason for revert: Something in here is failing deploys
Change-Id: I615a90e6a4edf743ba47a2673bc14483ad141b3d
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/282032
Reviewed-by: Andrea Cirulli <andrea.cirulli@instructure.com>
QA-Review: James Butters <jbutters@instructure.com>
Product-Review: James Butters <jbutters@instructure.com>
Tested-by: James Butters <jbutters@instructure.com>
run rspecq/rspec tests in separate sub-build.
flag = none
refs: DE-929
Test Plan:
-Jenkins passes
-test count is consistent
Change-Id: Ia62730c32d1793d591555c0fd034538254efffc3
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/282016
Reviewed-by: Aaron Ogata <aogata@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: James Butters <jbutters@instructure.com>
Product-Review: James Butters <jbutters@instructure.com>
refs DE-545
When apt-get tries to pull a package from a server that is down or undergoing maintenance, builds that modify Gemfile can fail due to not being able to pull packages. By splitting the package installation into its own layer, external packages no longer need to be reinstalled when gems are updated.
Test Plan
1. Cache builds correctly from scratch, uploads all relevant images.
2. Cache is correctly reused when no gems are updated
3. Base cache image is reused when gems are updated, and all other images are rebuilt
4. Pre-merge build passes and uses cache as appropriate
5. Updating Dockerfile.jenkins re-builds base image
[build-registry-path=jenkins/canvas-lms/de-545-1]
[change-merged]
Change-Id: Ifd76064892817abb80dd0daebe8c2189c0338d78
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279697
Reviewed-by: Andrea Cirulli <andrea.cirulli@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Aaron Ogata <aogata@instructure.com>
Product-Review: Aaron Ogata <aogata@instructure.com>
refs FOO-2371
flag = none
test plan: jenkins does what the title says (on post-merge)
Change-Id: Id17a194c1c96ade4d21cea0a6ed97205a8eb2754
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/275751
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: August Thornton <august@instructure.com>
QA-Review: Ahmad Amireh <ahmad@instructure.com>
Product-Review: Ahmad Amireh <ahmad@instructure.com>
Aaron Ogata