[skip-stages=Flakey]
Change-Id: I6abefdfa9fed6dd4525c8786e93efa548b3710f2
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/319603
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
QA-Review: Jacob Burroughs <jburroughs@instructure.com>
Product-Review: Jacob Burroughs <jburroughs@instructure.com>
Build-Review: Jacob Burroughs <jburroughs@instructure.com>
Migration-Review: Jacob Burroughs <jburroughs@instructure.com>
closes LF-290
flag = none
Test plan:
(Requires a NQ connection to test)
- Go to a course's modules page
- Click '+' to add content to a module
- Select each content type in the dropdown, and expect to see
'[Create Assignment]', not '[New Assignment]' (or quiz, page, etc)
- Select Quiz
- Expect to be able to choose between NQ and CQ
- Create a NQ and then a CQ
- Open each quiz
- Expect the quizzing engine to match the selected engine
Change-Id: I8a54874a78aace2c6a97250f704ecc0d6d61cb77
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/318759
Reviewed-by: Robin Kuss <rkuss@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Jackson Howe <jackson.howe@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
closes LF-285
flag = none
Test plan:
- have an assignment with a rubric that uses
free-form comments
- as a student, submit the assignment
- as a teacher, grade the assignment while leaving
comments in the rubric in speedgrader
- as a student, click the dashboard notification about
the graded assignment to go to the submission details
page
- there should be an unread indicator next to the
"Show Rubric" link
- click "Show Rubric" and that indicator should go away
- refresh the page and the indicator should still be gone
Change-Id: I382b6e580e46a780e246d58f572387c0ad0f2c14
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/318541
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Sarah Gerard <sarah.gerard@instructure.com>
QA-Review: Sarah Gerard <sarah.gerard@instructure.com>
Product-Review: Jackson Howe <jackson.howe@instructure.com>
flag=restrict_quantitative_data
fixes VICE-3498
test plan:
- have a student be graded on a
points assignment, a percentage assignment,
a letter-grade assignment, and a complete-incomplete
assignment
- make sure that student is quantitative data restricted
- as the student visit your home page
- verify that recent feedback on the right
converts points and percent grades to letter-grade,
while leaving complete-incomplete and letter-grade grades
alone
Change-Id: Ic8961976c89bcb112dd65575c6e235f80be19baf
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/317789
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Allison Pittler <allison.pittler@instructure.com>
Reviewed-by: Chawn Neal <chawn.neal@instructure.com>
QA-Review: Drake Harper <drake.harper@instructure.com>
Constants in an AR model get loaded when the model is loaded, including
translated strings. If the user switches languages, the cached string
might be stale. Thus, use a lambda in the constant that calculates the
translated setting name instead of storing the translated value. An
alternative would have been to make this entire constant a method
instead of a constant, but this is a less intrusive solution since it
has a number of usages.
flag = none
closes LS-3947
Test plan:
- Change user's language to something else (in the UI)
- Go to course settings
- Scroll down to visibility
- Check "customize"
- Expect "syllabus" and "files" to appear in the currently selected
language
Change-Id: Ifcfb95476f1e8d4f97007bfad1ccea9b0e55aa07
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/316412
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Robin Kuss <rkuss@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Jackson Howe <jackson.howe@instructure.com>
The url to access submissions from the dashboard's recent feedback
sidebar was generating the subissions url with the observer's user
id, which does not work because the observer doesn't have a submission
in the course. Instead, construct the url with the id of the student
whom the observer is currently observing.
closes LS-3934
flag = none
Test plan:
- Create an assignment in a course with a due date and online
submission type
- As a student, submit the assignment
- As a teacher, leave a submission comment
- As an observer (observing the student), open the dashboard and
click the link to the comment in the recent feedback sidebar
- Expect to be taken to the student's submission and see the comment
Change-Id: I52c16f4fc2efc885e4adc298b60a1140ac191b1d
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/316066
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Luis Oliveira <luis.oliveira@instructure.com>
QA-Review: Luis Oliveira <luis.oliveira@instructure.com>
Product-Review: Jackson Howe <jackson.howe@instructure.com>
Rendering external_tools/helpers/icon includes the new lines and spaces
that are present in the partial. Calling #squish on the output of that
partial in this helper will remove all the new lines and spaces but this
removes the html_safe flag on the out. Wrapping that entire thing in
the icon correctly and without spaces.
fixes LS-3926
flag=none
test plan:
- Create an LTI in a course with an icon
- Go to the course settings and verify the LTI is rendered with the icon
- Hover over the button and verify there isn't an extra space before
the label
- Inspect the HTML and verify there isn't an extra space or new line
between the icon and label
Change-Id: I954b65d5a6e2d2e2a6354235679d12023f15240c
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/316073
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jackson Howe <jackson.howe@instructure.com>
QA-Review: Jackson Howe <jackson.howe@instructure.com>
Product-Review: Eric Saupe <eric.saupe@instructure.com>
Launching duplicating/failed_to_duplicate new quizzes assignments
provides no value as the assignments do not yet exist, and is actually
destructive as it will create a blank assignment on the new quizzes
side with no connection to its parent assignment.
closes QUIZ-10828
flag=none
Test Plan:
- Create a BP parent course with a new quizzes assignment.
- ADD THE NQ ASSIGNMENT TO A MODULE.
- Create a child course.
- Ensure your live events are turned off and/or quiz lti is turned off.
- In the canvas rails console run this:
Setting.set("quizzes_next_timeout_minutes", "1")
- Run a BPS.
- Check the child course.
1. The Assignments/Quizzes list should have a spinner for the quiz.
2. The modules list should have no entries.
- Wait 1 minute, then in the Canvas rails console run:
Assignment.clean_up_duplicating_assignments
- Check the child course.
1. The assignments/quizzes list should have an 'Oops!' entry for the quiz.
2. The modules list should have no entries.
- Turn on quiz lti and your canvas live event streams.
- Run another BPS.
- Check the child course.
1. The assignments/quizzes list should have a valid entry for the quiz.
2. The modules list should have a valid entry for the quiz.
Change-Id: I971173ebca77e9ecfb152677092bd7f48f789d2b
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/311411
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Marissa Pio Roda <marissa.pioroda@instructure.com>
QA-Review: Weston Dransfield <wdransfield@instructure.com>
Reviewed-by: Stephen Kacsmark <skacsmark@instructure.com>
User login sso-icons were not showing in login information of the
user page. This was due to the lookup code for the svg not working,
when the view is checking if the svg exists. In my testing, the old
lookup code works for erb files but not svg files. This code change
will correctly check if the svg file exists.
fixes FOO-3368
flag=none
test plan:
- Import user with authentication_provider_id set to canvas
- Confirm login information of user shows canvas icon on user page
Change-Id: I09736471b5c317ce1b73a5f44439095c5547de2a
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/312704
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: August Thornton <august@instructure.com>
QA-Review: Ajmal Esa <ajmal.esa@instructure.com>
Product-Review: Ajmal Esa <ajmal.esa@instructure.com>
currently when a student has unread grades in their grade
summary, the blue unread dots appear for 5 seconds then disappear.
the blue dots will display if reloaded and only permanently disappear
if the student clicks into the submission. new change will make it
so that when a student goes to summary page, the blue dots stay on
the screen but a bulk api call is made to mark all the unread
submissions as read. next time user loads the page the blue dots will
not be there.
fixes EVAL-2775
flag=visibility_feedback_student_grades_page
flag=assignments_2_student
test plan:
- as teacher, make 3 changes to student's grade for 3 different
assignments
- as the student, view the grade summary page
- notice that the unread grade blue dots appear next to those 3
assignments and do not disappear
- notice that the content participation count next to grades tab is
correct with a count of 3
- as the student, refresh the grade summary page
- notice that the unread blue dots are no longer there and the content
participation count should now be 0.
Change-Id: Ief3bbe12fafe5cb4b022126b2a3bcddedd220cd2
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/308109
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Cameron Ray <cameron.ray@instructure.com>
Reviewed-by: Derek Williams <derek.williams@instructure.com>
Reviewed-by: Cameron Ray <cameron.ray@instructure.com>
QA-Review: Kai Bjorkman <kbjorkman@instructure.com>
refs OUT-1718
closes FOO-3281
flag = none
The ordering is the same for both views (and is working per the
docs linked above) with the exception that the “Recent Submissions”
filters out submissions belonging to assignments and their
respective context (i.e Course) that is not currently published.
It seems like we just missed the “Course Submission” view when
making that addition.
test plan:
- create a course
- create an assignment and publish it
- create another assignment and do not publish it
- create a quiz that has at least one text only
question (such as an essay)
- add a student to the course
- as the student, create an ePortfolio (found under
the 'account' submenu on the left-hand side)
- ensure that the unpublished assignment
is not seen under "Recent Submissions"
- as the student, submit to the publushed assignment
- the eportfolio should now show that assignment
- as the student, take the quiz
- the quiz should still not show in the portfolio
- as the teacher, grade the assignment submission
- the submission should still show for the student
in the portfolio
- as the teacher, grade the text only questions of
the quiz
- the quiz should now show in the portfolio
Change-Id: I1e3383b14acb8e3323c4fd7c9de78621297db086
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/308514
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Charley Kline <ckline@instructure.com>
Product-Review: Charley Kline <ckline@instructure.com>
Product-Review: Jesse Poulos <jpoulos@instructure.com>
QA-Review: August Thornton <august@instructure.com>
closes EVAL-2685
closes EVAL-2686
closes EVAL-2687
closes EVAL-2688
flag=proxy_file_uploads
test plan:
- turn on proxy_file_uploads siteAdmin FF
- grant Teachers permission with proxy_assignment_submission
- create an assigment on a course with file_upload submissions
- as a teacher, navigate to that assignment in gradebook
- notice 'Submit for Student' button on the submission tray
- upload a file and see that it saves to the student's folder
- click 'submit' to save the submission
- notice that the proxy submitter is saved on the submission
- verify proxy upload indicator appears in the following places
- gradebook submission tray
- SubmissionTray.tsx
- speedgrader
- submissions_dropdown.handlebars
- A2 student views
- SubmissionWorkflowTracker.js
- A1 student views
- submission_sidebar.html.erb
- views/submissions/show.html.erb
Change-Id: I2b9a7b8a5d1bd7c31bd2fe0c15b3316ce8b7e4bc
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/304943
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Spencer Olson <solson@instructure.com>
Reviewed-by: Cameron Ray <cameron.ray@instructure.com>
Migration-Review: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Christopher Soto <christopher.soto@instructure.com>
Product-Review: Deborah Kwak <deborah.kwak@instructure.com>
With feedback visibility flag we combined the out of and score
columns. This change adds the out of total for all special classes
which are total and group grades
fixes EVAL-2785
flag=visibility_feedback_student_grades_page
test plan:
- have a course with students and assignments/groups
- grade some of the assignments for some of the students
- verify that next to the Assignments row, any group rows,
and the Total score row, that you can see the out of values
or 0.00/0.00 if the score is N/A
Change-Id: I0df604faca6e53721baff1e3eae304f666604dfa
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/307522
Reviewed-by: Eduardo Escobar <eduardo.escobar@instructure.com>
Reviewed-by: Cameron Ray <cameron.ray@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Kai Bjorkman <kbjorkman@instructure.com>
Product-Review: Deborah Kwak <deborah.kwak@instructure.com>
closes: EVAL-2763
flag=none
Test Plan:
- have a published course.
- have a course with a teacher and a student.
- have an assignment created.
- as the teacher using the speedgrader or gradebook
grade the student.
- as the student go to the grade summary page.
- hover over the values of the grade column.
- ensure only "Click to test a different score"
custom tooltip is present.
Change-Id: I2cac720d658de301ff6bd14393da7dd5cc0a0d0f
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/306559
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Kai Bjorkman <kbjorkman@instructure.com>
Reviewed-by: Aaron Shafovaloff <ashafovaloff@instructure.com>
QA-Review: Kai Bjorkman <kbjorkman@instructure.com>
Product-Review: Deborah Kwak <deborah.kwak@instructure.com>
fix issue where when assignment enhancements flag
is on, when trying to print grades from student
grade page, it shows the speed grader url
fixes EVAL-2679
flag=assignments_2_student
test plan:
- have a course with a text assignment that is due
- with assignments_2_student flag on, navigate to
individual student grade page as a teacher
- for the text assignment, verify the url of the
assignment title navigates to speed grader page
- from the student grade page, right click and go
to print the page
- verify in the pdf preview that the url for the
assignment doesn't exist
- before the fix, the url would be displayed
Change-Id: I1bd3e059cc7f73dab932ecc2d32e3d58bb654d73
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/305548
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Derek Williams <derek.williams@instructure.com>
Reviewed-by: Kai Bjorkman <kbjorkman@instructure.com>
Product-Review: Deborah Kwak <deborah.kwak@instructure.com>
QA-Review: Kai Bjorkman <kbjorkman@instructure.com>
Test Plan:
1. Validate that a non-admin user can modify their name, profile links,
bio and communication channels
2. Disable the respective settings in the Account settings tab
3. Validate that the non-admin user can no longer edit the listed items
4. Validate that the API does not allow these changes either
flag=none
refs PFS-20887
Change-Id: I0d852613a64ee763c6de1bca8797f226c74f5f43
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/304025
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Vaughn Hepworth <vhepworth@instructure.com>
QA-Review: Douglas Rist <douglas.rist@instructure.com>
- Blue dot styling refactor
- Add specs for unread grade, comment and rubric on grade summary
- Doesn't show the blue dot if submission is not posted
- Remove unread grade blue dot after 5 seconds
- Fix blue dot position if a RTL lang is selected
closes EVAL-2542
flag=assignments_2_student
flag=visibility_feedback_student_grades_page
Test Plan:
- Enable the "Assignment Enhancements - Student" feature flag
- Enable the "Improve Feedback on Students Grade Page" feature flag
- Have a course with at least two students
- Have a published assignment (post grades - automatically)
- As a student submit the assignment
- As a teacher grade the student
- As a student, when landing on the grades page the blue dot
shows up on the grade
- That blue dot should disappear after 5 seconds
- If the page is reloaded the blue dot should be gone because
the grade is marked as read when the user views the grade
- And if the teacher changes the grade the blue dot should
appear again.
- Have a published assignment (post grades - manually)
- As a student submit the assignment
- As a teacher grade the student
- As a student, when landing on the grades page, you
should see no blue dot on the grade
Change-Id: I7f40137049ca00bb69cd0b50129b13f6cc6af19c
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/302822
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Spencer Olson <solson@instructure.com>
Reviewed-by: Cameron Ray <cameron.ray@instructure.com>
Reviewed-by: Aaron Shafovaloff <ashafovaloff@instructure.com>
QA-Review: Cameron Ray <cameron.ray@instructure.com>
Product-Review: Deborah Kwak <deborah.kwak@instructure.com>
refs DE-1383
Change-Id: I6ab3efff2328717a74626a4fc2b4e171e41bcb06
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/293150
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Aaron Ogata <aogata@instructure.com>
Fixed bug where badge next to grade does not disappear once student
refreshes or leaves the grade summary page while
Assignment Enhancement - Student feature flag is on.
Also fixed bug where badge count does not increment when teacher grades
assignment while Assignment Enhancement - Student feature flag is on.
flag=assignments_2_student
Fixes EVAL-2514
Test Plan:
1. Turn on the Assignment Enhancement - Student feature flag
2. Have a course with a student and at least one assignment
3. As a teacher/admin, grade the assignment in the course
for that student
4. Go to the student profile and on the grades tab
you should see a badge with the unread graded count of 1
5. Click the grade tab to enter the grade summary page.
6. You should notice that the badge count does not go away and
there is a blue dot next to the graded assignment.
7. Refresh or go to another link and you should see that the
badge count goes away.
8. Regrade the assignment with a different grade
and check to see if the badge reappears with a 1
9.Turn off feature flag and see that the old functionality
still exists.
Change-Id: Ifc02903745b71e39e46804dd0c499bac909f367b
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/295491
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Kai Bjorkman <kbjorkman@instructure.com>
Product-Review: Jody Sailor
Reviewed-by: Kai Bjorkman <kbjorkman@instructure.com>
Reviewed-by: Spencer Olson <solson@instructure.com>
Show blue dot on the region surrounding
the rubrics icon when a rubric is graded
or a comment is added
Closes EVAL-2419
flag=visibility_feedback_student_grades_page
test plan:
- Have a graded assignment with a rubric and
peer reviews (manually assign peer reviews)
and at least two students where one assesses
each others assignments, or you can assess
as a teacher via SpeedGrader where you
select the student then click on the rubric
- With the FF on:
- As a teacher go to SpeedGrader and make
a comment on the rubric or grade it.
Or as a student peer review the other
student's submission.
- As the student who owns the submission
go to the grades page
- The rubric icon should be present with
a gray region surrounding it. The blue
dot should also show up
- The blue is removed when clicking on
the rubric icon. The blue dot should
not show up after refreshing the page
- With the FF off:
- As a teacher go to SpeedGrader and make
a comment on the rubric or grade it.
Or as a student peer review the other
student's submission.
- As the student who owns the submission
go to the grades page
- Only the icon without the gray region
and blue dot should appear
Change-Id: I13f255d40e1471a4df56747af2304315c0588072
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/295765
Tested-by: Paulo Chaves <paulo.chaves@instructure.com>
Reviewed-by: Spencer Olson <solson@instructure.com>
Reviewed-by: Kai Bjorkman <kbjorkman@instructure.com>
QA-Review: Kai Bjorkman <kbjorkman@instructure.com>
Product-Review: Jody Sailor
fixes EVAL-2436
flag=assignments_2_student
flag=peer_reviews_for_a2
test plan:
- enable the FF "Assignment Enhancements - Student".
- enable the FF "Peer Review Support in Assignment
Enhancements".
- have a published course.
- have a course with a teacher and at least 2
students.
- create an assignment A1 with "Peer Reviews"
enabled and the "Peer Reviews Appear Anonymously"
disabled.
- create an assignment A2 with "Peer Reviews"
enabled and the "Peer Reviews Appear Anonymously"
enabled.
- assign some peer reviews to the students for
both assignments A1 and A2.
- as a student go to the "Modules" tab.
- notice the list of peer reviews is present
for each assignment.
- when the student clicks on the peer review
for A1 it should redirect to
/assignments/:assignment_id?reviewee_id=:id
- when the student clicks on the peer review
for A2 it should redirect to
/assignments/:assignment_id?anonymous_asset_id=:id
- disable the FF "Peer Review Support in Assignment
Enhancements".
- notice the list of peer reviews is not present
anymore.
Change-Id: I471a1b0fa98129c47cdd8c719ccf1100fa748853
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/291575
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Kai Bjorkman <kbjorkman@instructure.com>
Product-Review: Jody Sailor
Reviewed-by: Spencer Olson <solson@instructure.com>
Reviewed-by: Aaron Shafovaloff <ashafovaloff@instructure.com>
closes EVAL-2149
flag=assignments_2_student
Test plan:
Have a site admin, admin, teacher, student and observer with:
- an assignment and
- an anonymous grading assignment
1. With the FF ON, go to the student grades page for the
assignment (not anonymously graded) and click on the
assignment title:
1.1. As a student and observer, make sure it shows the
assignment in the improved assignment submission flow
1.2. As an admin, see that it takes you to speedgrader for
that assignment and student
1.3. Repeat 1.2. as a teacher and site admin
2. With the FF OFF, go to the student grades page for the
assignment (not anonymously graded) and click on the
assignment title:
2.1. As a student, see that you go to the old submission
details page
2.2 Repeat 2.1. as a teacher, admin, site admin
3. With the FF ON, go to the anonymous grading assignment
and click on the assignment title:
3.1. student and observer see the improved assignment
submission flow
3.2. link is hidden for teacher and admin
3.3. takes the site admin to speedgrader
4. With the FF OFF, go to the anonymous grading assignment
and click on the assignment title:
4.1. student goes to old submission details page
4.2. link is hidden for teacher and admin
4.3. site admin goes to old submission details page
Change-Id: I9f8e6d75b9151123616e07db2265cd4e07968bd8
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/290382
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Spencer Olson <solson@instructure.com>
Reviewed-by: Paulo Chaves <paulo.chaves@instructure.com>
QA-Review: Kai Bjorkman <kbjorkman@instructure.com>
Product-Review: Jody Sailor
closes EVAL-2323, EVAL-2324
flag=visibility_feedback_student_grades_page
test plan:
- Have a graded assignment with comments and
a rubric
- With the FF on:
- Go to the students grade page
- If there is any comment for an assignment
- There should be a gray region around the
comment icon and the number of comments
right next to the icon
- If any unread comment for an assignment
the blue dot should show up in the
top-right corner
- If there is any rubric for an assignment
- There should be a gray region around the
rubric icon
- If a comment is added and unread by
a student the blue dot should show up
in the top-right corner
- With the FF off:
- Go to the students grade page
- If any comment is present only the icon
without the gray region surrounding it
should appear
- if any rubric is present only the icon
without the gray region should appear
Change-Id: I5f3a303c1ab2e14796c75fceb0706476a11b77e2
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/289708
Reviewed-by: Eduardo Escobar <eduardo.escobar@instructure.com>
Reviewed-by: Spencer Olson <solson@instructure.com>
QA-Review: Eduardo Escobar <eduardo.escobar@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Jody Sailor
closes LS-1502
flag = none
Test plan:
- In a rails console, run:
Account.site_admin.external_integration_keys.create!(key_type: "salesforce_org_type", key_value: "Higher Ed")
- In config/dynamic_settings.yml, set
development.config.canvas.fullstory.sampling_rate to '1.0'
- Restart rails server and log user out
- Log in (as a siteadmin user)
- Inspect the head section of the html (search for org_type_str)
- Expect to see "org_type_str: 'Higher Ed'" in FS.setUserVars
Change-Id: Ie66668234ca78197f2b6cff8dd877a08f938478c
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/291706
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Ed Schiebel <eschiebel@instructure.com>
QA-Review: Ed Schiebel <eschiebel@instructure.com>
Product-Review: Jackson Howe <jackson.howe@instructure.com>
This adds a new page where Site Admin users can manage `Setting`s (aka,
"Internal Settings"). This can be done on the Site Admin settings page,
on the "Internal Settings" tab. Only Site Admin users see and may access
this tab.
The table displayed renders each setting and its value, and offers the
ability to edit or delete each setting. New settings may also be added.
Settings denoted internally as `secret` will be displayed, but their
values obscured. These settings may not be edited or deleted from the UI.
There is also a "Download as..." button that allows all internal settings
(except for secret ones) to be downloaded in JSON or CSV format.
closes DE-1136
flag=none
test plan:
- confirm that, as a site admin, you can add, edit, and delete internal
settings from the "Internal Settings" tab
(note: you can edit a setting by clicking on its value)
- confirm the table is sortable by clicking on the column headers
- confirm the table is downloadable by choosing either the JSON or CSV
options
- confirm that your changes are reflected in the database, and in
`Settings.get` once settings have been reloaded
- confirm that, as a non-site admin user, you can not see the Internal
Settings tab
Change-Id: Ia143bf40e85b43a1db2f6fcc2791718179c351c4
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/290906
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Isaac Moore <isaac.moore@instructure.com>
closes EVAL-2322
flag=visibility_feedback_student_grades_page
test plan:
- Have some graded assignment
- With the FF on:
- Go to the students grade page
- There should not be a `Out of` column
- The `Score` column should now show the
score with the format `Score/Points possible`
- With the FF off:
- Go to the students grade page
- There should be a `Score` column
- There should be a `Out of` column
Change-Id: Ibde7fa54e1ba20ae46d50fcc0480ab9f8c9c9723
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/288867
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Spencer Olson <solson@instructure.com>
Reviewed-by: Eduardo Escobar <eduardo.escobar@instructure.com>
QA-Review: Eduardo Escobar <eduardo.escobar@instructure.com>
Product-Review: Jody Sailor
why:
* placements added after the modules page was created were loading
tools in separate queries and formats
* there was already a hash of placement -> tool but instead newer
placements were using separate variables
* standardize calls to external_tools_menu_items for all placements
* load tools for newer placements during same call for older
placements
* ignore tools for tray placements if FF is disabled, as before
* group all tool definitions sent to front end for consistency
refs INTEROP-7294
flag=none
test plan:
* with a tool with assignment_menu, module_menu, module_index_menu,
module_group_menu,
and module_index_menu_modal placements configured
* with these feature flags enabled on the root account:
* commons_favorites
* lti_multiple_assignments_deep_linking
* lti_deep_linking_module_index_menu_modal
* launching the tool from all of these placements should work before
and after this commit is checked out:
(don't forget to run webpack)
* module_index_menu: 3-dot menu at the top of
the page, opens a side tray and launches tool
* module_index_menu_modal: 3-dot menu at the top of the page, opens a
modal and launches tool with deep linking request
* module_menu: 3-dot menu in each module, redirects to tool in new
page with module_menu placement
* module_group_menu: same place, opens a side tray and launches tool
* assignment_menu: add a normal assignment to a module and click on
the 3-dot menu of the assignment, launching the tool redirects to the
tool with the assignment_menu placement in a new page
Change-Id: I8e5c338f27443b03a4710fb577194f5b9509d1e4
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/287767
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Xander Moffatt <xmoffatt@instructure.com>
Reviewed-by: Tucker Mcknight <tmcknight@instructure.com>
QA-Review: Tucker Mcknight <tmcknight@instructure.com>
closes EVAL-2302
flag=submission_comment_emojis
Test Plan:
1. Verify a 'Emojis in Submission Comments' Course Feature Flag exists
(needs to be enabled at SiteAdmin level before visible at account and
course level). Enable the feature at the SiteAdmin account.
2. In the Account settings for your root account (not the SiteAdmin
account), 'unlock' the feature. Then, go to settings for the root
account and verify there is a 'Blocked Emojis' section. Click the
emoji picker, select 😬, and then click 'Update Settings' at the
bottom of the page.
3. Enable the feature flag in a course.
4. At the following pages, verify that the submission comment textarea
now includes an emoji 'picker' (button that opens a menu to pick
an emoji) and a emoji 'quick picker toolbar' (three emoji buttons
below the textarea, that when clicked insert the pictured emoji into
the textarea. The icons shown include the most recently used emoji
and the two most popular emojis. By default, 👍, 👏, and 😀 are
shown.
Logged in as a student:
- "Assignment Enhancement — Student" page
- Submission Details page
- "Submit Assignment" page (with "Assignment Enhancement —
Student" disabled). Make sure to check the textarea for each
submission type (easiest way to do this is to create an
assignment and click the checkbox for every submission type).
Logged in as a teacher:
- Gradebook
- SpeedGrader
5. Verify the 😬 emoji is not available in the emoji picker at any of
those pages listed above.
6. Disable the feature flag and verify at the pages listed above that
the emoji 'picker' and emoji 'quick picker toolbar' are no longer
shown.
Change-Id: I2c790904927a897bfb0ac30091a5bafb291fd115
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/286283
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Kai Bjorkman <kbjorkman@instructure.com>
Reviewed-by: Eduardo Escobar <eduardo.escobar@instructure.com>
QA-Review: Kai Bjorkman <kbjorkman@instructure.com>
Product-Review: Jody Sailor
closes: LS-858
flag=none
test plan:
- Confirm that responsive behavior sill works as it would
with the removed flags (responsive_awareness and responsive_misc) ON
Change-Id: Ia34f8c273db756fcc24f1412b4c3f7f5d88efc12
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/285420
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Ed Schiebel <eschiebel@instructure.com>
QA-Review: Ed Schiebel <eschiebel@instructure.com>
Product-Review: Luis Oliveira <luis.oliveira@instructure.com>
Fixes FOO-2545
flag=none
See the description in the ticket; when "buttons" are
instead coded as <a href="#" ...> it can confuse some
screenreaders because they think we're navigating to a
new page and thus restart at the top.
Converted everything called out in the ticket from
<a> to <button> as appropriate. Also did a few other
<a href="#" ...> elements as I saw them. Eventually we
should clean all of these up everywhere but that's
beyond the scope of this ticket.
Test plan:
* See the problem description in the ticket
* Voiceover should now navigate the page properly
Change-Id: Ic742c72c74d41380a13a4e5c0158eb59ea8f7f33
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/282127
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: August Thornton <august@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Daniel Sasaki <dsasaki@instructure.com>
[skip-stages=Flakey]
auto-corrected, with post review looking for opportunities to convert
to heredocs
Change-Id: Ic163882ebb5f4d2d28b5e5fd65188781d8eef3c8
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279287
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
[skip-stages=Flakey]
auto-corrected
also enable Style/PercentQLiterals forcing uppercase with it, so that
both %q and %Q get changed to bare %
Change-Id: I91389c18d864b3ec638c6cd366c2c74f78c69a57
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/278673
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Jacob Burroughs