Commit Graph

5 Commits

Author SHA1 Message Date
Cody Cutrer c2cba46851 RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation
[skip-stages=Flakey]

auto-corrected

Change-Id: I4a0145abfd50f126669b20f3deaeae8377bac24d
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279535
Tested-by: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Migration-Review: Cody Cutrer <cody@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
2021-11-25 14:03:06 +00:00
Cody Cutrer 9b71ed2054 RuboCop: Style/BlockDelimiters, Style/Lambda
[skip-stages=Flakey]

auto-corrected

Change-Id: I642f868d75c079e698f1fe4161bbbe419dbe1827
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279374
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Migration-Review: Cody Cutrer <cody@instructure.com>
2021-11-23 21:30:47 +00:00
Cody Cutrer 8e0327867e RuboCop: Layout spec/models
[skip-stages=Flakey]

Change-Id: I25b7f97dc3bb7fd9f24e63e372d7127c42cd3147
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/274147
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2021-09-22 19:17:48 +00:00
Cody Cutrer 81d0bbc465 add # frozen_string_literal: true for specs
Change-Id: Id508bec1817937b1c24c29f1db7221e09cb9c2ab
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/251157
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2020-10-27 20:48:35 +00:00
Michael Ziwisky bee060653d CSP: whitelist all tool subdomains and provide global whitelist setting
refs FOO-437
flag=none

This provides a 'csp.global_whitelist' Setting that can be used to add
comma-separated list of domains to the CSP whitelist for all Accounts.
With this, Studio LTI launches (and video downloads) can be fixed by
`Setting.set('csp.global_whitelist', '*.instructuremedia.com')`.

This also gives Commons a path to fix its download issues, namely by
serving catridges from a subdomain of the tool's domain.

test plan:
 = run `Setting.set('csp.global_whitelist', '*.instructuremedia.com')`
   in a rails console
 - install Studio as an LTI tool
 - turn on CSP:
   - go to https://<account>.instructure.com/accounts/self/settings/configurations
   - click "Feature Options" tab
   - ensure "Content Security Policy" is enabled
   - click "Security" tab
   - click "Enable Content Security Policy"
 - launch Studio.  it should work.
 - go to a video you uploaded in Studio and click the Download button.
   that should work, too.

Change-Id: I930b9b5ee5653cc5bbfd85b096f120fc21722e3a
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/246475
QA-Review: Ahmad Amireh <ahmad@instructure.com>
Product-Review: Ahmad Amireh <ahmad@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Ahmad Amireh <ahmad@instructure.com>
2020-09-04 21:35:39 +00:00