QuizSubmission now supports a new scope "for_students" that will grab
all submissions that are:
- not a teacher preview
- not a teacher-initiated "Student View" one
- submitted by students who really are rolled in a course
Closes CNVS-13694
TEST PLAN
---- ----
- create a quiz with one question
- enter Student View via the course settings
+ take the quiz
+ get out of Student View
- visit the statistics page (or hit the API)
+ verify the attempt is not factored
- generate the CSV of Item-Analysis to verify that IA does not factor
these attempts either
- test the change with Survey quizzes - need to make sure "logged out"
users are still OK where applicable
Change-Id: Ic58569be31576734eb6e309d548a7415c07e08a7
Reviewed-on: https://gerrit.instructure.com/38174
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jason Madsen <jmadsen@instructure.com>
Product-Review: Ahmad Amireh <ahmad@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Closes CNVS-12672
TEST PLAN
---- ----
- enable NQS, create a quiz, take it by one student
- go to ember quiz stats:
+ verify that the summary chart shows the 0 and 100 percentiles
- make the window small enough to show a horizontal scroller for the
rest of the page
+ verify that the chart scales down to stay visible
- make the window too small:
+ verify that the chart can be fully viewed using the horizontal
scroller
- make the window too large:
+ verify that the chart scales up to a certain point (width of
960px)
Change-Id: I2be601aaa6c98f574fe6fa944a3a57558e386e3f
Reviewed-on: https://gerrit.instructure.com/38342
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Reviewed-by: Jason Madsen <jmadsen@instructure.com>
Reviewed-by: Josh Simpson <jsimpson@instructure.com>
Product-Review: Ahmad Amireh <ahmad@instructure.com>
test plan:
* as a student, visit /dashboard/data_exports
* should be able to export a zip file containing
all of the student's submissions
refs #CNVS-14242
Change-Id: Iaab216e7411c27fa6d259f677e40a75d3de3f5a8
Reviewed-on: https://gerrit.instructure.com/36872
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Trevor deHaan <tdehaan@instructure.com>
Product-Review: Hilary Scharton <hilary@instructure.com>
test plan: using Chrome 36, upload a file via the "Add Module Item"
dialog on the modules page. the module item should match the file name
and should have any path, fake or otherwise, stuck in front of it.
fixes CNVS-14380
Change-Id: I050ea93797468636b3d35846cf54ebe3d6c302cc
Reviewed-on: https://gerrit.instructure.com/38047
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jon Willesen <jonw@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
test plan:
* set up a course_home_sub_navigation enabled tool, as in
the test plan for g/37834
* launch the tool from the course home page
* select the imscc file on the test tool content
selection page
* should be redirected to the content_migration page
and have a new migration queued for the course
closes #CNVS-13797
Change-Id: If94e65d2ba3c1f2ed53624b6a3b4c9a75d25c5ce
Reviewed-on: https://gerrit.instructure.com/38206
Reviewed-by: Jon Willesen <jonw@instructure.com>
Product-Review: Jon Willesen <jonw@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
fixes CNVS-13123
test plan:
- go to the course outcomes page
- enable a screenreader and view the headings list
- it should now have sequential headings, starting at h1 (specifically for this
page, it should have an h1 and an h2)
Change-Id: I616d212c343df7b8e277b505aa00e93697ddda7b
Reviewed-on: https://gerrit.instructure.com/38255
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Anna Koalenz <akoalenz@instructure.com>
Reviewed-by: Cameron Sutter <csutter@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
due to rounding error, a customer's date that should have been
30 days from the new start of the course was placed at
29.999999999999996 days, which was truncated to 29, which was then
shifted back 6 days to fall on the correct day of the week.
also, announcement post delay dates were not getting shifted
at all.
test plan:
follow the scenarios in CNVS-14130 and ensure that
* announcement post delay dates are shifted
* some dates don't mysteriously end up a week earlier
than they should
fixes CNVS-14130
Change-Id: Ice5bd3be0ddee0dec2af7b740c568750dd3c4ab8
Reviewed-on: https://gerrit.instructure.com/38223
Reviewed-by: James Williams <jamesw@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>
fixes CNVS-14443
This reverts commit 57427343e3.
Change-Id: Ic70da7d96965d368773c2e16c2b49c59f57e5c18
Reviewed-on: https://gerrit.instructure.com/38314
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
QA-Review: Simon Williams <simon@instructure.com>
fixes CNVS-9872
refs CNVS-14074
test plan:
* turn on the differentiated assignments feature flag
* edit an assignment so that not all sections can see it
* using assignment groups API
- in the request make sure to include "assignments" and "assignment_visibility"
> there should be an assignment_visibility object within each assignment object
> the assignment_visibility object should be an array of unique ids
> the ids should only be students in sections that can see the assignment
or students whose submissions were graded
* using the assignments API
- in the request make sure to include "assignment_visibility"
> there should be an assignment_visibility object
> it should be an array of unique ids
> the ids should only be students in sections that can see the assignment
or students whose submissions were graded
Change-Id: I68e832c3dc1859e398f656fa77804b2733f0dcd3
Reviewed-on: https://gerrit.instructure.com/36811
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Mike Nomitch <mnomitch@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
This recompiles the iconfont to have the correct path and
edits the styleguide path info
Testing:
- When you go to styleguide all the icons should appear
Change-Id: I1a300cd20b9965782771b7eabf8b475bd22f15c2
Reviewed-on: https://gerrit.instructure.com/38135
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
closes #CNVS-14302
Change-Id: Ie9850318290620da22a37b44fe151b3f36079b8f
Reviewed-on: https://gerrit.instructure.com/38264
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
occasionally users connections are very slow,
no need to error out on the page
fixes CNVS-13542
Change-Id: I49e0873b42bb7bb53c73d9b37d95dee00be0a733
Reviewed-on: https://gerrit.instructure.com/38233
QA-Review: August Thornton <august@instructure.com>
Product-Review: Matt Fairbourn <mfairbourn@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
Tested-by: Matt Fairbourn <mfairbourn@instructure.com>
***test plan
1. Make a POST like /accounts/1/account_notifications
2. Required Parameters:
1) account_notification[subject]
2) account_notification[start_at]
3) account_notification[end_at]
4) account_notification[message]
3. Optional Parameters:
1) account_notification[icon]
'warning' | 'information' | 'question' | 'error' | 'calendar'
note: defaults to warning
2) account_notification_roles[]
'StudentEnrollment', 'TeacherEnrollment' etc...
this defaults to all roles
4. Only account admins should be able to make the api call
5. Should not be able to create an account notification with an
end_at < start_at
closes: PS-1730
closes: PS-1872
Change-Id: Ide86722598ae4a7ab565422f2996015b48cf8910
Reviewed-on: https://gerrit.instructure.com/37477
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Matt Fairbourn <mfairbourn@instructure.com>
Reviewed-by: Brandon Broschinsky <brandonbr@instructure.com>
fixes CNVS-14403
test plan:
- create a quiz with a due date far in the future (and no time limit)
- take the quiz as a student
- look at the grade_history api for that user
- the graded_at for the quiz assignment should be when it was submitted, not
when it was due (in other words, it should be in the recent past, not the far
future)
Change-Id: I37754b4be5238e240bbc6a9826ea9d7599c9a61f
Reviewed-on: https://gerrit.instructure.com/38154
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Mike Nomitch <mnomitch@instructure.com>
Reviewed-by: Jason Madsen <jmadsen@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
to consolidate some of the stylesheets, but the majority of work
has just been to reorganize the files that we have so they can more
easily be found and edited. Not to mention a structure than can
organize any new features and styles we put into canvas!
7/23
* added correct path for compiled course_settings
* took out repeated variable sheet in publish_gradebook
7/22
* fixed css path for conversations styles
7/21
* changes from master rebase
* took out context_modules.sass because it was old and unused
7/17
* brought back legacy sass files and changed to right paths
* taking out ComboBox to move to analytics plugin
* moved tinymce file to correct place, fixed js file paths to point
to it correctly
* brought tinymce sass file to stylesheets root to see if
jenkins passes
* rebased master, took out onneeded _environment.sass
fixes DES-83
* regression fixes from master rebase
fixes DES-83
* fixes compile error on jst/UserObservees.sass pulling in environment
fixes DES-83
* brings back in calendar.css so we can separate that deletion out
on a separate occasion
fixes DES-83
* take out user_observees since it's a handlebars sheet
fixes DES-83
* stylesheets/pages/ now has compiler sheets
and a /shared/ partials folder
* consolidation for assets_real.yml - we've knocked this down
to each page having one sheet that is compiling
* moved anything in /public/stylesheets that wasn't
in our /app/stylesheets/ into there for better organization
* we've purged a few files that weren't being used or have been
updated elsewhere
fixes DES-83
* takes out unneeded _newheader file
* removes redundant @import base/environment in _g component files
* renames app_common to c-common
* moves static css from /public into assets/stylesheets and modifies assets_real.yml to reflect new paths
fixes DES-83
* added _ prefix to g_ components in /components so they won't compile to stylesheets
fixes DES-83
reworking the way that we're overriding bootstrap
* deleted bootstrap-parts directory
* moved bootstrap-parts scss to /base
* renamed _main.scss to _custom_bootstrap.scss
* renamed _overrides.scss to _bootstrap_overrides.scss
* deleted empty and unused popover.scss file
fixes DES-83
moved /mixins into /base since they were only being called into _environment.sass
fixes DES-83
consolidated /bootstrap into /vendor
fixes DES-83
consolidated utilities into components
fixes DES-83
initial folder structure added
* reorganized existing css files for better structure
fixes DES-83
got rid of unneeded dump file
Change-Id: Id6f1409d478087a6cf9ebaa19ffa3a10b50891ca
Reviewed-on: https://gerrit.instructure.com/37280
QA-Review: Adam Phillipps <adam@instructure.com>
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Colleen Palmer <colleen@instructure.com>
Fixes: CNVS-3771
Adds a peer review notification to go out after
a peer reviewer is added to the discussion. This
also resolves the issue with a notification not
being sent if a rubric is not attached.
Test-Plan:
1.) Run bundle exec rake db:migrate in the console
before doing anything else -- (This sets up your
db by using notification_types.yml to populate
notification types in the DB.)
2.) Create a graded discussion with at least 2
students
3.) Make sure both students have everything
in their notifications set to ASAP.
4.) Edit the assignment settings and select the
'Require Peer Reviews' - Choose to manually
select peer reviewers.
5.) Navigate to discussions as an admin
6.) Select the cog and go to peer reviews.
7.) Assign a peer reviewer and verify that the
notification was sent out.
Change-Id: I78212cb8043de0fcf809a9ffa56ffca327ffcacc
Reviewed-on: https://gerrit.instructure.com/36646
Reviewed-by: Matthew Wheeler <mwheeler@instructure.com>
Product-Review: Matthew Wheeler <mwheeler@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
It wasn't following the rails file naming convention
fixes CNVS-14360
Test plan: imports, such as state standards imports, should work even
without class caching
Change-Id: I99ac8448844b7ac852203a5b8127d6fa35ea5f12
Reviewed-on: https://gerrit.instructure.com/38090
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
closes CNVS-13475
test plan:
- create 10 assignments in a course
- call the 'list course assignments' endpoint with per_page=2 as a query
parameter
- it should only return 2 assignments and have pagination links to go to the
next page
- make sure those links work
- also try passing other allowed parameters like 'include[]', 'search_term' and
'override_assignment_dates', and make sure they are maintained in the
pagination links. in other words, make sure that if you are including
submissions in the first call with the include[] parameters, subsequent calls
to later pages also return the submission
Change-Id: Ib637eb95186a2d3c586aaca64ef3efe2d937b142
Reviewed-on: https://gerrit.instructure.com/37640
Reviewed-by: Cameron Matheson <cameron@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
closes: #CNVS-10113
this is the start of creating a new k12 specific
look-and-feel. To start using this, turn on the
'k12' feature flag for an account.
test plan:
this should do nothing for existing users
but to test that this is working you can
do:
Account.find(<id of your account>).enable_feature!(:k12)
and then make sure that the stylesheets being loaded
on the page are coming from either:
/stylesheets_compiled/k12_normal_contrast/
or
/stylesheets_compiled/k12_high_contrast/
(depending on if you have turned on high contrast
for yourself)
if everything looks just like it did before, this works.
Change-Id: I9355d1498ab4f6587faf137b129a998044a3bbeb
Reviewed-on: https://gerrit.instructure.com/37926
Reviewed-by: Colleen Palmer <colleen@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Chris Hart <chart@instructure.com>
Product-Review: Colleen Palmer <colleen@instructure.com>
fixes CNVS-14078
If you're using VoiceOver or NVDA and trying to add a user to your
course but don't add a correct email, it won't read the error message.
This is now fixed.
Test Plan
Given I'm on the People page
And I'm using NVDA in FireFox
And I'm a Teacher
When I click the '+ People button
And I enter an email address that is not formatted correctly
And I press the "Next" button
Then I should see an error message explaining why the email didn't work
And the error message should have focus
And the error message should be read to the user automatically
Change-Id: Ic644bc9b5f93123bb9305a0d7c11e232d0c6620f
Reviewed-on: https://gerrit.instructure.com/38079
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: James Williams <jamesw@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Sterling Cobb <sterling@instructure.com>
test plan:
* as an admin, visit the page of a user with an enrollment
* with a screenreader, the link with an "X" icon should
have descriptive text
closes #CNVS-13996
Change-Id: I2bb29fc10803028246f1fde121e5a0dba9f36452
Reviewed-on: https://gerrit.instructure.com/37932
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
Saves assignment names and due dates when modified in the SIS Post
Grades dialog.
Test Plan:
- for assignments that are missing names or duplicated, fix the
name
- for assignments that are missing due dates, add a due date
- once all assignments are fixed, the assignments should auto-
matically be saved to Canvas
- the user is sent to the next page in the dialog where they
can click "Post" button
Fixes SIS-250
Change-Id: I0bbcf6f4eea1c4bf645cbd09a123bf0ac37fd1cd
Reviewed-on: https://gerrit.instructure.com/37248
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Eric Adams <eadams@instructure.com>
Reviewed-by: Tyler Pickett <tpickett+gerrit@instructure.com>
Reviewed-by: Liz Abinante <labinante@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Ahmad Amireh