fixes COMMS-1133
Test Plan
1. Create a new course
2. Create a student and enroll
3. Create an observer or two and enroll
4. In the people tab click three dots to link observer to student
5. Go to conference tab and create a conference
6. Notice the new remove observers checkbox
7. Try to create conferences and update conferences with different settings
8. Notice when you edit the conferences they won’t have the observers checked
Change-Id: I678b8e62308d102bb591f1343313227f22182777
Reviewed-on: https://gerrit.instructure.com/170394
Tested-by: Jenkins
Reviewed-by: Landon Gilbert-Bland <lbland@instructure.com>
QA-Review: Steven Burnett <sburnett@instructure.com>
Product-Review: Aaron Hsu <ahsu@instructure.com>
Change-Id: I33c8ca114c32d09a00352a28724bd46624600be4
Reviewed-on: https://gerrit.instructure.com/120135
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
fixes CNVS-10155
we don't support dis-inviting conference invitees, so really what
we're doing is disable all checked checkboxes as soon as they're
saved.
test plan
- on the conferences page, edit a conference and add invitees
- reopen the edit dialog
- ensure that the invited users' checkboxes are greyed out
Change-Id: Ifc539f2b100e98a5cc8e77ff924386699510cc52
Reviewed-on: https://gerrit.instructure.com/83507
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Joel Hough <joel@instructure.com>
Our AUA system is set up to be 1-1 with requests, but in the case of
external tool assignments, we call log_asset_access twice, once for the
assignment and once for the tool, and the system is set up that the last
call wins. It has been determined that the old behavior of counting
these as assignments is a better fit.
However, this system is tied into the Live Events system, and that
system handles multiple accesses per request just fine, so we want to
continue to log these to that system.
fixes CNVS-26743
test plan:
- view assignment and non-assignment external tools as a student
- look at the results in the course user page "Access Report"
- the assignment views should be counted as assignments
Change-Id: I31687222065a99c7680012f240b799dd7485edc9
Reviewed-on: https://gerrit.instructure.com/72280
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
Fixes CNVS-20701
Test plan:
1. Create a course with several students, and conclude the enrollment of
one of them.
Create a conference, checking the "Invite all" option
Verify the concluded enrollment students are not invited
2. Try those steps again with a course-level group (invite several memebers, then
conclude the course enrollment of a user)
3. Try conference creation in an account-level group
4. Regression test inviting users to conferences, include group conferences
and account level group conferences
Change-Id: I8a6f255938d1910851e7d3d640b271648a61fd37
Reviewed-on: https://gerrit.instructure.com/63118
Reviewed-by: Joel Hough <joel@instructure.com>
Tested-by: Jenkins
QA-Review: Adrian Russell <arussell@instructure.com>
Product-Review: Matthew Wheeler <mwheeler@instructure.com>
fixes spurious test failures occuring when other specs
require webmock and cause conferences_controller_spec to
fail with a WebMock::NetConnectNotAllowedError
refs #CNVS-19842
Change-Id: Iad091471d4b339d036e182fe849946ea104e62f9
Reviewed-on: https://gerrit.instructure.com/52337
Tested-by: Jenkins
Reviewed-by: Dan Minkevitch <dan@instructure.com>
Product-Review: Dan Minkevitch <dan@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
fixes CNVS-10839
test plan
- enable wimba and adobe connect conference plugins
- make a conference
- ensure it is visible on the conference index page
- disable the plugin for the conference
- ensure it is no longer visible on the conference index page
Change-Id: Idc26d306f683fade5bf6d8619dfe9325047bb116
Reviewed-on: https://gerrit.instructure.com/29487
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Braden Anderson <banderson@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Product-Review: Joel Hough <joel@instructure.com>
force a page_view record when
submitting an assignment
and when updating an assignment
description
force a page_view when
starting a new discussion
or when replying to a discussion
force a page_view when updating
a wiki page and when joining
a conference and when starting
a collaboration
start tracking http methods for
page views
don't link through to urls
for page views if they aren't 'get'
methods
pull some of the page_view logging
down into the asset_user_access
object and simplify it so
that the application controller is
more readable and the scoring incrementing
is easier to understand
TEST PLAN:
1) login as a student
2) turn in an assignment submission
3) take a quiz
4) update an assignment description
5) start a discussion and reply to it
6) login as an admin and confirm through
analytics and through the detailed
page view listing that all these
actions counted as participations
(and that the ones that are not
'get' methods can't be clicked through
from the student accound details page)
Change-Id: I2dfe4df41e8b006e6a0c0d8a1f914ecd7fb62477
Reviewed-on: https://gerrit.instructure.com/15428
Reviewed-by: Jacob Fugal <jacob@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
fixes#8845
originally, this issue was that if a student was concluded from a course
they would still show up in the list of students to be added to both
collaborations and conferences. this commit fixes that and also prevents
the student view student from showing up in the list of students when
creating a new conference.
test plan
- be a teacher in a course with a few students and collaborations and
conferences enabled
- go to a collaboration and a conference and see the students listed
there (when starting a new collaboration/conference)
- conclude a student from the course
- click student student view, then leave student view
- back in the collaborations and conferences, the concluded student
should no longer be listed, and test student should not be listed
Change-Id: I08da39a79ef1508e53064adf54bfacac0c527457
Reviewed-on: https://gerrit.instructure.com/12100
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Sam Olds <sam@instructure.com>
added a :resume permission so participants can join long-running
conferences even if they go inactive
test plan:
1. set up wimba (or bbb)
2. create a conference with a duration
3. confirm that students can't join unless it's active (in the case of
wimba, that means an admin needs to be in the conference. for bbb,
an admin needs to have been present in the last hour)
4. create a long running conference (no duration)
5. confirm that students can join any time after it was started,
regardless of whether the admin is still participating
Change-Id: Ie81ea7309b6334d88269af098f3b0da6fb04a177
Reviewed-on: https://gerrit.instructure.com/9433
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Zach Pendleton <zachp@instructure.com>
Depending on spec run order, these would fail due to various plugin
setting problems and/or a bad stubbing in an api spec
Change-Id: I6b82949cb9eb67cc6b4d1e55c1393a42d7054c69
Reviewed-on: https://gerrit.instructure.com/6530
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Hudson <hudson@instructure.com>
* Add conference_close route for group conferences
* Pull *group* conferences, not the group's context's conferences
when showing the groups' feed
* Add the conferences tab (where appropriate) to the group sidebar,
so the conferences controller won't refuse to work
Change-Id: I37bfb546c4bf8ad4078e4c9ca7a7292bb475af2c
Reviewed-on: https://gerrit.instructure.com/4954
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
Aaron Kc Hsu