test plan
- existing errors should work
- have a raven.yml
- populate Settings.set('ignorable_errors', 'some error')
-
Change-Id: I1bbfc003506ef5f15aa7fdb887e0249c84f09c56
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/232977
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
closes TALLY-792
flag=grade_calculator_performance_improvements
Fixes N+1s around observers, observer alerts, and observer alert
thresholds.
Test Plan:
1. Enable the 'Grade Calculator Performance Improvements' release
flag at /accounts/site_admin/settings
2. Smoke test to make sure observers receive 'course_grade_high'
and 'course_grade_low' alerts when an observee gets graded and the
grade is above or below the set threshold, respectively.
3. Disable the 'Grade Calculator Performance Improvements' release
flag at /accounts/site_admin/settings. Repeat step 2.
Change-Id: Ie9c3139006fed9eeec9af0aababad87bb6adb8df
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/232210
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Gary Mei <gmei@instructure.com>
Reviewed-by: Keith Garner <kgarner@instructure.com>
QA-Review: Robin Kuss <rkuss@instructure.com>
Product-Review: Spencer Olson <solson@instructure.com>
closes TALLY-802
flag=none
Test Plan:
1. log in to canvas and go to the course landing page for any course
2. verify ENV.current_user_roles contains all role types for the user
that is logged in.
Change-Id: I14f533f63a95c7cdd35ed2cda67c29a35210a975
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/232811
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Gary Mei <gmei@instructure.com>
Reviewed-by: Adrian Packel <apackel@instructure.com>
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
closes TALLY-757
flag = none
test plan:
1. In the Rails console, enter:
Setting.set('gradebook.active_request_limit', '10')
* You can use any numerical value from 1–100
* These are arbitrary constraints
2. Visit Gradebook
3. Verify Gradebook loads as expected
* For verification of the request limit being honored,
the most direct way is to inspect the instance of
`NaiveRequestDispatch` being used within the Gradebook's
`DataLoader`. In its options, you should see:
`activeRequestLimit: 10`
* For more difficult verification, you can update the
Setting in the console to use `100` and watch the network
tab in dev tools while loading Gradebook. It will
effectively NOT be throttled with a limit that high.
Change-Id: I58b844359de24147806b6d0a931e594a018a066a
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/230763
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Adrian Packel <apackel@instructure.com>
Product-Review: Spencer Olson <solson@instructure.com>
Reviewed-by: Gary Mei <gmei@instructure.com>
Reviewed-by: Adrian Packel <apackel@instructure.com>
Builds off of previous work that has been done with Teacher
and student tour points.
These tour points only appear for users that have an admin role.
Adjusts the Courses Controller to include whether the current
user is a teacher in the currently viewed course as part of the
values provided to the front end.
When a user is an admin, teacher, and student in a course, the
admin tour immediately appears. Teacher and student tours
appear when the user visits the course page which they are a
teacher or student in.
Splits the tours into their own separate files to shorten files.
Adds a Selenium test for initial launch of the tour.
Test Plan:
Make sure the Product Tours feature flag is turned on
As an admin, open up canvas.
The tour should appear, allowing you to walk through the
steps.
As a admin, student, and teacher, open up canvas.
The admin tour should appear (unless it's already appeared)
Visit the course page for the course you are enrolled in.
The student tour should appear.
Visit the course page for the course you are teaching.
The teacher tour should appear.
flag = product_tours
Refs UXS-58
Change-Id: I254822836d7884cd182cfcf67cddde53824afca5
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/232654
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Daniel Sasaki <dsasaki@instructure.com>
Product-Review: Laura Leavitt <lleavitt@instructure.com>
Reviewed-by: Augusto Callejas <acallejas@instructure.com>
Reviewed-by: Aaron Shafovaloff <ashafovaloff@instructure.com>
test plan:
* specs
closes #LA-878
Change-Id: I1467925da4560c20be6b1184f2c29d51f35c82a5
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/232624
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
we were looking for audio and video mime-types from a list. when
recording on a mac, the type wasn't in our list. This change
generalized the check by considering mime-type starting with "audio"
to be audio, and "video" to be video.
closes LA-868
refs LA-595
flag=none
test plan:
You'll need notorious running
in chrome
With RCE Enhancements turned off and again with it on
- in the RCE select Media > upload/record media
- go to the record tab
- record a video
> expect it to be in the RCE
- repeat, but in the Record tab, click on the "webcam"
button and select "No Video"
- record some audio
> expect it to be in the RCE
- save
> expect to be able to play both.
- go to an assignment's submission
- go to speedgrader
- add a media comment
- record audio
- do it again for video
> expect the comments to be viewable
Change-Id: If2cdfd4dd689569ac539a079f270bd789f37a502
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/231542
QA-Review: Anju Reddy <areddy@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
test plan
- hit a course home page as teacher and student
- should not get an error
refs KNO-376
Change-Id: Ieb336e360d2f69ce4653596898a94a89be8797ab
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/232846
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Mysti Lilla <mysti@instructure.com>
Reviewed-by: Davis Hyer <dhyer@instructure.com>
QA-Review: Davis Hyer <dhyer@instructure.com>
Product-Review: Davis Hyer <dhyer@instructure.com>
Change-Id: Idf1857ce958b9044cb05da9302454bc094038b99
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/232685
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: James Williams <jamesw@instructure.com>
Product-Review: James Williams <jamesw@instructure.com>
test plan:
* specs
closes #LA-877
Change-Id: I85624494e7d4f7d19c1d6f57327f4ed62b3186cd
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/232622
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
closes #LA-885
Change-Id: I99880ba1b19aa3769dae3031e8c6ae1e89c01bb6
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/232678
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
fixes: USERS-325
flag=responsive_2020_04
TEST PLAN:
- ensure ePortfolios is set-up for your local user and the April
responsive flag is turned on for the account
- click the ePortfolios link in the "Account" sub-nav
- if there is an existing ePortfolio select it, otherwise
create one
- from the detailed screen either zoom your browser up to 400
or use the "Toggle device toolbar" to view a device with a
width of 320
- the share ePortfolio link should now wrap vs breaking the width
Change-Id: Ic73d2e299366337ce35352273429169bb31bfb79
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/232492
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Augusto Callejas <acallejas@instructure.com>
Reviewed-by: Chris Hart <chart@instructure.com>
QA-Review: Daniel Sasaki <dsasaki@instructure.com>
Product-Review: Daniel Sasaki <dsasaki@instructure.com>
fixes KNO-377
test plan
- hit discussion topics page
- you should not get any errors
Change-Id: I07630e7fc823d8fb6da52a65680dcb6f8c707f7a
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/232656
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Davis Hyer <dhyer@instructure.com>
QA-Review: Davis Hyer <dhyer@instructure.com>
Product-Review: Davis Hyer <dhyer@instructure.com>
test plan
- hit a dashboard
- should not get an error
fixes KNO-376
Change-Id: I919ef659d7de39f684e1364c3a242c7e49103994
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/232658
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Davis Hyer <dhyer@instructure.com>
QA-Review: Davis Hyer <dhyer@instructure.com>
Product-Review: Davis Hyer <dhyer@instructure.com>
Rob Orton