This gets canvas planner and canvas-rce on babel 7, which is a
prerequisite to canvas doing the same. Also, by not depending on the
Kitchen sink of ui-presets, it cleans a ton of unused stuff from our
node_modules/yarn.lock. It was originally 2 different commits but
in order to get the yarn.lock right, we have to do them all as one.
This also made it so we needed to have less “resolutions” in our
package.json since the newer versions of those things work fine with
the newer version of babel
So there are 2 test plan areas:
1. Canvas-planner
Closes: CORE-2575
Test plan:
* smoke test to make sure everything in canvas-planner still works/looks
like it used to in the canvas ui
* make sure the translation task (yarn check-transifex) still works
canvas-rce: upgrade to babel 7 & @instructure/ui-babel-preset
2. canvas-rce
Closes: CORE-2576
Test plan:
* smoke test the RCE editor
* theming should still work/look exactly as before
* make sure all the various build tasks (eg yarn test, test:coverage,
debug, lint, extract, etc) all still work as before
Change-Id: Id896687e3905f4df4627b181cad3f67ffe4417a5
Reviewed-on: https://gerrit.instructure.com/183877
Tested-by: Jenkins
Reviewed-by: Jon Willesen <jonw+gerrit@instructure.com>
Reviewed-by: Steven Burnett <sburnett@instructure.com>
QA-Review: Brent Burgoyne <bburgoyne@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
Closes: CORE-2560 CORE-2569
Refs: ADMIN-2453
Test plan:
* general spot check to make sure things look the same
(Specifically check the publish/unpublish button on the modules page)
* verify that the total size of the vendor & common production webpack
bundles is smaller
Change-Id: I734e9723917c14778cdc5fc4e22dcd1011b5e77e
Reviewed-on: https://gerrit.instructure.com/184911
Reviewed-by: Steven Burnett <sburnett@instructure.com>
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
Tested-by: Jenkins
QA-Review: Clay Diffrient <cdiffrient@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
It looks like this is not actually being used yet, so I deleted it.
If it is, in fact, being used that’s fine. Just let me know and I will
abandon this.
Change-Id: I47100e03408c4ad83ef9eed6ea9d68d57fc9d7d0
Reviewed-on: https://gerrit.instructure.com/183785
Tested-by: Jenkins
Reviewed-by: Jeremy Neander <jneander@instructure.com>
QA-Review: Jeremy Neander <jneander@instructure.com>
Product-Review: Jeremy Neander <jneander@instructure.com>
We really should only be writing eslint-ignore in files where we KNOW
We don’t want to do what it is suggesting.
If it is suggesting something that we probably should do, but it was
written before us so we want to be lazy and not do anything about it,
we should not just eslint-ignore it. We should fix it or leave it there
for someone else to fix.
Having an eslint-ignore in a file is a signal that someone who knew what
They are doing saw that error and said “no I want to do it anyway”
We really should not be having lots of cases where you need to even
write `eslint-ignore`. A rule should either be 99.9% always followed or
we should get rid of it (and as a side note, I think we are there now)
A lot of these were leftovers from before we did that ^
Change-Id: I1e515d486550ad3118d6d74e9c824d28ebf6e714
Reviewed-on: https://gerrit.instructure.com/183786
Tested-by: Jenkins
Reviewed-by: Steven Burnett <sburnett@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
This removes outdated code for treating missing submissions as
not-yet-submitted, which is no longer how submissions are handled.
test plan:
* Smoke test front end grade calculation
* Emphasis on differentiated assignments
assigned only to some students
Change-Id: I57bca1c1b7e63fdfbc0900928af35ff5ba277b64
Reviewed-on: https://gerrit.instructure.com/181982
Tested-by: Jenkins
Reviewed-by: Keith Garner <kgarner@instructure.com>
Reviewed-by: Gary Mei <gmei@instructure.com>
QA-Review: Gary Mei <gmei@instructure.com>
Product-Review: Keith Garner <kgarner@instructure.com>
test plan:
- tests pass and everything still works
Change-Id: I73540f1b5e4647c19f3446ce558bce7e4dfde684
Reviewed-on: https://gerrit.instructure.com/180736
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Daniel Sasaki <dsasaki@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
closes ADMIN-2233
test plan:
- click the delete button which will open a confirmation dialog that
roughly matches the design
- a11y for the dialog should make sense
- the close button should dismiss the dialog with no effect
- the cancel button should dismiss the dialog with no effect
- the delete button should start a delete operation
- when the delete operation completes, you should be redirected to the
assignment index screen with a message indicating the assignment has
been deleted
- if your user does not have permission to delete the assignment, or
some other error occurs, then the in-development error screen should
be shown
Change-Id: I0c3304360d3c389296bd0910d02d8215bdb0ac9e
Reviewed-on: https://gerrit.instructure.com/177754
Reviewed-by: Carl Kibler <ckibler@instructure.com>
Tested-by: Jenkins
QA-Review: Carl Kibler <ckibler@instructure.com>
Product-Review: Jon Willesen <jonw+gerrit@instructure.com>
refs ADMIN-2339
test plan:
- opportunities button badge should appear correctly
- screenreaders should read the button and the badge properly
Change-Id: I7b7a76c4a563ce18ab18806c5d42debb8431a222
Reviewed-on: https://gerrit.instructure.com/177999
Tested-by: Jenkins
Reviewed-by: Ed Schiebel <eschiebel@instructure.com>
QA-Review: Daniel Sasaki <dsasaki@instructure.com>
Product-Review: Jon Willesen <jonw+gerrit@instructure.com>
refs ADMIN-2339
test plan:
- focus the link in a planner item and see that the focus ring does not
overlap the text above it
Change-Id: Iaae8b50fef8ee82f9508caac9350073d919727e1
Reviewed-on: https://gerrit.instructure.com/178141
Tested-by: Jenkins
Reviewed-by: Ed Schiebel <eschiebel@instructure.com>
QA-Review: Ed Schiebel <eschiebel@instructure.com>
Product-Review: Jon Willesen <jonw+gerrit@instructure.com>
refs ADMIN-2277
test plan:
- Do some spot checking all around, esp. on newer stuff written with
InstUI
- Do some specific spot checking on:
- Assignments edit page. Esp. with moderated grading
- Gradebook late policies
- Check the original bug (ADMIN-2211)
Change-Id: Iaaaeb9d86dc2d59cb2c9ccca2a8764a5adb0896b
Reviewed-on: https://gerrit.instructure.com/176912
Tested-by: Jenkins
Reviewed-by: Anju Reddy <areddy@instructure.com>
QA-Review: Steven Burnett <sburnett@instructure.com>
Product-Review: Steven Burnett <sburnett@instructure.com>
fixes: ADMIN-2259
Test-Plan:
run the steps in ticket and make sure it doesnt happen anymore :)
Change-Id: I316fb4c72477afc2ed5c06a7c31fbdba558223d0
Reviewed-on: https://gerrit.instructure.com/174012
Tested-by: Jenkins
Reviewed-by: Ed Schiebel <eschiebel@instructure.com>
QA-Review: Anju Reddy <areddy@instructure.com>
Product-Review: Rex Fleischer <rfleischer@instructure.com>
fixes OUT-2848
Test plan:
* Visit the course or account outcomes page
* Click add a new outcome
* Turn on VoiceOver
* Navigate to rich text area
* VoiceOver should now read the label "Describe this outcome"
This fix should fix the label issue for all instances of RCE in Canvas
Change-Id: I476a50a4fae1d22c04ccbac0ffd142a594c8427c
Reviewed-on: https://gerrit.instructure.com/173366
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Brian Watson <bwatson@instructure.com>
Product-Review: Neil Gupta <ngupta@instructure.com>
closes QA-614
Test Plan:
- Run yarn test inside the canvas-planner directory
- A junit file should be created in ./coverage/canvas-planner-junit.xml
- It should also report to jenkins 'Test Results' when there is a failure
Change-Id: Ibfb1ec088ceb60f2c265b3c31e77029968268f9a
Reviewed-on: https://gerrit.instructure.com/173008
Tested-by: Jenkins
Reviewed-by: Carl Kibler <ckibler@instructure.com>
Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com>
QA-Review: Clay Diffrient <cdiffrient@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
refs QA-614
Test Plan:
- `yarn test` inside of packages/canvas-rce outputs
`coverage/canvas-rce-junit.xml`
- Also, Jenkins should pick that file up on patchset builds
as well
Change-Id: Ib4db4ba16b90e181e17a319219544aa2f0c205ea
Reviewed-on: https://gerrit.instructure.com/172430
Tested-by: Jenkins
Reviewed-by: Steven Burnett <sburnett@instructure.com>
QA-Review: Clay Diffrient <cdiffrient@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
closes CORE-1976
Test Plan:
- Set Canvas language to Dansk GR/GY
- Go to an RCE instance
- The sidebar should be translated
- Repeat for Norsk (Bokmal) GS/VGS and Svenska GR/GY
Change-Id: Iac81f9ac5246e1c874d62652a9e759180447e0d9
Reviewed-on: https://gerrit.instructure.com/170826
Tested-by: Jenkins
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
Reviewed-by: Ryan Shaw <ryan@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
refs CORE-1976
Test Plan:
- Setting language to Ukranian shows language
translated in the RCE and the RCE Sidebar
Change-Id: I37c6dab381421d93435d4cb91ea43aad8d7aac86
Reviewed-on: https://gerrit.instructure.com/168646
Tested-by: Jenkins
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Reviewed-by: Ryan Shaw <ryan@instructure.com>
refs CORE-1976
Test Plan:
- Set the language to Danish and notice that the
sidebar is translated on RCE pages.
Change-Id: Ia87a658da33fbd102e693e2ae8079a54f56019ad
Reviewed-on: https://gerrit.instructure.com/168654
Tested-by: Jenkins
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Reviewed-by: Ryan Shaw <ryan@instructure.com>
closes CORE-1983
Test Plan:
- Go to an instance of the RCE sidebar
- Use the keyboard to navigate into the Files and/or Images panel
- Go back to the tab bar and go to Links
- Press tab
- Focus should go into the Links panel
Change-Id: I8e4befba3d52a9bad1ae854e7f7040e36a271cfe
Reviewed-on: https://gerrit.instructure.com/168907
Tested-by: Jenkins
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Clay Diffrient <cdiffrient@instructure.com>
Reviewed-by: Brent Burgoyne <bburgoyne@instructure.com>
When something was due at midnight, the planner erroneously changed
the due time to 11:59pm the same day, not 1 minute earlier.
After discussing it with the team and @cwruck, we decided that planner
- should be displaying items at the time they were created
- should not do any fancy midnight stuff when the user creates a to do
fixes ADMIN-1522
test plan:
- have an assignment due at midnight in the student's timezone
which is easier to accomplish if the course and student are
in different timezones
- load the planner
> expect it to be due at midnight
- load the card dashboard
> expect it to be in the To Do sidebar at midnight
- in planner, create a new To Do due at midnight
> expect it show up in planner at midnight
Change-Id: I87190ccd5ed5dd22e62e9a8e92b41a573f418038
Reviewed-on: https://gerrit.instructure.com/169411
Tested-by: Jenkins
Reviewed-by: Jon Willesen <jonw+gerrit@instructure.com>
QA-Review: Jon Willesen <jonw+gerrit@instructure.com>
Product-Review: Christi Wruck
implements the planner layout for narrow screens.
in the process, the window.matchMedia mock used for
responsiviser.spec.js (since the dom used by jest doesn't support
window.matchMedia) became too much and the tests were more a test
of the mock than responsiviser. Added a selenium spec in its place.
the main difference between this implmentation and Mary's design is
that the item title should truncate after 2 lines, but is only 1.
Attempting to fix that sent me down a rabbit hole. I may revisit later.
also added `constrain="window"` to the opportunities popover. It doesn't
work now, but should when instui fixes their placement code, which is
currently a WIP.
skipping the "scrolls to the next new activity" spec, since it's not
behaving well. It thinks the page scrolls only 3px on the 2nd
new activity button click.
closes ADMIN-1527
test plan:
- open planner on your phone, or use devtools to simulate a phone, or
simply shrink the browser to < 592px wide
> expect planner to look like the screenshot attached to the ticket
- if you're using a skinny browser, make it wider. It should
automatically switch to tablet layout
- make the browser even wider. Planner should switch to desktop layout
Change-Id: Id8302bef1e9dd773cfb229d12a338d403df8ab68
Reviewed-on: https://gerrit.instructure.com/167588
Tested-by: Jenkins
Reviewed-by: Jon Willesen <jonw+gerrit@instructure.com>
QA-Review: Jon Willesen <jonw+gerrit@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
Ryan Shaw