refs FOO-1786
flag=none
No code should invoke these helpers anymore
so let's remove them before any more start
TEST PLAN:
1) specs pass
Change-Id: Ia9994424e804426afb90d3bc82e00e6916b0634e
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277296
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Ethan Vizitei <evizitei@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
[skip-stages=Flakey]
all manual, and this concludes this cop for the entire codebase, so
change it to error severity to enforce it
Change-Id: I770c62bbd93ccd4f0b11252fd0cf61158f1ee7cb
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277357
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
refs VICE-1995
flag=react_discussions_post
Test Plan:
- discussions redesign ff on
- create a discussion with an availability date in the future
- enter student view
> should see alert saying topic is locked (see ticket for designs)
Change-Id: I99e367822fb832b3678e2d513a505ade192e9ce2
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/275340
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
refs VICE-1995
flag=react_discussions_post
Test Plan:
- discussions redesign ff on
- create a discussion with an availability date in the future
- enter student view
> should only see topic title (see ticket for designs)
Change-Id: I3daf2a553633d8761ef6c4bec4aedf773f03922f
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/275336
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
refs VICE-1995
flag=react_discussions_post
Test Plan:
- turn discussions redesign ff on
- open network inspector
- go to a discussion
- open graphql response for the discussion
> should see availableForUser on the discussion
Change-Id: Iaa3181307f1aa2d398c4a2c5421b4f188f470b23
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277134
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
refs VICE-1995
flag=react_discussions_post
Test Plan:
- turn discussions redesign ff on
- create a discussion with the available date in the future
- open network inspector and check the graphql respose
> lockedForUser on the discussion should be true
> verify the same with a graded discussion
- set the due date to be in the past
> lockedForUser should be false for graded and ungraded
Change-Id: I99e807530f037b7edff19b7cd459cd19e9f57a65
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276410
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
closes VICE-2218
flag=none
Test Plan:
- go the the discussions landing page
- open the settings modal
- should see:
> "Edit and delete their own replies"
> "Manually mark replies as read"
Change-Id: I07488d779ce906c160103127cdc464dcd33019b4
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277143
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Omar Soto-Fortuño <omar.soto@instructure.com>
QA-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
Product-Review: Omar Soto-Fortuño <omar.soto@instructure.com>
[skip-stages=Flakey]
all manual
the fixes are a little scattered, since the same method doesn't work
everywhere depending on requirements. mostly I changed to `let`, but
some required `stub_const`. For `let`, I eventually settled on
avoiding a dedicated `let` for the class if it's only used one, and
it's a trivial class just to include the module. otherwise there's
a separate `let` for the class, and if there's only one it's named
`klass` instead of something contrived.
Change-Id: I84734c963d4789be3ec3cd852cca623e7c2a08df
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277285
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
test plan
- have a user that has multiple logins from multiple accounts
- the link to the account should be to the user on other accounts
- the link to the account should be the same as before for same account
Change-Id: If811980f82a7a0da8b5241bc34a6b55034e77e53
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/275978
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
it's no longer a problem with zeitwerk
Change-Id: I737701d9f3400468d9a8698a898b422f5969e780
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277227
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
fixes INTEROP-7116
flag=none
Test plan
- Have a course with new quizzes set up
- Have a new quiz set up for testing
- Ensure student view student can see
the quiz when the course is active
- The student view student should
get a concluded message if the
course is concluded
Change-Id: Id160cc51fe37337baf65c36e46ce9947a05c5776
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277149
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Xander Moffatt <xmoffatt@instructure.com>
Reviewed-by: Alex Slaughter <aslaughter@instructure.com>
QA-Review: Xander Moffatt <xmoffatt@instructure.com>
Product-Review: Mysti Lilla <mysti@instructure.com>
fixes LS-2770
flag=pace_plans
test plan
- Create a course with pace plans enabled
- Create a module with some assignments
- Go to pace plans
- Verify that in the settings drop down there is an option for
"Require completion by specified end date" and is selectable
- Verify that when selected that an end date selector is present and
functions respecting weekend setting and blackout dates
- Verify that the projection date selections don't affect the end date
selector in settings
- With the setting enabled verify that publishing the pace plan is
successful and the pace plan has hard_end_dates set to true and end_date
set to what was set on the frontend
Change-Id: Id24b7d3752e0a607d2be6953d5a8de308d7a2298
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276633
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jeff Largent <jeff.largent@instructure.com>
QA-Review: Jeff Largent <jeff.largent@instructure.com>
Product-Review: Eric Saupe <eric.saupe@instructure.com>
fixes VICE-2150
Test Plan
1. Pull down code and run storybook `yarn storybook`
2. Test the following cases to capture end to end component behavior
Case 1.
1. Open Dropdown menu with mouse
2. Both clicking address book button and input should work
3. Select an item
4. Item should show up in tags near input
5. Tags should be dismissable via mouse
6. Test same scenario with Limit of 1 story to test that limiting works
Case 2.
1. Use your keyboard to navigate to the input
2. Focus should open the menu
2a. Down arrow or Address book button can also open the menu
3. Use your up and down keys to navigate
3a. Note: Search filtering will be handlede at the container. Input only
returns characters to <AddressBook /> consumer at the moment
4. Select a user using the enter key
5. Notice shift tabbing should focus tags and allow them to be dismissed
Overall notes:
1. Nested navigation will be handled at the Container level as each
click will trigger a new query
2. Courses and Back button should not appear in tags
Change-Id: I4abad8f2c2b179b534032ce166da4d8df237a004
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276868
Reviewed-by: Matthew Lemon <mlemon@instructure.com>
Reviewed-by: Davis Hyer <dhyer@instructure.com>
QA-Review: Matthew Lemon <mlemon@instructure.com>
Product-Review: Matthew Lemon <mlemon@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
This is rendered in place of the existing course creation settings
in root account settings when the RootAccount
:create_course_subaccount_picker flag is enabled. It supports setting
the existing course creation settings, plus two new settings:
- teachers_can_create_courses_anywhere, and
- students_can_create_courses_anywhere
This will eventually be used in the CreateCourseModal to allow admins
to limit where users can create courses, if desired.
refs LS-2780
flag = create_course_subaccount_picker
Test plan:
- With the flag off, open root account settings as an admin
- Expect to see the classic settings under 'Who can create new
courses'
- Turn on create_course_subaccount_picker flag
- On the settings page, expect those classic controls to be replaced
- Expect the radio buttons under 'Teachers' and 'Students' to render
only when the parent checkbox is checked
- Alter the settings, save the page, and expect changes to persist
Change-Id: I6801b9c201f3fb00a3c0821ea1e855b4561bb72c
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/276964
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Jonathan Guardado <jonathan.guardado@instructure.com>
Reviewed-by: Jonathan Guardado <jonathan.guardado@instructure.com>
Product-Review: Jackson Howe <jackson.howe@instructure.com>
Omar Gerardo Soto-Fortuño