Removes user-event from canvas-media since its not actually used there,
and bumps the version in canvas-rce as well. The only non-spec files
that this commit touches are: package.json, canvas-media/package.json,
canvas-rce/package.json, and yarn.lock. The remainder of the changes
are changes to jest spec files to resolve breaking changes in the
user-event API. The vast majority of the changes make usages of
user-event adhere to the new API which returns a promise, so calls
now need to be explicitely `await`ed. This change also exposed a
couple of synchronicity issues in test code which were rectified.
6 total specs were skipped across 3 files: action_button.test.tsx,
FilterNav.test.tsx, and CreateCourseModal.test.jsx. These will be
addressed in follow-up commits by owning teams who have more context
about how the underlying component should behave.
closes LF-1289
flag = none
Test plan: specs pass
Change-Id: If8f9db685593e906da9b2af5ae8d39fc63fe8c7c
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/340719
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Ed Schiebel <eschiebel@instructure.com>
QA-Review: Jackson Howe <jackson.howe@instructure.com>
Product-Review: Jackson Howe <jackson.howe@instructure.com>
flag=speedgrader_studio_media_capture
test plan:
- enable speedgrader_studio_media_capture feature flag
- go to the speed grader
- click on the media recorder button
- verify that the screen capture option is available
Change-Id: I37349bbe5fa29f431ecb028c2c96f05290974488
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/341093
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Christopher Soto <christopher.soto@instructure.com>
Reviewed-by: Kai Bjorkman <kbjorkman@instructure.com>
QA-Review: Rohan Chugh <rohan.chugh@instructure.com>
Product-Review: Ravi Koll <ravi.koll@instructure.com>
We no longer use fullstory, remove anything related to full story and
the empty privacy tab in settings. And now you know the rest of the
story... good day!
flag=none
test plan:
- specs pass
- confirm canvas loads in a browser
- comfirm account settings page loads in a browser
Change-Id: I0529bc7b0075e93c9766ac8a4a0c79197c988cf1
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/341147
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Reviewed-by: Aaron Shafovaloff <ashafovaloff@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Keith Garner <kgarner@instructure.com>
Product-Review: Jody Sailor
with jquery-migrate 1.4.1 on QUnit specs and on
runOnEveryPageButDontBlockAnythingElse.jsx
flag=none
refs FOO-4258
[skip-crystalball]
Change-Id: I46606a064237b79a7f9b608ce0e3a93ff8c386d4
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/340741
QA-Review: Jen Smith <jen.smith@instructure.com>
Product-Review: Jen Smith <jen.smith@instructure.com>
Reviewed-by: Angela Gomba <angela.gomba@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
test plan:
- run rspack locally (as "webpack" for now)
- ensure coverage data for crystalball
- ensure build passes with skip-crystalball
- ensure source maps for local dev
- ensure bundle analysis is available and documented
- ensure compile times are at least comparable
refs CFA-32
[skip-crystalball]
flag=none
Change-Id: I8ad916ac7fbe9e3ecee5c690abcd78cdde748ab6
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/339401
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
Build-Review: Isaac Moore <isaac.moore@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Product-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Removing Babel in Jest ensures we won't add more of the
CommonJS-presuming mutative funny-business that Babel enabled
flag=none
Change-Id: I02a8b7387ff79c6f44b4304bfeb8e15ec26f787c
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/337966
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Product-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
one exception: I added jsdom condition on line 6954
this enables us to move forward more easily with jquery upgrades
test plan:
- build passes
refs FOO-3741
Change-Id: I40bce735119d81ab9bd53ef40134f6fee493cfc7
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/337415
Reviewed-by: Jackson Huang <jackson.huang@instructure.com>
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Product-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Build-Review: James Butters <jbutters@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
This avoids unnecessary tsx/jsx parsing on .ts/.js files,
a pattern recommended by rspack docs
This also enables externalHelpers
https://swc.rs/docs/configuration/compilation#jscexternalhelpers
flag=none
[skip-crystalball]
Change-Id: Ie0c2db9e67df115b24407fca5ba9d38002af5987
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/337127
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
Build-Review: Isaac Moore <isaac.moore@instructure.com>
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Product-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
test plan:
- build passes
- ensure bundles are not much larger
- canvas still works in dev environment
- smoke test in Safari
- smoke test in Firefox
closes CFA-38
flag=none
[skip-crystalball]
Change-Id: I7879b1e7274b9ce47c3aa1985a6a22e5e3659f25
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/337103
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
Build-Review: Isaac Moore <isaac.moore@instructure.com>
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Product-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
temporarily includes real underscore for those that
use require('underscore') in custom JS
flag=none
closes CFA-33
Change-Id: I62e10b7c4ab3bed67484ae98a729b6e7d381ed08
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/337045
Reviewed-by: Paul Gray <paul.gray@instructure.com>
Reviewed-by: Drake Harper <drake.harper@instructure.com>
Build-Review: Aaron Ogata <aogata@instructure.com>
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Product-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
The pathways dashboard and view pages.
refs VICE-3932
flag=learner_passport,learner_passport_r2
test plan:
- click on the Pathways tab
> expect the pathways dashboard
- click on the pathway name, or from the kabob menu select View
> expect the view page
> expect the graph of milestones
> expect zoom in/out to work
Change-Id: I86a3d172b5141a9505dc656d58300177b3076f65
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/335774
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Suggs <aaron.suggs@instructure.com>
QA-Review: Aaron Suggs <aaron.suggs@instructure.com>
Product-Review: Aaron Suggs <aaron.suggs@instructure.com>
this is included in yarn.lock, and
imported in various files. it should also
be in package.json
flag=none
Change-Id: I4a16b16e750280892ac0c9b7e960036524a58055
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/335917
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Product-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Reviewed-by: Michael Hulse <michael.hulse@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
also:
- more tests passing in vitests
- specifies which folders are left to resolve in the vitest config
test plan:
- build passes
Change-Id: I34fee1a8b44101fec4b801fa6f67b9562df0425c
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/335009
Reviewed-by: Cameron Ray <cameron.ray@instructure.com>
QA-Review: Cameron Ray <cameron.ray@instructure.com>
Product-Review: Cameron Ray <cameron.ray@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Closes FOO-4017
flag=none
Several bug fixes, plus this has the requested changes
from InstUI for the new look and feel for the side and
top navigation bars.
Test plan:
* automated tests pass
Change-Id: I5292256e4e479c70837cc77b10b97dfaba235848
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/333822
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Charley Kline <ckline@instructure.com>
Product-Review: Charley Kline <ckline@instructure.com>
Reviewed-by: Aaron Shafovaloff <ashafovaloff@instructure.com>
this commit adds the foundation for react-query to the rubrics redesign.
it also uses new graphql queries to return rubric data to the front end.
closes EVAL-3616
flag=enhanced_rubrics
test plan:
- navigate to /accounts/<id>/rubrics
- verify that if the account has rubrics, they are displayed in the
table
- navigate to /courses/<id>/rubrics
- verify that if the course has rubrics, they are displayed in the table
Change-Id: Ib340a37ad1c3a3d28413b3e8cfce359aa3f5db7a
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/331718
Reviewed-by: Aaron Shafovaloff <ashafovaloff@instructure.com>
Reviewed-by: Derek Williams <derek.williams@instructure.com>
Reviewed-by: Cameron Ray <cameron.ray@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Derek Williams <derek.williams@instructure.com>
Product-Review: Cameron Ray <cameron.ray@instructure.com>
test plan:
badge counts show up in navbar items in new SideNavBar
flag=instui_nav
refs FOO-3880
refs FOO-3894
refs FOO-3895
Change-Id: Iea01d6d9b5aa6aed7afe129842b17b1a6463c9b1
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/331126
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Martin Ochoa <martin.ochoa@instructure.com>
QA-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
Product-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>
We need more work to integrate the newer SourceCodeEditor.
Let's not do that with the clock ticking toward deployment.
closes LF-781
flag=none
test plan:
- the RCE's pretty html editor works as expected
- try flipping between wysiwyg and html
- try flipping between pretty and plain html editor
- try various combinations of fullscreen and switching
back and forth between editors
- insert enough html that you have to scroll, switch
to html editor. expect the html editor to resize
so that its scrollbar is correct.
Change-Id: Ieb0ad96ad2bb549676f7f9199d1231ece02b5aae
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/330095
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jackson Howe <jackson.howe@instructure.com>
QA-Review: Jackson Howe <jackson.howe@instructure.com>
Product-Review: Ed Schiebel <eschiebel@instructure.com>
Jackson Howe