bc3a49a39b
bundle update rspec-support
...
Change-Id: I6027df59b78db2aaba06c30aef8d7fb25dcc5f24
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/341539
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Ogata <aogata@instructure.com>
Build-Review: Aaron Ogata <aogata@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2024-03-01 22:27:40 +00:00
9c8f15d936
bundle update drb
...
Change-Id: I8c7d03fdb2cba7d4ff3a67b043d4cad2e568649f
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/341888
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Ogata <aogata@instructure.com>
Build-Review: Aaron Ogata <aogata@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2024-03-01 21:44:10 +00:00
369501d8dc
bundle update --bundler
...
Change-Id: Ic337ff6da406403f4d999cfef60d40227860f523
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/340413
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jake Oeding <jake.oeding@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
2024-02-14 22:30:21 +00:00
1e9f9ff387
add Rails 7.1 lockfiles for embedded gems
...
closes AE-777
test plan: specs pass
Change-Id: I0d9f9dc10fd0421d83f8f4604598871ae25f70d5
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/340308
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jake Oeding <jake.oeding@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
2024-02-14 22:30:10 +00:00
e3cbecc5f3
bundle update minitest
...
Change-Id: Ic990ac4ec74828c527720be6b5da241da9439ce4
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/339941
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
2024-02-13 16:12:54 +00:00
b568cef3aa
bundle update minitest
...
Change-Id: Id424fb8f8c83d389dba63a4be6af27a3b818ea70
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/339750
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
2024-02-06 23:04:22 +00:00
9916eca155
bundle update rspec
...
Change-Id: I3de31d5130326fd1657d1aa6198247353aa77a76
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/339732
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
2024-02-05 21:07:05 +00:00
f170bf3c00
bundle update diff-lcs
...
Change-Id: I9f2bb0232df447f8e53b9b94eed41d1f5008e515
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/339731
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
2024-02-05 21:05:33 +00:00
1c78c5e75a
bundle update minitest
...
Change-Id: I638cb735b0c2ebc5b48185c4078a8eeb27eadac7
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/338579
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
2024-01-30 20:06:43 +00:00
eacec0a606
bundle update factory_bot
...
Change-Id: I3ab74c597004c220cc2d0515546f0f584579d433
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/337908
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
2024-01-24 16:18:47 +00:00
655bb62690
bundle update concurrent-ruby
...
Change-Id: I83f239615f13ce8166b5aaa26295f993a88a4586
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/337904
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
Build-Review: Isaac Moore <isaac.moore@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2024-01-17 19:15:12 +00:00
1797b412c6
bundle update --bundler
...
Change-Id: Iffc641090e25eb1aefa9e3351bb804c361d69244
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/335507
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
Build-Review: Isaac Moore <isaac.moore@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2024-01-17 19:14:06 +00:00
3e27ddeae0
bundle update rubocop-performance, rubocop-rails
...
[skip-stages=Flakey]
[skip-crystalball]
99% of fixes are Performance/StringIdentifierArgument, but one or
two instances of each of Performance/Count, Performance/MapCompact,
Rails/Pluck in safe navigation chains
Change-Id: Ibd2292fb9e7c1e9162068021073c3c0f4b0d65df
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/335489
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Ogata <aogata@instructure.com>
Build-Review: Aaron Ogata <aogata@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2023-12-18 20:28:02 +00:00
c32d30f662
bundle update rubocop
...
[skip-stages=Flakey]
[skip-crystalball]
and apply corrections from new/updated cops:
* Layout
* Lint/AmbiguousRange
* Lint/RedundantSafeNavigation
* Style/HashEachMethods
* Style/HashSyntax
* Style/InverseMethods
* Style/RedundantLineContinuation
* Style/RedundantParentheses
* Style/RedundantReturn
* Style/SuperWithArgsParentheses
* Style/SymbolProc
Change-Id: I787e46f5b1c89e0fedebd5452ba74567d66954c1
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/334291
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Ogata <aogata@instructure.com>
Build-Review: Aaron Ogata <aogata@instructure.com>
Migration-Review: Aaron Ogata <aogata@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2023-12-06 14:25:02 +00:00
00f1eeeca9
bundle update rake
...
Change-Id: I4cdde145effb3ce7060d3c1eb280fcc75a873050
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/332704
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Ogata <aogata@instructure.com>
Build-Review: Aaron Ogata <aogata@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2023-11-13 21:37:43 +00:00
bd0097b762
bundle update --bundler
...
Change-Id: I20dc6723943fc442865dad2fb68d512d7b98459a
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/328959
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Aaron Ogata <aogata@instructure.com>
Build-Review: Aaron Ogata <aogata@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2023-09-29 15:42:35 +00:00
f4d059689f
bundle update rails
...
Change-Id: Ie89256cf0eff7ac0adbdb590248cfbe548f8353c
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/327335
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
2023-09-13 13:30:05 +00:00
6dff8b8bfe
bundle update factory_bot
...
Change-Id: I8a72032faaa8aa359a7b34b041633c947f3801b9
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/326814
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
Build-Review: Isaac Moore <isaac.moore@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2023-09-11 16:04:11 +00:00
f4c34f6393
bundle update --bundler
...
also, don't set BUNDLER_VERSION env var in Docker, so that
bundler's auto-install-and-restart-with-the-correct-version
feature can work
Change-Id: I8e3722197fb3598b5c40679d997f19b3b3957ea8
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/326580
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
2023-08-30 23:31:39 +00:00
752b0b3e84
reduce dependencies of vendored gems
...
only require the exact rails gems that are needed, instead of the
whole enchilada. this slightly speeds up running individual tests,
but massively reduces lockfile churn when we update gems
Change-Id: I6c360ed03d41e02563a460e669b2cee7ee7e8cca
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/326235
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
2023-08-28 15:58:30 +00:00
1397092957
bundle update rails
...
Change-Id: I8c3e93b99f9656e64520400e1ee10123b836a075
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/325864
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
2023-08-22 22:23:08 +00:00
dd453ba37c
bundle update rails
...
Change-Id: I39eb3799ab011b16fb2cb448f032ffafd21087d3
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/325834
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
2023-08-22 21:18:44 +00:00
5088ae332d
bundle update nokogiri
...
Change-Id: I6f47dd35205d7d463e93dcfdca032080d7626272
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/325721
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
2023-08-21 19:08:06 +00:00
d2bc4a9d38
bundle update rack-test
...
Change-Id: I242eac144911d29481e5169232409b61e9a647a5
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/325585
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
2023-08-18 20:19:43 +00:00
067af65314
bundle update rails-dom-testing
...
Change-Id: I1a15e312907f9728e657897677737afa219ea0f9
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/325520
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
2023-08-17 23:00:22 +00:00
91650d0cff
bundle update mail
...
Change-Id: I60774c71a7faa34b55670da2b0108f6607ebddf8
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/325510
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
2023-08-17 22:58:26 +00:00
893a7377d2
bundle update net-imap, net-pop, net-smtp
...
Change-Id: I94439fe38c7fc8a5449749ed94898d6db08c10df
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/325489
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
2023-08-17 19:37:59 +00:00
6347778e4e
bundle update tzinfo
...
Change-Id: Iea47a60ee8056b761d38ef854aa44ccb435bc585
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/325486
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
2023-08-17 19:37:28 +00:00
f450de57b6
bump rails
...
Change-Id: Idf23d6f1926efb208d8d8b3e6f9629676b4bdb76
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/324918
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
2023-08-11 17:42:20 +00:00
5de85fb2d3
bump rails
...
Change-Id: Ia59f4a8831c6bfc6f44d6490f7f2f5dbf43c0006
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/323855
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
2023-08-08 17:30:30 +00:00
ccba9e75b1
bump rspec-related gems
...
Change-Id: Id53c1d31be838972bcfb5c45dd9d9861aa240752
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/323856
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
2023-08-07 20:13:45 +00:00
399181bb27
bump rails
...
Change-Id: Ia540a9ccc668e7dab62cda642b6eb9da2b661604
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/321691
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
2023-06-30 19:07:11 +00:00
003e65f3aa
bump rails
...
Change-Id: Ib9a7f75fde9d85ac8d650ae2cad1b00cd5f98a4f
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/320432
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
2023-06-27 19:06:17 +00:00
c51fc4be30
add `ruby` platform to lockfiles
...
Change-Id: I865d51f54945dad9ec7ccc6f22e0cf4ee587c641
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/321480
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
2023-06-27 17:56:13 +00:00
d2b02ba910
rubocop: Lint/SendWithMixinArgument
...
I'm not sure why rubocop didn't find these; I found them manually
Change-Id: Id2654b6d2a4a2827d56dfd0baef7a7d668591144
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/320149
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2023-06-09 16:04:56 +00:00
7dcc507d0a
Rubocop for ruby 3.1
...
[skip-stages=Flakey]
Change-Id: I6abefdfa9fed6dd4525c8786e93efa548b3710f2
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/319603
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
QA-Review: Jacob Burroughs <jburroughs@instructure.com>
Product-Review: Jacob Burroughs <jburroughs@instructure.com>
Build-Review: Jacob Burroughs <jburroughs@instructure.com>
Migration-Review: Jacob Burroughs <jburroughs@instructure.com>
2023-06-06 16:44:26 +00:00
f00ee1e5db
bump nokogiri
...
Change-Id: Ib1bee8241147cfac7cd6bfd778c0fc6c271f8467
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/317808
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
2023-05-09 22:58:11 +00:00
5d6c6d5def
bump rack
...
Change-Id: I98ff462a8719be0c18f54763746be0a02b890bd3
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/317807
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Isaac Moore <isaac.moore@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Build-Review: Cody Cutrer <cody@instructure.com>
2023-05-09 22:57:57 +00:00
2ad4ea5d18
fix lockfile syncing from canvas lockfile to sub-gems
...
Actually use Bundler to write them out. this ensure that all
constraints are checked with the gem's Gemfile. Had to resolve
several issues with gems along the way.
also removed RedCloth from canvas_stringex, because it's never
used
Change-Id: I614be19e147bdfd3e351e7f032fd6f9b0c1926be
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/317781
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Andrea Cirulli <andrea.cirulli@instructure.com>
Reviewed-by: Aaron Ogata <aogata@instructure.com>
Build-Review: Aaron Ogata <aogata@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2023-05-09 22:57:42 +00:00
7c37aa5f64
rubocop: prep for updating rubocop-rails
...
auto-correctable cops applied
[skip-stages=Flakey]
Change-Id: Ie80bdfd170d9233d4a750edce6be467c93f3493f
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/315835
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2023-04-14 14:07:22 +00:00
1d3d9ed499
rubocop: fix miscelleneuos violations in prep of bumping rubocop
...
Change-Id: I9d37303737f00d6e022cb8fc08726e293a7336ab
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/315166
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2023-04-12 19:26:13 +00:00
66763fdfd5
Add enum-style references for model workflow state
...
refs QUIZ-9495
flag=none
This change allows referencing a Model's workflow_state
values an an enum-like way.
For example, let's pretend I want to conditinally set the
workflow_state in a Submission based on some condition.
In the current version of Canvas, I would write:
```
workflow_state = "graded" if something_is_true?
```
With the new code, I can instead write
```
workflow_state =
Submission.workflow_states.graded if something_is_true?
```
While the syntax is longer, we can avoid mistyping the
desired workflow_state string. Additionally, we can
begin to DRY up references to workflow_state values
Test Plan
- Pick an ActiveRecord model (like Submission)
- Call the new .workflow_states class method
- Validate each valid workflow_state for the chosen
model is represented in the returned OpenStruct
Change-Id: Ieeabcbb9956808a963f1c4a5e0c67d1082a36015
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/290181
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Product-Review: Stephen Kacsmark <skacsmark@instructure.com>
QA-Review: Jared Crystal <jcrystal@instructure.com>
Reviewed-by: Ricardo Oliveira <ricardo.oliveira@instructure.com>
Reviewed-by: Dustin Cowles <dustin.cowles@instructure.com>
Reviewed-by: Alex Slaughter <aslaughter@instructure.com>
2022-04-26 19:55:34 +00:00
c2cba46851
RuboCop: Style/StringLiterals, Style/StringLiteralsInInterpolation
...
[skip-stages=Flakey]
auto-corrected
Change-Id: I4a0145abfd50f126669b20f3deaeae8377bac24d
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279535
Tested-by: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Migration-Review: Cody Cutrer <cody@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
2021-11-25 14:03:06 +00:00
ff99d18138
RuboCop: Style/RedundantSelf
...
[skip-stages=Flakey]
auto-corrected
Change-Id: I5f26ad1f8210a74c2198b514235d5134dcd0dae1
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/279070
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Migration-Review: Cody Cutrer <cody@instructure.com>
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
2021-11-20 16:41:21 +00:00
9a92f3e4f2
RuboCop: Style/HashEachMethods
...
[skip-stages=Flakey]
auto-corrected, with a few instances of reworking things that modify
the hash as they're iterating
Change-Id: I73cef3016e46309c1c2ce906b013288d73976acf
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/278781
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-19 22:29:07 +00:00
185501719c
RuboCop: Style/RaiseArgs
...
auto-corrected
Change-Id: Ie7f1d2e54bbab1636b5d0a6fbf44f359cfcde712
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/278677
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-19 22:22:51 +00:00
157f0ae5d4
RuboCop: Style/RedundantPercentQ
...
[skip-stages=Flakey]
auto-corrected, with post review changing multiline strings into
heredocs
Change-Id: I1d4c543c936e5bf0ff5eb8bf10348652da7036c2
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/278652
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
Migration-Review: Cody Cutrer <cody@instructure.com>
2021-11-18 20:26:13 +00:00
d91263c442
RuboCop: Style/ExpandPathArguments
...
auto-corrected, but so many tweaks after to gemspecs it may as well
have been manual
Change-Id: I69aeb6e216894462d6d893ed4c123aa9898fc72f
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/278516
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Jacob Burroughs <jburroughs@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-17 22:06:59 +00:00
3512a9557e
RuboCop: Style/SafeNavigation
...
[skip-stages=Flakey]
auto-corrected
Change-Id: I0a907a6fa6229f05b4f756faf53a8dd2b18ea0c5
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/278213
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-16 06:36:38 +00:00
8125858d27
RuboCop: Style/RedundantInterpolation
...
[skip-stages=Flakey]
auto-corrected
Change-Id: Id04fd07bb918f0f4dc376b5c3474653a8e767e95
Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/277870
Tested-by: Service Cloud Jenkins <svc.cloudjenkins@instructure.com>
Reviewed-by: Simon Williams <simon@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
2021-11-11 02:06:11 +00:00
Cody Cutrer